)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"2968111807c59dc4861de13cf929881416d61a76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"72175344_beda9aa2","updated":"2022-03-04 22:51:01.000000000","message":"The ceph-ansible patch associated to this change merged [1].\nAt this point we should be able to move forward with this.\n\n\n[1] https://github.com/ceph/ceph-ansible/pull/7080","commit_id":"b74017075c8297af78bde23f59da569aff40fa19"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"a126114c5e4136e7422106fc0a2f7e98febb055b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3597724e_3d1dd906","updated":"2022-03-08 07:00:03.000000000","message":"recheck","commit_id":"b7d04f0d570541917c57f9ddbd5c21335e052fc4"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"c790c68560b044a26d1548d40780942c7a0bcf5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"665444dd_e6964d99","updated":"2022-03-14 07:11:05.000000000","message":"recheck","commit_id":"b7d04f0d570541917c57f9ddbd5c21335e052fc4"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"b49e3bd3d332c808b3cb7e151f23158cc1b5ec2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6de27b3d_c7710f1c","updated":"2022-03-05 14:12:01.000000000","message":"recheck","commit_id":"b7d04f0d570541917c57f9ddbd5c21335e052fc4"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"ec6a5874f22798bd0277008f7dbb79cdf09a2e38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d40f0215_10e06e2b","updated":"2022-03-07 12:12:31.000000000","message":"recheck","commit_id":"b7d04f0d570541917c57f9ddbd5c21335e052fc4"}],"deployment/ceph-ansible/ceph-base.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"3e498652139d7275b9b7b8e3bca0ad8b9c9177ca","unresolved":true,"context_lines":[{"line_number":572,"context_line":"      docker_config: {}"},{"line_number":573,"context_line":"      config_settings: {}"},{"line_number":574,"context_line":"      external_deploy_tasks:"},{"line_number":575,"context_line":"        - name: ceph-ansible extra vars"},{"line_number":576,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":577,"context_line":"          tags:"},{"line_number":578,"context_line":"            - ceph"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"350e0d8f_4eccea84","line":575,"updated":"2022-02-04 15:27:41.000000000","message":"I was wondering why you moved setting the ceph_ansible_skip_tags fact to it\u0027s own task. As per our conversation in IRC:\n \nOriginally the ceph_ansible_skip_tags fact was set in the block on line 591 with the tags ceph and cephadm_adopt. By creating a separate task to set the ceph_ansible_skip_tags fact, you can set this fact regardless of how the cephadm_adopt tag is set.\n\nCan you give me more context though on when the cephadm_adopt tag is set? Is it that you are now going to be calling the resultant playbook with tags\u003dcephadm_adopt and you don\u0027t want this fact set?","commit_id":"79d2fafa5d39e5c5904b75f404ae0d89a26300a3"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"c13f84a0d05a20ab5253267a5dad19fe02232ffc","unresolved":true,"context_lines":[{"line_number":572,"context_line":"      docker_config: {}"},{"line_number":573,"context_line":"      config_settings: {}"},{"line_number":574,"context_line":"      external_deploy_tasks:"},{"line_number":575,"context_line":"        - name: ceph-ansible extra vars"},{"line_number":576,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":577,"context_line":"          tags:"},{"line_number":578,"context_line":"            - ceph"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f37956ff_e0152b7c","line":575,"in_reply_to":"350e0d8f_4eccea84","updated":"2022-02-04 16:17:33.000000000","message":"Not really, let me try to explain better, and I should probably improve the COMMITMSG to explain the purpose of this change.\n\nWhen the command::\n\nopenstack overcloud external-upgrade run --stack overcloud --tags cephadm_adopt\n\nis run, in /var/lib/mistral/\u003cUUID\u003e/ the ansible playbook is exported and then executed, and the execution flow follows the tasks where the \"cephadm_adopt\" tag is present.\nBefore this patch, the skip tag list was set twice, the first time in the \"external_upgrades_tasks\" (L770), but later, the override of the same fact was performed in the \"external_deploy_tasks\" [1], because the cephadm_adopt tag is present at block level.\nI still need to execute all the tasks of that block because the ceph-ansible context is set there, but I need to skip the set_fact for the variables already set in the previous branch (external_upgrades_tasks).\nThis is the reason I moved both extra_vars and skip_tags on a different task, where the cephadm_adopt tag is not present in external_deploy_step but only in the exterrnal_upgrades_tasks branch. \n\n\n[1] https://github.com/openstack/tripleo-heat-templates/","commit_id":"79d2fafa5d39e5c5904b75f404ae0d89a26300a3"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"8f4fefebf165d032a1e6696652011eb054f6ecca","unresolved":false,"context_lines":[{"line_number":572,"context_line":"      docker_config: {}"},{"line_number":573,"context_line":"      config_settings: {}"},{"line_number":574,"context_line":"      external_deploy_tasks:"},{"line_number":575,"context_line":"        - name: ceph-ansible extra vars"},{"line_number":576,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":577,"context_line":"          tags:"},{"line_number":578,"context_line":"            - ceph"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"47a267f4_56d877ca","line":575,"in_reply_to":"f37956ff_e0152b7c","updated":"2022-02-04 17:00:42.000000000","message":"Ack","commit_id":"79d2fafa5d39e5c5904b75f404ae0d89a26300a3"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"3e498652139d7275b9b7b8e3bca0ad8b9c9177ca","unresolved":true,"context_lines":[{"line_number":671,"context_line":"              include_role:"},{"line_number":672,"context_line":"                name: tripleo_ceph_uuid"},{"line_number":673,"context_line":"                tasks_from: prepare"},{"line_number":674,"context_line":"        - name: set ceph-ansible skip tags facts"},{"line_number":675,"context_line":"          when: step|int \u003d\u003d 2"},{"line_number":676,"context_line":"          tags:"},{"line_number":677,"context_line":"            - ceph"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f20c5495_7b8a4b6f","line":674,"updated":"2022-02-04 15:27:41.000000000","message":"Ditto my comment above on line 575.","commit_id":"79d2fafa5d39e5c5904b75f404ae0d89a26300a3"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"8f4fefebf165d032a1e6696652011eb054f6ecca","unresolved":false,"context_lines":[{"line_number":671,"context_line":"              include_role:"},{"line_number":672,"context_line":"                name: tripleo_ceph_uuid"},{"line_number":673,"context_line":"                tasks_from: prepare"},{"line_number":674,"context_line":"        - name: set ceph-ansible skip tags facts"},{"line_number":675,"context_line":"          when: step|int \u003d\u003d 2"},{"line_number":676,"context_line":"          tags:"},{"line_number":677,"context_line":"            - ceph"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8a9e790b_98052404","line":674,"in_reply_to":"e05f3418_2f83e61c","updated":"2022-02-04 17:00:42.000000000","message":"Ack","commit_id":"79d2fafa5d39e5c5904b75f404ae0d89a26300a3"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"4bb2524c53e78016fc867d36808925cb7c604c93","unresolved":true,"context_lines":[{"line_number":671,"context_line":"              include_role:"},{"line_number":672,"context_line":"                name: tripleo_ceph_uuid"},{"line_number":673,"context_line":"                tasks_from: prepare"},{"line_number":674,"context_line":"        - name: set ceph-ansible skip tags facts"},{"line_number":675,"context_line":"          when: step|int \u003d\u003d 2"},{"line_number":676,"context_line":"          tags:"},{"line_number":677,"context_line":"            - ceph"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e05f3418_2f83e61c","line":674,"in_reply_to":"f20c5495_7b8a4b6f","updated":"2022-02-04 16:23:11.000000000","message":"see my reply on your L575 comment.","commit_id":"79d2fafa5d39e5c5904b75f404ae0d89a26300a3"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"3e498652139d7275b9b7b8e3bca0ad8b9c9177ca","unresolved":true,"context_lines":[{"line_number":747,"context_line":"            - name: set ceph_ansible_playbooks_default"},{"line_number":748,"context_line":"              set_fact:"},{"line_number":749,"context_line":"                ceph_ansible_playbooks_default: [\"/usr/share/ceph-ansible/infrastructure-playbooks/rolling_update.yml\"]"},{"line_number":750,"context_line":"      external_upgrade_tasks:"},{"line_number":751,"context_line":"        - when: step|int \u003d\u003d 0"},{"line_number":752,"context_line":"          tags:"},{"line_number":753,"context_line":"            - never"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"00a02a77_a2ab797d","line":750,"range":{"start_line":750,"start_character":6,"end_line":750,"end_character":28},"updated":"2022-02-04 15:27:41.000000000","message":"I understand why lines 777-785 are for external_upgrade_tasks as the adopt playbook needs them to set the ceph_ansible_extra_vars fact.","commit_id":"79d2fafa5d39e5c5904b75f404ae0d89a26300a3"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"4bb2524c53e78016fc867d36808925cb7c604c93","unresolved":true,"context_lines":[{"line_number":747,"context_line":"            - name: set ceph_ansible_playbooks_default"},{"line_number":748,"context_line":"              set_fact:"},{"line_number":749,"context_line":"                ceph_ansible_playbooks_default: [\"/usr/share/ceph-ansible/infrastructure-playbooks/rolling_update.yml\"]"},{"line_number":750,"context_line":"      external_upgrade_tasks:"},{"line_number":751,"context_line":"        - when: step|int \u003d\u003d 0"},{"line_number":752,"context_line":"          tags:"},{"line_number":753,"context_line":"            - never"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bdae13e5_fb45c85d","line":750,"range":{"start_line":750,"start_character":6,"end_line":750,"end_character":28},"in_reply_to":"00a02a77_a2ab797d","updated":"2022-02-04 16:23:11.000000000","message":"When the upgrade run is performed, two set of tasks are executed in the following order:\n\n1. the external_upgrade_tasks tasks \n2. the external_deploy_steps_tasks\n\nIf foo is set in #1, it shouldn\u0027t be set again in #2, otherwise an override is performed.\nThis is the reason of L575, where both extra_vars facts and skip tag list are moved away from the block and added (same step) as separated task, but w/ no \"cephadm_adopt\" tag.","commit_id":"79d2fafa5d39e5c5904b75f404ae0d89a26300a3"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"8f4fefebf165d032a1e6696652011eb054f6ecca","unresolved":false,"context_lines":[{"line_number":747,"context_line":"            - name: set ceph_ansible_playbooks_default"},{"line_number":748,"context_line":"              set_fact:"},{"line_number":749,"context_line":"                ceph_ansible_playbooks_default: [\"/usr/share/ceph-ansible/infrastructure-playbooks/rolling_update.yml\"]"},{"line_number":750,"context_line":"      external_upgrade_tasks:"},{"line_number":751,"context_line":"        - when: step|int \u003d\u003d 0"},{"line_number":752,"context_line":"          tags:"},{"line_number":753,"context_line":"            - never"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"487d7915_bea565d3","line":750,"range":{"start_line":750,"start_character":6,"end_line":750,"end_character":28},"in_reply_to":"bdae13e5_fb45c85d","updated":"2022-02-04 17:00:42.000000000","message":"Ack","commit_id":"79d2fafa5d39e5c5904b75f404ae0d89a26300a3"}]}