)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"6c7feee4ace8d61a7192bfff834fe2a7ad6849b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"844f0ff8_2bc2f435","updated":"2022-02-08 06:40:01.000000000","message":"I think this populated again in the client which supersedes and we need to change that too.\n\nhttps://opendev.org/openstack/python-tripleoclient/src/branch/master/tripleoclient/v1/undercloud_config.py#L160-L201\n","commit_id":"19c11813d58da3e66d0c9f852de2ce96693b0aba"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"90fbd71ad996688264be34ebdea63cd461ae10e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"536df6dc_ef10c615","updated":"2022-02-07 23:31:43.000000000","message":"check-rdo","commit_id":"19c11813d58da3e66d0c9f852de2ce96693b0aba"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e6e941b0c324d9d538b04fac04fd7a121c180b5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"21052f6e_5be8fbe2","in_reply_to":"4a5791ef_23c2a7a8","updated":"2022-02-08 18:34:03.000000000","message":"Ack","commit_id":"19c11813d58da3e66d0c9f852de2ce96693b0aba"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"45c44fc3448db80148b96c85e9462afd36408523","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fa319c87_7d855f73","in_reply_to":"844f0ff8_2bc2f435","updated":"2022-02-08 12:08:52.000000000","message":"AFICT the default result from ^^ is the same as this patch. See [1].\nI belive Julia may have proposed this patch based on a downstream CI issue?\n\nThe only ways I think it would be possible to end up without at-least [\u0027ipxe\u0027, \u0027pxe\u0027] in IronicEnabledBootInterfaces would be if the parameter is overridden in an undercloud environment file passed in using the `custom_env_files` parameter in undercloud.conf, or a `hieradata_override` file specifice in undercloud.conf?\n\nSnippets from undercloud.conf.sample:\n  # List of any custom environment yaml files to use. These are applied\n  # after any other configuration and can be used to override any\n  # derived values. This should be used only by advanced users. (list\n  # value)\n  #custom_env_files \u003d\n\n  # Path to hieradata override file. Relative paths get computed inside\n  # of $HOME. When it points to a heat env file, it is passed in\n  # tripleo-heat-templates via \"-e \u003cfile\u003e\", as is. When the file\n  # contains legacy instack data, it is wrapped with\n  # UndercloudExtraConfig and also passed in for tripleo-heat-templates\n  # as a temp file created in output_dir. Note, instack hieradata may be\n  # incompatible with tripleo-heat-templates and will highly likely\n  # require a manual revision. (string value)\n  #hieradata_override \u003d \u003cNone\u003e\n\n[1] https://opendev.org/openstack/python-tripleoclient/src/branch/master/tripleoclient/tests/v1/undercloud/test_config.py#L57","commit_id":"19c11813d58da3e66d0c9f852de2ce96693b0aba"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"06ed3885f3298594b378b79bb5822664ade46473","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4a5791ef_23c2a7a8","in_reply_to":"fa319c87_7d855f73","updated":"2022-02-08 18:33:36.000000000","message":"I found it as a result of a downstream CI issue which had a different cause, but stumbled across this file and went \"oh, this is not right!\"\n\nWith regards to the client, I guess it is okay that it does. It is not great, but customers forcing another option to be enabled is rare and the only option we might possibly ever encourage be used has not been officially requested, yet.","commit_id":"19c11813d58da3e66d0c9f852de2ce96693b0aba"}]}