)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"9938780dc527b9681ffc5bccb21241fdf6daf545","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"64b114c2_06d2e045","updated":"2022-02-10 18:38:04.000000000","message":"recheck","commit_id":"bea9ba6a7ce3cdca51afa7fbeef138f4d5b3212e"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"db47da27f143dd23e731a6d955cef6b608461633","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"712264e0_43f60b3e","updated":"2022-02-21 03:41:03.000000000","message":"recheck","commit_id":"ae866ab47c9180f6a7e6b24e50b1251afcfc70e7"}],"deployment/kernel/kernel-boot-params-baremetal-ansible.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"98d2f21c94292d6b04381f92b0469a6eb88240fe","unresolved":true,"context_lines":[{"line_number":104,"context_line":"              kernel_args: KernelArgs"},{"line_number":105,"context_line":"              kernel_args_defer_reboot: KernelArgsDeferReboot"},{"line_number":106,"context_line":"              hugepages: Hugepages"},{"line_number":107,"context_line":"              hugepages_remove: RemoveUnconfiguredHugepages"},{"line_number":108,"context_line":"            - values: {get_param: [RoleParameters]}"},{"line_number":109,"context_line":"          - values:"},{"line_number":110,"context_line":"              TunedProfileName: {get_param: TunedProfileName}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"efa6cc42_afc41c91","line":107,"range":{"start_line":107,"start_character":14,"end_line":107,"end_character":59},"updated":"2022-02-11 12:49:07.000000000","message":"RemoveUnconfiguredHugepages parameter does not have role_specific tag. No need to add it here. You can just use get_param in L140.\n\ntripleo_kernel_hugepages_remove: {get_param: RemoveUnconfiguredHugepages}","commit_id":"bea9ba6a7ce3cdca51afa7fbeef138f4d5b3212e"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"55d3715145746f1e175f64d042c0ab5367197a5e","unresolved":false,"context_lines":[{"line_number":104,"context_line":"              kernel_args: KernelArgs"},{"line_number":105,"context_line":"              kernel_args_defer_reboot: KernelArgsDeferReboot"},{"line_number":106,"context_line":"              hugepages: Hugepages"},{"line_number":107,"context_line":"              hugepages_remove: RemoveUnconfiguredHugepages"},{"line_number":108,"context_line":"            - values: {get_param: [RoleParameters]}"},{"line_number":109,"context_line":"          - values:"},{"line_number":110,"context_line":"              TunedProfileName: {get_param: TunedProfileName}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7eca7ab9_4dfa7f6d","line":107,"range":{"start_line":107,"start_character":14,"end_line":107,"end_character":59},"in_reply_to":"efa6cc42_afc41c91","updated":"2022-02-17 14:44:10.000000000","message":"Nice catch Rabi, it should have been role_specific. Thanks.","commit_id":"bea9ba6a7ce3cdca51afa7fbeef138f4d5b3212e"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"93b228d022a990e61453cc6b6d5b46bed43e695a","unresolved":true,"context_lines":[{"line_number":87,"context_line":"    type: boolean"},{"line_number":88,"context_line":"    description: \u003e"},{"line_number":89,"context_line":"      By default, tripleo-kernel will configure the provided Hugepages as specified by operators"},{"line_number":90,"context_line":"      but it won\u0027t try to remove Hugepages configured on the host that are not part of the TripleO"},{"line_number":91,"context_line":"      paramater. Enabling this setting will make sure everything is reconfigured exactly like the"},{"line_number":92,"context_line":"      TripleO parameter."},{"line_number":93,"context_line":"    tags:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5ef83a7e_d6f1ef0c","line":90,"updated":"2022-02-17 22:08:24.000000000","message":"so should be the parameter name be RemoveConfiguredHugepages then?","commit_id":"5e18f1d81f0c384724aa0a06c69b822b976094c7"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"8db12a77b8bc147d1810493a541070e0c6a904dd","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    type: boolean"},{"line_number":88,"context_line":"    description: \u003e"},{"line_number":89,"context_line":"      By default, tripleo-kernel will configure the provided Hugepages as specified by operators"},{"line_number":90,"context_line":"      but it won\u0027t try to remove Hugepages configured on the host that are not part of the TripleO"},{"line_number":91,"context_line":"      paramater. Enabling this setting will make sure everything is reconfigured exactly like the"},{"line_number":92,"context_line":"      TripleO parameter."},{"line_number":93,"context_line":"    tags:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba9ec406_d71958e1","line":90,"in_reply_to":"5ef83a7e_d6f1ef0c","updated":"2022-02-18 15:47:13.000000000","message":"Done","commit_id":"5e18f1d81f0c384724aa0a06c69b822b976094c7"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"93b228d022a990e61453cc6b6d5b46bed43e695a","unresolved":true,"context_lines":[{"line_number":88,"context_line":"    description: \u003e"},{"line_number":89,"context_line":"      By default, tripleo-kernel will configure the provided Hugepages as specified by operators"},{"line_number":90,"context_line":"      but it won\u0027t try to remove Hugepages configured on the host that are not part of the TripleO"},{"line_number":91,"context_line":"      paramater. Enabling this setting will make sure everything is reconfigured exactly like the"},{"line_number":92,"context_line":"      TripleO parameter."},{"line_number":93,"context_line":"    tags:"},{"line_number":94,"context_line":"      - role_specific"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a0f52c86_d84d47ce","line":91,"updated":"2022-02-17 22:08:24.000000000","message":"Or, ReconfigureHugepages","commit_id":"5e18f1d81f0c384724aa0a06c69b822b976094c7"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"8db12a77b8bc147d1810493a541070e0c6a904dd","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    description: \u003e"},{"line_number":89,"context_line":"      By default, tripleo-kernel will configure the provided Hugepages as specified by operators"},{"line_number":90,"context_line":"      but it won\u0027t try to remove Hugepages configured on the host that are not part of the TripleO"},{"line_number":91,"context_line":"      paramater. Enabling this setting will make sure everything is reconfigured exactly like the"},{"line_number":92,"context_line":"      TripleO parameter."},{"line_number":93,"context_line":"    tags:"},{"line_number":94,"context_line":"      - role_specific"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9d9a2998_f8356988","line":91,"in_reply_to":"a0f52c86_d84d47ce","updated":"2022-02-18 15:47:13.000000000","message":"Good idea, I like it.","commit_id":"5e18f1d81f0c384724aa0a06c69b822b976094c7"}]}