)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"acdec6be264934774f85fd29eaa352e97df1c199","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c77ae242_4f109a64","updated":"2022-02-14 13:01:40.000000000","message":"PTAL","commit_id":"0a7bf4d93932caaa507018b4a26df993d3cfd894"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"a04167791623e54343eda0a209fe12d11f3dc2e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0a0eca53_da7d235f","updated":"2022-02-16 20:54:53.000000000","message":"i think this needs further discussion","commit_id":"0a7bf4d93932caaa507018b4a26df993d3cfd894"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"02ffb01d6781176d134543a198596456762878e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"64cf6cde_58384a9e","updated":"2022-03-08 16:54:03.000000000","message":"note: this should NOT be backported down to Train","commit_id":"ac52a0b357120d8318791056e5ad04fa2d9cd171"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3c3069aa8f8b75dcf0e8488152c48d40316592f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"786ac156_032483ba","updated":"2022-03-11 08:08:34.000000000","message":"recheck","commit_id":"ac52a0b357120d8318791056e5ad04fa2d9cd171"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bc6c6988abe3b5dbb1ed30f6c806bf30a8fce137","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e16cd67a_760a7403","updated":"2022-03-09 11:12:47.000000000","message":"recheck","commit_id":"ac52a0b357120d8318791056e5ad04fa2d9cd171"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"97ee29b0ad6586b16427cc589bf813d83c0c8b18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bd963166_83857003","in_reply_to":"64cf6cde_58384a9e","updated":"2022-03-09 11:00:44.000000000","message":"...but it should be to Wallaby","commit_id":"ac52a0b357120d8318791056e5ad04fa2d9cd171"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"606d132e493a6bae4333e53970f3a7d83b749e49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"50d3562d_73287e83","updated":"2022-03-17 09:34:26.000000000","message":"PTAL","commit_id":"700cd6c68e12a733d9424e02c3531a04daa2c1bf"}],"environments/lifecycle/upgrade-prepare.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c635140156a68d906267d9dfd5346b3ae8047f5d","unresolved":true,"context_lines":[{"line_number":25,"context_line":"  #"},{"line_number":26,"context_line":"  # https://docs.openstack.org/nova/latest/admin/hw-machine-type.html"},{"line_number":27,"context_line":"  #"},{"line_number":28,"context_line":"  NovaHWMachineType: \u0027x86_64\u003dpc-i440fx-rhel7.6.0,aarch64\u003dvirt-rhel7.6.0,ppc64\u003dpseries-rhel7.6.0,ppc64le\u003dpseries-rhel7.6.0\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"67f25e20_779bb543","line":28,"updated":"2022-02-11 15:05:10.000000000","message":"I assumed we can skip this override for the upgrade-converge env file?..","commit_id":"0a7bf4d93932caaa507018b4a26df993d3cfd894"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"96a33a910c80d028a460087bd1495e281dfd7cc9","unresolved":true,"context_lines":[{"line_number":25,"context_line":"  #"},{"line_number":26,"context_line":"  # https://docs.openstack.org/nova/latest/admin/hw-machine-type.html"},{"line_number":27,"context_line":"  #"},{"line_number":28,"context_line":"  NovaHWMachineType: \u0027x86_64\u003dpc-i440fx-rhel7.6.0,aarch64\u003dvirt-rhel7.6.0,ppc64\u003dpseries-rhel7.6.0,ppc64le\u003dpseries-rhel7.6.0\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fa02d9f_1402b2c2","line":28,"in_reply_to":"56c87dee_d2fa3185","updated":"2022-02-17 20:21:30.000000000","message":"I believe I got from the docs link that the setting is \"sticky\" at instance creation time. So, for the sake of argument, if the configured type is X, I create an instance, change the config to Y, \"server rebuild\" the instance, the machine type would still be X.\n\nWhat still needs clarification though is what happens for users who have specifically set the NovaHWMachineType parameter to a different value than what you\u0027re setting here? Aren\u0027t we overwriting their desired configuration, and wouldn\u0027t this be unexpected for new instances they create in the future?","commit_id":"0a7bf4d93932caaa507018b4a26df993d3cfd894"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"a04167791623e54343eda0a209fe12d11f3dc2e1","unresolved":true,"context_lines":[{"line_number":25,"context_line":"  #"},{"line_number":26,"context_line":"  # https://docs.openstack.org/nova/latest/admin/hw-machine-type.html"},{"line_number":27,"context_line":"  #"},{"line_number":28,"context_line":"  NovaHWMachineType: \u0027x86_64\u003dpc-i440fx-rhel7.6.0,aarch64\u003dvirt-rhel7.6.0,ppc64\u003dpseries-rhel7.6.0,ppc64le\u003dpseries-rhel7.6.0\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"56c87dee_d2fa3185","line":28,"in_reply_to":"67f25e20_779bb543","updated":"2022-02-16 20:54:53.000000000","message":"what about the case where a user has this set to some other value, would it matter? is it also only set on the instance at instance create? what if you \"server rebuild\" and the configured nova value has changed, what happens?\n\nBased on my reading of https://docs.openstack.org/nova/latest/admin/hw-machine-type.html#update, the workflow needs to be:\n\n- update to latest nova-compute version\n- restart nova-compute (this sets hw_machine_type for any instance where it is not set)\n- configure hw_machine_type in nova.conf","commit_id":"0a7bf4d93932caaa507018b4a26df993d3cfd894"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ac6375efa21799df1ba60e62951a400824715c52","unresolved":true,"context_lines":[{"line_number":25,"context_line":"  #"},{"line_number":26,"context_line":"  # https://docs.openstack.org/nova/latest/admin/hw-machine-type.html"},{"line_number":27,"context_line":"  #"},{"line_number":28,"context_line":"  NovaHWMachineType: \u0027x86_64\u003dpc-i440fx-rhel7.6.0,aarch64\u003dvirt-rhel7.6.0,ppc64\u003dpseries-rhel7.6.0,ppc64le\u003dpseries-rhel7.6.0\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6e1f24_dc2a133a","line":28,"in_reply_to":"78d1b225_cfa11c99","updated":"2022-03-08 13:12:57.000000000","message":"it seems it would be enough to modify puppet tripleo profile defaults for it, for Train only. That would fit all the described scenarios, including a user with a custom value for NovaHWMachineType which must be retained","commit_id":"0a7bf4d93932caaa507018b4a26df993d3cfd894"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"57f26a62e575ab0517ba9767a4b7cbe5ed0475ee","unresolved":true,"context_lines":[{"line_number":25,"context_line":"  #"},{"line_number":26,"context_line":"  # https://docs.openstack.org/nova/latest/admin/hw-machine-type.html"},{"line_number":27,"context_line":"  #"},{"line_number":28,"context_line":"  NovaHWMachineType: \u0027x86_64\u003dpc-i440fx-rhel7.6.0,aarch64\u003dvirt-rhel7.6.0,ppc64\u003dpseries-rhel7.6.0,ppc64le\u003dpseries-rhel7.6.0\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"78d1b225_cfa11c99","line":28,"in_reply_to":"9fa02d9f_1402b2c2","updated":"2022-03-07 18:44:22.000000000","message":"the intended upgrade semantics are as follows\n\nfor clean deployment we shoudl use the new default which use the Q35 machine type on x86\n\nfor upgrades we should use the value that is currently being used on the cloud being upgraded and then as a post action the operator shoudl update there config to the new default.\n\nwhere an operator has already overridden the default that should take precidnece and still be applied.\n\nthe reason this is being done is that support for the PC machine type is expected to be removed in rhel/centos in the future.\n\nwith my downstream hat on the pc machine type is deprecated in osp 17(stable/wallaby) and unsupported in osp 18(stable/zed) and will be removed from qemu (tenitivly) in rhel 10\n\nso the intent is to have operators opt in to the new default after they upstrade\nand maintain the stable/wallaby(osp16.2) default until after the upgrade is complete. new deployment should use the new Q35 machine type from the start.\nwhere an override has been set by an opterator that should still take precidence.\nim not sure how to express that in ooo but that is what we intended to be implemented.","commit_id":"0a7bf4d93932caaa507018b4a26df993d3cfd894"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f4062cb44db3285de7cb1fa98b185bffb72f8f53","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  #"},{"line_number":26,"context_line":"  # https://docs.openstack.org/nova/latest/admin/hw-machine-type.html"},{"line_number":27,"context_line":"  #"},{"line_number":28,"context_line":"  NovaHWMachineType: \u0027x86_64\u003dpc-i440fx-rhel7.6.0,aarch64\u003dvirt-rhel7.6.0,ppc64\u003dpseries-rhel7.6.0,ppc64le\u003dpseries-rhel7.6.0\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ea2b113f_109366c1","line":28,"in_reply_to":"fa6e1f24_dc2a133a","updated":"2022-03-09 11:00:56.000000000","message":"Done","commit_id":"0a7bf4d93932caaa507018b4a26df993d3cfd894"}]}