)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"2c9e4d78b5cba0043872e007114f2161ac5d7a3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"983443f7_d9f6eed1","updated":"2022-02-17 01:32:54.000000000","message":"recheck","commit_id":"2bc31b5edcd27bc88f24246e137ae65c1639e62b"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"0c80f15c16d8f87d8beb19c07a8fb01a7f861447","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"46473989_df00b089","updated":"2022-02-17 06:57:51.000000000","message":"+1, I think we should consider Rabi\u0027s suggestion on adding an option.","commit_id":"200e10003f828b733a1c6ab794affd14300fb5d4"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"cb3a03673b592a9511477993c60591ef9e489305","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cdfd28d1_74c8669c","updated":"2022-02-17 11:41:45.000000000","message":"LGTM.","commit_id":"0c3ea4c286ee3109a04852c7676a1f3037a7aaf8"}],"tools/convert_heat_nic_config_to_ansible_j2.py":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"22f0ba7d78d905682a9ea2e57f86d386fc0cbcba","unresolved":true,"context_lines":[{"line_number":488,"context_line":"            return {}"},{"line_number":489,"context_line":"        stack_env \u003d conn.orchestration.get_stack_environment(stack)"},{"line_number":490,"context_line":"    except Exception:"},{"line_number":491,"context_line":"        return None"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    return stack_env"},{"line_number":494,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5212ae11_f1e90a2f","line":491,"range":{"start_line":491,"start_character":8,"end_line":491,"end_character":19},"updated":"2022-02-17 06:05:07.000000000","message":"Though it\u0027s just an utility, when using with existing deployments, in case of any error it would probably convert the configs incorrectly.\n\nWhy not have a cli option to specify (whether to use with a deployment or not)?","commit_id":"200e10003f828b733a1c6ab794affd14300fb5d4"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"a52beb168f31d4d25b783f1b2e55d5391e006b75","unresolved":false,"context_lines":[{"line_number":488,"context_line":"            return {}"},{"line_number":489,"context_line":"        stack_env \u003d conn.orchestration.get_stack_environment(stack)"},{"line_number":490,"context_line":"    except Exception:"},{"line_number":491,"context_line":"        return None"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    return stack_env"},{"line_number":494,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"27a3b84f_223936b6","line":491,"range":{"start_line":491,"start_character":8,"end_line":491,"end_character":19},"in_reply_to":"023fe2cb_08ac228d","updated":"2022-02-17 11:46:04.000000000","message":"Done","commit_id":"200e10003f828b733a1c6ab794affd14300fb5d4"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"0c80f15c16d8f87d8beb19c07a8fb01a7f861447","unresolved":true,"context_lines":[{"line_number":488,"context_line":"            return {}"},{"line_number":489,"context_line":"        stack_env \u003d conn.orchestration.get_stack_environment(stack)"},{"line_number":490,"context_line":"    except Exception:"},{"line_number":491,"context_line":"        return None"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    return stack_env"},{"line_number":494,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"b3a142f5_ceb6f2c3","line":491,"range":{"start_line":491,"start_character":8,"end_line":491,"end_character":19},"in_reply_to":"5212ae11_f1e90a2f","updated":"2022-02-17 06:57:51.000000000","message":"The tool would print a warning, see L249 above.\nAnd also put \u0027NEED MANUAL CONVERSION\u0027 in the output file.\n\nDue to the fact it does print warnings and try to highlight any errors in the generated output file I\u0027m not sure we must to have a CLI option? \n\nAlthough, UX wise it might be good to have such option. In that case I think we should enforce using the option to allow using the script without a deployment.","commit_id":"200e10003f828b733a1c6ab794affd14300fb5d4"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"759f56963f284e0986c8be1b1f334381d322e0e5","unresolved":true,"context_lines":[{"line_number":488,"context_line":"            return {}"},{"line_number":489,"context_line":"        stack_env \u003d conn.orchestration.get_stack_environment(stack)"},{"line_number":490,"context_line":"    except Exception:"},{"line_number":491,"context_line":"        return None"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    return stack_env"},{"line_number":494,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"023fe2cb_08ac228d","line":491,"range":{"start_line":491,"start_character":8,"end_line":491,"end_character":19},"in_reply_to":"b3a142f5_ceb6f2c3","updated":"2022-02-17 10:57:41.000000000","message":"Yeah, good idea. Let\u0027s do it. New patchset coming soon.","commit_id":"200e10003f828b733a1c6ab794affd14300fb5d4"}]}