)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"d42706709f7b3215c99e504ed9b92a1cbcbf6c1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"66b9d93a_abeac15e","updated":"2022-02-22 10:26:24.000000000","message":"I\u0027m not sure about these footgun fixes in general. Why on earth was libvirt installed on the UC int the first place?\n\nKevin\u0027s suggestion on masking the service makes sense.","commit_id":"155867eb64c8297af1748120b9d10f85b2dd4ce1"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"468c29a7be4c80e8cf6557b27294fc338eaef14c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d7dbf46f_9df8797e","updated":"2022-02-22 13:22:25.000000000","message":"recheck","commit_id":"155867eb64c8297af1748120b9d10f85b2dd4ce1"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"1b92b57b60756246b3a3dc146af9c2dc90beaccf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fa67b250_d83ba1bc","in_reply_to":"66b9d93a_abeac15e","updated":"2022-02-22 13:13:03.000000000","message":"Let\u0027s say customer deploy a RHEL server with GDM and libvirtd is installed and enabled by default in those groups ?   I think this is 99% of the ~50 cases we got in the past few cycles.","commit_id":"155867eb64c8297af1748120b9d10f85b2dd4ce1"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"864d8fdc7af4950f59582c3247d223ebc0e79bd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cbaf8dc1_a930d61c","in_reply_to":"fa67b250_d83ba1bc","updated":"2022-02-22 14:02:26.000000000","message":"+1 to what Harald said in chat. Effectively run two tasks: ensure the service is stopped if it\u0027s actually installed and always mask the server to ensure it is never started even if it is installed out-of-band.","commit_id":"155867eb64c8297af1748120b9d10f85b2dd4ce1"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"4ec4da62e26e7c209299fdd8701a03f6b514b6e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b6c371d8_eb5a3cb2","updated":"2022-02-22 15:54:09.000000000","message":"I\u0027m struggling as to why we need a new service to disable/mask libvirt.\n\nFor new installs, they won\u0027t have libvirt.\nFor upgrades, can\u0027t we just use the existing UndercloudUpgrade service?\n\nWhat is the intent here? Just to prevent accidental install of libvirt at a later date? I don\u0027t think we need to add handling for that, and would instead prefer this to be implemented as an undercloud validation if that is the motivation.","commit_id":"bf591308b4a49e193fc7332893641e2067369eb7"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"1c6789d4ba11bae847e53d530bac626f93714d41","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2bc6d9e8_b8c480cd","in_reply_to":"1316d9b4_a98e0e6a","updated":"2022-02-22 20:41:30.000000000","message":"So, we need to validate this before doing anything and raise an Error. 👍","commit_id":"bf591308b4a49e193fc7332893641e2067369eb7"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"8890a9a7779e50d7f6f18e29f16399a3a27db0a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7081b321_a2167fc9","in_reply_to":"3b96aa40_10aca510","updated":"2022-02-22 16:25:08.000000000","message":"this is exactly the case for a validation. same as if there isn\u0027t enough disk space. we shouldn\u0027t try to mask or hide that issue. what if the customer has installed virt-manager for a specific reason? i\u0027m not a fan of just masking out critical services on the RHEL node they\u0027ve chosen to install the undercloud. They\u0027ve clearly made a wrong choice...we need to surface that.","commit_id":"bf591308b4a49e193fc7332893641e2067369eb7"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"d926c2981db78016e92692308ff7649e3d387716","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e5907fa1_0aa11f93","in_reply_to":"7081b321_a2167fc9","updated":"2022-02-22 18:58:19.000000000","message":"I agree with James. \n\nI can imagine a junior sysadmin tasked with installing an undercloud, he/she is told to install it on host kvm-13. Junior sysadmin fail to realize the undercloud should be a VM on host kvm-13 and install the undercloud on kvm-13 ... boom libvirt stops and business is interupted because kvm-13 stopped working. Junior sysadmin looses confidence and does not go on to do great things.\n\nLet\u0027s raise the issue to the user instead of hiding it and potentially cause other problems.","commit_id":"bf591308b4a49e193fc7332893641e2067369eb7"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"8a5b1817c62e2062b95b1228ce7b629d62b0bc10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3b96aa40_10aca510","in_reply_to":"b6c371d8_eb5a3cb2","updated":"2022-02-22 15:58:57.000000000","message":"We\u0027ll move all the other place where we stop/disable/mask libvirt under tripleo_ansible too but we need to make sure dnsmasq / libvirtd is not running on the undercloud.   Troubleshooting those issues generates some cases that would\u0027ve been avoided if we did this from the beginning.   libvirtd can\u0027t be running on a node where you install the undercloud otherwise introspection will break.  This is not an upgrade but an installation issue.  Users will just install tripleo-client on a RHEL Server with virt-manager installed along with libvirtd , GDM anx X11 .   We could\u0027ve avoided a bunch of user issues with this ... along in the overcloud controllers where sometimes users will have pre-provisionned nodes where libvirtd is installed.   It adds hours of useless troubleshooting that could\u0027ve been avoided by handling those issues in the installer.","commit_id":"bf591308b4a49e193fc7332893641e2067369eb7"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"929e78f1ea6084179b4c67039117c1da533d37f5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1316d9b4_a98e0e6a","in_reply_to":"e5907fa1_0aa11f93","updated":"2022-02-22 19:30:51.000000000","message":"If a junior sysadmin installs the undercloud on that node and it goes up to that point, the node is dead anyways. ;)","commit_id":"bf591308b4a49e193fc7332893641e2067369eb7"}],"deployment/undercloud/undercloud-install.yaml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9301212f5da163093579528b591d94917a8908f9","unresolved":true,"context_lines":[{"line_number":32,"context_line":"  role_data:"},{"line_number":33,"context_line":"    description: Role data for the TripleO Undercloud Upgrade service."},{"line_number":34,"context_line":"    value:"},{"line_number":35,"context_line":"      service_name: undercloud_upgrade"},{"line_number":36,"context_line":"      config_settings: {}"},{"line_number":37,"context_line":"      deploy_steps_tasks: []"},{"line_number":38,"context_line":"      docker_config: {}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"335441a6_ce243c74","line":35,"range":{"start_line":35,"start_character":30,"end_line":35,"end_character":38},"updated":"2022-02-21 15:51:38.000000000","message":"upgrade?","commit_id":"c237bd95e630e87de695729e9bcbf3da12bf22fd"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"d42706709f7b3215c99e504ed9b92a1cbcbf6c1c","unresolved":true,"context_lines":[{"line_number":40,"context_line":"      puppet_config: {}"},{"line_number":41,"context_line":"      host_prep_tasks:"},{"line_number":42,"context_line":"        - name: check if libvirt is installed"},{"line_number":43,"context_line":"          command: /usr/bin/rpm -q libvirt-daemon"},{"line_number":44,"context_line":"          failed_when: false"},{"line_number":45,"context_line":"          register: libvirt_installed"},{"line_number":46,"context_line":"          check_mode: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9dd7d284_9441eb25","line":43,"range":{"start_line":43,"start_character":27,"end_line":43,"end_character":49},"updated":"2022-02-22 10:26:24.000000000","message":"Should we do \"rpm -q --whatprovides libvirt-daemon\" here, in case there is ever a wrapper RPM?","commit_id":"c237bd95e630e87de695729e9bcbf3da12bf22fd"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"1b92b57b60756246b3a3dc146af9c2dc90beaccf","unresolved":true,"context_lines":[{"line_number":40,"context_line":"      puppet_config: {}"},{"line_number":41,"context_line":"      host_prep_tasks:"},{"line_number":42,"context_line":"        - name: check if libvirt is installed"},{"line_number":43,"context_line":"          command: /usr/bin/rpm -q libvirt-daemon"},{"line_number":44,"context_line":"          failed_when: false"},{"line_number":45,"context_line":"          register: libvirt_installed"},{"line_number":46,"context_line":"          check_mode: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8a2ce394_890d079f","line":43,"range":{"start_line":43,"start_character":27,"end_line":43,"end_character":49},"in_reply_to":"9dd7d284_9441eb25","updated":"2022-02-22 13:13:03.000000000","message":"I copy/pasted this code from 2 other deployment files already present in tht... would \"--whatprovides\" change something to \"-q\" alone or would it just return the name of the package wrapping that libvirt-daemon package like \"libvirtd\" but either ones works ?  Sorry I\u0027m not dnf/rpm expert here.","commit_id":"c237bd95e630e87de695729e9bcbf3da12bf22fd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9301212f5da163093579528b591d94917a8908f9","unresolved":true,"context_lines":[{"line_number":38,"context_line":"      docker_config: {}"},{"line_number":39,"context_line":"      kolla_config: {}"},{"line_number":40,"context_line":"      puppet_config: {}"},{"line_number":41,"context_line":"      host_prep_tasks:"},{"line_number":42,"context_line":"        - name: check if libvirt is installed"},{"line_number":43,"context_line":"          command: /usr/bin/rpm -q libvirt-daemon"},{"line_number":44,"context_line":"          failed_when: false"},{"line_number":45,"context_line":"          register: libvirt_installed"},{"line_number":46,"context_line":"          check_mode: false"},{"line_number":47,"context_line":"        - name: make sure libvirt services are disabled and masked"},{"line_number":48,"context_line":"          service:"},{"line_number":49,"context_line":"            name: \"{{ item }}\""},{"line_number":50,"context_line":"            state: stopped"},{"line_number":51,"context_line":"            enabled: false"},{"line_number":52,"context_line":"            masked: true"},{"line_number":53,"context_line":"            daemon_reload: true"},{"line_number":54,"context_line":"          loop:"},{"line_number":55,"context_line":"            - libvirtd.service"},{"line_number":56,"context_line":"            - virtlogd.socket"},{"line_number":57,"context_line":"          when: libvirt_installed.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a59a76bf_f6f3076b","line":57,"range":{"start_line":41,"start_character":0,"end_line":57,"end_character":41},"updated":"2022-02-21 15:51:38.000000000","message":"As a host prep-task interacting with systemd is there a potential here for a race? If so, I think we can do this and fallback to some sort of a systemd override which can be dropped at any time and force libvirt to never start when running on the undercloud.","commit_id":"c237bd95e630e87de695729e9bcbf3da12bf22fd"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"e4050fdbeeba438b37c99bee960c3a9928fcd4e5","unresolved":true,"context_lines":[{"line_number":38,"context_line":"      docker_config: {}"},{"line_number":39,"context_line":"      kolla_config: {}"},{"line_number":40,"context_line":"      puppet_config: {}"},{"line_number":41,"context_line":"      host_prep_tasks:"},{"line_number":42,"context_line":"        - name: check if libvirt is installed"},{"line_number":43,"context_line":"          command: /usr/bin/rpm -q libvirt-daemon"},{"line_number":44,"context_line":"          failed_when: false"},{"line_number":45,"context_line":"          register: libvirt_installed"},{"line_number":46,"context_line":"          check_mode: false"},{"line_number":47,"context_line":"        - name: make sure libvirt services are disabled and masked"},{"line_number":48,"context_line":"          service:"},{"line_number":49,"context_line":"            name: \"{{ item }}\""},{"line_number":50,"context_line":"            state: stopped"},{"line_number":51,"context_line":"            enabled: false"},{"line_number":52,"context_line":"            masked: true"},{"line_number":53,"context_line":"            daemon_reload: true"},{"line_number":54,"context_line":"          loop:"},{"line_number":55,"context_line":"            - libvirtd.service"},{"line_number":56,"context_line":"            - virtlogd.socket"},{"line_number":57,"context_line":"          when: libvirt_installed.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"db7c5010_085628ae","line":57,"range":{"start_line":41,"start_character":0,"end_line":57,"end_character":41},"in_reply_to":"054ecf41_5beca8cb","updated":"2022-02-22 13:16:33.000000000","message":"I don\u0027t get what\u0027s different here beside that you splitted the \"- name: make sure libvirt services are disabled and masked\" section into 2  ... if it\u0027s installed, we mask, disable and stop it .    In your example, in the first section you just make sure it\u0027s not enabled and masked ... if it\u0027s installed then you stop it ... but it\u0027s masked ?   What\u0027s wrong with the code on the right side ?  It\u0027s the same code being used in 2 other deployment files that I just re-used.","commit_id":"c237bd95e630e87de695729e9bcbf3da12bf22fd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"97e6e83f55aba8bcba6c8502dfe0be16ebf924f2","unresolved":true,"context_lines":[{"line_number":38,"context_line":"      docker_config: {}"},{"line_number":39,"context_line":"      kolla_config: {}"},{"line_number":40,"context_line":"      puppet_config: {}"},{"line_number":41,"context_line":"      host_prep_tasks:"},{"line_number":42,"context_line":"        - name: check if libvirt is installed"},{"line_number":43,"context_line":"          command: /usr/bin/rpm -q libvirt-daemon"},{"line_number":44,"context_line":"          failed_when: false"},{"line_number":45,"context_line":"          register: libvirt_installed"},{"line_number":46,"context_line":"          check_mode: false"},{"line_number":47,"context_line":"        - name: make sure libvirt services are disabled and masked"},{"line_number":48,"context_line":"          service:"},{"line_number":49,"context_line":"            name: \"{{ item }}\""},{"line_number":50,"context_line":"            state: stopped"},{"line_number":51,"context_line":"            enabled: false"},{"line_number":52,"context_line":"            masked: true"},{"line_number":53,"context_line":"            daemon_reload: true"},{"line_number":54,"context_line":"          loop:"},{"line_number":55,"context_line":"            - libvirtd.service"},{"line_number":56,"context_line":"            - virtlogd.socket"},{"line_number":57,"context_line":"          when: libvirt_installed.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"054ecf41_5beca8cb","line":57,"range":{"start_line":41,"start_character":0,"end_line":57,"end_character":41},"in_reply_to":"a59a76bf_f6f3076b","updated":"2022-02-21 20:35:56.000000000","message":"To ensure everything is masked, and not started, and not started should libvirt be installed on the undercloud at a later date, I think we should do something like this::\n\n\n      host_prep_tasks:\n        - name: make sure libvirt services are disabled and masked\n          service:\n            name: \"{{ item }}\"\n            enabled: false\n            masked: true\n            daemon_reload: true\n          loop:\n            - libvirtd.service\n            - virtlogd.socket\n        - name: check if libvirt is installed\n          command: /usr/bin/rpm -q libvirt-daemon\n          failed_when: false\n          register: libvirt_installed\n          check_mode: false\n        - name: make sure libvirt services are disabled and masked\n          service:\n            name: \"{{ item }}\"\n            state: stopped\n          loop:\n            - libvirtd.service\n            - virtlogd.socket\n          when:\n            - libvirt_installed.rc \u003d\u003d 0","commit_id":"c237bd95e630e87de695729e9bcbf3da12bf22fd"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"9f01ffb3406c5a5b9c5b38a4e96c28a554d83de3","unresolved":true,"context_lines":[{"line_number":38,"context_line":"      docker_config: {}"},{"line_number":39,"context_line":"      kolla_config: {}"},{"line_number":40,"context_line":"      puppet_config: {}"},{"line_number":41,"context_line":"      host_prep_tasks:"},{"line_number":42,"context_line":"        - name: check if libvirt is installed"},{"line_number":43,"context_line":"          command: /usr/bin/rpm -q libvirt-daemon"},{"line_number":44,"context_line":"          failed_when: false"},{"line_number":45,"context_line":"          register: libvirt_installed"},{"line_number":46,"context_line":"          check_mode: false"},{"line_number":47,"context_line":"        - name: make sure libvirt services are disabled and masked"},{"line_number":48,"context_line":"          service:"},{"line_number":49,"context_line":"            name: \"{{ item }}\""},{"line_number":50,"context_line":"            state: stopped"},{"line_number":51,"context_line":"            enabled: false"},{"line_number":52,"context_line":"            masked: true"},{"line_number":53,"context_line":"            daemon_reload: true"},{"line_number":54,"context_line":"          loop:"},{"line_number":55,"context_line":"            - libvirtd.service"},{"line_number":56,"context_line":"            - virtlogd.socket"},{"line_number":57,"context_line":"          when: libvirt_installed.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f965a134_f363bf34","line":57,"range":{"start_line":41,"start_character":0,"end_line":57,"end_character":41},"in_reply_to":"db7c5010_085628ae","updated":"2022-02-22 13:33:15.000000000","message":"I think Kevin\u0027s idea is that even if libvirt is not installed, we mask the service.\nSo that if someone does \u0027dnf install libvirt\u0027 or \u0027group install \"Virtualization Host\", the services are \"pre-masked\" so they won\u0027t start?\n\nI\u0027m not 100% sure if masking the service will work when the packages are not present. If it does, it seems like a good idea?","commit_id":"c237bd95e630e87de695729e9bcbf3da12bf22fd"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"8a5b1817c62e2062b95b1228ce7b629d62b0bc10","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      docker_config: {}"},{"line_number":39,"context_line":"      kolla_config: {}"},{"line_number":40,"context_line":"      puppet_config: {}"},{"line_number":41,"context_line":"      host_prep_tasks:"},{"line_number":42,"context_line":"        - name: check if libvirt is installed"},{"line_number":43,"context_line":"          command: /usr/bin/rpm -q libvirt-daemon"},{"line_number":44,"context_line":"          failed_when: false"},{"line_number":45,"context_line":"          register: libvirt_installed"},{"line_number":46,"context_line":"          check_mode: false"},{"line_number":47,"context_line":"        - name: make sure libvirt services are disabled and masked"},{"line_number":48,"context_line":"          service:"},{"line_number":49,"context_line":"            name: \"{{ item }}\""},{"line_number":50,"context_line":"            state: stopped"},{"line_number":51,"context_line":"            enabled: false"},{"line_number":52,"context_line":"            masked: true"},{"line_number":53,"context_line":"            daemon_reload: true"},{"line_number":54,"context_line":"          loop:"},{"line_number":55,"context_line":"            - libvirtd.service"},{"line_number":56,"context_line":"            - virtlogd.socket"},{"line_number":57,"context_line":"          when: libvirt_installed.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"83aafbbe_a1e568ee","line":57,"range":{"start_line":41,"start_character":0,"end_line":57,"end_character":41},"in_reply_to":"f965a134_f363bf34","updated":"2022-02-22 15:58:57.000000000","message":"[root@overcloud-controller-0 etc]# systemctl mask asdf\nUnit asdf.service does not exist, proceeding anyway.\nCreated symlink /etc/systemd/system/asdf.service → /dev/null.\n\n\nthat would depend if it over write the file or not.","commit_id":"c237bd95e630e87de695729e9bcbf3da12bf22fd"}]}