)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"db875b90ab3f055ad21b307b5f45eb5e1f2bf197","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e85f7816_68d54f31","updated":"2022-02-21 19:48:34.000000000","message":"This master version is an \"upport\" of the stable/train version.\n\nThe main implication is that this hasn\u0027t been tested on a master env yet.","commit_id":"0144ca92772f53e38a75946abd8a7d552c0651d6"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"7dc8c1a5bbe0b7397057b37bdf52d4b9aad1a399","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5e20e7fa_beae24ac","updated":"2022-02-28 00:37:59.000000000","message":"I guess my concern would be, what happens if the user forgets / doesn\u0027t run this step? OVN just doesn\u0027t get upgraded? Does that cause other problems for us?\n\nI\u0027m familiar with the issue you\u0027re addressing, and ovn_controller not being able to connect to northd if the versions mismatch occurs. It happens to users even during overcloud deploy outside of updates if they are using tag: 16.x instead of specific z-streams. But it would be nice if we could somehow better handle this during the update run process itself. Purely from a user-experience perspective.\n\nEven if we did something like record a Ansible fact containing the current version of northd and ovn_controller and block updates to OVN based on those facts. I guess it would break our --limit Controller though if we needed to go and upgrade the Compute ovn_controller.\n\nI don\u0027t have a concrete solution that I would say is better than this proposal. So I personally wont object to the change. Just thought I would throw in a different perspective and opinion for consideration.","commit_id":"88f2dfbba603a07f159a38fdf1a7e37bfccf1d0e"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"0dd645c67fc68dae598e4f8bef69ea001169cfb7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b3209f17_0ab73433","in_reply_to":"5e20e7fa_beae24ac","updated":"2022-03-10 11:03:07.000000000","message":"\u003e But it would be nice if we could somehow better handle this during the update run process itself. Purely from a user-experience perspective.\n\nTotally agree on this, but given how triple revolves around the idea that *a* server is *a* role, we have a very hard time to model anything around a distributed service like OVN with hard constraint about how its architecture is updated.\n\nWhen updating the controller, trying to delegate a task that all compute to update the ovn_controller would just be unexpected long and fragile (and would break the Role barrier).\n\nWhen updating the OSP controller, trying to block any request from the ovn_controller until they are updated on the computes would create a control plane issue during update (no new VMs can be created), which is not acceptable.\n\n\u003e I guess my concern would be, what happens if the user forgets / doesn\u0027t run this \u003e step? OVN just doesn\u0027t get upgraded? Does that cause other problems for us?\n\nIf the user forget, then two things can happen:\n 1. nothing: some versions of OVN manage to work just fine while being updated starting with ovn-northd;\n 2. data plane and control plane total failure: all ping to FIP attached to VMs are broken and no new VMs can be trigger, this is solved by updating ovn_controller on each server belonging to the Compute Role.\n\nThe impact in 2. is pretty dramatic, but then the solution is to run the new command and everything will recover very quickly, so now at least we have an easy way to recover instantaneously, while before we had only \"run the update on all compute ASAP\"","commit_id":"88f2dfbba603a07f159a38fdf1a7e37bfccf1d0e"}],"deployment/ovn/ovn-controller-container-puppet.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"b393a61c184d90eac61063073a4eb39f11f1f52f","unresolved":true,"context_lines":[{"line_number":494,"context_line":"            config_patterns: \u0027ovn_controller.json\u0027"},{"line_number":495,"context_line":"            config_id:"},{"line_number":496,"context_line":"              - \u0027tripleo_step4\u0027"},{"line_number":497,"context_line":"            container_cli: \"{{ container_cli }}\""},{"line_number":498,"context_line":"            log_path: \"{{ container_log_stdout_path }}\""},{"line_number":499,"context_line":"            debug: \"{{ enable_debug | bool }}\""},{"line_number":500,"context_line":"            config_overrides:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a8489045_63469341","line":497,"range":{"start_line":497,"start_character":12,"end_line":497,"end_character":48},"updated":"2022-09-12 13:35:47.000000000","message":"I don\u0027t see this option in tripleo_container_manage","commit_id":"88f2dfbba603a07f159a38fdf1a7e37bfccf1d0e"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"15957929bb2d8f6e6c33aba41001357b7107e7e2","unresolved":false,"context_lines":[{"line_number":494,"context_line":"            config_patterns: \u0027ovn_controller.json\u0027"},{"line_number":495,"context_line":"            config_id:"},{"line_number":496,"context_line":"              - \u0027tripleo_step4\u0027"},{"line_number":497,"context_line":"            container_cli: \"{{ container_cli }}\""},{"line_number":498,"context_line":"            log_path: \"{{ container_log_stdout_path }}\""},{"line_number":499,"context_line":"            debug: \"{{ enable_debug | bool }}\""},{"line_number":500,"context_line":"            config_overrides:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"59371716_d63d274c","line":497,"range":{"start_line":497,"start_character":12,"end_line":497,"end_character":48},"in_reply_to":"a8489045_63469341","updated":"2022-09-27 14:56:39.000000000","message":"fixed in https://review.opendev.org/c/openstack/tripleo-heat-templates/+/857433","commit_id":"88f2dfbba603a07f159a38fdf1a7e37bfccf1d0e"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"b393a61c184d90eac61063073a4eb39f11f1f52f","unresolved":true,"context_lines":[{"line_number":495,"context_line":"            config_id:"},{"line_number":496,"context_line":"              - \u0027tripleo_step4\u0027"},{"line_number":497,"context_line":"            container_cli: \"{{ container_cli }}\""},{"line_number":498,"context_line":"            log_path: \"{{ container_log_stdout_path }}\""},{"line_number":499,"context_line":"            debug: \"{{ enable_debug | bool }}\""},{"line_number":500,"context_line":"            config_overrides:"},{"line_number":501,"context_line":"              ovn_controller:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d4290968_4fdfa283","line":498,"range":{"start_line":498,"start_character":12,"end_line":498,"end_character":20},"updated":"2022-09-12 13:35:47.000000000","message":"log_base_path.. there is no log_path AFAICT.","commit_id":"88f2dfbba603a07f159a38fdf1a7e37bfccf1d0e"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"15957929bb2d8f6e6c33aba41001357b7107e7e2","unresolved":false,"context_lines":[{"line_number":495,"context_line":"            config_id:"},{"line_number":496,"context_line":"              - \u0027tripleo_step4\u0027"},{"line_number":497,"context_line":"            container_cli: \"{{ container_cli }}\""},{"line_number":498,"context_line":"            log_path: \"{{ container_log_stdout_path }}\""},{"line_number":499,"context_line":"            debug: \"{{ enable_debug | bool }}\""},{"line_number":500,"context_line":"            config_overrides:"},{"line_number":501,"context_line":"              ovn_controller:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2f3c2eee_8506a59c","line":498,"range":{"start_line":498,"start_character":12,"end_line":498,"end_character":20},"in_reply_to":"d4290968_4fdfa283","updated":"2022-09-27 14:56:39.000000000","message":"Same.","commit_id":"88f2dfbba603a07f159a38fdf1a7e37bfccf1d0e"}]}