)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"8c2a8ba44b36d81afc85b4e18b5156f8550b802d","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Train-only] Update cells db connection, if needed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For regular Train deployments only create or map the new cells."},{"line_number":10,"context_line":"That saves a few CPU cycles by not checking for the existing cells DB"},{"line_number":11,"context_line":"URIs formats each time."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"When rolling minor updates, only check if existing cells DB URIs have"},{"line_number":14,"context_line":"to be updated into the templated format."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"When upgrading from Queens to Train we should remap the default and"},{"line_number":17,"context_line":"cell0 DB URIs to the templated format. Use the existing FFU detection"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dcefb60b_e9dff4d1","line":14,"range":{"start_line":9,"start_character":0,"end_line":14,"end_character":39},"updated":"2022-03-08 11:24:58.000000000","message":"It the cost really that significant? Far simpler and far safer (especially since this is a train-only bugfix patch) to just update the cell details on every deploy.","commit_id":"add1bfbb51ce9eeab246c9aee975dc56310f61d6"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"dc5100886feed721d90449dbdb580ab3c2b173d6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Train-only] Update cells db connection, if needed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For regular Train deployments only create or map the new cells."},{"line_number":10,"context_line":"That saves a few CPU cycles by not checking for the existing cells DB"},{"line_number":11,"context_line":"URIs formats each time."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"When rolling minor updates, only check if existing cells DB URIs have"},{"line_number":14,"context_line":"to be updated into the templated format."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"When upgrading from Queens to Train we should remap the default and"},{"line_number":17,"context_line":"cell0 DB URIs to the templated format. Use the existing FFU detection"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"b3d31823_28b9cf6c","line":14,"range":{"start_line":9,"start_character":0,"end_line":14,"end_character":39},"in_reply_to":"890359c4_87bbb376","updated":"2022-03-09 10:55:24.000000000","message":"Done","commit_id":"add1bfbb51ce9eeab246c9aee975dc56310f61d6"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"85f0932d4a56a02dc05465e47531a8f4905e545c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Train-only] Update cells db connection, if needed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For regular Train deployments only create or map the new cells."},{"line_number":10,"context_line":"That saves a few CPU cycles by not checking for the existing cells DB"},{"line_number":11,"context_line":"URIs formats each time."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"When rolling minor updates, only check if existing cells DB URIs have"},{"line_number":14,"context_line":"to be updated into the templated format."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"When upgrading from Queens to Train we should remap the default and"},{"line_number":17,"context_line":"cell0 DB URIs to the templated format. Use the existing FFU detection"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"890359c4_87bbb376","line":14,"range":{"start_line":9,"start_character":0,"end_line":14,"end_character":39},"in_reply_to":"dcefb60b_e9dff4d1","updated":"2022-03-09 10:47:50.000000000","message":"I\u0027ve been addressing James\u0027 concerns.","commit_id":"add1bfbb51ce9eeab246c9aee975dc56310f61d6"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"8c2a8ba44b36d81afc85b4e18b5156f8550b802d","unresolved":true,"context_lines":[{"line_number":20,"context_line":"clean things up and run before the common bootstrap and deploy steps."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"In order to retain the expected ordering, move Nova Conductor deploy"},{"line_number":23,"context_line":"tasks to step 4 order 10-12, and align the remaining Nova services:"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"deploy step 3:"},{"line_number":26,"context_line":"0 nova_api_db_sync_stein stein (if FFU)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5e8d0292_be881603","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":27},"updated":"2022-03-08 11:24:58.000000000","message":"I would be particularly cautious when changing any of this. If it\u0027s really necessary then I\u0027d recommend landing it on master for a while first to shake out any timing issues.","commit_id":"add1bfbb51ce9eeab246c9aee975dc56310f61d6"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2c0f34081b6bd70d5207de417782bb7c16919047","unresolved":true,"context_lines":[{"line_number":20,"context_line":"clean things up and run before the common bootstrap and deploy steps."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"In order to retain the expected ordering, move Nova Conductor deploy"},{"line_number":23,"context_line":"tasks to step 4 order 10-12, and align the remaining Nova services:"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"deploy step 3:"},{"line_number":26,"context_line":"0 nova_api_db_sync_stein stein (if FFU)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"af93d906_34372773","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":27},"in_reply_to":"5e8d0292_be881603","updated":"2022-03-09 10:49:00.000000000","message":"there is no other way to implement it in today framework unfortunately","commit_id":"add1bfbb51ce9eeab246c9aee975dc56310f61d6"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"de2bdedebaadb7b4be9327251afe3ffbe0b6861f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"clean things up and run before the common bootstrap and deploy steps."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"In order to retain the expected ordering, move Nova Conductor deploy"},{"line_number":23,"context_line":"tasks to step 4 order 10-12, and align the remaining Nova services:"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"deploy step 3:"},{"line_number":26,"context_line":"0 nova_api_db_sync_stein stein (if FFU)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"cc4920f6_9291b7a2","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":27},"in_reply_to":"af93d906_34372773","updated":"2022-03-09 10:59:08.000000000","message":"Done","commit_id":"add1bfbb51ce9eeab246c9aee975dc56310f61d6"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e0b52f50094490d5ecbd1794a89b900603f66db6","unresolved":true,"context_lines":[{"line_number":50,"context_line":"- Use Kolla configs for the update/map cell containers."},{"line_number":51,"context_line":"  (to simplify backporting as it provides a partial backport for Nova"},{"line_number":52,"context_line":"  of I0e3d5748a50937880a55413b75fe6eca479c9160)"},{"line_number":53,"context_line":"- Make scripts to support multi-cell FFU case as well."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Related: rhbz#2030191"},{"line_number":56,"context_line":"Related: rhbz#1759007"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"e51cdccc_c65c8a5d","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":54},"updated":"2022-03-11 12:28:12.000000000","message":"As Oliver explained it to me, we don\u0027t have to care about other cells templated URIs here.\nIf the user followed the docs [0], then they should have a templated uri already [1]\n\n\n[0] then they should have a templated uri https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_cellv2/tasks/create_cell.yml#L24\n\n[1] https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_cellv2/tasks/create_cell.yml#L24","commit_id":"1a345b8bf40b314639cf47165dd3f54e7301e490"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5c12ac91a1c55830911a9f4943b84cdf6389d742","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"99e7d5b2_9dcc561e","updated":"2022-03-11 08:50:51.000000000","message":"@Oliver, I hope I\u0027ve addressed all you concerns.\nMulti-cell iteration will help us in future with https://bugzilla.redhat.com/show_bug.cgi?id\u003d1759007","commit_id":"4247866e6a1fccbd7e92c511fd099065bbe17486"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"623a1c36a921d7adca714748bb49940d34ff24d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b2702656_18f8433b","updated":"2022-03-11 12:19:27.000000000","message":"let\u0027s try https://review.opendev.org/c/openstack/tripleo-heat-templates/+/833285/2/deployment/nova/nova-api-container-puppet.yaml","commit_id":"1a345b8bf40b314639cf47165dd3f54e7301e490"}],"deployment/nova/nova-api-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"58ddeca264b982fc998cf2be10dadea4893a14e3","unresolved":true,"context_lines":[{"line_number":643,"context_line":"      update_tasks:"},{"line_number":644,"context_line":"        # NOTE(bogdando): this runs on step 4 since it needs nova_api up after step 3,"},{"line_number":645,"context_line":"        # and it must finish before nova-conductor dbsync in the same step 4"},{"line_number":646,"context_line":"        - name: Update URI for Nova default cell DB to use a template"},{"line_number":647,"context_line":"          when:"},{"line_number":648,"context_line":"            - step|int \u003d\u003d 4"},{"line_number":649,"context_line":"          shell: \u0026cells_map_tasks |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2aee1d96_bc249c31","line":646,"updated":"2022-02-22 16:42:11.000000000","message":"oh, actually cached data must be updated w/ SIGHUP\nfor all the scheduler, conductor, API service workers","commit_id":"32452aecede518fb45dd6f51197b4db169114901"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"0c7ae6430a9d42d0dd3d90098ea2843ae396d2d6","unresolved":true,"context_lines":[{"line_number":643,"context_line":"      update_tasks:"},{"line_number":644,"context_line":"        # NOTE(bogdando): this runs on step 4 since it needs nova_api up after step 3,"},{"line_number":645,"context_line":"        # and it must finish before nova-conductor dbsync in the same step 4"},{"line_number":646,"context_line":"        - name: Update URI for Nova default cell DB to use a template"},{"line_number":647,"context_line":"          when:"},{"line_number":648,"context_line":"            - step|int \u003d\u003d 4"},{"line_number":649,"context_line":"          shell: \u0026cells_map_tasks |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b2983114_2e3eddad","line":646,"in_reply_to":"2aee1d96_bc249c31","updated":"2022-02-22 16:58:01.000000000","message":"Please disregard, we can omit reloading these, since containers images versions are always poked for a minor update","commit_id":"32452aecede518fb45dd6f51197b4db169114901"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"93cbb6d59ec44f7c1dc3b199dc9cf4ff7d98b2f7","unresolved":false,"context_lines":[{"line_number":643,"context_line":"      update_tasks:"},{"line_number":644,"context_line":"        # NOTE(bogdando): this runs on step 4 since it needs nova_api up after step 3,"},{"line_number":645,"context_line":"        # and it must finish before nova-conductor dbsync in the same step 4"},{"line_number":646,"context_line":"        - name: Update URI for Nova default cell DB to use a template"},{"line_number":647,"context_line":"          when:"},{"line_number":648,"context_line":"            - step|int \u003d\u003d 4"},{"line_number":649,"context_line":"          shell: \u0026cells_map_tasks |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ef80afd5_9d44c451","line":646,"in_reply_to":"b2983114_2e3eddad","updated":"2022-02-22 16:59:38.000000000","message":"Done","commit_id":"32452aecede518fb45dd6f51197b4db169114901"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"8c2a8ba44b36d81afc85b4e18b5156f8550b802d","unresolved":true,"context_lines":[{"line_number":408,"context_line":"                    #!/bin/bash"},{"line_number":409,"context_line":"                    CLIST\u003d$(su nova -s /bin/bash -c \"nova-manage cell_v2 list_cells\")"},{"line_number":410,"context_line":"                    echo \"(cellv2) Cell list: $CLIST\""},{"line_number":411,"context_line":"                    CELL\u003dcell0  # which cell to create by mapping it"},{"line_number":412,"context_line":"                    CELLID\u003d$(printf \"$CLIST\" | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -v cell\u003d$CELL -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d cell {print $4}\u0027)"},{"line_number":413,"context_line":"                    CELLDBC\u003d$(printf \"$CLIST\" | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -v cell\u003d$CELL -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d cell {print $8}\u0027)"},{"line_number":414,"context_line":"                    echo \"(cellv2) CELLID: $CELLID\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"59d1a6a7_a7b97655","line":411,"range":{"start_line":411,"start_character":34,"end_line":411,"end_character":44},"updated":"2022-03-08 11:24:58.000000000","message":"This implies it\u0027s variable when it is not. Could cause confusion for maintainers in future.","commit_id":"b48dcf182b645c5493c48b2bd86a08467de7773f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"dc5100886feed721d90449dbdb580ab3c2b173d6","unresolved":true,"context_lines":[{"line_number":408,"context_line":"                    #!/bin/bash"},{"line_number":409,"context_line":"                    CLIST\u003d$(su nova -s /bin/bash -c \"nova-manage cell_v2 list_cells\")"},{"line_number":410,"context_line":"                    echo \"(cellv2) Cell list: $CLIST\""},{"line_number":411,"context_line":"                    CELL\u003dcell0  # which cell to create by mapping it"},{"line_number":412,"context_line":"                    CELLID\u003d$(printf \"$CLIST\" | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -v cell\u003d$CELL -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d cell {print $4}\u0027)"},{"line_number":413,"context_line":"                    CELLDBC\u003d$(printf \"$CLIST\" | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -v cell\u003d$CELL -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d cell {print $8}\u0027)"},{"line_number":414,"context_line":"                    echo \"(cellv2) CELLID: $CELLID\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"61462e01_e493d1f8","line":411,"range":{"start_line":411,"start_character":34,"end_line":411,"end_character":44},"in_reply_to":"59d1a6a7_a7b97655","updated":"2022-03-09 10:55:24.000000000","message":"could you please suggest an alternative? should I hardcode cell0 for every CELL?","commit_id":"b48dcf182b645c5493c48b2bd86a08467de7773f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"cc3e976a16fe6f9a06a19a1931b0c8524cde859c","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                    #!/bin/bash"},{"line_number":409,"context_line":"                    CLIST\u003d$(su nova -s /bin/bash -c \"nova-manage cell_v2 list_cells\")"},{"line_number":410,"context_line":"                    echo \"(cellv2) Cell list: $CLIST\""},{"line_number":411,"context_line":"                    CELL\u003dcell0  # which cell to create by mapping it"},{"line_number":412,"context_line":"                    CELLID\u003d$(printf \"$CLIST\" | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -v cell\u003d$CELL -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d cell {print $4}\u0027)"},{"line_number":413,"context_line":"                    CELLDBC\u003d$(printf \"$CLIST\" | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -v cell\u003d$CELL -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d cell {print $8}\u0027)"},{"line_number":414,"context_line":"                    echo \"(cellv2) CELLID: $CELLID\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"78236d22_f66599a3","line":411,"range":{"start_line":411,"start_character":34,"end_line":411,"end_character":44},"in_reply_to":"61462e01_e493d1f8","updated":"2022-03-11 08:37:58.000000000","message":"I\u0027ll make it a var, and iterate in a loop for all cells","commit_id":"b48dcf182b645c5493c48b2bd86a08467de7773f"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"8c2a8ba44b36d81afc85b4e18b5156f8550b802d","unresolved":true,"context_lines":[{"line_number":414,"context_line":"                    echo \"(cellv2) CELLID: $CELLID\""},{"line_number":415,"context_line":"                    echo \"(cellv2) Cell DBC: $CELLDBC\""},{"line_number":416,"context_line":"                    CONN\u003d\"--database_connection\u003d\u0027CELLDB/nova_${CELL}?{query}\u0027\""},{"line_number":417,"context_line":"                    if [ \"$CELL\" \u003d \"cell0\" ]; then"},{"line_number":418,"context_line":"                      echo \"(cellv2) Creating $CELL cell_v2 cell $CELLID\""},{"line_number":419,"context_line":"                      TRANSP\u003d\"--transport-url\u003dnone:///\""},{"line_number":420,"context_line":"                      su nova -s /bin/bash -c \"/usr/bin/nova-manage cell_v2 map_cell0 $CONN $TRANSP\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d547c35d_e7a7eaa5","line":417,"range":{"start_line":417,"start_character":20,"end_line":417,"end_character":50},"updated":"2022-03-08 11:24:58.000000000","message":"Always true, can remove the conditional.","commit_id":"b48dcf182b645c5493c48b2bd86a08467de7773f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"06c010f27e713049c6ecf229c3d19a486baa8778","unresolved":false,"context_lines":[{"line_number":414,"context_line":"                    echo \"(cellv2) CELLID: $CELLID\""},{"line_number":415,"context_line":"                    echo \"(cellv2) Cell DBC: $CELLDBC\""},{"line_number":416,"context_line":"                    CONN\u003d\"--database_connection\u003d\u0027CELLDB/nova_${CELL}?{query}\u0027\""},{"line_number":417,"context_line":"                    if [ \"$CELL\" \u003d \"cell0\" ]; then"},{"line_number":418,"context_line":"                      echo \"(cellv2) Creating $CELL cell_v2 cell $CELLID\""},{"line_number":419,"context_line":"                      TRANSP\u003d\"--transport-url\u003dnone:///\""},{"line_number":420,"context_line":"                      su nova -s /bin/bash -c \"/usr/bin/nova-manage cell_v2 map_cell0 $CONN $TRANSP\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0d4d7b85_d647a3b3","line":417,"range":{"start_line":417,"start_character":20,"end_line":417,"end_character":50},"in_reply_to":"1e101ddd_2c3a2b14","updated":"2022-03-09 10:57:34.000000000","message":"Done","commit_id":"b48dcf182b645c5493c48b2bd86a08467de7773f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"dc5100886feed721d90449dbdb580ab3c2b173d6","unresolved":true,"context_lines":[{"line_number":414,"context_line":"                    echo \"(cellv2) CELLID: $CELLID\""},{"line_number":415,"context_line":"                    echo \"(cellv2) Cell DBC: $CELLDBC\""},{"line_number":416,"context_line":"                    CONN\u003d\"--database_connection\u003d\u0027CELLDB/nova_${CELL}?{query}\u0027\""},{"line_number":417,"context_line":"                    if [ \"$CELL\" \u003d \"cell0\" ]; then"},{"line_number":418,"context_line":"                      echo \"(cellv2) Creating $CELL cell_v2 cell $CELLID\""},{"line_number":419,"context_line":"                      TRANSP\u003d\"--transport-url\u003dnone:///\""},{"line_number":420,"context_line":"                      su nova -s /bin/bash -c \"/usr/bin/nova-manage cell_v2 map_cell0 $CONN $TRANSP\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1e101ddd_2c3a2b14","line":417,"range":{"start_line":417,"start_character":20,"end_line":417,"end_character":50},"in_reply_to":"d547c35d_e7a7eaa5","updated":"2022-03-09 10:55:24.000000000","message":"My expectation that we\u0027ll need to iterate over multiple cells in the upcoming Train-\u003eWallaby FFU development (since train supports multi-cell, right?)","commit_id":"b48dcf182b645c5493c48b2bd86a08467de7773f"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"8c2a8ba44b36d81afc85b4e18b5156f8550b802d","unresolved":true,"context_lines":[{"line_number":297,"context_line":"      kolla_config:"},{"line_number":298,"context_line":"        /var/lib/kolla/config_files/nova_api.json:"},{"line_number":299,"context_line":"          command: /usr/sbin/httpd -DFOREGROUND"},{"line_number":300,"context_line":"          config_files: \u0026nova_api_db_sync"},{"line_number":301,"context_line":"            - source: \"/var/lib/kolla/config_files/src/etc/httpd/conf.d\""},{"line_number":302,"context_line":"              dest: \"/etc/httpd/conf.d\""},{"line_number":303,"context_line":"              merge: false"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7aa27473_fb4e4ca8","line":300,"range":{"start_line":300,"start_character":25,"end_line":300,"end_character":41},"updated":"2022-03-08 11:24:58.000000000","message":"The yaml placeholder name isn\u0027t very clear. Also not sure if the use of so many placeholders is helpful. It makes the yaml more difficult to grok IMO.","commit_id":"add1bfbb51ce9eeab246c9aee975dc56310f61d6"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"dc5100886feed721d90449dbdb580ab3c2b173d6","unresolved":false,"context_lines":[{"line_number":297,"context_line":"      kolla_config:"},{"line_number":298,"context_line":"        /var/lib/kolla/config_files/nova_api.json:"},{"line_number":299,"context_line":"          command: /usr/sbin/httpd -DFOREGROUND"},{"line_number":300,"context_line":"          config_files: \u0026nova_api_db_sync"},{"line_number":301,"context_line":"            - source: \"/var/lib/kolla/config_files/src/etc/httpd/conf.d\""},{"line_number":302,"context_line":"              dest: \"/etc/httpd/conf.d\""},{"line_number":303,"context_line":"              merge: false"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5be5dd4c_b75fccc0","line":300,"range":{"start_line":300,"start_character":25,"end_line":300,"end_character":41},"in_reply_to":"4471507a_fcad38cf","updated":"2022-03-09 10:55:24.000000000","message":"Done","commit_id":"add1bfbb51ce9eeab246c9aee975dc56310f61d6"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4ac5481bea11591ce068f4cf99c5e3aa76c2b0b1","unresolved":true,"context_lines":[{"line_number":297,"context_line":"      kolla_config:"},{"line_number":298,"context_line":"        /var/lib/kolla/config_files/nova_api.json:"},{"line_number":299,"context_line":"          command: /usr/sbin/httpd -DFOREGROUND"},{"line_number":300,"context_line":"          config_files: \u0026nova_api_db_sync"},{"line_number":301,"context_line":"            - source: \"/var/lib/kolla/config_files/src/etc/httpd/conf.d\""},{"line_number":302,"context_line":"              dest: \"/etc/httpd/conf.d\""},{"line_number":303,"context_line":"              merge: false"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4471507a_fcad38cf","line":300,"range":{"start_line":300,"start_character":25,"end_line":300,"end_character":41},"in_reply_to":"7aa27473_fb4e4ca8","updated":"2022-03-09 10:51:57.000000000","message":"I can rename it, not a problem 😊\n\nPlease see in the commit msg:\n- Use Kolla configs for the update/map cell containers.\n  (to simplify backporting as it provides a partial backport for Nova\n  of I0e3d5748a50937880a55413b75fe6eca479c9160)\n\nSo I wouldn\u0027t change it to not complicate further backports, if any","commit_id":"add1bfbb51ce9eeab246c9aee975dc56310f61d6"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"8c2a8ba44b36d81afc85b4e18b5156f8550b802d","unresolved":true,"context_lines":[{"line_number":298,"context_line":"        /var/lib/kolla/config_files/nova_api.json:"},{"line_number":299,"context_line":"          command: /usr/sbin/httpd -DFOREGROUND"},{"line_number":300,"context_line":"          config_files: \u0026nova_api_db_sync"},{"line_number":301,"context_line":"            - source: \"/var/lib/kolla/config_files/src/etc/httpd/conf.d\""},{"line_number":302,"context_line":"              dest: \"/etc/httpd/conf.d\""},{"line_number":303,"context_line":"              merge: false"},{"line_number":304,"context_line":"              preserve_properties: true"},{"line_number":305,"context_line":"            - source: \"/var/lib/kolla/config_files/src/etc/httpd/conf.modules.d\""},{"line_number":306,"context_line":"              dest: \"/etc/httpd/conf.modules.d\""},{"line_number":307,"context_line":"              # TODO(emilien) remove optional flag once we get a promotion"},{"line_number":308,"context_line":"              # https://launchpad.net/bugs/1884115"},{"line_number":309,"context_line":"              optional: true"},{"line_number":310,"context_line":"              merge: false"},{"line_number":311,"context_line":"              preserve_properties: true"},{"line_number":312,"context_line":"            - source: \"/var/lib/kolla/config_files/src/*\""},{"line_number":313,"context_line":"              dest: \"/\""},{"line_number":314,"context_line":"              merge: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"684b75e2_f23b6ed5","line":311,"range":{"start_line":301,"start_character":12,"end_line":311,"end_character":39},"updated":"2022-03-08 11:24:58.000000000","message":"Apache conf isn\u0027t necessary to run nova-manage, just need \"/var/lib/kolla/config_files/src/*\".","commit_id":"add1bfbb51ce9eeab246c9aee975dc56310f61d6"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"dc5100886feed721d90449dbdb580ab3c2b173d6","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        /var/lib/kolla/config_files/nova_api.json:"},{"line_number":299,"context_line":"          command: /usr/sbin/httpd -DFOREGROUND"},{"line_number":300,"context_line":"          config_files: \u0026nova_api_db_sync"},{"line_number":301,"context_line":"            - source: \"/var/lib/kolla/config_files/src/etc/httpd/conf.d\""},{"line_number":302,"context_line":"              dest: \"/etc/httpd/conf.d\""},{"line_number":303,"context_line":"              merge: false"},{"line_number":304,"context_line":"              preserve_properties: true"},{"line_number":305,"context_line":"            - source: \"/var/lib/kolla/config_files/src/etc/httpd/conf.modules.d\""},{"line_number":306,"context_line":"              dest: \"/etc/httpd/conf.modules.d\""},{"line_number":307,"context_line":"              # TODO(emilien) remove optional flag once we get a promotion"},{"line_number":308,"context_line":"              # https://launchpad.net/bugs/1884115"},{"line_number":309,"context_line":"              optional: true"},{"line_number":310,"context_line":"              merge: false"},{"line_number":311,"context_line":"              preserve_properties: true"},{"line_number":312,"context_line":"            - source: \"/var/lib/kolla/config_files/src/*\""},{"line_number":313,"context_line":"              dest: \"/\""},{"line_number":314,"context_line":"              merge: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"6f7133d8_c3f3f368","line":311,"range":{"start_line":301,"start_character":12,"end_line":311,"end_character":39},"in_reply_to":"0ee3ce4d_1cc1141a","updated":"2022-03-09 10:55:24.000000000","message":"Done","commit_id":"add1bfbb51ce9eeab246c9aee975dc56310f61d6"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4ac5481bea11591ce068f4cf99c5e3aa76c2b0b1","unresolved":true,"context_lines":[{"line_number":298,"context_line":"        /var/lib/kolla/config_files/nova_api.json:"},{"line_number":299,"context_line":"          command: /usr/sbin/httpd -DFOREGROUND"},{"line_number":300,"context_line":"          config_files: \u0026nova_api_db_sync"},{"line_number":301,"context_line":"            - source: \"/var/lib/kolla/config_files/src/etc/httpd/conf.d\""},{"line_number":302,"context_line":"              dest: \"/etc/httpd/conf.d\""},{"line_number":303,"context_line":"              merge: false"},{"line_number":304,"context_line":"              preserve_properties: true"},{"line_number":305,"context_line":"            - source: \"/var/lib/kolla/config_files/src/etc/httpd/conf.modules.d\""},{"line_number":306,"context_line":"              dest: \"/etc/httpd/conf.modules.d\""},{"line_number":307,"context_line":"              # TODO(emilien) remove optional flag once we get a promotion"},{"line_number":308,"context_line":"              # https://launchpad.net/bugs/1884115"},{"line_number":309,"context_line":"              optional: true"},{"line_number":310,"context_line":"              merge: false"},{"line_number":311,"context_line":"              preserve_properties: true"},{"line_number":312,"context_line":"            - source: \"/var/lib/kolla/config_files/src/*\""},{"line_number":313,"context_line":"              dest: \"/\""},{"line_number":314,"context_line":"              merge: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"0ee3ce4d_1cc1141a","line":311,"range":{"start_line":301,"start_character":12,"end_line":311,"end_character":39},"in_reply_to":"684b75e2_f23b6ed5","updated":"2022-03-09 10:51:57.000000000","message":"ditto, this provides a partial backport from master, I wouldn\u0027t change it to not complicate further backports, if any","commit_id":"add1bfbb51ce9eeab246c9aee975dc56310f61d6"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"8c2a8ba44b36d81afc85b4e18b5156f8550b802d","unresolved":true,"context_lines":[{"line_number":409,"context_line":"                    CLIST\u003d$(su nova -s /bin/bash -c \"nova-manage cell_v2 list_cells\")"},{"line_number":410,"context_line":"                    echo \"(cellv2) Cell list: $CLIST\""},{"line_number":411,"context_line":"                    CELL\u003dcell0  # which cell to create by mapping it"},{"line_number":412,"context_line":"                    CELLID\u003d$(printf \"$CLIST\" | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -v cell\u003d$CELL -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d cell {print $4}\u0027)"},{"line_number":413,"context_line":"                    CELLDBC\u003d$(printf \"$CLIST\" | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -v cell\u003d$CELL -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d cell {print $8}\u0027)"},{"line_number":414,"context_line":"                    echo \"(cellv2) CELLID: $CELLID\""},{"line_number":415,"context_line":"                    echo \"(cellv2) Cell DBC: $CELLDBC\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"41f822ab_68932548","line":412,"range":{"start_line":412,"start_character":20,"end_line":412,"end_character":26},"updated":"2022-03-08 11:24:58.000000000","message":"This isn\u0027t variable, always 00000000-0000-0000-0000-000000000000 for cell0","commit_id":"add1bfbb51ce9eeab246c9aee975dc56310f61d6"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"06c010f27e713049c6ecf229c3d19a486baa8778","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                    CLIST\u003d$(su nova -s /bin/bash -c \"nova-manage cell_v2 list_cells\")"},{"line_number":410,"context_line":"                    echo \"(cellv2) Cell list: $CLIST\""},{"line_number":411,"context_line":"                    CELL\u003dcell0  # which cell to create by mapping it"},{"line_number":412,"context_line":"                    CELLID\u003d$(printf \"$CLIST\" | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -v cell\u003d$CELL -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d cell {print $4}\u0027)"},{"line_number":413,"context_line":"                    CELLDBC\u003d$(printf \"$CLIST\" | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -v cell\u003d$CELL -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d cell {print $8}\u0027)"},{"line_number":414,"context_line":"                    echo \"(cellv2) CELLID: $CELLID\""},{"line_number":415,"context_line":"                    echo \"(cellv2) Cell DBC: $CELLDBC\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"77dbba1f_0b38108c","line":412,"range":{"start_line":412,"start_character":20,"end_line":412,"end_character":26},"in_reply_to":"41f822ab_68932548","updated":"2022-03-09 10:57:34.000000000","message":"Done","commit_id":"add1bfbb51ce9eeab246c9aee975dc56310f61d6"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"8c2a8ba44b36d81afc85b4e18b5156f8550b802d","unresolved":true,"context_lines":[{"line_number":419,"context_line":"                      TRANSP\u003d\"--transport-url\u003dnone:///\""},{"line_number":420,"context_line":"                      su nova -s /bin/bash -c \"/usr/bin/nova-manage cell_v2 map_cell0 $CONN $TRANSP\""},{"line_number":421,"context_line":"                    else"},{"line_number":422,"context_line":"                      echo \"(cellv2) Mapping $CELL cell_v2 cell $CELLID is not implemented\""},{"line_number":423,"context_line":"                    fi"},{"line_number":424,"context_line":"                  params: *cell_params"},{"line_number":425,"context_line":"            nova_api_update_cell0.sh:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1ca707f1_7131becd","line":422,"range":{"start_line":422,"start_character":22,"end_line":422,"end_character":91},"updated":"2022-03-08 11:24:58.000000000","message":"It is implemented: the discover_hosts nova-manage command. Only cell0 needs special handling as it will never have any compute hosts.","commit_id":"add1bfbb51ce9eeab246c9aee975dc56310f61d6"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"61e7b801e689d8f51bf6b5411caa230937473e83","unresolved":false,"context_lines":[{"line_number":419,"context_line":"                      TRANSP\u003d\"--transport-url\u003dnone:///\""},{"line_number":420,"context_line":"                      su nova -s /bin/bash -c \"/usr/bin/nova-manage cell_v2 map_cell0 $CONN $TRANSP\""},{"line_number":421,"context_line":"                    else"},{"line_number":422,"context_line":"                      echo \"(cellv2) Mapping $CELL cell_v2 cell $CELLID is not implemented\""},{"line_number":423,"context_line":"                    fi"},{"line_number":424,"context_line":"                  params: *cell_params"},{"line_number":425,"context_line":"            nova_api_update_cell0.sh:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1ffd3115_4e008fa8","line":422,"range":{"start_line":422,"start_character":22,"end_line":422,"end_character":91},"in_reply_to":"1ca707f1_7131becd","updated":"2022-03-09 10:58:43.000000000","message":"Meant to say it is not implemented for t-h-t. It will be, once we\u0027ll iterate for other cells as well, probably as a part of Train-\u003eWallaby multi-cell FFU future work","commit_id":"add1bfbb51ce9eeab246c9aee975dc56310f61d6"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"676012a13f46f797f26399c78ab0e3690e45896f","unresolved":true,"context_lines":[{"line_number":419,"context_line":"                      if [ \"$cell\" \u003d \"cell0\" ]; then"},{"line_number":420,"context_line":"                        echo \"(cellv2) Creating $cell cell_v2 cell $CELLID\""},{"line_number":421,"context_line":"                        TRANSP\u003d\"--transport-url\u003dnone:///\""},{"line_number":422,"context_line":"                        su nova -s /bin/bash -c \"/usr/bin/nova-manage cell_v2 map_cell0 $CONN $TRANSP\""},{"line_number":423,"context_line":"                      else"},{"line_number":424,"context_line":"                        echo \"(cellv2) Mapping $cell cell_v2 cell $CELLID\""},{"line_number":425,"context_line":"                        su nova -s /bin/bash -c \"nova-manage cell_v2 discover_hosts --cell_uuid $CELLID --by-service\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"2e65e3a1_2a33d5af","line":422,"range":{"start_line":422,"start_character":94,"end_line":422,"end_character":101},"updated":"2022-03-11 12:07:53.000000000","message":"map_cell0 doesn\u0027t accept a transport url","commit_id":"1a345b8bf40b314639cf47165dd3f54e7301e490"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4c647d1792940b32071cb7db0b0d130323a92938","unresolved":true,"context_lines":[{"line_number":419,"context_line":"                      if [ \"$cell\" \u003d \"cell0\" ]; then"},{"line_number":420,"context_line":"                        echo \"(cellv2) Creating $cell cell_v2 cell $CELLID\""},{"line_number":421,"context_line":"                        TRANSP\u003d\"--transport-url\u003dnone:///\""},{"line_number":422,"context_line":"                        su nova -s /bin/bash -c \"/usr/bin/nova-manage cell_v2 map_cell0 $CONN $TRANSP\""},{"line_number":423,"context_line":"                      else"},{"line_number":424,"context_line":"                        echo \"(cellv2) Mapping $cell cell_v2 cell $CELLID\""},{"line_number":425,"context_line":"                        su nova -s /bin/bash -c \"nova-manage cell_v2 discover_hosts --cell_uuid $CELLID --by-service\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"28d83940_cfb11967","line":422,"range":{"start_line":422,"start_character":94,"end_line":422,"end_character":101},"in_reply_to":"2e65e3a1_2a33d5af","updated":"2022-03-11 12:24:25.000000000","message":"without transport url the command was failing (and asking for it, even if it\u0027s none)","commit_id":"1a345b8bf40b314639cf47165dd3f54e7301e490"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"676012a13f46f797f26399c78ab0e3690e45896f","unresolved":true,"context_lines":[{"line_number":422,"context_line":"                        su nova -s /bin/bash -c \"/usr/bin/nova-manage cell_v2 map_cell0 $CONN $TRANSP\""},{"line_number":423,"context_line":"                      else"},{"line_number":424,"context_line":"                        echo \"(cellv2) Mapping $cell cell_v2 cell $CELLID\""},{"line_number":425,"context_line":"                        su nova -s /bin/bash -c \"nova-manage cell_v2 discover_hosts --cell_uuid $CELLID --by-service\""},{"line_number":426,"context_line":"                      fi"},{"line_number":427,"context_line":"                    done"},{"line_number":428,"context_line":"                  params: *cell_params"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dd4f7c57_031f68fe","line":425,"range":{"start_line":425,"start_character":69,"end_line":425,"end_character":83},"updated":"2022-03-11 12:07:53.000000000","message":"The compute services need to be up. We already run it at the correct time here https://opendev.org/openstack/tripleo-heat-templates/src/branch/stable/train/deployment/nova/nova-compute-common-container-puppet.yaml#L83\n\ndiscover_hosts already iterates over all the cells if you don\u0027t specify a cell uuid","commit_id":"1a345b8bf40b314639cf47165dd3f54e7301e490"}],"deployment/nova/nova-conductor-container-puppet.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"8c2a8ba44b36d81afc85b4e18b5156f8550b802d","unresolved":true,"context_lines":[{"line_number":240,"context_line":"                      - /var/lib/config-data/puppet-generated/nova:/var/lib/kolla/config_files/src:ro"},{"line_number":241,"context_line":"                environment:"},{"line_number":242,"context_line":"                  KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"},{"line_number":243,"context_line":"            - if:"},{"line_number":244,"context_line":"                - fast_forward_upgrade"},{"line_number":245,"context_line":"                - nova_db_sync_stein:"},{"line_number":246,"context_line":"                    image: {get_param: ContainerNovaConductorImageStein}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a502cf95_18114108","line":243,"range":{"start_line":243,"start_character":12,"end_line":243,"end_character":17},"updated":"2022-03-08 11:24:58.000000000","message":"I would move this above nova_db_sync \u0026 nova_conductor container as it has a lower start_order","commit_id":"add1bfbb51ce9eeab246c9aee975dc56310f61d6"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e4527a2da2491e43d2534b587d8c4d186e7dcfaa","unresolved":true,"context_lines":[{"line_number":240,"context_line":"                      - /var/lib/config-data/puppet-generated/nova:/var/lib/kolla/config_files/src:ro"},{"line_number":241,"context_line":"                environment:"},{"line_number":242,"context_line":"                  KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"},{"line_number":243,"context_line":"            - if:"},{"line_number":244,"context_line":"                - fast_forward_upgrade"},{"line_number":245,"context_line":"                - nova_db_sync_stein:"},{"line_number":246,"context_line":"                    image: {get_param: ContainerNovaConductorImageStein}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c6b49377_fcf97458","line":243,"range":{"start_line":243,"start_character":12,"end_line":243,"end_character":17},"in_reply_to":"a502cf95_18114108","updated":"2022-03-11 08:24:46.000000000","message":"oh, now I got it, will update, thanks!","commit_id":"add1bfbb51ce9eeab246c9aee975dc56310f61d6"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8448f2d5d4ac1f416d90944bec95f21a456bd082","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                      - /var/lib/config-data/puppet-generated/nova:/var/lib/kolla/config_files/src:ro"},{"line_number":241,"context_line":"                environment:"},{"line_number":242,"context_line":"                  KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"},{"line_number":243,"context_line":"            - if:"},{"line_number":244,"context_line":"                - fast_forward_upgrade"},{"line_number":245,"context_line":"                - nova_db_sync_stein:"},{"line_number":246,"context_line":"                    image: {get_param: ContainerNovaConductorImageStein}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bbdbf5c0_587200aa","line":243,"range":{"start_line":243,"start_character":12,"end_line":243,"end_character":17},"in_reply_to":"c6b49377_fcf97458","updated":"2022-03-11 08:53:29.000000000","message":"Done","commit_id":"add1bfbb51ce9eeab246c9aee975dc56310f61d6"}],"deployment/nova/nova-manager-container-puppet.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"8c2a8ba44b36d81afc85b4e18b5156f8550b802d","unresolved":true,"context_lines":[{"line_number":88,"context_line":"          get_attr: [NovaLogging, docker_config, step_2]"},{"line_number":89,"context_line":"        step_4:"},{"line_number":90,"context_line":"          nova_manager:"},{"line_number":91,"context_line":"            start_order: 12 # Runs after dbsyncs done and cells DB URIs mapped/updated"},{"line_number":92,"context_line":"            image: *nova_conductor_image"},{"line_number":93,"context_line":"            net: host"},{"line_number":94,"context_line":"            privileged: false"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ac593c8c_ac57cd4f","line":91,"range":{"start_line":91,"start_character":28,"end_line":91,"end_character":86},"updated":"2022-03-08 11:24:58.000000000","message":"It doesn\u0027t matter. This container isn\u0027t used until after all the deploy steps","commit_id":"add1bfbb51ce9eeab246c9aee975dc56310f61d6"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"06c010f27e713049c6ecf229c3d19a486baa8778","unresolved":false,"context_lines":[{"line_number":88,"context_line":"          get_attr: [NovaLogging, docker_config, step_2]"},{"line_number":89,"context_line":"        step_4:"},{"line_number":90,"context_line":"          nova_manager:"},{"line_number":91,"context_line":"            start_order: 12 # Runs after dbsyncs done and cells DB URIs mapped/updated"},{"line_number":92,"context_line":"            image: *nova_conductor_image"},{"line_number":93,"context_line":"            net: host"},{"line_number":94,"context_line":"            privileged: false"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a0527d6_01e1e559","line":91,"range":{"start_line":91,"start_character":28,"end_line":91,"end_character":86},"in_reply_to":"86cbcb62_c2198c02","updated":"2022-03-09 10:57:34.000000000","message":"Done","commit_id":"add1bfbb51ce9eeab246c9aee975dc56310f61d6"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3f597c96ac8b0165528c2cfbaa203ae07f8ec7ae","unresolved":true,"context_lines":[{"line_number":88,"context_line":"          get_attr: [NovaLogging, docker_config, step_2]"},{"line_number":89,"context_line":"        step_4:"},{"line_number":90,"context_line":"          nova_manager:"},{"line_number":91,"context_line":"            start_order: 12 # Runs after dbsyncs done and cells DB URIs mapped/updated"},{"line_number":92,"context_line":"            image: *nova_conductor_image"},{"line_number":93,"context_line":"            net: host"},{"line_number":94,"context_line":"            privileged: false"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"86cbcb62_c2198c02","line":91,"range":{"start_line":91,"start_character":28,"end_line":91,"end_character":86},"in_reply_to":"ac593c8c_ac57cd4f","updated":"2022-03-09 10:56:58.000000000","message":"I left these comments to not change the today ordering for none of the involved tasks and steps.","commit_id":"add1bfbb51ce9eeab246c9aee975dc56310f61d6"}],"deployment/nova/nova-migration-target-container-puppet.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"8c2a8ba44b36d81afc85b4e18b5156f8550b802d","unresolved":true,"context_lines":[{"line_number":166,"context_line":"      docker_config:"},{"line_number":167,"context_line":"        step_4:"},{"line_number":168,"context_line":"          nova_migration_target:"},{"line_number":169,"context_line":"            start_order: 12 # Runs after dbsyncs done and cells DB URIs mapped/updated"},{"line_number":170,"context_line":"            image: {get_param: ContainerNovaComputeImage}"},{"line_number":171,"context_line":"            net: host"},{"line_number":172,"context_line":"            privileged: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"db37068b_272bcd9d","line":169,"range":{"start_line":169,"start_character":12,"end_line":169,"end_character":86},"updated":"2022-03-08 11:24:58.000000000","message":"Doesn\u0027t matter. This is just an ssh daemon.","commit_id":"add1bfbb51ce9eeab246c9aee975dc56310f61d6"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"06c010f27e713049c6ecf229c3d19a486baa8778","unresolved":false,"context_lines":[{"line_number":166,"context_line":"      docker_config:"},{"line_number":167,"context_line":"        step_4:"},{"line_number":168,"context_line":"          nova_migration_target:"},{"line_number":169,"context_line":"            start_order: 12 # Runs after dbsyncs done and cells DB URIs mapped/updated"},{"line_number":170,"context_line":"            image: {get_param: ContainerNovaComputeImage}"},{"line_number":171,"context_line":"            net: host"},{"line_number":172,"context_line":"            privileged: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d99bcdf2_8ed6d1e7","line":169,"range":{"start_line":169,"start_character":12,"end_line":169,"end_character":86},"in_reply_to":"db37068b_272bcd9d","updated":"2022-03-09 10:57:34.000000000","message":"Done","commit_id":"add1bfbb51ce9eeab246c9aee975dc56310f61d6"}]}