)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"774a5a965a28f12a795598243fe3efe7bceb9202","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Ensure db initialization is not executed by puppet"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Each puppet module provides the sync_db parameter to run commands to"},{"line_number":10,"context_line":"initialize database schema. This change ensures the feature is disabled"},{"line_number":11,"context_line":"as we have independent tasks to run the same."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I8ccf4ddd40a0d1a9bff9c1ca001284eda25dc9b2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bdc24697_34c9cabe","line":10,"range":{"start_line":10,"start_character":40,"end_line":10,"end_character":71},"updated":"2022-03-02 08:15:33.000000000","message":"did this cause explosions already or you are being pre-emptive?\nif we have a bug please add it","commit_id":"263fee246a4214f4c56c675cd1245ea77a3cd9ea"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9fe1150b0fe928577652491f001c8b27c0a27389","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Ensure db initialization is not executed by puppet"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Each puppet module provides the sync_db parameter to run commands to"},{"line_number":10,"context_line":"initialize database schema. This change ensures the feature is disabled"},{"line_number":11,"context_line":"as we have independent tasks to run the same."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I8ccf4ddd40a0d1a9bff9c1ca001284eda25dc9b2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f003a73_8a51cda3","line":10,"range":{"start_line":10,"start_character":40,"end_line":10,"end_character":71},"in_reply_to":"bdc24697_34c9cabe","updated":"2022-03-02 08:26:26.000000000","message":"This is pre-emptive work. We have never seen actual issues caused by this, mainly because we don\u0027t enable exec resource in container-puppet. However currently I\u0027m working on refactoring which removes sync_db parameter definition in puppet-tripleo layer, and this might reveal unexpected issues, so I\u0027m making sure we disable what we don\u0027t want.","commit_id":"263fee246a4214f4c56c675cd1245ea77a3cd9ea"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"137610f0225f4daa4e87efa08d83bf7e4f21a524","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c079da91_bd70f3e8","updated":"2022-03-02 15:23:23.000000000","message":"I cross checked the list of THT files against all the relevant puppet modules, and everything looks in sync (i.e. this patch covers all the puppet db_sync variables).","commit_id":"263fee246a4214f4c56c675cd1245ea77a3cd9ea"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2020def080df121f72359f0f9ecefa5d788955c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7b4428f1_f3eea1e5","updated":"2022-03-07 10:24:19.000000000","message":"that\u0027s a nice catch. Does it impact deployment in any way or just a cosmetic change?\nWe should backport it to W and T at least.","commit_id":"263fee246a4214f4c56c675cd1245ea77a3cd9ea"}],"deployment/cinder/cinder-api-container-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"137610f0225f4daa4e87efa08d83bf7e4f21a524","unresolved":true,"context_lines":[{"line_number":238,"context_line":"                params:"},{"line_number":239,"context_line":"                  TIMEOUT: {get_param: CinderApiWsgiTimeout}"},{"line_number":240,"context_line":"            cinder::wsgi::apache::workers: {get_param: CinderWorkers}"},{"line_number":241,"context_line":"            cinder::api::sync_db: false"},{"line_number":242,"context_line":"      service_config_settings:"},{"line_number":243,"context_line":"        rsyslog:"},{"line_number":244,"context_line":"          tripleo_logging_sources_cinder_api:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"db3564e1_1561091c","line":241,"updated":"2022-03-02 15:23:23.000000000","message":"very minor nit: keeping lists like this alphabetized is not always easy, but I feel that it does help. This line could have been located near L205.","commit_id":"263fee246a4214f4c56c675cd1245ea77a3cd9ea"}],"deployment/nova/nova-api-container-puppet.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"774a5a965a28f12a795598243fe3efe7bceb9202","unresolved":false,"context_lines":[{"line_number":394,"context_line":"            nova::api::instance_name_template: {get_param: InstanceNameTemplate}"},{"line_number":395,"context_line":"            nova::api::allow_resize_to_same_host: {get_param: NovaAllowResizeToSameHost}"},{"line_number":396,"context_line":"            nova::api::sync_db: false"},{"line_number":397,"context_line":"            nova::api::sync_db_api: false"},{"line_number":398,"context_line":"            nova_enable_db_purge: {get_param: NovaEnableDBPurge}"},{"line_number":399,"context_line":"            nova::cron::purge_shadow_tables::minute: {get_param: NovaCronPurgeShadowTablesMinute}"},{"line_number":400,"context_line":"            nova::cron::purge_shadow_tables::hour: {get_param: NovaCronPurgeShadowTablesHour}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f484d1d_2cefb0ac","line":397,"updated":"2022-03-02 08:15:33.000000000","message":"k apparently those are both things... https://opendev.org/openstack/puppet-nova/src/commit/02b85ba3a0b6d086c8060c8eb66eff44b798ccc3/manifests/api.pp#L60-L64","commit_id":"263fee246a4214f4c56c675cd1245ea77a3cd9ea"}]}