)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d0a3dc596f8207eb26e68021ad4107fb70386f1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"b9f2c54d_57f0cb05","updated":"2022-03-21 23:24:22.000000000","message":"Thank you, James, for the feedback !","commit_id":"e5537e91e96f6011b088f9f9b86f322dcdf152c6"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"801ff9614d426c8415371d93c7881fb9c4097037","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"0f843aa5_cbbab902","updated":"2022-03-21 22:30:15.000000000","message":"initial review, I spotted a few issues.","commit_id":"e5537e91e96f6011b088f9f9b86f322dcdf152c6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d93cfc0cfd0f1e88314128aa4ecc2d813d2e936e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"fed8ec6b_2b441c55","updated":"2022-04-12 14:27:56.000000000","message":"recheck","commit_id":"5d63e95e12798e8dd7020c219f16b18d0dda5eea"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"78d195353687973a889e05b41d52b3830cabd298","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"41bdadea_42bf0bd1","updated":"2022-04-14 07:55:38.000000000","message":"Hmm... it seems ssh connection is lost after ssh rules are applied. I\u0027ll look into the issue.","commit_id":"c7f1fdf870efd82b042e9249c5e139a8767780a7"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"69dc134ed306a0789708fd6caf35f29839271392","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"e1867f39_7558320e","updated":"2022-04-15 09:39:40.000000000","message":"So the SSH loss isn\u0027t linked to your patch - imho, it\u0027s due to how we configure iptables in the first place: first rule is a lockout one, then we add the opening with \"insert\", meaning whatever happens to the connection once the lockout rule is in place, we\u0027re doomed.\n\nThis other patch MAY help:\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/838097\n\nIt\u0027s currently being tested in multiple envs, among them tesproject here:\nhttps://review.rdoproject.org/r/c/testproject/+/36255","commit_id":"c7f1fdf870efd82b042e9249c5e139a8767780a7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ee6a6b56b675f2bc2f42acb3aba1b5bf0e2feb74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"d4502cb0_45ede250","updated":"2022-04-25 23:30:05.000000000","message":"recheck","commit_id":"c7f1fdf870efd82b042e9249c5e139a8767780a7"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"f8475b1c4e51b978b177356185a23d71f5ddf97c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"73a9841f_def88216","updated":"2022-04-28 15:26:43.000000000","message":"recheck","commit_id":"a3dd02377394c6fab4a556f0c666a04755fa905c"}],"common/services/role.role.j2.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"801ff9614d426c8415371d93c7881fb9c4097037","unresolved":true,"context_lines":[{"line_number":439,"context_line":"          - {get_attr: [DockerPuppetTasks, value]}"},{"line_number":440,"context_line":"      host_prep_tasks:"},{"line_number":441,"context_line":"        list_concat:"},{"line_number":442,"context_line":"          - {get_attr: [HostFirewallTasks, value]}"},{"line_number":443,"context_line":"          - {get_attr: [HostPrepTasks, value]}"},{"line_number":444,"context_line":"      pre_deploy_step_tasks: {get_attr: [PreDeployStepTasks, value]}"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"266c485a_f16065a1","line":442,"updated":"2022-03-21 22:30:15.000000000","message":"instead of adding a new top level tasks interface, isn\u0027t this something that could be defined to run as part of the HAProxy config?","commit_id":"e5537e91e96f6011b088f9f9b86f322dcdf152c6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"88b53b5eef2b0315e1f1b1c12d195b4f307ef6fd","unresolved":false,"context_lines":[{"line_number":439,"context_line":"          - {get_attr: [DockerPuppetTasks, value]}"},{"line_number":440,"context_line":"      host_prep_tasks:"},{"line_number":441,"context_line":"        list_concat:"},{"line_number":442,"context_line":"          - {get_attr: [HostFirewallTasks, value]}"},{"line_number":443,"context_line":"          - {get_attr: [HostPrepTasks, value]}"},{"line_number":444,"context_line":"      pre_deploy_step_tasks: {get_attr: [PreDeployStepTasks, value]}"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"b870cb77_8f9f5d55","line":442,"in_reply_to":"1cddf271_3891cef5","updated":"2022-04-26 16:04:48.000000000","message":"Done","commit_id":"e5537e91e96f6011b088f9f9b86f322dcdf152c6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d0a3dc596f8207eb26e68021ad4107fb70386f1d","unresolved":true,"context_lines":[{"line_number":439,"context_line":"          - {get_attr: [DockerPuppetTasks, value]}"},{"line_number":440,"context_line":"      host_prep_tasks:"},{"line_number":441,"context_line":"        list_concat:"},{"line_number":442,"context_line":"          - {get_attr: [HostFirewallTasks, value]}"},{"line_number":443,"context_line":"          - {get_attr: [HostPrepTasks, value]}"},{"line_number":444,"context_line":"      pre_deploy_step_tasks: {get_attr: [PreDeployStepTasks, value]}"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"599c99e7_696a8265","line":442,"in_reply_to":"266c485a_f16065a1","updated":"2022-03-21 23:24:22.000000000","message":"We need to merge all frontend rules in all roles/services and inject the merged rules to group vars, so this can\u0027t be a part of haproxy template. Alternative approach is to add all these firewall rules in haproxy template but that means we have two templates with the same set of firewall rules defined.\n\nIf we can avoid using this top-level stuff that would be ideal, but I was not able to find any alternative so far","commit_id":"e5537e91e96f6011b088f9f9b86f322dcdf152c6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5364fce9f85e24643ff100ed47f9e8b47067447b","unresolved":true,"context_lines":[{"line_number":439,"context_line":"          - {get_attr: [DockerPuppetTasks, value]}"},{"line_number":440,"context_line":"      host_prep_tasks:"},{"line_number":441,"context_line":"        list_concat:"},{"line_number":442,"context_line":"          - {get_attr: [HostFirewallTasks, value]}"},{"line_number":443,"context_line":"          - {get_attr: [HostPrepTasks, value]}"},{"line_number":444,"context_line":"      pre_deploy_step_tasks: {get_attr: [PreDeployStepTasks, value]}"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1cddf271_3891cef5","line":442,"in_reply_to":"599c99e7_696a8265","updated":"2022-04-12 14:42:14.000000000","message":"I misunderstood your point, James.\nWe need a seprate interface because firewall rule should be applied in very beginning. There are no existing interface which would be suitable for firewall configuration so that\u0027s why I\u0027m adding this new task interface.\n\nBy the way, firewall configuration should be part of tripleo-firewall service, instead of haproxy service, IMO.","commit_id":"e5537e91e96f6011b088f9f9b86f322dcdf152c6"}],"deployment/cephadm/ceph-mgr.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"801ff9614d426c8415371d93c7881fb9c4097037","unresolved":true,"context_lines":[{"line_number":108,"context_line":"              - if:"},{"line_number":109,"context_line":"                - {get_param: CephEnableDashboard}"},{"line_number":110,"context_line":"                - - {get_param: CephDashboardPort}"},{"line_number":111,"context_line":"      frontend_firewall_rules:"},{"line_number":112,"context_line":"        if:"},{"line_number":113,"context_line":"          - {get_param: CephEnableDashboard}"},{"line_number":114,"context_line":"          - \u0027100 ceph_dashboard\u0027:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"58829c33_38ff1187","line":111,"updated":"2022-03-21 22:30:15.000000000","message":"firewall_frontend_rules?","commit_id":"e5537e91e96f6011b088f9f9b86f322dcdf152c6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d0a3dc596f8207eb26e68021ad4107fb70386f1d","unresolved":false,"context_lines":[{"line_number":108,"context_line":"              - if:"},{"line_number":109,"context_line":"                - {get_param: CephEnableDashboard}"},{"line_number":110,"context_line":"                - - {get_param: CephDashboardPort}"},{"line_number":111,"context_line":"      frontend_firewall_rules:"},{"line_number":112,"context_line":"        if:"},{"line_number":113,"context_line":"          - {get_param: CephEnableDashboard}"},{"line_number":114,"context_line":"          - \u0027100 ceph_dashboard\u0027:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1d3e690e_7f260548","line":111,"in_reply_to":"58829c33_38ff1187","updated":"2022-03-21 23:24:22.000000000","message":"Done","commit_id":"e5537e91e96f6011b088f9f9b86f322dcdf152c6"}],"deployment/cephadm/ceph-rgw.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"801ff9614d426c8415371d93c7881fb9c4097037","unresolved":true,"context_lines":[{"line_number":97,"context_line":"                - {get_param: [EndpointMap, CephRgwPublic, port]}"},{"line_number":98,"context_line":"              - if:"},{"line_number":99,"context_line":"                - {get_param: CephEnableDashboard}"},{"line_number":100,"context_line":"                - - \u00279100\u0027"},{"line_number":101,"context_line":"      firewall_frontend_rules:"},{"line_number":102,"context_line":"        \u0027100 ceph_rgw\u0027:"},{"line_number":103,"context_line":"          dport:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"90c783c2_5bfa52be","line":100,"updated":"2022-03-21 22:30:15.000000000","message":"why not 9100 on the frontend? is it not behind HAProxy?","commit_id":"e5537e91e96f6011b088f9f9b86f322dcdf152c6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d0a3dc596f8207eb26e68021ad4107fb70386f1d","unresolved":true,"context_lines":[{"line_number":97,"context_line":"                - {get_param: [EndpointMap, CephRgwPublic, port]}"},{"line_number":98,"context_line":"              - if:"},{"line_number":99,"context_line":"                - {get_param: CephEnableDashboard}"},{"line_number":100,"context_line":"                - - \u00279100\u0027"},{"line_number":101,"context_line":"      firewall_frontend_rules:"},{"line_number":102,"context_line":"        \u0027100 ceph_rgw\u0027:"},{"line_number":103,"context_line":"          dport:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"c725e133_b611c252","line":100,"in_reply_to":"90c783c2_5bfa52be","updated":"2022-03-21 23:24:22.000000000","message":"tcp/9100 has never been used by haproxy, and I believe that is used by backends only. I\u0027d be nice if any ceph folks can confirm that.\n\nFrontend rule for ceph dashboard (tcp/8444) is defined in a different template file(ceph-mgr.yaml).","commit_id":"e5537e91e96f6011b088f9f9b86f322dcdf152c6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"88b53b5eef2b0315e1f1b1c12d195b4f307ef6fd","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                - {get_param: [EndpointMap, CephRgwPublic, port]}"},{"line_number":98,"context_line":"              - if:"},{"line_number":99,"context_line":"                - {get_param: CephEnableDashboard}"},{"line_number":100,"context_line":"                - - \u00279100\u0027"},{"line_number":101,"context_line":"      firewall_frontend_rules:"},{"line_number":102,"context_line":"        \u0027100 ceph_rgw\u0027:"},{"line_number":103,"context_line":"          dport:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1c6955e8_a603a7e7","line":100,"in_reply_to":"c725e133_b611c252","updated":"2022-04-26 16:04:48.000000000","message":"Done","commit_id":"e5537e91e96f6011b088f9f9b86f322dcdf152c6"}],"deployment/haproxy/haproxy-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"88b53b5eef2b0315e1f1b1c12d195b4f307ef6fd","unresolved":true,"context_lines":[{"line_number":182,"context_line":"      monitoring_subscription: {get_param: MonitoringSubscriptionHaproxy}"},{"line_number":183,"context_line":"      ansible_group_vars:"},{"line_number":184,"context_line":"        map_merge:"},{"line_number":185,"context_line":"          - tripleo_firewall_frontend_enabled: true"},{"line_number":186,"context_line":"          - if:"},{"line_number":187,"context_line":"            - public_tls_enabled"},{"line_number":188,"context_line":"            - tripleo_firewall_ssl_frontend_enabled: true"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3f7b3bd6_930b8cc6","line":185,"range":{"start_line":185,"start_character":12,"end_line":185,"end_character":51},"updated":"2022-04-26 16:04:48.000000000","message":"hmmm... it seems this is not properly rendered into groupvar.\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_648/831549/16/check/tripleo-ci-centos-9-scenario004-standalone/648c95d/logs/undercloud/home/zuul/tripleo-deploy/standalone-ansible-uwsoxwbo/group_vars/Standalone","commit_id":"c7f1fdf870efd82b042e9249c5e139a8767780a7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"317d6888ce1549f49063954a23b67743bbb23636","unresolved":false,"context_lines":[{"line_number":182,"context_line":"      monitoring_subscription: {get_param: MonitoringSubscriptionHaproxy}"},{"line_number":183,"context_line":"      ansible_group_vars:"},{"line_number":184,"context_line":"        map_merge:"},{"line_number":185,"context_line":"          - tripleo_firewall_frontend_enabled: true"},{"line_number":186,"context_line":"          - if:"},{"line_number":187,"context_line":"            - public_tls_enabled"},{"line_number":188,"context_line":"            - tripleo_firewall_ssl_frontend_enabled: true"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"bf3bdf4a_ca4d0838","line":185,"range":{"start_line":185,"start_character":12,"end_line":185,"end_character":51},"in_reply_to":"1b581bc9_e4860a9b","updated":"2022-04-27 13:10:56.000000000","message":"for example, in https://review.opendev.org/c/openstack/tripleo-heat-templates/+/792729/4/deployment/swift/swift-proxy-container-puppet.yaml#376 I would then expect the map_merge gone (including swift_proxy config) when EnableInternalTLS \u003d SwiftEncryptionEnabled \u003d False !","commit_id":"c7f1fdf870efd82b042e9249c5e139a8767780a7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"57303dd182ada1d91280d1923b7a04ab5acf313f","unresolved":false,"context_lines":[{"line_number":182,"context_line":"      monitoring_subscription: {get_param: MonitoringSubscriptionHaproxy}"},{"line_number":183,"context_line":"      ansible_group_vars:"},{"line_number":184,"context_line":"        map_merge:"},{"line_number":185,"context_line":"          - tripleo_firewall_frontend_enabled: true"},{"line_number":186,"context_line":"          - if:"},{"line_number":187,"context_line":"            - public_tls_enabled"},{"line_number":188,"context_line":"            - tripleo_firewall_ssl_frontend_enabled: true"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"f9595273_1cbcbfc1","line":185,"range":{"start_line":185,"start_character":12,"end_line":185,"end_character":51},"in_reply_to":"3f7b3bd6_930b8cc6","updated":"2022-04-27 12:36:06.000000000","message":"The problem was that heat was wiping the whole ansible_group_vars when tls is disabled. This version should have it solved.","commit_id":"c7f1fdf870efd82b042e9249c5e139a8767780a7"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"6640d0b3abc0ab08ff10054ed3cac51581af58af","unresolved":false,"context_lines":[{"line_number":182,"context_line":"      monitoring_subscription: {get_param: MonitoringSubscriptionHaproxy}"},{"line_number":183,"context_line":"      ansible_group_vars:"},{"line_number":184,"context_line":"        map_merge:"},{"line_number":185,"context_line":"          - tripleo_firewall_frontend_enabled: true"},{"line_number":186,"context_line":"          - if:"},{"line_number":187,"context_line":"            - public_tls_enabled"},{"line_number":188,"context_line":"            - tripleo_firewall_ssl_frontend_enabled: true"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"82412a5e_e9ba818a","line":185,"range":{"start_line":185,"start_character":12,"end_line":185,"end_character":51},"in_reply_to":"bf3bdf4a_ca4d0838","updated":"2022-04-27 13:47:12.000000000","message":"This should not be an issue. Don\u0027t have an environment will verify later.","commit_id":"c7f1fdf870efd82b042e9249c5e139a8767780a7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c9305428c7034561a26f5e17593a88ccd5bc3e20","unresolved":false,"context_lines":[{"line_number":182,"context_line":"      monitoring_subscription: {get_param: MonitoringSubscriptionHaproxy}"},{"line_number":183,"context_line":"      ansible_group_vars:"},{"line_number":184,"context_line":"        map_merge:"},{"line_number":185,"context_line":"          - tripleo_firewall_frontend_enabled: true"},{"line_number":186,"context_line":"          - if:"},{"line_number":187,"context_line":"            - public_tls_enabled"},{"line_number":188,"context_line":"            - tripleo_firewall_ssl_frontend_enabled: true"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1b581bc9_e4860a9b","line":185,"range":{"start_line":185,"start_character":12,"end_line":185,"end_character":51},"in_reply_to":"f9595273_1cbcbfc1","updated":"2022-04-27 13:07:55.000000000","message":"if it does, that\u0027s a major Heat issue, we have multiple similar places in t-h-t.","commit_id":"c7f1fdf870efd82b042e9249c5e139a8767780a7"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"fabb1fca51fdf36bbe51aaf19eaf8d4c7aebf062","unresolved":true,"context_lines":[{"line_number":186,"context_line":"          if:"},{"line_number":187,"context_line":"            - public_tls_enabled"},{"line_number":188,"context_line":"            - true"},{"line_number":189,"context_line":"            - false"},{"line_number":190,"context_line":"      config_settings:"},{"line_number":191,"context_line":"        map_merge:"},{"line_number":192,"context_line":"          - get_attr: [HAProxyLogging, config_settings]"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"38bd6f71_3b67c471","line":189,"range":{"start_line":189,"start_character":12,"end_line":189,"end_character":19},"updated":"2022-04-28 04:09:41.000000000","message":"don\u0027t need this and that would remove tripleo_firewall_frontend_enabled from ansible_group_vars.","commit_id":"611d18a905b54c591117dae5028886a863bd7e0c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"150ea292e745ad5b50ed882fc61a942e532e1305","unresolved":false,"context_lines":[{"line_number":186,"context_line":"          if:"},{"line_number":187,"context_line":"            - public_tls_enabled"},{"line_number":188,"context_line":"            - true"},{"line_number":189,"context_line":"            - false"},{"line_number":190,"context_line":"      config_settings:"},{"line_number":191,"context_line":"        map_merge:"},{"line_number":192,"context_line":"          - get_attr: [HAProxyLogging, config_settings]"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"2d25c4c9_fa6058fe","line":189,"range":{"start_line":189,"start_character":12,"end_line":189,"end_character":19},"in_reply_to":"38bd6f71_3b67c471","updated":"2022-04-28 04:24:20.000000000","message":"Indeed.","commit_id":"611d18a905b54c591117dae5028886a863bd7e0c"}],"deployment/haproxy/haproxy-pacemaker-puppet.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"f7b7e6ebb1b080e1fed40b40655a7a3dbd2cfec1","unresolved":true,"context_lines":[{"line_number":178,"context_line":"    value:"},{"line_number":179,"context_line":"      service_name: haproxy"},{"line_number":180,"context_line":"      monitoring_subscription: {get_attr: [HAProxyBase, role_data, monitoring_subscription]}"},{"line_number":181,"context_line":"      ansible_group_vars: {getattr: [HAProxyBase, role_data, ansible_group_vars]}"},{"line_number":182,"context_line":"      config_settings:"},{"line_number":183,"context_line":"        map_merge:"},{"line_number":184,"context_line":"          - get_attr: [HAProxyBase, role_data, config_settings]"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"07ca4c01_525747d7","line":181,"range":{"start_line":181,"start_character":27,"end_line":181,"end_character":34},"updated":"2022-04-27 16:22:57.000000000","message":"This is incorrect.. get_attr","commit_id":"391c0909e230077ac47ef6d35df5524ca0743987"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e8c9cb67f2944090f4eef4dbdc682c12c2ac051f","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    value:"},{"line_number":179,"context_line":"      service_name: haproxy"},{"line_number":180,"context_line":"      monitoring_subscription: {get_attr: [HAProxyBase, role_data, monitoring_subscription]}"},{"line_number":181,"context_line":"      ansible_group_vars: {getattr: [HAProxyBase, role_data, ansible_group_vars]}"},{"line_number":182,"context_line":"      config_settings:"},{"line_number":183,"context_line":"        map_merge:"},{"line_number":184,"context_line":"          - get_attr: [HAProxyBase, role_data, config_settings]"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"750be0ec_4d6839cc","line":181,"range":{"start_line":181,"start_character":27,"end_line":181,"end_character":34},"in_reply_to":"07ca4c01_525747d7","updated":"2022-04-27 17:03:39.000000000","message":":facepalm: Fixed now ...","commit_id":"391c0909e230077ac47ef6d35df5524ca0743987"}],"deployment/ironic/ironic-api-container-puppet.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"801ff9614d426c8415371d93c7881fb9c4097037","unresolved":true,"context_lines":[{"line_number":1,"context_line":"ironic_template_version: wallaby"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: \u003e"},{"line_number":4,"context_line":"  OpenStack containerized Ironic API service"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"6f44791c_bd1b2d67","line":2,"updated":"2022-03-21 22:30:15.000000000","message":"?","commit_id":"e5537e91e96f6011b088f9f9b86f322dcdf152c6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d0a3dc596f8207eb26e68021ad4107fb70386f1d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ironic_template_version: wallaby"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: \u003e"},{"line_number":4,"context_line":"  OpenStack containerized Ironic API service"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"658f9bda_11a1a3f9","line":2,"in_reply_to":"6f44791c_bd1b2d67","updated":"2022-03-21 23:24:22.000000000","message":"Done","commit_id":"e5537e91e96f6011b088f9f9b86f322dcdf152c6"}],"deployment/keystone/keystone-container-puppet.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"801ff9614d426c8415371d93c7881fb9c4097037","unresolved":true,"context_lines":[{"line_number":506,"context_line":"            - 5000"},{"line_number":507,"context_line":"        \u0027100 keystone_admin_haproxy_frontend\u0027:"},{"line_number":508,"context_line":"          dport:"},{"line_number":509,"context_line":"            - 5000"},{"line_number":510,"context_line":"            - {get_param: [EndpointMap, KeystoneAdmin, port]}"},{"line_number":511,"context_line":"      firewall_ssl_frontend_rules:"},{"line_number":512,"context_line":"        \u0027100 keystone_public_haproxy_frontend_ssl\u0027:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ec0b3e72_77598e82","line":509,"updated":"2022-03-21 22:30:15.000000000","message":"why 5000 twice?","commit_id":"e5537e91e96f6011b088f9f9b86f322dcdf152c6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d0a3dc596f8207eb26e68021ad4107fb70386f1d","unresolved":false,"context_lines":[{"line_number":506,"context_line":"            - 5000"},{"line_number":507,"context_line":"        \u0027100 keystone_admin_haproxy_frontend\u0027:"},{"line_number":508,"context_line":"          dport:"},{"line_number":509,"context_line":"            - 5000"},{"line_number":510,"context_line":"            - {get_param: [EndpointMap, KeystoneAdmin, port]}"},{"line_number":511,"context_line":"      firewall_ssl_frontend_rules:"},{"line_number":512,"context_line":"        \u0027100 keystone_public_haproxy_frontend_ssl\u0027:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"f4d572eb_bbdc1b6e","line":509,"in_reply_to":"ec0b3e72_77598e82","updated":"2022-03-21 23:24:22.000000000","message":"Done","commit_id":"e5537e91e96f6011b088f9f9b86f322dcdf152c6"}],"overcloud.j2.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ea06215aa9b7ba863a329a558cf6cfef5e41f9c3","unresolved":true,"context_lines":[{"line_number":1033,"context_line":"        tripleo_network_config_with_ansible: {get_param: NetworkConfigWithAnsible}"},{"line_number":1034,"context_line":"        default_route_networks: {{role.default_route_networks|default([\u0027ControlPlane\u0027])}}"},{"line_number":1035,"context_line":"        networks_skip_config: {{ role.networks_skip_config|default([]) }}"},{"line_number":1036,"context_line":"        tripleo_firewall_rules: {get_attr: [{{role.name}}ServiceChainRoleData, value, firewall_rules]}"},{"line_number":1037,"context_line":"        tripleo_firewall_frontend_rules: {get_attr: [FirewallFrontendRules, value, frontend]}"},{"line_number":1038,"context_line":"        tripleo_firewall_ssl_frontend_rules: {get_attr: [FirewallFrontendRules, value, ssl_frontend]}"},{"line_number":1039,"context_line":"        tripleo_firewall_edge_frontend_rules: {get_attr: [FirewallFrontendRules, value, edge_frontend]}"},{"line_number":1040,"context_line":"        tripleo_firewall_edge_ssl_frontend_rules: {get_attr: [FirewallFrontendRules, value, edge_ssl_frontend]}"},{"line_number":1041,"context_line":"        role_tags: {{role.tags}}"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"  {{role.name}}NetworkConfig:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"213ee0d4_39062751","line":1040,"range":{"start_line":1036,"start_character":0,"end_line":1040,"end_character":101},"updated":"2022-04-12 15:31:20.000000000","message":"similarly to complex data structures of container manager ansible plugin, I think these can be compined into just tripleo_firewall_rules dict?","commit_id":"5d63e95e12798e8dd7020c219f16b18d0dda5eea"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cf8df529508849440a666296c2dd9742b6d94505","unresolved":true,"context_lines":[{"line_number":1033,"context_line":"        tripleo_network_config_with_ansible: {get_param: NetworkConfigWithAnsible}"},{"line_number":1034,"context_line":"        default_route_networks: {{role.default_route_networks|default([\u0027ControlPlane\u0027])}}"},{"line_number":1035,"context_line":"        networks_skip_config: {{ role.networks_skip_config|default([]) }}"},{"line_number":1036,"context_line":"        tripleo_firewall_rules: {get_attr: [{{role.name}}ServiceChainRoleData, value, firewall_rules]}"},{"line_number":1037,"context_line":"        tripleo_firewall_frontend_rules: {get_attr: [FirewallFrontendRules, value, frontend]}"},{"line_number":1038,"context_line":"        tripleo_firewall_ssl_frontend_rules: {get_attr: [FirewallFrontendRules, value, ssl_frontend]}"},{"line_number":1039,"context_line":"        tripleo_firewall_edge_frontend_rules: {get_attr: [FirewallFrontendRules, value, edge_frontend]}"},{"line_number":1040,"context_line":"        tripleo_firewall_edge_ssl_frontend_rules: {get_attr: [FirewallFrontendRules, value, edge_ssl_frontend]}"},{"line_number":1041,"context_line":"        role_tags: {{role.tags}}"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"  {{role.name}}NetworkConfig:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"53f40341_07eaf89c","line":1040,"range":{"start_line":1036,"start_character":0,"end_line":1040,"end_character":101},"in_reply_to":"213ee0d4_39062751","updated":"2022-04-14 07:55:04.000000000","message":"There is a tradeoff. We need to select right set of rules according to services (haproxy or edge haproxy) and public SSL.\n\nTo provide the only required rules but that requires logic to detect these two conditions. I think that\u0027s too much complicated to be implemented in tht.","commit_id":"5d63e95e12798e8dd7020c219f16b18d0dda5eea"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"88b53b5eef2b0315e1f1b1c12d195b4f307ef6fd","unresolved":false,"context_lines":[{"line_number":1033,"context_line":"        tripleo_network_config_with_ansible: {get_param: NetworkConfigWithAnsible}"},{"line_number":1034,"context_line":"        default_route_networks: {{role.default_route_networks|default([\u0027ControlPlane\u0027])}}"},{"line_number":1035,"context_line":"        networks_skip_config: {{ role.networks_skip_config|default([]) }}"},{"line_number":1036,"context_line":"        tripleo_firewall_rules: {get_attr: [{{role.name}}ServiceChainRoleData, value, firewall_rules]}"},{"line_number":1037,"context_line":"        tripleo_firewall_frontend_rules: {get_attr: [FirewallFrontendRules, value, frontend]}"},{"line_number":1038,"context_line":"        tripleo_firewall_ssl_frontend_rules: {get_attr: [FirewallFrontendRules, value, ssl_frontend]}"},{"line_number":1039,"context_line":"        tripleo_firewall_edge_frontend_rules: {get_attr: [FirewallFrontendRules, value, edge_frontend]}"},{"line_number":1040,"context_line":"        tripleo_firewall_edge_ssl_frontend_rules: {get_attr: [FirewallFrontendRules, value, edge_ssl_frontend]}"},{"line_number":1041,"context_line":"        role_tags: {{role.tags}}"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"  {{role.name}}NetworkConfig:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"f01c6e29_370f2a92","line":1040,"range":{"start_line":1036,"start_character":0,"end_line":1040,"end_character":101},"in_reply_to":"53f40341_07eaf89c","updated":"2022-04-26 16:04:48.000000000","message":"Done","commit_id":"5d63e95e12798e8dd7020c219f16b18d0dda5eea"}]}