)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"0ff11a7d432f27ba871c6ee1211a1645f2509257","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d1a8e36b_78fc4094","updated":"2022-03-04 08:51:32.000000000","message":"it didn\u0027t work it seems\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_83d/831813/2/check/tripleo-ci-centos-9-scenario007-multinode-oooq-container/83d7f81/logs/subnode-1/var/log/extra/podman/containers/nova_virtqemud/podman_info.log","commit_id":"82a21745da85d54ffb9c2effbb9ff3a3b3245b58"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"3698f98774df7e347ab904d5ec5922d0702f461b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c67d38e0_f301040c","in_reply_to":"d1a8e36b_78fc4094","updated":"2022-03-07 18:43:57.000000000","message":"Why do you say it didn\u0027t work? It won\u0027t show there. This will effectively pass an environment variable when running subscription-manager commands via ansible. There\u0027s no way to test this upstream unfortunately.","commit_id":"82a21745da85d54ffb9c2effbb9ff3a3b3245b58"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b5351d8b981ea39703d963284e512ee9fb212424","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a04f6cb3_f449df17","updated":"2022-03-22 17:00:58.000000000","message":"thanks! back to WIP :)","commit_id":"ddc76b21876c70f27cc75cf9c81b93347c7ccc08"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"b201ab1ee0c1abea10b2e841eaca91be674e47a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"62afe50a_1718a37c","updated":"2022-03-25 10:08:09.000000000","message":"@Bogdan","commit_id":"0ac3f8b3338748e9f986f08e0fdaf5adad70b1cd"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"0d115cc314928cdb8d2754aa1cf056501edd8970","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"27bfb31d_2e946bb8","updated":"2022-03-25 09:45:24.000000000","message":"folks, PTAL, it works for my testing","commit_id":"0ac3f8b3338748e9f986f08e0fdaf5adad70b1cd"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5fb8ff7bdd9e63c8f9d6d031a82b5cdbe57dc97e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3155e990_cb8e830e","updated":"2022-03-24 16:53:28.000000000","message":"recheck","commit_id":"0ac3f8b3338748e9f986f08e0fdaf5adad70b1cd"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b84df2a2a3f304e0c65548915f70bbaf48a14f2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a63c02a1_9fed910c","updated":"2022-03-25 10:19:34.000000000","message":"sigh, I have to wrap my head around that new test case :)","commit_id":"0ac3f8b3338748e9f986f08e0fdaf5adad70b1cd"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"b201ab1ee0c1abea10b2e841eaca91be674e47a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d873f4bd_59c1b459","in_reply_to":"27bfb31d_2e946bb8","updated":"2022-03-25 10:08:09.000000000","message":"Probably not:)\n\nhttps://paste.opendev.org/show/b7yBylKvUyicgbyZUIKC/","commit_id":"0ac3f8b3338748e9f986f08e0fdaf5adad70b1cd"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1ab27a4d250644c95c371f20559bb59c58b1c246","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e797a20f_0c0d8213","updated":"2022-03-25 15:00:46.000000000","message":"*now* it really works for me https://paste.openstack.org/show/b74QmYEiFw9Nsehfh32s/","commit_id":"5641473695f36fb96089db84fcbddd5042d11f1f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"6017648530d61a33f8677be66dc7f0418b18bf8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bde59cb4_61857933","updated":"2022-03-30 15:10:13.000000000","message":"PTAL, it\u0027s all good now","commit_id":"532bd777768d2d432124e7c8515d19c1dab54077"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"98adc09603cba34bafa7bc9edfc299b473dfa07e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2cd9dfad_985d0ad9","updated":"2022-04-01 11:25:55.000000000","message":"Yes, this works! Thanks","commit_id":"53d3af77f717ffbe52d629f83e6381d351f113e6"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8b9c935514ebb8a19f35b233a7b5bc13931ff9bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7f5d5e60_927e6ac8","updated":"2022-04-01 10:11:35.000000000","message":"as I explained earlier, this merges things with unexpected results.\nPlease don\u0027t do that","commit_id":"53d3af77f717ffbe52d629f83e6381d351f113e6"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"9da2e634254574b0ea0bdff8612649d32f383779","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5768d3ad_b379c06c","updated":"2022-04-15 07:58:44.000000000","message":"recheck","commit_id":"53d3af77f717ffbe52d629f83e6381d351f113e6"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"c8013c4df5183b84a96e3d5b2060bd58c464ecfc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"829e0ed5_21a74539","updated":"2022-04-08 05:31:24.000000000","message":"recheck","commit_id":"53d3af77f717ffbe52d629f83e6381d351f113e6"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"78a655f4114c5a4c628d3acd92c46dbfe658b4cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1d65b6e2_c88d79dc","in_reply_to":"7f5d5e60_927e6ac8","updated":"2022-04-01 10:23:14.000000000","message":"What unexpected things it merges? Did you comment without checking/testing. It\u0027s different from last version.","commit_id":"53d3af77f717ffbe52d629f83e6381d351f113e6"}],"deployment/rhsm/rhsm-baremetal-ansible.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"91ec789dad4a7f486ff3b34bebc0b7a586455579","unresolved":true,"context_lines":[{"line_number":75,"context_line":"            name: redhat-subscription"},{"line_number":76,"context_line":"            tasks_from: unregister"},{"line_number":77,"context_line":"          vars:"},{"line_number":78,"context_line":"            rhsm_disable_container_check: true"},{"line_number":79,"context_line":"      upgrade_tasks:"},{"line_number":80,"context_line":"        - name: Red Hat Subscription Management configuration"},{"line_number":81,"context_line":"          import_role:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5b756772_661145f3","line":78,"updated":"2022-03-07 21:32:27.000000000","message":"don\u0027t you want the same as line 69 here? what if someone put rhsm_disable_container_check:false in RhsmVars?","commit_id":"82a21745da85d54ffb9c2effbb9ff3a3b3245b58"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5878be7ba9d035dd7ca75331ede3121d3b2230c7","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            name: redhat-subscription"},{"line_number":76,"context_line":"            tasks_from: unregister"},{"line_number":77,"context_line":"          vars:"},{"line_number":78,"context_line":"            rhsm_disable_container_check: true"},{"line_number":79,"context_line":"      upgrade_tasks:"},{"line_number":80,"context_line":"        - name: Red Hat Subscription Management configuration"},{"line_number":81,"context_line":"          import_role:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d49728b6_21e2832e","line":78,"in_reply_to":"5b756772_661145f3","updated":"2022-03-18 14:00:01.000000000","message":"Done","commit_id":"82a21745da85d54ffb9c2effbb9ff3a3b3245b58"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"d93497905fb8d9146a5c5ae92b94f07e47690a27","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        map_replace:"},{"line_number":51,"context_line":"          - map_replace:"},{"line_number":52,"context_line":"            - vars:"},{"line_number":53,"context_line":"              - map_merge:"},{"line_number":54,"context_line":"                - rhsm_disable_container_check: true"},{"line_number":55,"context_line":"                - RhsmVars"},{"line_number":56,"context_line":"            - values: {get_param: [RoleParameters]}"},{"line_number":57,"context_line":"          - values:"},{"line_number":58,"context_line":"              RhsmVars: {get_param: RhsmVars}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"998d1330_0a735642","line":55,"range":{"start_line":53,"start_character":0,"end_line":55,"end_character":26},"updated":"2022-03-21 11:42:12.000000000","message":"Not sure what we\u0027re trying to do here. RhsmVars is just a string and not a map. get_param: RhsmVars is a map.","commit_id":"3becd86bae87649b32d52ff2d16df4ca15a45553"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"c016e9001d455b125eba147d5b5d10f0a83a302f","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        map_replace:"},{"line_number":51,"context_line":"          - map_replace:"},{"line_number":52,"context_line":"            - vars:"},{"line_number":53,"context_line":"              - map_merge:"},{"line_number":54,"context_line":"                - rhsm_disable_container_check: true"},{"line_number":55,"context_line":"                - RhsmVars"},{"line_number":56,"context_line":"            - values: {get_param: [RoleParameters]}"},{"line_number":57,"context_line":"          - values:"},{"line_number":58,"context_line":"              RhsmVars: {get_param: RhsmVars}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d8e00463_b802c7e0","line":55,"range":{"start_line":53,"start_character":0,"end_line":55,"end_character":26},"in_reply_to":"14ff0d0f_9f748cd7","updated":"2022-03-21 12:38:35.000000000","message":"Earlier it was correct. Has this been tested? This map_merge won\u0027t work and would fail with the below error.\n\nIncorrect arguments: Items to merge must be maps.\n\nYou should instead merge it with value in L58 or in L78.","commit_id":"3becd86bae87649b32d52ff2d16df4ca15a45553"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"977023d83173afbfb592788675576336c43283c0","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        map_replace:"},{"line_number":51,"context_line":"          - map_replace:"},{"line_number":52,"context_line":"            - vars:"},{"line_number":53,"context_line":"              - map_merge:"},{"line_number":54,"context_line":"                - rhsm_disable_container_check: true"},{"line_number":55,"context_line":"                - RhsmVars"},{"line_number":56,"context_line":"            - values: {get_param: [RoleParameters]}"},{"line_number":57,"context_line":"          - values:"},{"line_number":58,"context_line":"              RhsmVars: {get_param: RhsmVars}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"14ff0d0f_9f748cd7","line":55,"range":{"start_line":53,"start_character":0,"end_line":55,"end_character":26},"in_reply_to":"88c78090_fb63ae40","updated":"2022-03-21 12:32:41.000000000","message":"btw, this patch doesn\u0027t change that, the poor naming choice is out of scope.\nCould you please clarify what should be done?","commit_id":"3becd86bae87649b32d52ff2d16df4ca15a45553"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b37fee6402bde4bd2b3bbca2c3bc61844034391e","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        map_replace:"},{"line_number":51,"context_line":"          - map_replace:"},{"line_number":52,"context_line":"            - vars:"},{"line_number":53,"context_line":"              - map_merge:"},{"line_number":54,"context_line":"                - rhsm_disable_container_check: true"},{"line_number":55,"context_line":"                - RhsmVars"},{"line_number":56,"context_line":"            - values: {get_param: [RoleParameters]}"},{"line_number":57,"context_line":"          - values:"},{"line_number":58,"context_line":"              RhsmVars: {get_param: RhsmVars}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"88c78090_fb63ae40","line":55,"range":{"start_line":53,"start_character":0,"end_line":55,"end_character":26},"in_reply_to":"998d1330_0a735642","updated":"2022-03-21 12:30:36.000000000","message":"RhsmVars is {}. Should I rename the value that it takes from it?","commit_id":"3becd86bae87649b32d52ff2d16df4ca15a45553"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e5e56c1669a901c27ba32be72c2a9ecfc9aaa4cb","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        map_replace:"},{"line_number":51,"context_line":"          - map_replace:"},{"line_number":52,"context_line":"            - vars:"},{"line_number":53,"context_line":"              - map_merge:"},{"line_number":54,"context_line":"                - rhsm_disable_container_check: true"},{"line_number":55,"context_line":"                - RhsmVars"},{"line_number":56,"context_line":"            - values: {get_param: [RoleParameters]}"},{"line_number":57,"context_line":"          - values:"},{"line_number":58,"context_line":"              RhsmVars: {get_param: RhsmVars}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ea0efcc1_dc9383c6","line":55,"range":{"start_line":53,"start_character":0,"end_line":55,"end_character":26},"in_reply_to":"d8e00463_b802c7e0","updated":"2022-03-21 15:54:51.000000000","message":"Done\n\n{\n  \"attributes\": {\n\t\"value\": {\n\t  \"vars\": {\n\t\t\"rhsm_release\": \"8.2\",\n\t\t\"rhsm_repos\": [\n\t\t  \"rhel-8-foo\"             \n\t\t],                                          \n\t\t\"rhsm_disable_container_check\": true\n  ...","commit_id":"3becd86bae87649b32d52ff2d16df4ca15a45553"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"abc41081746e47dbbfa8f69b1d5e1e8bc0763898","unresolved":true,"context_lines":[{"line_number":49,"context_line":"      value:"},{"line_number":50,"context_line":"        map_replace:"},{"line_number":51,"context_line":"          - map_replace:"},{"line_number":52,"context_line":"            - vars: $RHSMVARS"},{"line_number":53,"context_line":"            - values: {get_param: [RoleParameters]}"},{"line_number":54,"context_line":"          - values:"},{"line_number":55,"context_line":"              $RHSMVARS:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e77adc39_5de7e555","line":52,"range":{"start_line":52,"start_character":21,"end_line":52,"end_character":29},"updated":"2022-03-22 03:45:21.000000000","message":"This is incorrect. It has to be the parameter name RhsmVars, else the inner map replace won\u0027t work.","commit_id":"ff27c1382af06b1587b360d1ee7891ce74458a2f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ece38608c5a8de4de8f02cb53f1a37fa8566cb75","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      value:"},{"line_number":50,"context_line":"        map_replace:"},{"line_number":51,"context_line":"          - map_replace:"},{"line_number":52,"context_line":"            - vars: $RHSMVARS"},{"line_number":53,"context_line":"            - values: {get_param: [RoleParameters]}"},{"line_number":54,"context_line":"          - values:"},{"line_number":55,"context_line":"              $RHSMVARS:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1d4e6eed_6ca3a17b","line":52,"range":{"start_line":52,"start_character":21,"end_line":52,"end_character":29},"in_reply_to":"62bf5f2e_7734512e","updated":"2022-03-22 14:39:54.000000000","message":"Done","commit_id":"ff27c1382af06b1587b360d1ee7891ce74458a2f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"cef948a5d60cb9f5fbab704e71b13ba52f3faa23","unresolved":true,"context_lines":[{"line_number":49,"context_line":"      value:"},{"line_number":50,"context_line":"        map_replace:"},{"line_number":51,"context_line":"          - map_replace:"},{"line_number":52,"context_line":"            - vars: $RHSMVARS"},{"line_number":53,"context_line":"            - values: {get_param: [RoleParameters]}"},{"line_number":54,"context_line":"          - values:"},{"line_number":55,"context_line":"              $RHSMVARS:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"62bf5f2e_7734512e","line":52,"range":{"start_line":52,"start_character":21,"end_line":52,"end_character":29},"in_reply_to":"e77adc39_5de7e555","updated":"2022-03-22 09:46:01.000000000","message":"I tested that, it worked","commit_id":"ff27c1382af06b1587b360d1ee7891ce74458a2f"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"abc41081746e47dbbfa8f69b1d5e1e8bc0763898","unresolved":true,"context_lines":[{"line_number":52,"context_line":"            - vars: $RHSMVARS"},{"line_number":53,"context_line":"            - values: {get_param: [RoleParameters]}"},{"line_number":54,"context_line":"          - values:"},{"line_number":55,"context_line":"              $RHSMVARS:"},{"line_number":56,"context_line":"                map_merge:"},{"line_number":57,"context_line":"                - {get_param: RhsmVars}"},{"line_number":58,"context_line":"                - rhsm_disable_container_check: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b6a8fc0f_6b049a86","line":55,"range":{"start_line":55,"start_character":14,"end_line":55,"end_character":23},"updated":"2022-03-22 03:45:21.000000000","message":"Same here","commit_id":"ff27c1382af06b1587b360d1ee7891ce74458a2f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ece38608c5a8de4de8f02cb53f1a37fa8566cb75","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            - vars: $RHSMVARS"},{"line_number":53,"context_line":"            - values: {get_param: [RoleParameters]}"},{"line_number":54,"context_line":"          - values:"},{"line_number":55,"context_line":"              $RHSMVARS:"},{"line_number":56,"context_line":"                map_merge:"},{"line_number":57,"context_line":"                - {get_param: RhsmVars}"},{"line_number":58,"context_line":"                - rhsm_disable_container_check: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"101d7e4e_3710efbe","line":55,"range":{"start_line":55,"start_character":14,"end_line":55,"end_character":23},"in_reply_to":"b6a8fc0f_6b049a86","updated":"2022-03-22 14:39:54.000000000","message":"Done","commit_id":"ff27c1382af06b1587b360d1ee7891ce74458a2f"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"abc41081746e47dbbfa8f69b1d5e1e8bc0763898","unresolved":true,"context_lines":[{"line_number":54,"context_line":"          - values:"},{"line_number":55,"context_line":"              $RHSMVARS:"},{"line_number":56,"context_line":"                map_merge:"},{"line_number":57,"context_line":"                - {get_param: RhsmVars}"},{"line_number":58,"context_line":"                - rhsm_disable_container_check: true"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"outputs:"},{"line_number":61,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"6d11aba7_e1a9d04c","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":52},"updated":"2022-03-22 03:45:21.000000000","message":"We should reverse the list order here. If there is rhsm_disable_container_check in  RhsmVars global parameter it would take precedence.","commit_id":"ff27c1382af06b1587b360d1ee7891ce74458a2f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"cef948a5d60cb9f5fbab704e71b13ba52f3faa23","unresolved":true,"context_lines":[{"line_number":54,"context_line":"          - values:"},{"line_number":55,"context_line":"              $RHSMVARS:"},{"line_number":56,"context_line":"                map_merge:"},{"line_number":57,"context_line":"                - {get_param: RhsmVars}"},{"line_number":58,"context_line":"                - rhsm_disable_container_check: true"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"outputs:"},{"line_number":61,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b181bd51_c614037e","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":52},"in_reply_to":"6d11aba7_e1a9d04c","updated":"2022-03-22 09:46:01.000000000","message":"I\u0027ll retest with precedence, thanks","commit_id":"ff27c1382af06b1587b360d1ee7891ce74458a2f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"91eed4def3d30a1a42d5d1560f0705dc5c63b6ad","unresolved":false,"context_lines":[{"line_number":54,"context_line":"          - values:"},{"line_number":55,"context_line":"              $RHSMVARS:"},{"line_number":56,"context_line":"                map_merge:"},{"line_number":57,"context_line":"                - {get_param: RhsmVars}"},{"line_number":58,"context_line":"                - rhsm_disable_container_check: true"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"outputs:"},{"line_number":61,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"0d1c29e9_aa82520f","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":52},"in_reply_to":"a2d356b9_33ff782f","updated":"2022-03-22 15:03:59.000000000","message":"I\u0027ve also tried the inputs:\n\nparameter_defaults:\n  RhsmVars:\n    rhsm_repos:\n      - rhel-8-foo\n    rhsm_release: \u00278.2\u0027\n  ControllerParameters:\n    RhsmVars:\n      rhsm_repos:\n        - rhel-8-bar\n      rhsm_release: \u00278.4\u0027\n      rhsm_disable_container_check: false\n\n\nand got the same result. Is that expected? I couldn\u0027t see the role specific got overrode anything","commit_id":"ff27c1382af06b1587b360d1ee7891ce74458a2f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ece38608c5a8de4de8f02cb53f1a37fa8566cb75","unresolved":false,"context_lines":[{"line_number":54,"context_line":"          - values:"},{"line_number":55,"context_line":"              $RHSMVARS:"},{"line_number":56,"context_line":"                map_merge:"},{"line_number":57,"context_line":"                - {get_param: RhsmVars}"},{"line_number":58,"context_line":"                - rhsm_disable_container_check: true"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"outputs:"},{"line_number":61,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a2d356b9_33ff782f","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":52},"in_reply_to":"b181bd51_c614037e","updated":"2022-03-22 14:39:54.000000000","message":"I don\u0027t think we should reverse it, here is what my testing shows:\n\nfor the input:\n\nparameter_defaults:\n  RhsmVars:\n    rhsm_repos:\n      - rhel-8-foo\n    rhsm_release: \u00278.2\u0027\n  ControllerRhsmVars:\n    rhsm_release: \u00278.4\u0027\n    rhsm_disable_container_check: false\n\nit gives:\n{\n  \"attributes\": {\n    \"value\": {\n      \"vars\": {\n        \"rhsm_release\": \"8.2\",\n        \"rhsm_repos\": [\n          \"rhel-8-foo\"\n        ],\n        \"rhsm_disable_container_check\": true\n      }\n    }\n  }\n}","commit_id":"ff27c1382af06b1587b360d1ee7891ce74458a2f"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"040d866f4bda39c25e682eaf66a9857efb4077b9","unresolved":true,"context_lines":[{"line_number":75,"context_line":"            name: redhat-subscription"},{"line_number":76,"context_line":"            tasks_from: unregister"},{"line_number":77,"context_line":"          vars:"},{"line_number":78,"context_line":"            vars: {get_attr: [RoleParametersValue, value, vars]}"},{"line_number":79,"context_line":"      upgrade_tasks:"},{"line_number":80,"context_line":"        - name: Red Hat Subscription Management configuration"},{"line_number":81,"context_line":"          import_role:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dc5bcafd_b0b73fa1","line":78,"updated":"2022-03-21 21:26:36.000000000","message":"this looks odd. isn\u0027t there an extra vars key?","commit_id":"ff27c1382af06b1587b360d1ee7891ce74458a2f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"0c7a6491d464a65cdf742324f30a2170ca421c80","unresolved":true,"context_lines":[{"line_number":75,"context_line":"            name: redhat-subscription"},{"line_number":76,"context_line":"            tasks_from: unregister"},{"line_number":77,"context_line":"          vars:"},{"line_number":78,"context_line":"            vars: {get_attr: [RoleParametersValue, value, vars]}"},{"line_number":79,"context_line":"      upgrade_tasks:"},{"line_number":80,"context_line":"        - name: Red Hat Subscription Management configuration"},{"line_number":81,"context_line":"          import_role:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9e805b2c_85a6b447","line":78,"in_reply_to":"0ee0dd00_6aefb498","updated":"2022-03-22 09:45:16.000000000","message":"sorry, I meant that for the heat stack update testing, not this one","commit_id":"ff27c1382af06b1587b360d1ee7891ce74458a2f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ece38608c5a8de4de8f02cb53f1a37fa8566cb75","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            name: redhat-subscription"},{"line_number":76,"context_line":"            tasks_from: unregister"},{"line_number":77,"context_line":"          vars:"},{"line_number":78,"context_line":"            vars: {get_attr: [RoleParametersValue, value, vars]}"},{"line_number":79,"context_line":"      upgrade_tasks:"},{"line_number":80,"context_line":"        - name: Red Hat Subscription Management configuration"},{"line_number":81,"context_line":"          import_role:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d129ad48_e251f54b","line":78,"in_reply_to":"9e805b2c_85a6b447","updated":"2022-03-22 14:39:54.000000000","message":"Done","commit_id":"ff27c1382af06b1587b360d1ee7891ce74458a2f"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"abc41081746e47dbbfa8f69b1d5e1e8bc0763898","unresolved":true,"context_lines":[{"line_number":75,"context_line":"            name: redhat-subscription"},{"line_number":76,"context_line":"            tasks_from: unregister"},{"line_number":77,"context_line":"          vars:"},{"line_number":78,"context_line":"            vars: {get_attr: [RoleParametersValue, value, vars]}"},{"line_number":79,"context_line":"      upgrade_tasks:"},{"line_number":80,"context_line":"        - name: Red Hat Subscription Management configuration"},{"line_number":81,"context_line":"          import_role:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ee49eb76_de80f62d","line":78,"in_reply_to":"dc5bcafd_b0b73fa1","updated":"2022-03-22 03:45:21.000000000","message":"+1","commit_id":"ff27c1382af06b1587b360d1ee7891ce74458a2f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"144a9ae634541b88a50f297ab1483f53c6b01db6","unresolved":true,"context_lines":[{"line_number":75,"context_line":"            name: redhat-subscription"},{"line_number":76,"context_line":"            tasks_from: unregister"},{"line_number":77,"context_line":"          vars:"},{"line_number":78,"context_line":"            vars: {get_attr: [RoleParametersValue, value, vars]}"},{"line_number":79,"context_line":"      upgrade_tasks:"},{"line_number":80,"context_line":"        - name: Red Hat Subscription Management configuration"},{"line_number":81,"context_line":"          import_role:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"0ee0dd00_6aefb498","line":78,"in_reply_to":"ee49eb76_de80f62d","updated":"2022-03-22 09:44:18.000000000","message":"I tested that, it worked","commit_id":"ff27c1382af06b1587b360d1ee7891ce74458a2f"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"f067fba4c6b791582b00304f509d482177a1ebe8","unresolved":true,"context_lines":[{"line_number":48,"context_line":"      type: json"},{"line_number":49,"context_line":"      value:"},{"line_number":50,"context_line":"        map_replace:"},{"line_number":51,"context_line":"          - map_replace:"},{"line_number":52,"context_line":"            - vars: $RHSMVARS"},{"line_number":53,"context_line":"            - values: {get_param: [RoleParameters]}"},{"line_number":54,"context_line":"          - values:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"2f570ca6_0bba51e4","line":51,"range":{"start_line":51,"start_character":12,"end_line":51,"end_character":23},"updated":"2022-03-22 16:52:34.000000000","message":"None of my earlier comments are addressed in this patch. This map_replace is useless as there won\u0027t be any key $RHSMVARS in RoleParameters. RhsmVars in role won\u0027t be used and also every time you would get rhsm_disable_container_check: true\n\n(undercloud) [stack@undercloud-0 ~]$ cat test_tamplate.yaml \nheat_template_version: queens\nparameters:\n  RhsmVars:\n    type: json\n    default: {\u0027rhsm_xxx\u0027: \u0027xxx\u0027, \u0027rhsm_disable_container_check\u0027: false}\n  RoleParameters:\n    type: json\n    default: {\u0027RhsmVars\u0027: {\u0027rhsm_yyy\u0027: \u0027yyy\u0027, \u0027rhsm_disable_container_check\u0027: false }, \u0027other_vars\u0027: \u0027yyy\u0027}\n\nresources:\n  RoleParametersValue:\n    type: OS::Heat::Value\n    properties:\n      type: json\n      value:\n        map_replace:\n          - map_replace:\n            - vars: $RHSMVARS\n            - values: {get_param: [RoleParameters]}\n          - values:\n              $RHSMVARS:\n                map_merge:\n                - {get_param: RhsmVars}\n                - rhsm_disable_container_check: true\n\noutputs:\n  vars:\n    value: {get_attr: [RoleParametersValue, value, vars]}\n(undercloud) [stack@undercloud-0 ~]$ openstack stack create test -t test_tamplate.yaml\n+---------------------+--------------------------------------+\n| Field               | Value                                |\n+---------------------+--------------------------------------+\n| id                  | 075213ed-c8c6-4661-b8e4-24fa60b6d3c8 |\n| stack_name          | test                                 |\n| description         | No description                       |\n| creation_time       | 2022-03-22T16:50:54Z                 |\n| updated_time        | None                                 |\n| stack_status        | CREATE_IN_PROGRESS                   |\n| stack_status_reason | Stack CREATE started                 |\n+---------------------+--------------------------------------+\n(undercloud) [stack@undercloud-0 ~]$ openstack stack output show test vars\n+--------------+-----------------------------------------------------------+\n| Field        | Value                                                     |\n+--------------+-----------------------------------------------------------+\n| description  | No description given                                      |\n| output_key   | vars                                                      |\n| output_value | {\u0027rhsm_xxx\u0027: \u0027xxx\u0027, \u0027rhsm_disable_container_check\u0027: True} |\n+--------------+-----------------------------------------------------------+","commit_id":"ddc76b21876c70f27cc75cf9c81b93347c7ccc08"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d357f9fb7cea4cf9267440b65140041238fc3929","unresolved":false,"context_lines":[{"line_number":48,"context_line":"      type: json"},{"line_number":49,"context_line":"      value:"},{"line_number":50,"context_line":"        map_replace:"},{"line_number":51,"context_line":"          - map_replace:"},{"line_number":52,"context_line":"            - vars: $RHSMVARS"},{"line_number":53,"context_line":"            - values: {get_param: [RoleParameters]}"},{"line_number":54,"context_line":"          - values:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1b235502_d0aaa7a3","line":51,"range":{"start_line":51,"start_character":12,"end_line":51,"end_character":23},"in_reply_to":"0c018791_196cd4ce","updated":"2022-03-23 09:40:28.000000000","message":"Done","commit_id":"ddc76b21876c70f27cc75cf9c81b93347c7ccc08"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"85ff13e131d656890ee15affb80ee8163a833221","unresolved":true,"context_lines":[{"line_number":48,"context_line":"      type: json"},{"line_number":49,"context_line":"      value:"},{"line_number":50,"context_line":"        map_replace:"},{"line_number":51,"context_line":"          - map_replace:"},{"line_number":52,"context_line":"            - vars: $RHSMVARS"},{"line_number":53,"context_line":"            - values: {get_param: [RoleParameters]}"},{"line_number":54,"context_line":"          - values:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c6ae2918_e87b33f9","line":51,"range":{"start_line":51,"start_character":12,"end_line":51,"end_character":23},"in_reply_to":"2f570ca6_0bba51e4","updated":"2022-03-23 07:54:16.000000000","message":"Note that with the original code, the result was:\n\n| output_value | {\u0027rhsm_yyy\u0027: \u0027yyy\u0027, \u0027rhsm_disable_container_check\u0027: False} |\n\nWhile I think we expect \u0027other_vars\u0027: \u0027yyy\u0027 as well? So it seems this merging had  never worked as expected?","commit_id":"ddc76b21876c70f27cc75cf9c81b93347c7ccc08"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"ce2b1a1f85490061ec6fe4de27e835f5e3472d91","unresolved":true,"context_lines":[{"line_number":48,"context_line":"      type: json"},{"line_number":49,"context_line":"      value:"},{"line_number":50,"context_line":"        map_replace:"},{"line_number":51,"context_line":"          - map_replace:"},{"line_number":52,"context_line":"            - vars: $RHSMVARS"},{"line_number":53,"context_line":"            - values: {get_param: [RoleParameters]}"},{"line_number":54,"context_line":"          - values:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0c018791_196cd4ce","line":51,"range":{"start_line":51,"start_character":12,"end_line":51,"end_character":23},"in_reply_to":"c6ae2918_e87b33f9","updated":"2022-03-23 08:00:58.000000000","message":"I think it\u0027s working as expected. If the parameter i.e other_vars, is not in the template , we won\u0027t be using it anywhere in this template. So it\u0027s fine.","commit_id":"ddc76b21876c70f27cc75cf9c81b93347c7ccc08"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"f3c51f040d86ba103f12c80f2a9d6844a4a9a70b","unresolved":true,"context_lines":[{"line_number":51,"context_line":"          - map_replace:"},{"line_number":52,"context_line":"            - vars: RhsmVars"},{"line_number":53,"context_line":"            - values:"},{"line_number":54,"context_line":"                yaql:"},{"line_number":55,"context_line":"                  expression:  $.data.reduce($1.mergeWith($2, itemMerger \u003d\u003e ($1 \u003d true)), {})"},{"line_number":56,"context_line":"                  data:"},{"line_number":57,"context_line":"                    - {get_param: [RoleParameters]}"},{"line_number":58,"context_line":"                    - RhsmVars:"},{"line_number":59,"context_line":"                        rhsm_disable_container_check: true"},{"line_number":60,"context_line":"          - values:"},{"line_number":61,"context_line":"              RhsmVars:"},{"line_number":62,"context_line":"                yaql:"},{"line_number":63,"context_line":"                  expression:  $.data.reduce($1.mergeWith($2, itemMerger \u003d\u003e ($1 \u003d true)), {})"},{"line_number":64,"context_line":"                  data:"},{"line_number":65,"context_line":"                    - {get_param: RhsmVars}"},{"line_number":66,"context_line":"                    - rhsm_disable_container_check: true"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"outputs:"},{"line_number":69,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"55df0b48_e31aa04d","line":66,"range":{"start_line":54,"start_character":0,"end_line":66,"end_character":56},"updated":"2022-03-29 06:02:13.000000000","message":"This does not work when only RhsmVars global var is provided (no role parameters).\n\nLet me know what you think about this simplified one without yaql.\n\nheat_template_version: wallaby\nparameters:\n  RoleParameters:\n    type: json\n    default: {}\n  RhsmVars:\n    type: json\n    default: {}\nresources:\n  RoleParametersValue:\n    type: OS::Heat::Value\n    properties:\n      type: json\n      value:\n        vars:\n          map_merge:\n            - rhsm_disable_container_check: true\n            - {get_param: [RhsmVars]}\n            - if:\n                - not: {equals: [{get_param: [RoleParameters, RhsmVars]}, \u0027\u0027]}\n                - {get_param: [RoleParameters, RhsmVars]}\noutputs:\n  vars:\n    value: {get_attr: [RoleParametersValue, value, vars]}","commit_id":"5641473695f36fb96089db84fcbddd5042d11f1f"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"acf1679b35923247d768a6e014dd8913ca3cbaee","unresolved":false,"context_lines":[{"line_number":51,"context_line":"          - map_replace:"},{"line_number":52,"context_line":"            - vars: RhsmVars"},{"line_number":53,"context_line":"            - values:"},{"line_number":54,"context_line":"                yaql:"},{"line_number":55,"context_line":"                  expression:  $.data.reduce($1.mergeWith($2, itemMerger \u003d\u003e ($1 \u003d true)), {})"},{"line_number":56,"context_line":"                  data:"},{"line_number":57,"context_line":"                    - {get_param: [RoleParameters]}"},{"line_number":58,"context_line":"                    - RhsmVars:"},{"line_number":59,"context_line":"                        rhsm_disable_container_check: true"},{"line_number":60,"context_line":"          - values:"},{"line_number":61,"context_line":"              RhsmVars:"},{"line_number":62,"context_line":"                yaql:"},{"line_number":63,"context_line":"                  expression:  $.data.reduce($1.mergeWith($2, itemMerger \u003d\u003e ($1 \u003d true)), {})"},{"line_number":64,"context_line":"                  data:"},{"line_number":65,"context_line":"                    - {get_param: RhsmVars}"},{"line_number":66,"context_line":"                    - rhsm_disable_container_check: true"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"outputs:"},{"line_number":69,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bfa6ec96_029cd970","line":66,"range":{"start_line":54,"start_character":0,"end_line":66,"end_character":56},"in_reply_to":"36ecdadf_a116ca43","updated":"2022-03-29 12:13:52.000000000","message":"\u003e this doesn\u0027t work with both (merges it instead of replacing):\n\nThat would be acceptable I think as RoleParameters/RhsmVars keys are meant to override and they would have the high precedence.","commit_id":"5641473695f36fb96089db84fcbddd5042d11f1f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"83848e26340d387d5099ebc06d6521dadbd3d44c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"          - map_replace:"},{"line_number":52,"context_line":"            - vars: RhsmVars"},{"line_number":53,"context_line":"            - values:"},{"line_number":54,"context_line":"                yaql:"},{"line_number":55,"context_line":"                  expression:  $.data.reduce($1.mergeWith($2, itemMerger \u003d\u003e ($1 \u003d true)), {})"},{"line_number":56,"context_line":"                  data:"},{"line_number":57,"context_line":"                    - {get_param: [RoleParameters]}"},{"line_number":58,"context_line":"                    - RhsmVars:"},{"line_number":59,"context_line":"                        rhsm_disable_container_check: true"},{"line_number":60,"context_line":"          - values:"},{"line_number":61,"context_line":"              RhsmVars:"},{"line_number":62,"context_line":"                yaql:"},{"line_number":63,"context_line":"                  expression:  $.data.reduce($1.mergeWith($2, itemMerger \u003d\u003e ($1 \u003d true)), {})"},{"line_number":64,"context_line":"                  data:"},{"line_number":65,"context_line":"                    - {get_param: RhsmVars}"},{"line_number":66,"context_line":"                    - rhsm_disable_container_check: true"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"outputs:"},{"line_number":69,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bc099a0e_d581eafa","line":66,"range":{"start_line":54,"start_character":0,"end_line":66,"end_character":56},"in_reply_to":"36ecdadf_a116ca43","updated":"2022-03-29 12:26:59.000000000","message":"I\u0027ve updated with your extra test case now passed, thank you for the idea!","commit_id":"5641473695f36fb96089db84fcbddd5042d11f1f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1a4c86bedcb8c3a4b6c6c769172dec785f9c8854","unresolved":false,"context_lines":[{"line_number":51,"context_line":"          - map_replace:"},{"line_number":52,"context_line":"            - vars: RhsmVars"},{"line_number":53,"context_line":"            - values:"},{"line_number":54,"context_line":"                yaql:"},{"line_number":55,"context_line":"                  expression:  $.data.reduce($1.mergeWith($2, itemMerger \u003d\u003e ($1 \u003d true)), {})"},{"line_number":56,"context_line":"                  data:"},{"line_number":57,"context_line":"                    - {get_param: [RoleParameters]}"},{"line_number":58,"context_line":"                    - RhsmVars:"},{"line_number":59,"context_line":"                        rhsm_disable_container_check: true"},{"line_number":60,"context_line":"          - values:"},{"line_number":61,"context_line":"              RhsmVars:"},{"line_number":62,"context_line":"                yaql:"},{"line_number":63,"context_line":"                  expression:  $.data.reduce($1.mergeWith($2, itemMerger \u003d\u003e ($1 \u003d true)), {})"},{"line_number":64,"context_line":"                  data:"},{"line_number":65,"context_line":"                    - {get_param: RhsmVars}"},{"line_number":66,"context_line":"                    - rhsm_disable_container_check: true"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"outputs:"},{"line_number":69,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"36ecdadf_a116ca43","line":66,"range":{"start_line":54,"start_character":0,"end_line":66,"end_character":56},"in_reply_to":"55df0b48_e31aa04d","updated":"2022-03-29 12:02:14.000000000","message":"this doesn\u0027t work with both (merges it instead of replacing):\n\nheat_template_version: queens\nparameters:\n  RoleParameters:\n    type: json\n    default: {\u0027RhsmVars\u0027: {\u0027some\u0027: \u0027thing\u0027, 1: 2}}\n  RhsmVars:\n    type: json\n    default: {\u0027ignore\u0027 : \u0027me\u0027}\nresources:\n  RoleParametersValue:\n    type: OS::Heat::Value\n    properties:\n      type: json\n      value:\n        vars:\n          map_merge:\n            - rhsm_disable_container_check: true\n            - {get_param: [RhsmVars]}\n            - if:\n                - not: {equals: [{get_param: [RoleParameters, RhsmVars]}, \u0027\u0027]}\n                - {get_param: [RoleParameters, RhsmVars]}\n                - {}\noutputs:\n  vars:\n    value: {get_attr: [RoleParametersValue, value, vars]}\n\n...\n| output_value | {\u0027rhsm_disable_container_check\u0027: True, \u0027ignore\u0027: \u0027me\u0027, \u0027some\u0027: \u0027thing\u0027, \u00271\u0027: 2} |","commit_id":"5641473695f36fb96089db84fcbddd5042d11f1f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"274f2afe6794219295d53bda4f5966b58a6ef853","unresolved":false,"context_lines":[{"line_number":51,"context_line":"          - map_replace:"},{"line_number":52,"context_line":"            - vars: RhsmVars"},{"line_number":53,"context_line":"            - values:"},{"line_number":54,"context_line":"                yaql:"},{"line_number":55,"context_line":"                  expression:  $.data.reduce($1.mergeWith($2, itemMerger \u003d\u003e ($1 \u003d true)), {})"},{"line_number":56,"context_line":"                  data:"},{"line_number":57,"context_line":"                    - {get_param: [RoleParameters]}"},{"line_number":58,"context_line":"                    - RhsmVars:"},{"line_number":59,"context_line":"                        rhsm_disable_container_check: true"},{"line_number":60,"context_line":"          - values:"},{"line_number":61,"context_line":"              RhsmVars:"},{"line_number":62,"context_line":"                yaql:"},{"line_number":63,"context_line":"                  expression:  $.data.reduce($1.mergeWith($2, itemMerger \u003d\u003e ($1 \u003d true)), {})"},{"line_number":64,"context_line":"                  data:"},{"line_number":65,"context_line":"                    - {get_param: RhsmVars}"},{"line_number":66,"context_line":"                    - rhsm_disable_container_check: true"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"outputs:"},{"line_number":69,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"e9271a02_cbc2b17f","line":66,"range":{"start_line":54,"start_character":0,"end_line":66,"end_character":56},"in_reply_to":"bc099a0e_d581eafa","updated":"2022-03-29 12:31:52.000000000","message":"\u003e That would be acceptable I think as RoleParameters/RhsmVars keys are meant to override and they would have the high precedence.\n\nnot really, that also shows unexpected results when role env and env files get merged and the latter contains rhsm_disable_container_check: false. When overriding, it should be ignored and the result would contain rhsm_disable_container_check: true. But if not replaced but merged (as your code does) the result ends up with rhsm_disable_container_check: false.","commit_id":"5641473695f36fb96089db84fcbddd5042d11f1f"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"405ca71d22885d7bef29cfb500a22224c1cb9fc8","unresolved":true,"context_lines":[{"line_number":52,"context_line":"            - vars: RhsmVars"},{"line_number":53,"context_line":"            - values:"},{"line_number":54,"context_line":"                if:"},{"line_number":55,"context_line":"                  - not: {equals: [{get_param: [RoleParameters]}, {get_param: [RoleParameters, RhsmVars, {}]}]}"},{"line_number":56,"context_line":"                  - yaql:"},{"line_number":57,"context_line":"                      expression:  $.data.reduce($1.mergeWith($2, itemMerger \u003d\u003e ($1 \u003d true)), {})"},{"line_number":58,"context_line":"                      data:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"8bd5ad80_27a25fbd","line":55,"range":{"start_line":55,"start_character":18,"end_line":55,"end_character":111},"updated":"2022-03-31 06:01:31.000000000","message":"Not sure I understand what we\u0027re doing here..\n\n{get_param: [RoleParameters, RhsmVars, {}]} would always return empty string (\u0027\u0027)\n\nWe should not make it so complicated and try avoid yaql usage as mentioned earlier.","commit_id":"532bd777768d2d432124e7c8515d19c1dab54077"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c9c2ae21a81c3bfdab4c1d86c7136ea3048035e8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            - vars: RhsmVars"},{"line_number":53,"context_line":"            - values:"},{"line_number":54,"context_line":"                if:"},{"line_number":55,"context_line":"                  - not: {equals: [{get_param: [RoleParameters]}, {get_param: [RoleParameters, RhsmVars, {}]}]}"},{"line_number":56,"context_line":"                  - yaql:"},{"line_number":57,"context_line":"                      expression:  $.data.reduce($1.mergeWith($2, itemMerger \u003d\u003e ($1 \u003d true)), {})"},{"line_number":58,"context_line":"                      data:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"de5f124d_533eb59b","line":55,"range":{"start_line":55,"start_character":18,"end_line":55,"end_character":111},"in_reply_to":"6f00c59a_1e600423","updated":"2022-04-15 08:00:17.000000000","message":"Done","commit_id":"532bd777768d2d432124e7c8515d19c1dab54077"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"dcc9c912c58cdaa34769a12b4c13bd5a21282bd0","unresolved":true,"context_lines":[{"line_number":52,"context_line":"            - vars: RhsmVars"},{"line_number":53,"context_line":"            - values:"},{"line_number":54,"context_line":"                if:"},{"line_number":55,"context_line":"                  - not: {equals: [{get_param: [RoleParameters]}, {get_param: [RoleParameters, RhsmVars, {}]}]}"},{"line_number":56,"context_line":"                  - yaql:"},{"line_number":57,"context_line":"                      expression:  $.data.reduce($1.mergeWith($2, itemMerger \u003d\u003e ($1 \u003d true)), {})"},{"line_number":58,"context_line":"                      data:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"6f00c59a_1e600423","line":55,"range":{"start_line":55,"start_character":18,"end_line":55,"end_character":111},"in_reply_to":"8bd5ad80_27a25fbd","updated":"2022-03-31 11:32:55.000000000","message":"I don\u0027t have better solution sorry. Would you please take it over?","commit_id":"532bd777768d2d432124e7c8515d19c1dab54077"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5400d4b31c945165c29561157d87e5c0945a7644","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                        - {get_param: [RoleParameters]}"},{"line_number":60,"context_line":"                        - RhsmVars:"},{"line_number":61,"context_line":"                            rhsm_disable_container_check: true"},{"line_number":62,"context_line":"                  - {}"},{"line_number":63,"context_line":"          - values:"},{"line_number":64,"context_line":"              RhsmVars:"},{"line_number":65,"context_line":"                yaql:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"f0165d39_b1a6bcdc","line":62,"updated":"2022-03-29 12:29:10.000000000","message":"this can be omitted for master, but we should keep it for train backports I think","commit_id":"532bd777768d2d432124e7c8515d19c1dab54077"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"c00965736659d9494bc15a480e97d8a0189a45bd","unresolved":true,"context_lines":[{"line_number":51,"context_line":"          - rhsm_disable_container_check: true"},{"line_number":52,"context_line":"          - if:"},{"line_number":53,"context_line":"              - not: {equals: [{get_param: [RoleParameters, RhsmVars]}, \u0027\u0027]}"},{"line_number":54,"context_line":"              - {get_param: [RoleParameters, RhsmVars]}"},{"line_number":55,"context_line":"              - {get_param: RhsmVars}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"outputs:"},{"line_number":58,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"d2aede8a_edcdc620","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":37},"updated":"2022-04-01 10:27:39.000000000","message":"This will use from RoleParameters if provided else use from global parameter RhsmVars.","commit_id":"53d3af77f717ffbe52d629f83e6381d351f113e6"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c9c2ae21a81c3bfdab4c1d86c7136ea3048035e8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"          - rhsm_disable_container_check: true"},{"line_number":52,"context_line":"          - if:"},{"line_number":53,"context_line":"              - not: {equals: [{get_param: [RoleParameters, RhsmVars]}, \u0027\u0027]}"},{"line_number":54,"context_line":"              - {get_param: [RoleParameters, RhsmVars]}"},{"line_number":55,"context_line":"              - {get_param: RhsmVars}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"outputs:"},{"line_number":58,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3c34996d_d073aa31","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":37},"in_reply_to":"d2aede8a_edcdc620","updated":"2022-04-15 08:00:17.000000000","message":"Done","commit_id":"53d3af77f717ffbe52d629f83e6381d351f113e6"}]}