)]}'
{"deployment/memcached/memcached-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"26887ebe4be6cf3b7ca3895628c1e6c983df4607","unresolved":true,"context_lines":[{"line_number":366,"context_line":"                              - if:"},{"line_number":367,"context_line":"                                - is_ipv6"},{"line_number":368,"context_line":"                                - \u0027::1\u0027"},{"line_number":369,"context_line":"                                - \u0027127.0.0.1\u0027"},{"line_number":370,"context_line":"                            $MEMCACHED_PORT: {get_param: MemcachedPort}"},{"line_number":371,"context_line":"                        key_size:"},{"line_number":372,"context_line":"                          if:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"efeab575_21d1fc87","line":369,"updated":"2022-03-07 10:45:32.000000000","message":"this doesn\u0027t look a correct replacement? Loopback IPs provide only a fallback if lookup returns no data.","commit_id":"17fadfbe051384b1a3f450f06618dac99a8edf23"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6a03f198a55a5bfc8982598caea797ca6ef18c12","unresolved":true,"context_lines":[{"line_number":366,"context_line":"                              - if:"},{"line_number":367,"context_line":"                                - is_ipv6"},{"line_number":368,"context_line":"                                - \u0027::1\u0027"},{"line_number":369,"context_line":"                                - \u0027127.0.0.1\u0027"},{"line_number":370,"context_line":"                            $MEMCACHED_PORT: {get_param: MemcachedPort}"},{"line_number":371,"context_line":"                        key_size:"},{"line_number":372,"context_line":"                          if:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"19602d4f_9100ec4d","line":369,"in_reply_to":"13e1e0d5_4aedf38c","updated":"2022-03-18 14:09:18.000000000","message":"The value is replaced by Heat while Heat processes templates to create stack resources. Thus missing value should be detected at that time, and there is no way to make this fail during deployment.","commit_id":"17fadfbe051384b1a3f450f06618dac99a8edf23"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"80024360502c7ebf91318ff67523c7ca2d8d4e6e","unresolved":true,"context_lines":[{"line_number":366,"context_line":"                              - if:"},{"line_number":367,"context_line":"                                - is_ipv6"},{"line_number":368,"context_line":"                                - \u0027::1\u0027"},{"line_number":369,"context_line":"                                - \u0027127.0.0.1\u0027"},{"line_number":370,"context_line":"                            $MEMCACHED_PORT: {get_param: MemcachedPort}"},{"line_number":371,"context_line":"                        key_size:"},{"line_number":372,"context_line":"                          if:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"356898d2_8b563f17","line":369,"in_reply_to":"19602d4f_9100ec4d","updated":"2022-04-12 21:32:50.000000000","message":"this doesn\u0027t look right to me either. we need the value here that would have been returned by hiera -c /etc/puppet/hiera.yaml memcached::listen_ip.0, not the fallback value.","commit_id":"17fadfbe051384b1a3f450f06618dac99a8edf23"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d4c571100447fcb8c5f5aec3e2348babcec984be","unresolved":true,"context_lines":[{"line_number":366,"context_line":"                              - if:"},{"line_number":367,"context_line":"                                - is_ipv6"},{"line_number":368,"context_line":"                                - \u0027::1\u0027"},{"line_number":369,"context_line":"                                - \u0027127.0.0.1\u0027"},{"line_number":370,"context_line":"                            $MEMCACHED_PORT: {get_param: MemcachedPort}"},{"line_number":371,"context_line":"                        key_size:"},{"line_number":372,"context_line":"                          if:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b59599f0_2763cc96","line":369,"in_reply_to":"356898d2_8b563f17","updated":"2022-04-18 13:44:39.000000000","message":"memcached::listen_ip.0 is defined at [1] and the logic here I\u0027m implementing is exactly same as that logic.\n\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/832190/1/deployment/memcached/memcached-container-puppet.yaml#207","commit_id":"17fadfbe051384b1a3f450f06618dac99a8edf23"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"57e085fd129df6d75e2388f3f0cf7175c851e9f0","unresolved":true,"context_lines":[{"line_number":366,"context_line":"                              - if:"},{"line_number":367,"context_line":"                                - is_ipv6"},{"line_number":368,"context_line":"                                - \u0027::1\u0027"},{"line_number":369,"context_line":"                                - \u0027127.0.0.1\u0027"},{"line_number":370,"context_line":"                            $MEMCACHED_PORT: {get_param: MemcachedPort}"},{"line_number":371,"context_line":"                        key_size:"},{"line_number":372,"context_line":"                          if:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d8abb2ae_1ff67e16","line":369,"in_reply_to":"727033c1_e226d009","updated":"2022-04-25 11:50:30.000000000","message":"ok, that makes sense. i was thrown off by the fact that this is just always the loopback address. The Heat calculated value for the IP address on MemcachedNetwork is not used here.","commit_id":"17fadfbe051384b1a3f450f06618dac99a8edf23"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"512fbe9e372b110dd4464d7a3a66ad5f80252bf5","unresolved":true,"context_lines":[{"line_number":366,"context_line":"                              - if:"},{"line_number":367,"context_line":"                                - is_ipv6"},{"line_number":368,"context_line":"                                - \u0027::1\u0027"},{"line_number":369,"context_line":"                                - \u0027127.0.0.1\u0027"},{"line_number":370,"context_line":"                            $MEMCACHED_PORT: {get_param: MemcachedPort}"},{"line_number":371,"context_line":"                        key_size:"},{"line_number":372,"context_line":"                          if:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"727033c1_e226d009","line":369,"in_reply_to":"b59599f0_2763cc96","updated":"2022-04-21 19:17:49.000000000","message":"I have no horse in this race, but I agree with Takashi\u0027s reasoning. The \"fallback value\" only makes sense in the context of using the hiera cli tool, but we\u0027re now using heat\u0027s value which is established at L206, and the first (.0) entry is the same loopback address generated for the MEMCACHED_IP at L365.","commit_id":"17fadfbe051384b1a3f450f06618dac99a8edf23"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ee3289289a676acfc4a69b425867d455627a75bc","unresolved":true,"context_lines":[{"line_number":366,"context_line":"                              - if:"},{"line_number":367,"context_line":"                                - is_ipv6"},{"line_number":368,"context_line":"                                - \u0027::1\u0027"},{"line_number":369,"context_line":"                                - \u0027127.0.0.1\u0027"},{"line_number":370,"context_line":"                            $MEMCACHED_PORT: {get_param: MemcachedPort}"},{"line_number":371,"context_line":"                        key_size:"},{"line_number":372,"context_line":"                          if:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"13e1e0d5_4aedf38c","line":369,"in_reply_to":"bf89b59b_b3e0b9f0","updated":"2022-03-18 14:01:56.000000000","message":"then please make deployment failing instead of silently configuring suboptimal memcached config as a failback","commit_id":"17fadfbe051384b1a3f450f06618dac99a8edf23"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"67d99941e53eed7302a44fb315be4cb4d7cba0b3","unresolved":true,"context_lines":[{"line_number":366,"context_line":"                              - if:"},{"line_number":367,"context_line":"                                - is_ipv6"},{"line_number":368,"context_line":"                                - \u0027::1\u0027"},{"line_number":369,"context_line":"                                - \u0027127.0.0.1\u0027"},{"line_number":370,"context_line":"                            $MEMCACHED_PORT: {get_param: MemcachedPort}"},{"line_number":371,"context_line":"                        key_size:"},{"line_number":372,"context_line":"                          if:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf89b59b_b3e0b9f0","line":369,"in_reply_to":"efeab575_21d1fc87","updated":"2022-03-07 10:53:36.000000000","message":"These two puppet parameters(memcached:listen_ip and memcached::tcp_port) are defined in the same template and should be available in the same node. So it should not happen that these keys are not found in hieradata, so these default fallback is a kind of meaningless..","commit_id":"17fadfbe051384b1a3f450f06618dac99a8edf23"}]}