)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1a489cd745b355f01b0c1cb7a759540995ce3aa7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"325b085d_73a9b2e9","updated":"2022-04-08 07:49:52.000000000","message":"I know it\u0027s too late but let me leave some feedback which I found when checking wallaby backport.","commit_id":"875155550959d112acc37f74d88a674fca640167"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"dbf52bf1cde9a29b5ebe5304fd9377ee86b1edb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6347a308_b6d58681","updated":"2022-03-10 19:00:37.000000000","message":"removed +2 due to the review being in WIP status.","commit_id":"875155550959d112acc37f74d88a674fca640167"}],"deployment/octavia/octavia-api-container-puppet.yaml":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"c02b5383069e41ccd18214a8545766f6e585bb35","unresolved":true,"context_lines":[{"line_number":99,"context_line":"    type: string  # comma separated list"},{"line_number":100,"context_line":"    default: \u0027\u0027"},{"line_number":101,"context_line":"  OctaviaListenerTlsVersions:"},{"line_number":102,"context_line":"    type: string"},{"line_number":103,"context_line":"    default: \u0027TLSv1.2, TLSv1.3\u0027"},{"line_number":104,"context_line":"  OctaviaPoolTlsVersions:"},{"line_number":105,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"20b02d2d_6f707d55","line":102,"range":{"start_line":102,"start_character":10,"end_line":102,"end_character":16},"updated":"2022-03-07 14:56:28.000000000","message":"you can use the \"comma_delimited_list\" type\nit means that the default could be [\"TLSv1.2\", \"TLSv1.3\"]","commit_id":"37860147eb8d93aef97483b02ceb4d9efa5d128a"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"780df3df34cd87ff59bd19fbec2c0db83572aa8e","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    type: string  # comma separated list"},{"line_number":100,"context_line":"    default: \u0027\u0027"},{"line_number":101,"context_line":"  OctaviaListenerTlsVersions:"},{"line_number":102,"context_line":"    type: string"},{"line_number":103,"context_line":"    default: \u0027TLSv1.2, TLSv1.3\u0027"},{"line_number":104,"context_line":"  OctaviaPoolTlsVersions:"},{"line_number":105,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e8a048b1_1e9aecec","line":102,"range":{"start_line":102,"start_character":10,"end_line":102,"end_character":16},"in_reply_to":"20b02d2d_6f707d55","updated":"2022-03-07 16:07:46.000000000","message":"Thanks.","commit_id":"37860147eb8d93aef97483b02ceb4d9efa5d128a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1a489cd745b355f01b0c1cb7a759540995ce3aa7","unresolved":true,"context_lines":[{"line_number":90,"context_line":"    description: Number of workers for Octavia service."},{"line_number":91,"context_line":"    type: number"},{"line_number":92,"context_line":"  OctaviaDefaultListenerCiphers:"},{"line_number":93,"context_line":"    type: string"},{"line_number":94,"context_line":"    default: \u0027TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256:TLS_AES_128_GCM_SHA256:DHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-SHA256:DHE-RSA-AES128-SHA256:ECDHE-RSA-AES256-SHA384:ECDHE-RSA-AES128-SHA256\u0027"},{"line_number":95,"context_line":"  OctaviaDefaultPoolCiphers:"},{"line_number":96,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"2f4e9214_99c5f0f0","line":93,"range":{"start_line":93,"start_character":10,"end_line":93,"end_character":16},"updated":"2022-04-08 07:49:52.000000000","message":"you can use commma_delimited_list here. puppet-octavia automatically joins array items by : when rendering the value into octavia.conf.","commit_id":"875155550959d112acc37f74d88a674fca640167"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6c5b08946156c5534d9ff23fb99bf60dc12769cb","unresolved":true,"context_lines":[{"line_number":90,"context_line":"    description: Number of workers for Octavia service."},{"line_number":91,"context_line":"    type: number"},{"line_number":92,"context_line":"  OctaviaDefaultListenerCiphers:"},{"line_number":93,"context_line":"    type: string"},{"line_number":94,"context_line":"    default: \u0027TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256:TLS_AES_128_GCM_SHA256:DHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-SHA256:DHE-RSA-AES128-SHA256:ECDHE-RSA-AES256-SHA384:ECDHE-RSA-AES128-SHA256\u0027"},{"line_number":95,"context_line":"  OctaviaDefaultPoolCiphers:"},{"line_number":96,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7029b4f1_dde2af3f","line":93,"range":{"start_line":93,"start_character":10,"end_line":93,"end_character":16},"in_reply_to":"147b538c_9086b032","updated":"2022-04-08 08:49:52.000000000","message":"For further reference: https://github.com/openstack/puppet-octavia/blob/a3be80d1fb55b5be9d90a7e1814c345246b9ae64/manifests/api.pp#L221","commit_id":"875155550959d112acc37f74d88a674fca640167"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"7cfbfe1ca774357555907bd19d9c01d286ca63a2","unresolved":true,"context_lines":[{"line_number":90,"context_line":"    description: Number of workers for Octavia service."},{"line_number":91,"context_line":"    type: number"},{"line_number":92,"context_line":"  OctaviaDefaultListenerCiphers:"},{"line_number":93,"context_line":"    type: string"},{"line_number":94,"context_line":"    default: \u0027TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256:TLS_AES_128_GCM_SHA256:DHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-SHA256:DHE-RSA-AES128-SHA256:ECDHE-RSA-AES256-SHA384:ECDHE-RSA-AES128-SHA256\u0027"},{"line_number":95,"context_line":"  OctaviaDefaultPoolCiphers:"},{"line_number":96,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"147b538c_9086b032","line":93,"range":{"start_line":93,"start_character":10,"end_line":93,"end_character":16},"in_reply_to":"2f4e9214_99c5f0f0","updated":"2022-04-08 08:10:44.000000000","message":"Thanks, I didn\u0027t know that.","commit_id":"875155550959d112acc37f74d88a674fca640167"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1a489cd745b355f01b0c1cb7a759540995ce3aa7","unresolved":true,"context_lines":[{"line_number":93,"context_line":"    type: string"},{"line_number":94,"context_line":"    default: \u0027TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256:TLS_AES_128_GCM_SHA256:DHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-SHA256:DHE-RSA-AES128-SHA256:ECDHE-RSA-AES256-SHA384:ECDHE-RSA-AES128-SHA256\u0027"},{"line_number":95,"context_line":"  OctaviaDefaultPoolCiphers:"},{"line_number":96,"context_line":"    type: string"},{"line_number":97,"context_line":"    default: \u0027TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256:TLS_AES_128_GCM_SHA256:DHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-SHA256:DHE-RSA-AES128-SHA256:ECDHE-RSA-AES256-SHA384:ECDHE-RSA-AES128-SHA256\u0027"},{"line_number":98,"context_line":"  OctaviaTlsCiphersProhibitList:"},{"line_number":99,"context_line":"    type: string  # colon separated list"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"d3b57813_4b7fa716","line":96,"range":{"start_line":96,"start_character":10,"end_line":96,"end_character":16},"updated":"2022-04-08 07:49:52.000000000","message":"ditto","commit_id":"875155550959d112acc37f74d88a674fca640167"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1a489cd745b355f01b0c1cb7a759540995ce3aa7","unresolved":true,"context_lines":[{"line_number":96,"context_line":"    type: string"},{"line_number":97,"context_line":"    default: \u0027TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256:TLS_AES_128_GCM_SHA256:DHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-SHA256:DHE-RSA-AES128-SHA256:ECDHE-RSA-AES256-SHA384:ECDHE-RSA-AES128-SHA256\u0027"},{"line_number":98,"context_line":"  OctaviaTlsCiphersProhibitList:"},{"line_number":99,"context_line":"    type: string  # colon separated list"},{"line_number":100,"context_line":"    default: \u0027\u0027"},{"line_number":101,"context_line":"  OctaviaListenerTlsVersions:"},{"line_number":102,"context_line":"    type: comma_delimited_list"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"030977fc_c39dbc83","line":99,"range":{"start_line":99,"start_character":10,"end_line":99,"end_character":16},"updated":"2022-04-08 07:49:52.000000000","message":"ditto","commit_id":"875155550959d112acc37f74d88a674fca640167"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"4521a68509111e43a5d7ad1ddb23eaa3f265a4ea","unresolved":true,"context_lines":[{"line_number":253,"context_line":"          - if:"},{"line_number":254,"context_line":"              - octavia_workers_set"},{"line_number":255,"context_line":"              - octavia::wsgi::apache::workers: {get_param: OctaviaWorkers}"},{"line_number":256,"context_line":"          - if:"},{"line_number":257,"context_line":"              - octavia_min_tls_version"},{"line_number":258,"context_line":"              - octavia::api::minimum_tls_version: {get_param: OctaviaMinimumTlsVersion}"},{"line_number":259,"context_line":"      service_config_settings:"},{"line_number":260,"context_line":"        rsyslog:"},{"line_number":261,"context_line":"          tripleo_logging_sources_octavia_api:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"99d9a362_c76294ac","line":258,"range":{"start_line":256,"start_character":1,"end_line":258,"end_character":88},"updated":"2022-03-21 11:45:51.000000000","message":"Could also avoid merging so many maps.","commit_id":"875155550959d112acc37f74d88a674fca640167"}]}