)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"1d91aa9f4f9a6faf5d3c8e9c292ebee779df761b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b97dc9cb_771bf157","updated":"2022-03-15 13:25:26.000000000","message":"This\u0027s the initial draft of firstboot yaml file,\nPlease review it, and I\u0027m going to run a full deployment with it to make sure everything is OK","commit_id":"e2aa12ddae4081f740b9200cde1bacaea5f0a24c"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"9a523161753034d4fc57184bfe91592bf165eb8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2754f9c1_7ff6e94e","updated":"2022-03-21 11:56:30.000000000","message":"Is this for backport to some old release? These firstboot configurations can\u0027t be used since wallaby with novaless node provisioning. Instead you should be using config-drive[1].\n\n[1] https://docs.openstack.org/project-deploy-guide/tripleo-docs/latest/provisioning/baremetal_provision.html#config-drive\n\n","commit_id":"511e306d28728d89bf4fb6518a7d43a567f1f254"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"f6dce57fb93c9b8a4cf8698e548725dfb524dea9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"47c745fa_41fc5164","in_reply_to":"2754f9c1_7ff6e94e","updated":"2022-03-21 12:24:23.000000000","message":"It\u0027s going to be backported to queens for rhel-osp 6.2","commit_id":"511e306d28728d89bf4fb6518a7d43a567f1f254"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"5c10d980b31a17a26dec0e5cfc29653bc90eb398","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"993a3fa1_4e730bcd","updated":"2022-03-24 03:15:45.000000000","message":"I don\u0027t think this will work with any version of TripleO using Ephemeral Heat, since Heat isn\u0027t used to provision the nodes and thus can\u0027t provide userdata.\n\nSo, if the intention is to include this in anything \u003e W, then I don\u0027t believe this is the right approach:\nhttps://specs.openstack.org/openstack/tripleo-specs/specs/wallaby/ephemeral-heat-overcloud.html\n\nRefer to the link mentioned by tkajinam for how to use userdata in version \u003e W using the new node provision process.","commit_id":"f78ba117a88f50f6f20aa621014b6375a3bbc49c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"90cc9818d8c5b95cd5683e023011a04ed4d21f2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cdea0651_21b1f4a1","updated":"2022-03-24 03:12:44.000000000","message":"Note that NodeUserData no longer works in master and wallaby, since heat and nova are no longer involved in baremetal node provisioning.\nIf you intend to make this work in these branches they this should be re-implemented by a new method.\n https://docs.openstack.org/project-deploy-guide/tripleo-docs/latest/provisioning/baremetal_provision.html#config-drive","commit_id":"f78ba117a88f50f6f20aa621014b6375a3bbc49c"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"94234101fd593ea99d4dacef64e1b705496a288d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"efa88518_0b7bf48d","updated":"2022-03-24 03:34:30.000000000","message":"We already discussed about it not being relevant from wallaby+ in patchset2 (check earlier comments). Let\u0027s merge this and leave it for them to work out the approach for master/wallaby later.","commit_id":"f78ba117a88f50f6f20aa621014b6375a3bbc49c"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"4a8e87ef1c20b556b171b754e8934068fe02275d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a34e7d4e_af8317db","updated":"2022-03-23 12:38:38.000000000","message":"recheck","commit_id":"f78ba117a88f50f6f20aa621014b6375a3bbc49c"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"1c716d699e5b6604af40080f2ce89ba4612b3b49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"05445340_a620aa8e","in_reply_to":"cdea0651_21b1f4a1","updated":"2022-03-24 03:18:16.000000000","message":"Assuming this is something that need to happen before applying network configuration with os-net-config an alternative to config-drive is to use the playbook interface. See kernel args example.\n\nhttps://docs.openstack.org/project-deploy-guide/tripleo-docs/latest/provisioning/baremetal_provision.html#set-kernel-arguments-playbook","commit_id":"f78ba117a88f50f6f20aa621014b6375a3bbc49c"}],"firstboot/nvidia_firstboot.yaml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"0ad4c4b4ed93cb4017ae7061fe15be681636df05","unresolved":true,"context_lines":[{"line_number":20,"context_line":"                 If the value is empty, all MLNX devices will be processed."},{"line_number":21,"context_line":"                 Example, [\u00270000:04:00.0\u0027, \u00270000:81:00.0\u0027]"},{"line_number":22,"context_line":"                 Make sure to choose only the PCI ends with 0"},{"line_number":23,"context_line":"  NUM_OF_VFS:"},{"line_number":24,"context_line":"    type: number"},{"line_number":25,"context_line":"    default: 32"},{"line_number":26,"context_line":"    description: \u0027Max number of vfs\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c2894b94_f8ae9a0d","line":23,"updated":"2022-03-17 05:15:23.000000000","message":"Why is the VF need to be configured as part of the first-boot? I was under the understanding that first-boot will only do the mode change and rest of the configuration will be done by os-net-config. Looks like we are doing more than just the mode change.","commit_id":"e2aa12ddae4081f740b9200cde1bacaea5f0a24c"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"69db3584f74e8fd74e308adb291ff1c15c56531c","unresolved":true,"context_lines":[{"line_number":20,"context_line":"                 If the value is empty, all MLNX devices will be processed."},{"line_number":21,"context_line":"                 Example, [\u00270000:04:00.0\u0027, \u00270000:81:00.0\u0027]"},{"line_number":22,"context_line":"                 Make sure to choose only the PCI ends with 0"},{"line_number":23,"context_line":"  NUM_OF_VFS:"},{"line_number":24,"context_line":"    type: number"},{"line_number":25,"context_line":"    default: 32"},{"line_number":26,"context_line":"    description: \u0027Max number of vfs\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b6baa308_78dfb252","line":23,"in_reply_to":"c2894b94_f8ae9a0d","updated":"2022-03-20 12:44:52.000000000","message":"The first boot script is for updating the FW and setting the FW config. It here sets the max allowed num of vfs in FW and not the actual number of vfs,","commit_id":"e2aa12ddae4081f740b9200cde1bacaea5f0a24c"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"e2f1150159402eab562d083665629c216351ab3a","unresolved":true,"context_lines":[{"line_number":58,"context_line":"      value as below for index 2 to be 17 and index 3 to be 16"},{"line_number":59,"context_line":"      Example, {\"2\": \"17\", \"3\": \"16\"}"},{"line_number":60,"context_line":"      Make sure to choose only the PCI ends with 0"},{"line_number":61,"context_line":"  BF_SMODE:"},{"line_number":62,"context_line":"    type: boolean"},{"line_number":63,"context_line":"    default: True"},{"line_number":64,"context_line":"    description: \u003e"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"970d47cb_5eb7b4e0","line":61,"range":{"start_line":61,"start_character":2,"end_line":61,"end_character":10},"updated":"2022-03-15 15:04:34.000000000","message":"Myabe BF_NIC_MODE?","commit_id":"e2aa12ddae4081f740b9200cde1bacaea5f0a24c"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"69db3584f74e8fd74e308adb291ff1c15c56531c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      value as below for index 2 to be 17 and index 3 to be 16"},{"line_number":59,"context_line":"      Example, {\"2\": \"17\", \"3\": \"16\"}"},{"line_number":60,"context_line":"      Make sure to choose only the PCI ends with 0"},{"line_number":61,"context_line":"  BF_SMODE:"},{"line_number":62,"context_line":"    type: boolean"},{"line_number":63,"context_line":"    default: True"},{"line_number":64,"context_line":"    description: \u003e"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5716165a_eb83c881","line":61,"range":{"start_line":61,"start_character":2,"end_line":61,"end_character":10},"in_reply_to":"970d47cb_5eb7b4e0","updated":"2022-03-20 12:44:52.000000000","message":"Done","commit_id":"e2aa12ddae4081f740b9200cde1bacaea5f0a24c"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"e2f1150159402eab562d083665629c216351ab3a","unresolved":true,"context_lines":[{"line_number":81,"context_line":"    description: \u003e"},{"line_number":82,"context_line":"      Run mstfwreset with the specified reset-sync [0,1],"},{"line_number":83,"context_line":"      The default and Current supported option now is 0"},{"line_number":84,"context_line":"      "},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"resources:"},{"line_number":87,"context_line":"  userdata:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"22fc907d_3edb2296","line":84,"updated":"2022-03-15 15:04:34.000000000","message":"whitespace","commit_id":"e2aa12ddae4081f740b9200cde1bacaea5f0a24c"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"69db3584f74e8fd74e308adb291ff1c15c56531c","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    description: \u003e"},{"line_number":82,"context_line":"      Run mstfwreset with the specified reset-sync [0,1],"},{"line_number":83,"context_line":"      The default and Current supported option now is 0"},{"line_number":84,"context_line":"      "},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"resources:"},{"line_number":87,"context_line":"  userdata:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"38fc4db8_abb95f62","line":84,"in_reply_to":"22fc907d_3edb2296","updated":"2022-03-20 12:44:52.000000000","message":"Done","commit_id":"e2aa12ddae4081f740b9200cde1bacaea5f0a24c"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"e2f1150159402eab562d083665629c216351ab3a","unresolved":true,"context_lines":[{"line_number":139,"context_line":"                \"ESWITCH_HAIRPIN_TOT_BUFFER_SIZE\": $ESWITCH_HAIRPIN_TOT_BUFFER_SIZE,"},{"line_number":140,"context_line":"                \"ESWITCH_HAIRPIN_DESCRIPTORS\": $ESWITCH_HAIRPIN_DESCRIPTORS"},{"line_number":141,"context_line":"            }"},{"line_number":142,"context_line":"            if \"$BF_SMODE\".lower() \u003d\u003d \"true\":"},{"line_number":143,"context_line":"                # It means we are in smart nic mode for BF"},{"line_number":144,"context_line":"                _MLX_CONFIG[\"INTERNAL_CPU_PAGE_SUPPLIER\"] \u003d \"ECPF\""},{"line_number":145,"context_line":"                _MLX_CONFIG[\"INTERNAL_CPU_ESWITCH_MANAGER\"] \u003d \"ECPF\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2fe70cc3_12082f97","line":142,"updated":"2022-03-15 15:04:34.000000000","message":"do you check the device id is BF? Do you check if ethernet only","commit_id":"e2aa12ddae4081f740b9200cde1bacaea5f0a24c"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"69db3584f74e8fd74e308adb291ff1c15c56531c","unresolved":true,"context_lines":[{"line_number":139,"context_line":"                \"ESWITCH_HAIRPIN_TOT_BUFFER_SIZE\": $ESWITCH_HAIRPIN_TOT_BUFFER_SIZE,"},{"line_number":140,"context_line":"                \"ESWITCH_HAIRPIN_DESCRIPTORS\": $ESWITCH_HAIRPIN_DESCRIPTORS"},{"line_number":141,"context_line":"            }"},{"line_number":142,"context_line":"            if \"$BF_SMODE\".lower() \u003d\u003d \"true\":"},{"line_number":143,"context_line":"                # It means we are in smart nic mode for BF"},{"line_number":144,"context_line":"                _MLX_CONFIG[\"INTERNAL_CPU_PAGE_SUPPLIER\"] \u003d \"ECPF\""},{"line_number":145,"context_line":"                _MLX_CONFIG[\"INTERNAL_CPU_ESWITCH_MANAGER\"] \u003d \"ECPF\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"62370ea6_987b0d4d","line":142,"in_reply_to":"2fe70cc3_12082f97","updated":"2022-03-20 12:44:52.000000000","message":"Those parameters are only set later on if they are exist in the config of the device.\nI don\u0027t think there is need to check the link type. The default link type is ethernet","commit_id":"e2aa12ddae4081f740b9200cde1bacaea5f0a24c"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"e9fef0ec295ceeec4f4c81608e1b7e95fa64b08e","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                \"ESWITCH_HAIRPIN_TOT_BUFFER_SIZE\": $ESWITCH_HAIRPIN_TOT_BUFFER_SIZE,"},{"line_number":140,"context_line":"                \"ESWITCH_HAIRPIN_DESCRIPTORS\": $ESWITCH_HAIRPIN_DESCRIPTORS"},{"line_number":141,"context_line":"            }"},{"line_number":142,"context_line":"            if \"$BF_SMODE\".lower() \u003d\u003d \"true\":"},{"line_number":143,"context_line":"                # It means we are in smart nic mode for BF"},{"line_number":144,"context_line":"                _MLX_CONFIG[\"INTERNAL_CPU_PAGE_SUPPLIER\"] \u003d \"ECPF\""},{"line_number":145,"context_line":"                _MLX_CONFIG[\"INTERNAL_CPU_ESWITCH_MANAGER\"] \u003d \"ECPF\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"908a270d_9b791296","line":142,"in_reply_to":"62370ea6_987b0d4d","updated":"2022-03-21 08:33:17.000000000","message":"Sorry connectx mode exist also for IB","commit_id":"e2aa12ddae4081f740b9200cde1bacaea5f0a24c"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"737946a38afbca0d099e56f6443c5f3a7e2b1d29","unresolved":true,"context_lines":[{"line_number":94,"context_line":"    properties:"},{"line_number":95,"context_line":"      config:"},{"line_number":96,"context_line":"        str_replace:"},{"line_number":97,"context_line":"          template: |"},{"line_number":98,"context_line":"            #!/usr/bin/env python"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"            import logging"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5d933688_47bcca4b","line":97,"updated":"2022-03-21 14:50:01.000000000","message":"Is it possible to have this script elsewhere? I kinda hate that it is being stored directly in THT. Maybe this template should be delivered via tripleo-ansible in a role which could be reused?","commit_id":"511e306d28728d89bf4fb6518a7d43a567f1f254"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"37ad33f9142ace9c99ac379622cbdf4afc40d06c","unresolved":true,"context_lines":[{"line_number":94,"context_line":"    properties:"},{"line_number":95,"context_line":"      config:"},{"line_number":96,"context_line":"        str_replace:"},{"line_number":97,"context_line":"          template: |"},{"line_number":98,"context_line":"            #!/usr/bin/env python"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"            import logging"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d97a1f1f_569b39eb","line":97,"in_reply_to":"5d933688_47bcca4b","updated":"2022-03-22 05:40:18.000000000","message":"tripleo-ansible is not a viable option as the understanding is that tripleo-ansible scripts are used for deploying overcloud from undercloud. first-boot scripts are pushed as part of the nova user data while provisioning. I would recommend having this as it is (well tested with train) so that it can be backported, then work on the wallaby version, as suggested by Rabi by using config drive (OR) another alternative is to create cli-playbook (with ansible role) so that it can be added to baremetal_deployment template as part of the node provision.","commit_id":"511e306d28728d89bf4fb6518a7d43a567f1f254"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"d64e412a4d02033b2e7d270966b543eda78cb166","unresolved":true,"context_lines":[{"line_number":94,"context_line":"    properties:"},{"line_number":95,"context_line":"      config:"},{"line_number":96,"context_line":"        str_replace:"},{"line_number":97,"context_line":"          template: |"},{"line_number":98,"context_line":"            #!/usr/bin/env python"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"            import logging"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1c4cad64_624d67b4","line":97,"in_reply_to":"d97a1f1f_569b39eb","updated":"2022-03-23 08:14:52.000000000","message":"Yeah I agree with Saravanan, I\u0027ll do a follow-up patch for configuring it using config drive or a cli-playbook","commit_id":"511e306d28728d89bf4fb6518a7d43a567f1f254"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"737946a38afbca0d099e56f6443c5f3a7e2b1d29","unresolved":true,"context_lines":[{"line_number":577,"context_line":"                    \"\"\" Check if device requires firmware reset before applying any"},{"line_number":578,"context_line":"                    configurations on the device."},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"                    :return: (bool, bool) True if reset is needed, "},{"line_number":581,"context_line":"                                          True if skip_fms_sync is needed"},{"line_number":582,"context_line":"                    \"\"\""},{"line_number":583,"context_line":"                    self.query_device(force\u003dTrue)"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"07df6d0b_1d079a56","line":580,"range":{"start_line":580,"start_character":66,"end_line":580,"end_character":67},"updated":"2022-03-21 14:50:01.000000000","message":"extra space.","commit_id":"511e306d28728d89bf4fb6518a7d43a567f1f254"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"d64e412a4d02033b2e7d270966b543eda78cb166","unresolved":false,"context_lines":[{"line_number":577,"context_line":"                    \"\"\" Check if device requires firmware reset before applying any"},{"line_number":578,"context_line":"                    configurations on the device."},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"                    :return: (bool, bool) True if reset is needed, "},{"line_number":581,"context_line":"                                          True if skip_fms_sync is needed"},{"line_number":582,"context_line":"                    \"\"\""},{"line_number":583,"context_line":"                    self.query_device(force\u003dTrue)"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a0a77be0_107f05af","line":580,"range":{"start_line":580,"start_character":66,"end_line":580,"end_character":67},"in_reply_to":"07df6d0b_1d079a56","updated":"2022-03-23 08:14:52.000000000","message":"Done","commit_id":"511e306d28728d89bf4fb6518a7d43a567f1f254"}]}