)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d2db15d542aaa04b497a76d96bb090f47f120c0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2899474e_6783e066","updated":"2022-03-18 14:48:50.000000000","message":"recheck","commit_id":"f0becf06adaec62b0ac9e1ae317c357cf72c4dc6"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"85f8fcf31b135e3660a436147128e7cbe0ffd021","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6db77b6d_a9be1af7","updated":"2022-03-18 12:30:31.000000000","message":"recheck","commit_id":"f0becf06adaec62b0ac9e1ae317c357cf72c4dc6"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bd1959c05020049fc95a2ed0e2c92a91d39f1aea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"de2cef97_01d6161c","updated":"2022-03-22 15:14:25.000000000","message":"In the job log https://be0016b376733497e69d-4c8f4b6e3b038cf39327e185ac433084.ssl.cf2.rackcdn.com/834275/2/check/tripleo-ci-centos-9-scenario001-standalone/d31ebf8/job-output.txt I can see hiera settings applied as expected, but no config changes done by puppet. Did https://cb49211289fea625eb85-6d8b7cde59daae87cebda88f7b508422.ssl.cf2.rackcdn.com/834275/2/check/tripleo-ci-centos-9-content-provider/2e4fde1/job-output.txt silently fail oslo.log build?","commit_id":"703ea4e29c294eae48eb4da9f5162c3c6196b663"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"2733e8a83616543c2077255b9d1a07981b959e48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5451ca55_95abf71a","in_reply_to":"b6b0acc4_c6a450df","updated":"2022-03-24 10:04:30.000000000","message":"I am taking a look at the content provider and found that in tripleoclient container gating repo is used and packages are installed there:\nhttps://cb49211289fea625eb85-6d8b7cde59daae87cebda88f7b508422.ssl.cf2.rackcdn.com/834275/2/check/tripleo-ci-centos-9-content-provider/2e4fde1/logs/undercloud/home/zuul/workspace/logs/container-builds/7224329c-9de7-4f7f-ab9c-a549de920afc/base/tripleoclient/tripleoclient-build.log\n\n```\n puppet-oslo                            noarch  20.3.0-0.20220322100948.b20e12f.el9   gating-repo                     49 k\n\n```\nOn patchset 2 only puppet-oslo review was used as a depends-on, So it is built by DLRN and installed during the container-build process.","commit_id":"703ea4e29c294eae48eb4da9f5162c3c6196b663"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"6385d03b7a9eada46479be7c342dc410f24f7ac2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b6b0acc4_c6a450df","in_reply_to":"de2cef97_01d6161c","updated":"2022-03-22 15:18:55.000000000","message":"Meant to say this log: https://be0016b376733497e69d-4c8f4b6e3b038cf39327e185ac433084.ssl.cf2.rackcdn.com/834275/2/check/tripleo-ci-centos-9-scenario001-standalone/d31ebf8/logs/undercloud/etc/puppet/hieradata/role_extraconfig.json : contains \"oslo::log::log_global_request_id\": true\n\nbut not in the configs as it would have to be generated with the dependency puppet-oslo change in place","commit_id":"703ea4e29c294eae48eb4da9f5162c3c6196b663"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"302c46c36d9d24b4a11dd14becbef11b4c8ae5d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6c180ada_8d9add69","updated":"2022-03-29 08:01:58.000000000","message":"recheck","commit_id":"ebfd0020f21a169d850dd0510825955f84f3bd75"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f12bef3862ba41829d1787ef9da9b2d9155d5583","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ec26e976_c122c81d","updated":"2022-03-30 08:42:07.000000000","message":"recheck","commit_id":"ebfd0020f21a169d850dd0510825955f84f3bd75"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d90e9b07f0c56c0871451546114a7621d76b4142","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"419d682b_1cb6bc64","updated":"2022-04-08 14:33:05.000000000","message":"recheck","commit_id":"1c73674603a56b9a9c7968c1e395c9fab0a73ffa"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"6d63c0887737625148207f6a9713b77363d3eadb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8214670a_02f18b23","updated":"2022-04-08 14:46:45.000000000","message":"recheck","commit_id":"1c73674603a56b9a9c7968c1e395c9fab0a73ffa"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"cf2ab3aa5db4bf683724b2157980ea22cef933f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3928e3d0_829acdb1","updated":"2022-04-15 08:57:25.000000000","message":"recheck","commit_id":"ddd434aeef6d0dd4cffc35843b70ebc17d97ea9a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a0ad0151cd7c745abf0b7a30f29eb33995855a3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8f0e38b2_794ef07b","updated":"2022-04-15 09:57:21.000000000","message":"recheck","commit_id":"ddd434aeef6d0dd4cffc35843b70ebc17d97ea9a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"07cd5dd950cbc95bf2695430edf01442d6d4245c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b124731b_73499e87","updated":"2022-04-15 13:41:45.000000000","message":"recheck","commit_id":"ddd434aeef6d0dd4cffc35843b70ebc17d97ea9a"}],"ci/environments/multinode-containers.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f54ffcd7e70de8c95847785ba833c81d3f28f3a8","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    - OS::TripleO::Services::Clustercheck"},{"line_number":45,"context_line":"    - OS::TripleO::Services::NovaManager"},{"line_number":46,"context_line":"  ControllerExtraConfig:"},{"line_number":47,"context_line":"    oslo::log::log_global_request_id: true"},{"line_number":48,"context_line":"    nova::compute::libvirt::services::libvirt_virt_type: qemu"},{"line_number":49,"context_line":"    nova::compute::libvirt::virt_type: qemu"},{"line_number":50,"context_line":"  Debug: True"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"36c65742_de73e348","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":42},"updated":"2022-03-22 16:05:01.000000000","message":"Unfortunately current puppet doesn\u0027t allow this usage.\n\noslo::log is not a class but a resource type. All parameters passed to the resource type should be defined in a class which declares a resource using the resource type. So we should use parameters of each *::log classes (eg nova::logging, cinder::logging), or we need to implement a logic in puppet-tripleo which picks up this hieradata key and pass the value to the corresponding class parameters of *::logging class.","commit_id":"f84b91c7671d8353ff8d64ece30825bcb50fd91c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e51df547fb6d9c8506090988faca03690af167bd","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    - OS::TripleO::Services::Clustercheck"},{"line_number":45,"context_line":"    - OS::TripleO::Services::NovaManager"},{"line_number":46,"context_line":"  ControllerExtraConfig:"},{"line_number":47,"context_line":"    oslo::log::log_global_request_id: true"},{"line_number":48,"context_line":"    nova::compute::libvirt::services::libvirt_virt_type: qemu"},{"line_number":49,"context_line":"    nova::compute::libvirt::virt_type: qemu"},{"line_number":50,"context_line":"  Debug: True"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9dba6219_e44741bd","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":42},"in_reply_to":"1ba69353_99775510","updated":"2022-03-23 07:46:45.000000000","message":"Thank you Takashi-san, I\u0027ve totally missed (again!) that that\u0027s a definition, not a class.","commit_id":"f84b91c7671d8353ff8d64ece30825bcb50fd91c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"96be27588ac2a33545f18ef1775b7f68a1b265b4","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    - OS::TripleO::Services::Clustercheck"},{"line_number":45,"context_line":"    - OS::TripleO::Services::NovaManager"},{"line_number":46,"context_line":"  ControllerExtraConfig:"},{"line_number":47,"context_line":"    oslo::log::log_global_request_id: true"},{"line_number":48,"context_line":"    nova::compute::libvirt::services::libvirt_virt_type: qemu"},{"line_number":49,"context_line":"    nova::compute::libvirt::virt_type: qemu"},{"line_number":50,"context_line":"  Debug: True"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1ba69353_99775510","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":42},"in_reply_to":"36c65742_de73e348","updated":"2022-03-22 16:10:24.000000000","message":"The required steps here are;\n\n* Add a new parameter in oslo.log\n* Update oslo::log to support the new parameter\n* Update the *::logging class in individual modules to expose the new parameter and set the parameter of oslo::log resource type.\n\nThen\n\n* Add puppet parameters for individual modules here\n\nor \n\n* Implement a logic to pick up common hieradata key and set *::logging::log_global_request_id\n* Use that specifial hieradata key in tht\n\nthough honestly I don\u0027t recommend the second approach, to avoid implementing more logic in puppet manifest considering less people and less interest to maintain it.","commit_id":"f84b91c7671d8353ff8d64ece30825bcb50fd91c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e1c2242676b3a7a4e2bda1ce6d9b5ad739ca80a8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    - OS::TripleO::Services::Clustercheck"},{"line_number":45,"context_line":"    - OS::TripleO::Services::NovaManager"},{"line_number":46,"context_line":"  ControllerExtraConfig:"},{"line_number":47,"context_line":"    oslo::log::log_global_request_id: true"},{"line_number":48,"context_line":"    nova::compute::libvirt::services::libvirt_virt_type: qemu"},{"line_number":49,"context_line":"    nova::compute::libvirt::virt_type: qemu"},{"line_number":50,"context_line":"  Debug: True"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"91013202_ad870c24","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":42},"in_reply_to":"9dba6219_e44741bd","updated":"2022-03-30 09:04:40.000000000","message":"Done","commit_id":"f84b91c7671d8353ff8d64ece30825bcb50fd91c"}]}