)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"40d75ac68e6a98f342984729b87d26775294dc94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"946c0e8f_b97064aa","updated":"2022-05-18 17:09:05.000000000","message":"There\u0027s a pep8 error that needs to be addressed, and a merge conflict with mkatari\u0027s [1] if that patch merges first.\n\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/839358\n\nManoj has been helping in this area, and might be willing to help fix up this patch.","commit_id":"6b161ad65e056e82fab77c232e939211d10bd0c2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"71b48be6a0a21b160656c4d86e9b1e7fd226b74f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"414e8e45_612b5465","updated":"2022-07-30 09:40:39.000000000","message":"Adding +A because this change already has 2 +2s.","commit_id":"6a55550a866560553ceabe6c4e86e3409293feb9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"38d12c4d594f99e587a7cacebe453580c2f09f59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"68ca4d24_66dd66ad","updated":"2022-05-24 13:09:09.000000000","message":"I\u0027d hesitate to update the patch after nice update by Manoj but was hoping to fix the typo before getting this merged ...","commit_id":"6a55550a866560553ceabe6c4e86e3409293feb9"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"870e542abafc8fda8eb260166654c7d1020a90bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9bc3a748_e97635fc","updated":"2022-05-24 13:18:56.000000000","message":"The typo fixed in patchset 7 should affect CI.","commit_id":"6a55550a866560553ceabe6c4e86e3409293feb9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c88ffc871613f52718b4d8f809030a568e7ed26e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"10dd750c_53e16c9e","updated":"2022-07-30 06:17:33.000000000","message":"recheck\n\nto get the fresh CI result","commit_id":"6a55550a866560553ceabe6c4e86e3409293feb9"}],"deployment/cinder/cinder-backend-netapp-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"af046abfc095fb698629b11ba3d4e11d5fb5c26d","unresolved":true,"context_lines":[{"line_number":126,"context_line":"  parameters:"},{"line_number":127,"context_line":"  - CinderNetappVfiler"},{"line_number":128,"context_line":"  - CinderNetappPartnerBackendName"},{"line_number":129,"context_line":"  - CinderNetappControllerIPs"},{"line_number":130,"context_line":"  - CinderNetappSaPassword"},{"line_number":131,"context_line":"  - CinderNetappWebservicePath"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"29c6f96f_54f56dc8","line":129,"range":{"start_line":129,"start_character":4,"end_line":129,"end_character":29},"updated":"2022-05-23 15:45:54.000000000","message":"typo: CinderNetappControllerIps","commit_id":"bca95e76b1c69431759f449609eb6489c00b4683"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"38d12c4d594f99e587a7cacebe453580c2f09f59","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  parameters:"},{"line_number":127,"context_line":"  - CinderNetappVfiler"},{"line_number":128,"context_line":"  - CinderNetappPartnerBackendName"},{"line_number":129,"context_line":"  - CinderNetappControllerIPs"},{"line_number":130,"context_line":"  - CinderNetappSaPassword"},{"line_number":131,"context_line":"  - CinderNetappWebservicePath"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fae6c42f_6d27a4c0","line":129,"range":{"start_line":129,"start_character":4,"end_line":129,"end_character":29},"in_reply_to":"29c6f96f_54f56dc8","updated":"2022-05-24 13:09:09.000000000","message":"Done","commit_id":"bca95e76b1c69431759f449609eb6489c00b4683"}],"environments/storage/cinder-netapp-config.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"af046abfc095fb698629b11ba3d4e11d5fb5c26d","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  # "},{"line_number":21,"context_line":"  # Type: string"},{"line_number":22,"context_line":"  CinderNetappControllerIps: \u0027\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  # "},{"line_number":25,"context_line":"  # Type: string"},{"line_number":26,"context_line":"  CinderNetappCopyOffloadToolPath: \u0027\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  # "}],"source_content_type":"text/x-yaml","patch_set":5,"id":"37d86a06_0ed27c6c","side":"PARENT","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":16},"updated":"2022-05-23 15:45:54.000000000","message":"looks like pep8 validation is failing because these parameter were removed. To make the current validation happy, we can add these back but I feel like it\u0027s not quite appropriate and we need to fix the validation/generation script.","commit_id":"54aa3ed9643a45c757e37ff26b3219c08a6c1f9d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"82128471bb1da5b7db1a3be42a59e389475cd0bf","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  # "},{"line_number":21,"context_line":"  # Type: string"},{"line_number":22,"context_line":"  CinderNetappControllerIps: \u0027\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  # "},{"line_number":25,"context_line":"  # Type: string"},{"line_number":26,"context_line":"  CinderNetappCopyOffloadToolPath: \u0027\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  # "}],"source_content_type":"text/x-yaml","patch_set":5,"id":"89eafe49_c60ef761","side":"PARENT","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":16},"in_reply_to":"37d86a06_0ed27c6c","updated":"2022-05-23 16:13:19.000000000","message":"There\u0027s another approach, which I explained to mkatari in a private exchange on irc. I believe he\u0027s investigating a solution.","commit_id":"54aa3ed9643a45c757e37ff26b3219c08a6c1f9d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c2b69248ce3844d4c6b03bfb40516c7519e6df09","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  # "},{"line_number":21,"context_line":"  # Type: string"},{"line_number":22,"context_line":"  CinderNetappControllerIps: \u0027\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  # "},{"line_number":25,"context_line":"  # Type: string"},{"line_number":26,"context_line":"  CinderNetappCopyOffloadToolPath: \u0027\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  # "}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d54afbb5_0edacefc","side":"PARENT","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":16},"in_reply_to":"89eafe49_c60ef761","updated":"2022-05-24 12:32:37.000000000","message":"Thank you and Manoj for fixing the error ! Yeah I think the proposed approach looks good.","commit_id":"54aa3ed9643a45c757e37ff26b3219c08a6c1f9d"}],"sample-env-generator/storage.yaml":[{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"3932725f15bc77d6714cfd2b9b2b31ec9d4b93ca","unresolved":true,"context_lines":[{"line_number":69,"context_line":"    files:"},{"line_number":70,"context_line":"      deployment/cinder/cinder-backend-netapp-puppet.yaml:"},{"line_number":71,"context_line":"        parameters:"},{"line_number":72,"context_line":"          - CinderEnableNetappBackend"},{"line_number":73,"context_line":"          - CinderNetappAvailabilityZone"},{"line_number":74,"context_line":"          - CinderNetappBackendName"},{"line_number":75,"context_line":"          - CinderNetappCopyOffloadToolPath"},{"line_number":76,"context_line":"          - CinderNetappHostType"},{"line_number":77,"context_line":"          - CinderNetappLogin"},{"line_number":78,"context_line":"          - CinderNetappMultiConfig"},{"line_number":79,"context_line":"          - CinderNetappNasSecureFileOperations"},{"line_number":80,"context_line":"          - CinderNetappNasSecureFilePermissions"},{"line_number":81,"context_line":"          - CinderNetappNfsMountOptions"},{"line_number":82,"context_line":"          - CinderNetappNfsShares"},{"line_number":83,"context_line":"          - CinderNetappNfsSharesConfig"},{"line_number":84,"context_line":"          - CinderNetappPassword"},{"line_number":85,"context_line":"          - CinderNetappPoolNameSearchPattern"},{"line_number":86,"context_line":"          - CinderNetappServerHostname"},{"line_number":87,"context_line":"          - CinderNetappServerPort"},{"line_number":88,"context_line":"          - CinderNetappSizeMultiplier"},{"line_number":89,"context_line":"          - CinderNetappStorageFamily"},{"line_number":90,"context_line":"          - CinderNetappStorageProtocol"},{"line_number":91,"context_line":"          - CinderNetappTransportType"},{"line_number":92,"context_line":"          - CinderNetappVserver"},{"line_number":93,"context_line":"    static:"},{"line_number":94,"context_line":"      - CinderEnableNetappBackend"},{"line_number":95,"context_line":"    resource_registry:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"cb0670f5_f034be83","line":92,"range":{"start_line":72,"start_character":8,"end_line":92,"end_character":31},"updated":"2022-05-24 09:56:27.000000000","message":"With this change, pep8 issue will be resolved as sample-env-generator will generate a netapp sample environment file without deprecated parameters.\n\nIn future, if a parameter is deprecated, it should be removed from\nsample-env-generator/storage.yaml and environments/storage/cinder-netapp-config.yaml.","commit_id":"3886d5cc648006282abe74f1b5e495563afbd344"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"38d12c4d594f99e587a7cacebe453580c2f09f59","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    files:"},{"line_number":70,"context_line":"      deployment/cinder/cinder-backend-netapp-puppet.yaml:"},{"line_number":71,"context_line":"        parameters:"},{"line_number":72,"context_line":"          - CinderEnableNetappBackend"},{"line_number":73,"context_line":"          - CinderNetappAvailabilityZone"},{"line_number":74,"context_line":"          - CinderNetappBackendName"},{"line_number":75,"context_line":"          - CinderNetappCopyOffloadToolPath"},{"line_number":76,"context_line":"          - CinderNetappHostType"},{"line_number":77,"context_line":"          - CinderNetappLogin"},{"line_number":78,"context_line":"          - CinderNetappMultiConfig"},{"line_number":79,"context_line":"          - CinderNetappNasSecureFileOperations"},{"line_number":80,"context_line":"          - CinderNetappNasSecureFilePermissions"},{"line_number":81,"context_line":"          - CinderNetappNfsMountOptions"},{"line_number":82,"context_line":"          - CinderNetappNfsShares"},{"line_number":83,"context_line":"          - CinderNetappNfsSharesConfig"},{"line_number":84,"context_line":"          - CinderNetappPassword"},{"line_number":85,"context_line":"          - CinderNetappPoolNameSearchPattern"},{"line_number":86,"context_line":"          - CinderNetappServerHostname"},{"line_number":87,"context_line":"          - CinderNetappServerPort"},{"line_number":88,"context_line":"          - CinderNetappSizeMultiplier"},{"line_number":89,"context_line":"          - CinderNetappStorageFamily"},{"line_number":90,"context_line":"          - CinderNetappStorageProtocol"},{"line_number":91,"context_line":"          - CinderNetappTransportType"},{"line_number":92,"context_line":"          - CinderNetappVserver"},{"line_number":93,"context_line":"    static:"},{"line_number":94,"context_line":"      - CinderEnableNetappBackend"},{"line_number":95,"context_line":"    resource_registry:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"50f38f41_28470b5c","line":92,"range":{"start_line":72,"start_character":8,"end_line":92,"end_character":31},"in_reply_to":"28ff2eef_eed9d185","updated":"2022-05-24 13:09:09.000000000","message":"Done","commit_id":"3886d5cc648006282abe74f1b5e495563afbd344"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d5e342d92fb66cfbc1be8b5783b9fe626d7c7965","unresolved":true,"context_lines":[{"line_number":69,"context_line":"    files:"},{"line_number":70,"context_line":"      deployment/cinder/cinder-backend-netapp-puppet.yaml:"},{"line_number":71,"context_line":"        parameters:"},{"line_number":72,"context_line":"          - CinderEnableNetappBackend"},{"line_number":73,"context_line":"          - CinderNetappAvailabilityZone"},{"line_number":74,"context_line":"          - CinderNetappBackendName"},{"line_number":75,"context_line":"          - CinderNetappCopyOffloadToolPath"},{"line_number":76,"context_line":"          - CinderNetappHostType"},{"line_number":77,"context_line":"          - CinderNetappLogin"},{"line_number":78,"context_line":"          - CinderNetappMultiConfig"},{"line_number":79,"context_line":"          - CinderNetappNasSecureFileOperations"},{"line_number":80,"context_line":"          - CinderNetappNasSecureFilePermissions"},{"line_number":81,"context_line":"          - CinderNetappNfsMountOptions"},{"line_number":82,"context_line":"          - CinderNetappNfsShares"},{"line_number":83,"context_line":"          - CinderNetappNfsSharesConfig"},{"line_number":84,"context_line":"          - CinderNetappPassword"},{"line_number":85,"context_line":"          - CinderNetappPoolNameSearchPattern"},{"line_number":86,"context_line":"          - CinderNetappServerHostname"},{"line_number":87,"context_line":"          - CinderNetappServerPort"},{"line_number":88,"context_line":"          - CinderNetappSizeMultiplier"},{"line_number":89,"context_line":"          - CinderNetappStorageFamily"},{"line_number":90,"context_line":"          - CinderNetappStorageProtocol"},{"line_number":91,"context_line":"          - CinderNetappTransportType"},{"line_number":92,"context_line":"          - CinderNetappVserver"},{"line_number":93,"context_line":"    static:"},{"line_number":94,"context_line":"      - CinderEnableNetappBackend"},{"line_number":95,"context_line":"    resource_registry:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"28ff2eef_eed9d185","line":92,"range":{"start_line":72,"start_character":8,"end_line":92,"end_character":31},"in_reply_to":"cb0670f5_f034be83","updated":"2022-05-24 12:31:45.000000000","message":"That\u0027s nice and I agree with the AI you explained (exclude deprecated parameters). You might want to add TODO item here so that we don\u0027t forget that AI (or at least removing this when we remove the deprecated parameters)","commit_id":"3886d5cc648006282abe74f1b5e495563afbd344"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"870e542abafc8fda8eb260166654c7d1020a90bc","unresolved":true,"context_lines":[{"line_number":69,"context_line":"    files:"},{"line_number":70,"context_line":"      deployment/cinder/cinder-backend-netapp-puppet.yaml:"},{"line_number":71,"context_line":"        parameters:"},{"line_number":72,"context_line":"          # TODO(tkajinam): Currently this is required to skip the deprecated"},{"line_number":73,"context_line":"          #                 parameters but ideally these should be excluded"},{"line_number":74,"context_line":"          #                 by generator. Remove this once that is fixed or"},{"line_number":75,"context_line":"          #                 the deprecated parameters are removed."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ee132d71_1df4eb78","line":72,"range":{"start_line":72,"start_character":12,"end_line":72,"end_character":16},"updated":"2022-05-24 13:18:56.000000000","message":"An alternate approach would be to remove this backend (and possibly the others, as well) from the sample-env-generator. Auto-generating env files was a design initiative that never really took off, and at one PTG (Pike?) there was a discussion in which it was clear that not everyone wanted to adopt the idea.","commit_id":"6a55550a866560553ceabe6c4e86e3409293feb9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"395ec413144e26e733b5f2d6192b17f34c6bfde0","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    files:"},{"line_number":70,"context_line":"      deployment/cinder/cinder-backend-netapp-puppet.yaml:"},{"line_number":71,"context_line":"        parameters:"},{"line_number":72,"context_line":"          # TODO(tkajinam): Currently this is required to skip the deprecated"},{"line_number":73,"context_line":"          #                 parameters but ideally these should be excluded"},{"line_number":74,"context_line":"          #                 by generator. Remove this once that is fixed or"},{"line_number":75,"context_line":"          #                 the deprecated parameters are removed."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"23cfad34_53939324","line":72,"range":{"start_line":72,"start_character":12,"end_line":72,"end_character":16},"in_reply_to":"ee132d71_1df4eb78","updated":"2022-05-25 02:49:44.000000000","message":"I agree that is also a valid approach.\n\nWe can discuss further later when we work on removing this TODO. The desire here is to leave a not so that we don\u0027t forget removing this tricky hack in the future :-)","commit_id":"6a55550a866560553ceabe6c4e86e3409293feb9"}]}