)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"bcaed254edd0dcd80db7961acb03a3a19b528e3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"01711f9b_001a56d6","updated":"2022-03-26 06:34:12.000000000","message":"I don\u0027t think this is immediately intuitive. Traditionally, our undercloud and overclouds have operated entirely independently from a configuration perspective. ie, users would define any settings they want for the overcloud in their environment files rather than relying on any configuration from the undercloud.\n\nThe fact that we were defaulting to the undercloud ctlplane-subnet dns_nameservers I don\u0027t think has been overtly obvious to our users and customers.\n\nI get the technical limitation, and that we need to handle this prior to stack creation now, so +1 for this change. But I think maybe we might need to consider adding an option to either the networks_data_v2 file, or the file used to provision the baremetal nodes. Kind of similar to how we\u0027re doing it here for the default route network:\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/baremetal-samples/baremetal_deployment.yaml#L20\n\nMaybe another option for:\n```\n default_dns_nameservers:\n - 1.1.1.1\n - 8.8.8.8\n```","commit_id":"3553cdaf46a4480c11b09791abc5fe4e953af1e8"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"635ead226905d5a1d3b212f1a198be4b9f5be5a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c2610ec1_914a7b1a","updated":"2022-03-25 23:15:15.000000000","message":"check-rdo","commit_id":"3553cdaf46a4480c11b09791abc5fe4e953af1e8"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"1f757a27be1381b80850f7e9a209dfe5ade91bce","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a4c29928_283d1cb6","in_reply_to":"01711f9b_001a56d6","updated":"2022-03-26 16:31:49.000000000","message":"\u003e I don\u0027t think this is immediately intuitive. Traditionally, our undercloud and overclouds have operated entirely independently from a configuration perspective. ie, users would define any settings they want for the overcloud in their environment files rather than relying on any configuration from the undercloud.\n\u003e \n\nIMO that is problematic, we allowed users to put dns servers and gateway addresses for a subnet in undercloud.conf, and then the values could be overridden in overcloud environment. So what you have in undercloud.conf and neutron resource properties are not equal to what is on deployed nodes. Confusing, make troubleshooting harder etc.\n\n\u003e The fact that we were defaulting to the undercloud ctlplane-subnet dns_nameservers I don\u0027t think has been overtly obvious to our users and customers.\n\u003e \n\nI agree we probably failed to document/communicate this well.\n\n\u003e I get the technical limitation, and that we need to handle this prior to stack creation now, so +1 for this change. But I think maybe we might need to consider adding an option to either the networks_data_v2 file, or the file used to provision the baremetal nodes. Kind of similar to how we\u0027re doing it here for the default route network:\n\u003e https://github.com/openstack/tripleo-heat-templates/blob/master/baremetal-samples/baremetal_deployment.yaml#L20\n\u003e \n\u003e Maybe another option for:\n\u003e ```\n\u003e  default_dns_nameservers:\n\u003e  - 1.1.1.1\n\u003e  - 8.8.8.8\n\u003e ```\n\nI don\u0027t agree. :) Because ...\n\n  If the users are forced to change how they define nameservers, it does not matter if that is \"set dns_nameservers on the subnet in \u0027undercloud.conf\u0027\" or set \u0027default_dns_nameservers\u0027 in network_data/baremetal_deployment YAML\u0027s.\n\n  Also, implementing such an override is complex, changes in tripleo-ansible, tripleo-common and tripleo-heat-templates. Adding back conditions/complexity in THT which I removed in the next patch in this chain.\n\nI will leave this unresolved, for other reviewers to chime in as well.","commit_id":"3553cdaf46a4480c11b09791abc5fe4e953af1e8"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"52a8101318079ea0ad9f2554a66fb5401c139796","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"24529840_653ba2bd","in_reply_to":"a4c29928_283d1cb6","updated":"2022-03-27 23:09:25.000000000","message":"That is a fair point. If we\u0027re already asking them to define it somewhere, then we shouldn\u0027t need them to define it again later in Heat environment files.\n\nAs long as we document it in the undercloud install guide; that the DNS server they define in the undercloud.conf file, will be used for the overcloud nodes as well. And again in the overcloud deploy guide as a note when we talk about network configuration. That should be enough to address any confusion that might come from users.","commit_id":"3553cdaf46a4480c11b09791abc5fe4e953af1e8"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"5d746cbd5ac7fb31d0230f68a8e4bdc520389cfc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e7eac74f_2f0389ef","updated":"2022-04-12 12:34:14.000000000","message":"To be clear, this deprecation will be backported to wallaby and the follow removal is only for master?","commit_id":"42506f635dcc57f803e097ab0ea8abf9519565c4"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"0970c0dd13949eb94cff4e5dfeb6dc1a6b82dd1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"52504249_13aa46ce","in_reply_to":"e7eac74f_2f0389ef","updated":"2022-06-02 09:40:44.000000000","message":"Yes, that seems reasonable.","commit_id":"42506f635dcc57f803e097ab0ea8abf9519565c4"}],"overcloud.j2.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"6fb6ef6d9ec05ed015fdb842bebbf338b0cbee6e","unresolved":true,"context_lines":[{"line_number":939,"context_line":"      value:"},{"line_number":940,"context_line":"        ctlplane_mtu: {get_attr: [Networks, net_attributes_map, ctlplane, network, mtu]}"},{"line_number":941,"context_line":"        ctlplane_gateway_ip: {get_attr: [Networks, net_attributes_map, ctlplane, subnets, {get_param: {{role.name}}ControlPlaneSubnet}, gateway_ip]}"},{"line_number":942,"context_line":"        ctlplane_dns_nameservers:"},{"line_number":943,"context_line":"          if:"},{"line_number":944,"context_line":"            - dnsservers_set"},{"line_number":945,"context_line":"            - {get_param: DnsServers}"},{"line_number":946,"context_line":"            - {get_attr: [Networks, net_attributes_map, ctlplane, subnets, {get_param: {{role.name}}ControlPlaneSubnet}, dns_nameservers]}"},{"line_number":947,"context_line":"        ctlplane_subnet_cidr: {str_split: [\u0027/\u0027, {get_attr: [Networks, net_attributes_map, ctlplane, subnets, {get_param: {{role.name}}ControlPlaneSubnet}, cidr]}, 1]}"},{"line_number":948,"context_line":"        ctlplane_host_routes:"},{"line_number":949,"context_line":"          list_concat_unique:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b663f827_14aeee5e","line":946,"range":{"start_line":942,"start_character":0,"end_line":946,"end_character":138},"updated":"2022-03-28 05:30:45.000000000","message":"Can we get rid of these from GroupVars? We get these from neutron during config-download/inventory generation and add to inventory anyway.","commit_id":"3553cdaf46a4480c11b09791abc5fe4e953af1e8"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"3e9cad11bcae169a8a9f40853efb544af2b58668","unresolved":false,"context_lines":[{"line_number":939,"context_line":"      value:"},{"line_number":940,"context_line":"        ctlplane_mtu: {get_attr: [Networks, net_attributes_map, ctlplane, network, mtu]}"},{"line_number":941,"context_line":"        ctlplane_gateway_ip: {get_attr: [Networks, net_attributes_map, ctlplane, subnets, {get_param: {{role.name}}ControlPlaneSubnet}, gateway_ip]}"},{"line_number":942,"context_line":"        ctlplane_dns_nameservers:"},{"line_number":943,"context_line":"          if:"},{"line_number":944,"context_line":"            - dnsservers_set"},{"line_number":945,"context_line":"            - {get_param: DnsServers}"},{"line_number":946,"context_line":"            - {get_attr: [Networks, net_attributes_map, ctlplane, subnets, {get_param: {{role.name}}ControlPlaneSubnet}, dns_nameservers]}"},{"line_number":947,"context_line":"        ctlplane_subnet_cidr: {str_split: [\u0027/\u0027, {get_attr: [Networks, net_attributes_map, ctlplane, subnets, {get_param: {{role.name}}ControlPlaneSubnet}, cidr]}, 1]}"},{"line_number":948,"context_line":"        ctlplane_host_routes:"},{"line_number":949,"context_line":"          list_concat_unique:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"80fa79c3_115a28e4","line":946,"range":{"start_line":942,"start_character":0,"end_line":946,"end_character":138},"in_reply_to":"4f460758_a12468e1","updated":"2022-03-29 03:20:20.000000000","message":"oh, right I think I got ahead of myself.\n\nWe would have to change the multinode job to run \u0027overcloud node provision\u0027 with a baremetal_deployment.yaml defining the instance as pre-deployed. That would make it create the ports in neutron, but not deploy the node with ironic. Not sure we want to remove these GroupVars, it would make \u0027overcloud node provision\u0027 a requirement also for pre-provisioned, and break the no-neutron usecase.\n\nI remove the use of DnsServer parameter in the follow up change.","commit_id":"3553cdaf46a4480c11b09791abc5fe4e953af1e8"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e97d042a5ec7a0822252d58f0ed80023ed3c46ec","unresolved":true,"context_lines":[{"line_number":939,"context_line":"      value:"},{"line_number":940,"context_line":"        ctlplane_mtu: {get_attr: [Networks, net_attributes_map, ctlplane, network, mtu]}"},{"line_number":941,"context_line":"        ctlplane_gateway_ip: {get_attr: [Networks, net_attributes_map, ctlplane, subnets, {get_param: {{role.name}}ControlPlaneSubnet}, gateway_ip]}"},{"line_number":942,"context_line":"        ctlplane_dns_nameservers:"},{"line_number":943,"context_line":"          if:"},{"line_number":944,"context_line":"            - dnsservers_set"},{"line_number":945,"context_line":"            - {get_param: DnsServers}"},{"line_number":946,"context_line":"            - {get_attr: [Networks, net_attributes_map, ctlplane, subnets, {get_param: {{role.name}}ControlPlaneSubnet}, dns_nameservers]}"},{"line_number":947,"context_line":"        ctlplane_subnet_cidr: {str_split: [\u0027/\u0027, {get_attr: [Networks, net_attributes_map, ctlplane, subnets, {get_param: {{role.name}}ControlPlaneSubnet}, cidr]}, 1]}"},{"line_number":948,"context_line":"        ctlplane_host_routes:"},{"line_number":949,"context_line":"          list_concat_unique:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4f460758_a12468e1","line":946,"range":{"start_line":942,"start_character":0,"end_line":946,"end_character":138},"in_reply_to":"50457290_e205dd0b","updated":"2022-03-28 14:37:09.000000000","message":"We can probably remove the usage of DnsServers parameter here which is ineffective. I noticed that we don\u0027t generate these vars (with inventory) for deployed server where no ctlplane port[2] is created (and tagged) es. multinode job[1]. Probably getting of all these lines is not that straight forward(?)\n\n[1] https://2302f195cca0bd2fbfcf-1aafb108750144ecd9565eaf1429d9e4.ssl.cf1.rackcdn.com/835247/1/check/tripleo-ci-centos-9-containers-multinode/6666115/logs/undercloud/home/zuul/config-download.yaml\n[2] https://github.com/openstack/tripleo-common/blob/master/tripleo_common/inventory.py#L495-L497","commit_id":"3553cdaf46a4480c11b09791abc5fe4e953af1e8"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"199e33f09f3c1e9962eeb07d398d582a53a5e77e","unresolved":true,"context_lines":[{"line_number":939,"context_line":"      value:"},{"line_number":940,"context_line":"        ctlplane_mtu: {get_attr: [Networks, net_attributes_map, ctlplane, network, mtu]}"},{"line_number":941,"context_line":"        ctlplane_gateway_ip: {get_attr: [Networks, net_attributes_map, ctlplane, subnets, {get_param: {{role.name}}ControlPlaneSubnet}, gateway_ip]}"},{"line_number":942,"context_line":"        ctlplane_dns_nameservers:"},{"line_number":943,"context_line":"          if:"},{"line_number":944,"context_line":"            - dnsservers_set"},{"line_number":945,"context_line":"            - {get_param: DnsServers}"},{"line_number":946,"context_line":"            - {get_attr: [Networks, net_attributes_map, ctlplane, subnets, {get_param: {{role.name}}ControlPlaneSubnet}, dns_nameservers]}"},{"line_number":947,"context_line":"        ctlplane_subnet_cidr: {str_split: [\u0027/\u0027, {get_attr: [Networks, net_attributes_map, ctlplane, subnets, {get_param: {{role.name}}ControlPlaneSubnet}, cidr]}, 1]}"},{"line_number":948,"context_line":"        ctlplane_host_routes:"},{"line_number":949,"context_line":"          list_concat_unique:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"50457290_e205dd0b","line":946,"range":{"start_line":942,"start_character":0,"end_line":946,"end_character":138},"in_reply_to":"b663f827_14aeee5e","updated":"2022-03-28 12:46:07.000000000","message":"I think we could remove almost everything L935-L1058.\n\nLet\u0027s look at that in the follow up?","commit_id":"3553cdaf46a4480c11b09791abc5fe4e953af1e8"}],"releasenotes/notes/deprecate-DnsServers-a65541c2dceced08.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"6fb6ef6d9ec05ed015fdb842bebbf338b0cbee6e","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    The dns_nameservers from the ctlplane subnets has been used by default for"},{"line_number":7,"context_line":"    overcloud node nameservers for a long time, see:"},{"line_number":8,"context_line":"    https://review.opendev.org/579582."},{"line_number":9,"context_line":"    "},{"line_number":10,"context_line":"    Since Wallaby network configuration is applied prior to the Heat stack"},{"line_number":11,"context_line":"    create, during overcloud node provisioning. In this case the THT parameter"},{"line_number":12,"context_line":"    DnsServers is not available when network configuration is applied."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0250dd78_22ca0bf5","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":4},"updated":"2022-03-28 05:30:45.000000000","message":"White space.","commit_id":"3553cdaf46a4480c11b09791abc5fe4e953af1e8"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"199e33f09f3c1e9962eeb07d398d582a53a5e77e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    The dns_nameservers from the ctlplane subnets has been used by default for"},{"line_number":7,"context_line":"    overcloud node nameservers for a long time, see:"},{"line_number":8,"context_line":"    https://review.opendev.org/579582."},{"line_number":9,"context_line":"    "},{"line_number":10,"context_line":"    Since Wallaby network configuration is applied prior to the Heat stack"},{"line_number":11,"context_line":"    create, during overcloud node provisioning. In this case the THT parameter"},{"line_number":12,"context_line":"    DnsServers is not available when network configuration is applied."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5615d17d_6de4c63d","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":4},"in_reply_to":"0250dd78_22ca0bf5","updated":"2022-03-28 12:46:07.000000000","message":"Done","commit_id":"3553cdaf46a4480c11b09791abc5fe4e953af1e8"}]}