)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f3aae7d4dec096c4a15e9fed60b4f115398b890f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dd2987db_15c8bd80","updated":"2022-03-28 12:39:17.000000000","message":"I think we cannot remove in the same release where it has been deprecated?","commit_id":"b4a5e746e240456c1a3a643d65529bee0d1f5979"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"179838b095f735d82f55b974a63c68f211028806","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0f3fe39c_8f72b22a","updated":"2022-03-25 23:12:53.000000000","message":"recheck","commit_id":"b4a5e746e240456c1a3a643d65529bee0d1f5979"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"0c412b583685609a77f08f62cb1a2b5692cb6939","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8c542efb_a12c9287","updated":"2022-03-26 16:33:48.000000000","message":"recheck - looks like unrelated python setuptools issue.","commit_id":"b4a5e746e240456c1a3a643d65529bee0d1f5979"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"90d9b0db109231c1b71c7a10302b367acb89a421","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"da82eda2_b7fbdcae","in_reply_to":"dd2987db_15c8bd80","updated":"2022-03-28 12:48:51.000000000","message":"In this case, it doesn\u0027t work at all. So I guess we could make an exception here given it\u0027s just removing broken functionality?\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d2068489\n\nRealistically, it needs to be removed from Wallaby as well.","commit_id":"b4a5e746e240456c1a3a643d65529bee0d1f5979"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"c15227a14be848fd140edec28851244902dcf790","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"31627114_7183df80","updated":"2022-06-09 05:59:17.000000000","message":"Looks good. Lets get this backported to W","commit_id":"4949f9a867daa9f195a157cfa47440c6ccf3d5ba"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"5560dcf976411d5d373c19bd787656767fb0b11e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5dd18dfe_854da2e2","updated":"2022-06-14 13:58:44.000000000","message":"check-rdo","commit_id":"4949f9a867daa9f195a157cfa47440c6ccf3d5ba"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"814172278e3091320df1c3d2a254f05439b9159f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"89c10e0c_0043a266","updated":"2022-07-04 18:39:52.000000000","message":"See nit re comment","commit_id":"ba1f84362406858acc5086493301a9d5e13cedf2"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"fe9cb6b7e02f0a1364394d0ade56282ef51d1ad4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4abedc4b_223d9727","updated":"2022-07-13 12:16:13.000000000","message":"recheck RETRY_LIMIT","commit_id":"b4dc341f1b2573b508a2e6c78cbc5dbf73027933"}],"ci/environments/standalone-ipa.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2946c3724c64660670a88c79b5672afd4507508c","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  PasswordAuthentication: \u0027yes\u0027"},{"line_number":17,"context_line":"  HAProxyExternalNetwork: ctlplane"},{"line_number":18,"context_line":"  # Add setting for custom DNS server"},{"line_number":19,"context_line":"  DnsSearchDomains: [\"ooo.test\"]"},{"line_number":20,"context_line":"  LocalContainerRegistry: \"192.168.24.1\""},{"line_number":21,"context_line":"  AddVipsToEtcHosts: True"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2d160acd_67bf8dcf","line":19,"updated":"2022-04-13 13:05:07.000000000","message":"is this ok to remove dnsservers config options but keep dns search domains?","commit_id":"9565da0ed79cbfe76132b58aca3eda2333a6624b"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"337b6d1b51f8d0c61cb7980cd84fae6dff187ddc","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  PasswordAuthentication: \u0027yes\u0027"},{"line_number":17,"context_line":"  HAProxyExternalNetwork: ctlplane"},{"line_number":18,"context_line":"  # Add setting for custom DNS server"},{"line_number":19,"context_line":"  DnsSearchDomains: [\"ooo.test\"]"},{"line_number":20,"context_line":"  LocalContainerRegistry: \"192.168.24.1\""},{"line_number":21,"context_line":"  AddVipsToEtcHosts: True"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"402c59ce_842818b5","line":19,"in_reply_to":"2d160acd_67bf8dcf","updated":"2022-05-11 06:23:53.000000000","message":"I also second this. Are we going to hit the same issues with this param? If so, we should be deprecating and removing both of them?","commit_id":"9565da0ed79cbfe76132b58aca3eda2333a6624b"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"dfe8666596eb8f5f8d367b482e40b1d40f634cd5","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  PasswordAuthentication: \u0027yes\u0027"},{"line_number":17,"context_line":"  HAProxyExternalNetwork: ctlplane"},{"line_number":18,"context_line":"  # Add setting for custom DNS server"},{"line_number":19,"context_line":"  DnsSearchDomains: [\"ooo.test\"]"},{"line_number":20,"context_line":"  LocalContainerRegistry: \"192.168.24.1\""},{"line_number":21,"context_line":"  AddVipsToEtcHosts: True"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"61cfe768_c54cab15","line":19,"in_reply_to":"402c59ce_842818b5","updated":"2022-06-02 09:35:34.000000000","message":"DnsSearchDomains will kind of hit the same issue, only if `dns_search_domains` is defined in baremetal deployment YAML definitions[1] `network_config` section.\n\nWhen the inventory is generated, we do it in stages:\n\n  #1 From information in neutron, as well as some files on the filesystem.\n  #2 From the ephemeral heat stack.\n\nThe code uses setdefault(), so in the case the value for a variable is available in the stage #1 this value is used in the inventory. In the case that `dns_search_domains` are defined in the baremetal deployment YAML definition[1] the `DnsSearchDomains` will be ignored. If `dns_search_domains` is not defined in the bm-deploy YAML `DnsSearchDomains` will be in the used to set the value in the inventory.\n\n\nNOTE: If you don\u0027t set `dns_search_domains` in bm-deploy YAML the flag to enable network config update must be enabled to ensure the search domain is updated when config-download run the playbooks.\n\n[1] https://docs.openstack.org/project-deploy-guide/tripleo-docs/latest/provisioning/baremetal_provision.html#network-config-properties","commit_id":"9565da0ed79cbfe76132b58aca3eda2333a6624b"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5888426694ad5186bdbe7052acf4f630e78038a7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  PasswordAuthentication: \u0027yes\u0027"},{"line_number":17,"context_line":"  HAProxyExternalNetwork: ctlplane"},{"line_number":18,"context_line":"  # Add setting for custom DNS server"},{"line_number":19,"context_line":"  DnsSearchDomains: [\"ooo.test\"]"},{"line_number":20,"context_line":"  LocalContainerRegistry: \"192.168.24.1\""},{"line_number":21,"context_line":"  AddVipsToEtcHosts: True"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"24b99126_f4fc5a4d","line":19,"in_reply_to":"61cfe768_c54cab15","updated":"2022-06-03 13:11:36.000000000","message":"Ack","commit_id":"9565da0ed79cbfe76132b58aca3eda2333a6624b"}],"environments/standalone/standalone-tripleo.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bb35b6a8c6e7e03481df7820305b3d7424c9d8c9","unresolved":true,"context_lines":[{"line_number":25,"context_line":"#   openstack overcloud roles generate -o ~/roles_data.yaml Standalone"},{"line_number":26,"context_line":"parameter_defaults:"},{"line_number":27,"context_line":"  # Set to true to append per network Vips to /etc/hosts on each node."},{"line_number":28,"context_line":"  # Type: string"},{"line_number":29,"context_line":"  AddVipsToEtcHosts: False"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  # Set to true to enable package installation at deploy time"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6dfb09cb_12405aee","line":28,"updated":"2022-04-13 13:04:04.000000000","message":"I believe this remains to be a boolean?","commit_id":"9565da0ed79cbfe76132b58aca3eda2333a6624b"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5888426694ad5186bdbe7052acf4f630e78038a7","unresolved":true,"context_lines":[{"line_number":25,"context_line":"#   openstack overcloud roles generate -o ~/roles_data.yaml Standalone"},{"line_number":26,"context_line":"parameter_defaults:"},{"line_number":27,"context_line":"  # Set to true to append per network Vips to /etc/hosts on each node."},{"line_number":28,"context_line":"  # Type: string"},{"line_number":29,"context_line":"  AddVipsToEtcHosts: False"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  # Set to true to enable package installation at deploy time"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c62c480c_c691486f","line":28,"in_reply_to":"6dfb09cb_12405aee","updated":"2022-06-03 13:11:36.000000000","message":"what about this one?","commit_id":"9565da0ed79cbfe76132b58aca3eda2333a6624b"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b17f3015b469ab6fddc347973ec616d112603525","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#   openstack overcloud roles generate -o ~/roles_data.yaml Standalone"},{"line_number":26,"context_line":"parameter_defaults:"},{"line_number":27,"context_line":"  # Set to true to append per network Vips to /etc/hosts on each node."},{"line_number":28,"context_line":"  # Type: string"},{"line_number":29,"context_line":"  AddVipsToEtcHosts: False"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  # Set to true to enable package installation at deploy time"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba15ecae_792ac575","line":28,"in_reply_to":"c62c480c_c691486f","updated":"2022-06-03 17:25:56.000000000","message":"yes, it does. Done.","commit_id":"9565da0ed79cbfe76132b58aca3eda2333a6624b"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"814172278e3091320df1c3d2a254f05439b9159f","unresolved":true,"context_lines":[{"line_number":25,"context_line":"#   openstack overcloud roles generate -o ~/roles_data.yaml Standalone"},{"line_number":26,"context_line":"parameter_defaults:"},{"line_number":27,"context_line":"  # Set to true to append per network Vips to /etc/hosts on each node."},{"line_number":28,"context_line":"  # Type: boolean"},{"line_number":29,"context_line":"  AddVipsToEtcHosts: False"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  # DNS servers to use for the Overcloud (2 max for some implementations). If not set the nameservers configured in the ctlplane subnet\u0027s dns_nameservers attribute will be used."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"51a83dc4_1d4b3a1e","side":"PARENT","line":28,"updated":"2022-07-04 18:39:52.000000000","message":"did you mean to change this \"string\"?","commit_id":"8857188bd6b265316b77c7ef52afc857da0e27a1"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"5916339aa132c9948c6ddd39a283750b0d89266f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#   openstack overcloud roles generate -o ~/roles_data.yaml Standalone"},{"line_number":26,"context_line":"parameter_defaults:"},{"line_number":27,"context_line":"  # Set to true to append per network Vips to /etc/hosts on each node."},{"line_number":28,"context_line":"  # Type: boolean"},{"line_number":29,"context_line":"  AddVipsToEtcHosts: False"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  # DNS servers to use for the Overcloud (2 max for some implementations). If not set the nameservers configured in the ctlplane subnet\u0027s dns_nameservers attribute will be used."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f0030e0_a19d113e","side":"PARENT","line":28,"in_reply_to":"51a83dc4_1d4b3a1e","updated":"2022-07-04 18:45:45.000000000","message":"ugh, I have a feeling I fixed that once before.\nDone.","commit_id":"8857188bd6b265316b77c7ef52afc857da0e27a1"}]}