)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"401ea9ff577c1a4497acfaee242b5e6de625541b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2b4ce40a_68b28d7c","updated":"2022-05-30 22:59:12.000000000","message":"Implementation looks good.","commit_id":"32bb1728c310bf301de3e9f1b15787381ccf81ab"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"a4de6bbd814703a01496852fdef605a83cc921f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"28c6f96f_1a84b122","updated":"2022-05-30 09:18:20.000000000","message":"recheck","commit_id":"32bb1728c310bf301de3e9f1b15787381ccf81ab"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"f04c04e2cf3048bf13fa85ddf5dc5bffd393c580","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"78af5211_f2278b22","updated":"2022-05-30 06:11:34.000000000","message":"recheck","commit_id":"32bb1728c310bf301de3e9f1b15787381ccf81ab"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"96f518e880edf6d4d400f2d49a698a9f00a54e86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c3726fbb_72b2990b","updated":"2022-06-01 09:55:18.000000000","message":"Looks good. ","commit_id":"4ca3a075176ee20d603635ae62785ad1d2b0f4e0"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"83985413fca9307f293a6132dd03f620ab2a6305","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cc29160c_5d3c96b4","updated":"2022-05-31 23:49:23.000000000","message":"The failure was an error pulling the ceph containers for some reason. Let\u0027s recheck on this one.","commit_id":"4ca3a075176ee20d603635ae62785ad1d2b0f4e0"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"b9917f4f316a064f3d476f3a0828d57c55d443a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"73c14fe3_ebc4ba37","updated":"2022-05-31 23:49:28.000000000","message":"recheck","commit_id":"4ca3a075176ee20d603635ae62785ad1d2b0f4e0"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"27c34c7661f1729b726f1c0764a538f50b816974","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"58c11694_f49b7e45","updated":"2022-06-16 09:28:07.000000000","message":"rebased to get rid of merge conflict","commit_id":"1b29097e50e0bbac69cafcbb62bc3bcdfa298dcb"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"54cb7ad7c47983f81e96b4f9e42fe35544d4cd11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2ac36d1e_ec0bae68","updated":"2022-06-18 05:49:43.000000000","message":"recheck","commit_id":"1b29097e50e0bbac69cafcbb62bc3bcdfa298dcb"},{"author":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"change_message_id":"3d37667f3716db41bcf41093903c689493c0c93b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"96ab5337_ad9569a8","updated":"2022-06-30 10:25:48.000000000","message":"recheck","commit_id":"4cceeebc86b99f76abaf15990e14d85406628be1"},{"author":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"change_message_id":"d40f4031223eb796c5fae2bed3b80ceb896d16c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f956556e_d77694e0","updated":"2022-07-01 07:34:49.000000000","message":"recheck","commit_id":"4cceeebc86b99f76abaf15990e14d85406628be1"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"6af196da85da4a0afa4ecf5ce9d43b214eb09c09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"08210326_9067c1fb","updated":"2022-07-04 03:41:39.000000000","message":"recheck tempest failure","commit_id":"4cceeebc86b99f76abaf15990e14d85406628be1"}],"deployment/database/mysql-pacemaker-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9e7eb622a6f92f570f299876572de97e40041d8e","unresolved":true,"context_lines":[{"line_number":101,"context_line":"                 of the database user that executes the SST."},{"line_number":102,"context_line":"  MysqlMariabackupPassword:"},{"line_number":103,"context_line":"    type: string"},{"line_number":104,"context_line":"    default: \u0027\u0027"},{"line_number":105,"context_line":"    description: When MysqlGaleraSSTMethod is set to mariabackup, the password"},{"line_number":106,"context_line":"                 of the database user that executes the SST."},{"line_number":107,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"cbafa948_94e9bbe1","line":104,"range":{"start_line":104,"start_character":13,"end_line":104,"end_character":15},"updated":"2022-06-20 12:14:02.000000000","message":"(low-prio, can be left for a follow-up): Because the password is always generated by tripleo-common, we can make this parameter required. If we don\u0027t do that then I think it\u0027s better to implement a validation logic in puppet-tripleo to make it fail when sst method is mariabackup but the password is not given.","commit_id":"1b29097e50e0bbac69cafcbb62bc3bcdfa298dcb"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"5d296d56c218dd4ff19d291729f7beb73e740b58","unresolved":true,"context_lines":[{"line_number":101,"context_line":"                 of the database user that executes the SST."},{"line_number":102,"context_line":"  MysqlMariabackupPassword:"},{"line_number":103,"context_line":"    type: string"},{"line_number":104,"context_line":"    default: \u0027\u0027"},{"line_number":105,"context_line":"    description: When MysqlGaleraSSTMethod is set to mariabackup, the password"},{"line_number":106,"context_line":"                 of the database user that executes the SST."},{"line_number":107,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ccf58cb7_1d6d1165","line":104,"range":{"start_line":104,"start_character":4,"end_line":104,"end_character":15},"updated":"2022-06-28 09:54:18.000000000","message":"Yeah we should remove the default and use \u0027hidden: true\u0027 like other passwords.","commit_id":"1b29097e50e0bbac69cafcbb62bc3bcdfa298dcb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5b28f3c99804dbad27b6072f88c55385ac786aa3","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                 of the database user that executes the SST."},{"line_number":102,"context_line":"  MysqlMariabackupPassword:"},{"line_number":103,"context_line":"    type: string"},{"line_number":104,"context_line":"    default: \u0027\u0027"},{"line_number":105,"context_line":"    description: When MysqlGaleraSSTMethod is set to mariabackup, the password"},{"line_number":106,"context_line":"                 of the database user that executes the SST."},{"line_number":107,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d09eccce_9dc9a2a6","line":104,"range":{"start_line":104,"start_character":13,"end_line":104,"end_character":15},"in_reply_to":"cbafa948_94e9bbe1","updated":"2022-06-29 14:56:22.000000000","message":"Done","commit_id":"1b29097e50e0bbac69cafcbb62bc3bcdfa298dcb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5b28f3c99804dbad27b6072f88c55385ac786aa3","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                 of the database user that executes the SST."},{"line_number":102,"context_line":"  MysqlMariabackupPassword:"},{"line_number":103,"context_line":"    type: string"},{"line_number":104,"context_line":"    default: \u0027\u0027"},{"line_number":105,"context_line":"    description: When MysqlGaleraSSTMethod is set to mariabackup, the password"},{"line_number":106,"context_line":"                 of the database user that executes the SST."},{"line_number":107,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7cdc866b_feca9af3","line":104,"range":{"start_line":104,"start_character":4,"end_line":104,"end_character":15},"in_reply_to":"ccf58cb7_1d6d1165","updated":"2022-06-29 14:56:22.000000000","message":"Done","commit_id":"1b29097e50e0bbac69cafcbb62bc3bcdfa298dcb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9e7eb622a6f92f570f299876572de97e40041d8e","unresolved":false,"context_lines":[{"line_number":266,"context_line":"              - \u0027bash\u0027"},{"line_number":267,"context_line":"              - \u0027-ec\u0027"},{"line_number":268,"context_line":"              -"},{"line_number":269,"context_line":"                list_join:"},{"line_number":270,"context_line":"                  - \"\\n\""},{"line_number":271,"context_line":"                  - - \u0027if [ -e /var/lib/mysql/mysql ]; then exit 0; fi\u0027"},{"line_number":272,"context_line":"                    - \u0027echo -e \"\\n[mysqld]\\nwsrep_provider\u003dnone\" \u003e\u003e /etc/my.cnf\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1dcffcf2_95d261f9","line":269,"range":{"start_line":269,"start_character":16,"end_line":269,"end_character":25},"updated":"2022-06-20 12:14:02.000000000","message":"note to self: list_join can take multiple lists and concat them automatically.\n\nhttps://docs.openstack.org/heat/latest/template_guide/hot_spec.html#list-join","commit_id":"1b29097e50e0bbac69cafcbb62bc3bcdfa298dcb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9e7eb622a6f92f570f299876572de97e40041d8e","unresolved":true,"context_lines":[{"line_number":274,"context_line":"                    - \u0027sudo -u mysql -E kolla_extend_start\u0027"},{"line_number":275,"context_line":"                    - \u0027timeout ${DB_MAX_TIMEOUT} /bin/bash -c \u0027\u0027while pgrep -af /usr/bin/mysqld_safe | grep -q -v grep; do sleep 1; done\u0027\u0027\u0027"},{"line_number":276,"context_line":"                    - \u0027mysqld_safe --skip-networking --wsrep-on\u003dOFF \u0026\u0027"},{"line_number":277,"context_line":"                    - \u0027timeout ${DB_MAX_TIMEOUT} /bin/bash -c \u0027\u0027until mysqladmin -uroot -p\"${DB_ROOT_PASSWORD}\" ping 2\u003e/dev/null; do sleep 1; done\u0027\u0027\u0027"},{"line_number":278,"context_line":"                  - if:"},{"line_number":279,"context_line":"                    - {equals: [{get_param: MysqlGaleraSSTMethod}, \u0027mariabackup\u0027]}"},{"line_number":280,"context_line":"                    - - \u0027mysql -uroot -p\"${DB_ROOT_PASSWORD}\" -e \"CREATE USER \u0027\u0027${DB_MARIABACKUP_USER}\u0027\u0027@\u0027\u0027localhost\u0027\u0027 IDENTIFIED BY \u0027\u0027${DB_MARIABACKUP_PASSWORD}\u0027\u0027;\"\u0027"},{"line_number":281,"context_line":"                      - \u0027mysql -uroot -p\"${DB_ROOT_PASSWORD}\" -e \"GRANT RELOAD, PROCESS, LOCK TABLES, REPLICATION CLIENT ON *.* TO \u0027\u0027${DB_MARIABACKUP_USER}\u0027\u0027@\u0027\u0027localhost\u0027\u0027;\"\u0027"},{"line_number":282,"context_line":"                  - - \u0027mysql -uroot -p\"${DB_ROOT_PASSWORD}\" -e \"CREATE USER \u0027\u0027clustercheck\u0027\u0027@\u0027\u0027localhost\u0027\u0027 IDENTIFIED BY \u0027\u0027${DB_CLUSTERCHECK_PASSWORD}\u0027\u0027;\"\u0027"},{"line_number":283,"context_line":"                    - \u0027mysql -uroot -p\"${DB_ROOT_PASSWORD}\" -e \"GRANT PROCESS ON *.* TO \u0027\u0027clustercheck\u0027\u0027@\u0027\u0027localhost\u0027\u0027 WITH GRANT OPTION;\"\u0027"},{"line_number":284,"context_line":"                    - \u0027mysql -uroot -p\"${DB_ROOT_PASSWORD}\" -e \"DELETE FROM mysql.user WHERE user \u003d \u0027\u0027root\u0027\u0027 AND host NOT IN (\u0027\u0027%\u0027\u0027,\u0027\u0027localhost\u0027\u0027);\"\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3dc118c2_3911feee","line":281,"range":{"start_line":277,"start_character":149,"end_line":281,"end_character":174},"updated":"2022-06-20 12:14:02.000000000","message":"Do we have any reason to inject this before the clustercheck user ? If not I think we can add these lines after L282.","commit_id":"1b29097e50e0bbac69cafcbb62bc3bcdfa298dcb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5b836cc5d328504b5490ca54c5396d5705e19e0d","unresolved":true,"context_lines":[{"line_number":274,"context_line":"                    - \u0027sudo -u mysql -E kolla_extend_start\u0027"},{"line_number":275,"context_line":"                    - \u0027timeout ${DB_MAX_TIMEOUT} /bin/bash -c \u0027\u0027while pgrep -af /usr/bin/mysqld_safe | grep -q -v grep; do sleep 1; done\u0027\u0027\u0027"},{"line_number":276,"context_line":"                    - \u0027mysqld_safe --skip-networking --wsrep-on\u003dOFF \u0026\u0027"},{"line_number":277,"context_line":"                    - \u0027timeout ${DB_MAX_TIMEOUT} /bin/bash -c \u0027\u0027until mysqladmin -uroot -p\"${DB_ROOT_PASSWORD}\" ping 2\u003e/dev/null; do sleep 1; done\u0027\u0027\u0027"},{"line_number":278,"context_line":"                  - if:"},{"line_number":279,"context_line":"                    - {equals: [{get_param: MysqlGaleraSSTMethod}, \u0027mariabackup\u0027]}"},{"line_number":280,"context_line":"                    - - \u0027mysql -uroot -p\"${DB_ROOT_PASSWORD}\" -e \"CREATE USER \u0027\u0027${DB_MARIABACKUP_USER}\u0027\u0027@\u0027\u0027localhost\u0027\u0027 IDENTIFIED BY \u0027\u0027${DB_MARIABACKUP_PASSWORD}\u0027\u0027;\"\u0027"},{"line_number":281,"context_line":"                      - \u0027mysql -uroot -p\"${DB_ROOT_PASSWORD}\" -e \"GRANT RELOAD, PROCESS, LOCK TABLES, REPLICATION CLIENT ON *.* TO \u0027\u0027${DB_MARIABACKUP_USER}\u0027\u0027@\u0027\u0027localhost\u0027\u0027;\"\u0027"},{"line_number":282,"context_line":"                  - - \u0027mysql -uroot -p\"${DB_ROOT_PASSWORD}\" -e \"CREATE USER \u0027\u0027clustercheck\u0027\u0027@\u0027\u0027localhost\u0027\u0027 IDENTIFIED BY \u0027\u0027${DB_CLUSTERCHECK_PASSWORD}\u0027\u0027;\"\u0027"},{"line_number":283,"context_line":"                    - \u0027mysql -uroot -p\"${DB_ROOT_PASSWORD}\" -e \"GRANT PROCESS ON *.* TO \u0027\u0027clustercheck\u0027\u0027@\u0027\u0027localhost\u0027\u0027 WITH GRANT OPTION;\"\u0027"},{"line_number":284,"context_line":"                    - \u0027mysql -uroot -p\"${DB_ROOT_PASSWORD}\" -e \"DELETE FROM mysql.user WHERE user \u003d \u0027\u0027root\u0027\u0027 AND host NOT IN (\u0027\u0027%\u0027\u0027,\u0027\u0027localhost\u0027\u0027);\"\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f1fca3cf_9c398046","line":281,"range":{"start_line":277,"start_character":149,"end_line":281,"end_character":174},"in_reply_to":"3dc118c2_3911feee","updated":"2022-06-20 12:15:58.000000000","message":"Maybe to make the replication work before we create the users in mysql ?","commit_id":"1b29097e50e0bbac69cafcbb62bc3bcdfa298dcb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9eff79f35f7af8f72f25698aceac13c727715833","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                    - \u0027sudo -u mysql -E kolla_extend_start\u0027"},{"line_number":275,"context_line":"                    - \u0027timeout ${DB_MAX_TIMEOUT} /bin/bash -c \u0027\u0027while pgrep -af /usr/bin/mysqld_safe | grep -q -v grep; do sleep 1; done\u0027\u0027\u0027"},{"line_number":276,"context_line":"                    - \u0027mysqld_safe --skip-networking --wsrep-on\u003dOFF \u0026\u0027"},{"line_number":277,"context_line":"                    - \u0027timeout ${DB_MAX_TIMEOUT} /bin/bash -c \u0027\u0027until mysqladmin -uroot -p\"${DB_ROOT_PASSWORD}\" ping 2\u003e/dev/null; do sleep 1; done\u0027\u0027\u0027"},{"line_number":278,"context_line":"                  - if:"},{"line_number":279,"context_line":"                    - {equals: [{get_param: MysqlGaleraSSTMethod}, \u0027mariabackup\u0027]}"},{"line_number":280,"context_line":"                    - - \u0027mysql -uroot -p\"${DB_ROOT_PASSWORD}\" -e \"CREATE USER \u0027\u0027${DB_MARIABACKUP_USER}\u0027\u0027@\u0027\u0027localhost\u0027\u0027 IDENTIFIED BY \u0027\u0027${DB_MARIABACKUP_PASSWORD}\u0027\u0027;\"\u0027"},{"line_number":281,"context_line":"                      - \u0027mysql -uroot -p\"${DB_ROOT_PASSWORD}\" -e \"GRANT RELOAD, PROCESS, LOCK TABLES, REPLICATION CLIENT ON *.* TO \u0027\u0027${DB_MARIABACKUP_USER}\u0027\u0027@\u0027\u0027localhost\u0027\u0027;\"\u0027"},{"line_number":282,"context_line":"                  - - \u0027mysql -uroot -p\"${DB_ROOT_PASSWORD}\" -e \"CREATE USER \u0027\u0027clustercheck\u0027\u0027@\u0027\u0027localhost\u0027\u0027 IDENTIFIED BY \u0027\u0027${DB_CLUSTERCHECK_PASSWORD}\u0027\u0027;\"\u0027"},{"line_number":283,"context_line":"                    - \u0027mysql -uroot -p\"${DB_ROOT_PASSWORD}\" -e \"GRANT PROCESS ON *.* TO \u0027\u0027clustercheck\u0027\u0027@\u0027\u0027localhost\u0027\u0027 WITH GRANT OPTION;\"\u0027"},{"line_number":284,"context_line":"                    - \u0027mysql -uroot -p\"${DB_ROOT_PASSWORD}\" -e \"DELETE FROM mysql.user WHERE user \u003d \u0027\u0027root\u0027\u0027 AND host NOT IN (\u0027\u0027%\u0027\u0027,\u0027\u0027localhost\u0027\u0027);\"\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"273bb520_8c685445","line":281,"range":{"start_line":277,"start_character":149,"end_line":281,"end_character":174},"in_reply_to":"45643b5b_a14882c3","updated":"2022-06-20 12:30:36.000000000","message":"Ack. Thanks for clarification. I understand the intention and am good with that. We can make required changes once we test the implementation.","commit_id":"1b29097e50e0bbac69cafcbb62bc3bcdfa298dcb"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"535626a0f81dab6b65782b8f37eb240223406186","unresolved":true,"context_lines":[{"line_number":274,"context_line":"                    - \u0027sudo -u mysql -E kolla_extend_start\u0027"},{"line_number":275,"context_line":"                    - \u0027timeout ${DB_MAX_TIMEOUT} /bin/bash -c \u0027\u0027while pgrep -af /usr/bin/mysqld_safe | grep -q -v grep; do sleep 1; done\u0027\u0027\u0027"},{"line_number":276,"context_line":"                    - \u0027mysqld_safe --skip-networking --wsrep-on\u003dOFF \u0026\u0027"},{"line_number":277,"context_line":"                    - \u0027timeout ${DB_MAX_TIMEOUT} /bin/bash -c \u0027\u0027until mysqladmin -uroot -p\"${DB_ROOT_PASSWORD}\" ping 2\u003e/dev/null; do sleep 1; done\u0027\u0027\u0027"},{"line_number":278,"context_line":"                  - if:"},{"line_number":279,"context_line":"                    - {equals: [{get_param: MysqlGaleraSSTMethod}, \u0027mariabackup\u0027]}"},{"line_number":280,"context_line":"                    - - \u0027mysql -uroot -p\"${DB_ROOT_PASSWORD}\" -e \"CREATE USER \u0027\u0027${DB_MARIABACKUP_USER}\u0027\u0027@\u0027\u0027localhost\u0027\u0027 IDENTIFIED BY \u0027\u0027${DB_MARIABACKUP_PASSWORD}\u0027\u0027;\"\u0027"},{"line_number":281,"context_line":"                      - \u0027mysql -uroot -p\"${DB_ROOT_PASSWORD}\" -e \"GRANT RELOAD, PROCESS, LOCK TABLES, REPLICATION CLIENT ON *.* TO \u0027\u0027${DB_MARIABACKUP_USER}\u0027\u0027@\u0027\u0027localhost\u0027\u0027;\"\u0027"},{"line_number":282,"context_line":"                  - - \u0027mysql -uroot -p\"${DB_ROOT_PASSWORD}\" -e \"CREATE USER \u0027\u0027clustercheck\u0027\u0027@\u0027\u0027localhost\u0027\u0027 IDENTIFIED BY \u0027\u0027${DB_CLUSTERCHECK_PASSWORD}\u0027\u0027;\"\u0027"},{"line_number":283,"context_line":"                    - \u0027mysql -uroot -p\"${DB_ROOT_PASSWORD}\" -e \"GRANT PROCESS ON *.* TO \u0027\u0027clustercheck\u0027\u0027@\u0027\u0027localhost\u0027\u0027 WITH GRANT OPTION;\"\u0027"},{"line_number":284,"context_line":"                    - \u0027mysql -uroot -p\"${DB_ROOT_PASSWORD}\" -e \"DELETE FROM mysql.user WHERE user \u003d \u0027\u0027root\u0027\u0027 AND host NOT IN (\u0027\u0027%\u0027\u0027,\u0027\u0027localhost\u0027\u0027);\"\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"45643b5b_a14882c3","line":281,"range":{"start_line":277,"start_character":149,"end_line":281,"end_character":174},"in_reply_to":"f1fca3cf_9c398046","updated":"2022-06-20 12:23:43.000000000","message":"Yes exactly. The minute a second replica of mysql/galera is being started, it will request a full DB synchronization with this mariabackup user credentials. So prior to sync, the user has to exist in the DB or the very first connection to the galera cluster won\u0027t work.\nRight now I don\u0027t see a very nice way of ensuring that a mariabacup exists in the DB when mariadb is being configured in the galera config. So the only safe place to create it was prior to any use of galera (i.e. during DB creation).","commit_id":"1b29097e50e0bbac69cafcbb62bc3bcdfa298dcb"}],"releasenotes/notes/galera-sst-mariabackup-5a667eed1787353f.yaml":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"401ea9ff577c1a4497acfaee242b5e6de625541b","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When deploying a new HA overcloud, the mysql/galera service can now be"},{"line_number":5,"context_line":"    configured to use mariabackup for State Snapshot Transfers (SST)."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    The new support for mariabackup SST for the mysql/galera service is"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"728a46ea_6115c1ed","line":5,"updated":"2022-05-30 22:59:12.000000000","message":"Looks good. Do you think it\u0027s worth mentioning the 3 new THT parameters that are added by this change? If it\u0027s in the release note, it might make it easier for users to understand how they can leverage this feature.\n\nI\u0027m easy either way though. Just leaving it as a suggestion for you.","commit_id":"32bb1728c310bf301de3e9f1b15787381ccf81ab"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"7e91924fa41bbcf62a68b8759f4c9b0f7bed3406","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When deploying a new HA overcloud, the mysql/galera service can now be"},{"line_number":5,"context_line":"    configured to use mariabackup for State Snapshot Transfers (SST)."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    The new support for mariabackup SST for the mysql/galera service is"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"686453fc_4e348e61","line":5,"in_reply_to":"728a46ea_6115c1ed","updated":"2022-05-31 11:31:31.000000000","message":"Good idea, I\u0027m adding that at once.\nThanks for the review","commit_id":"32bb1728c310bf301de3e9f1b15787381ccf81ab"}]}