)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c30c7bcc3e76af247060874af326c71bfcf9fd4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"04cf8058_e5a634c4","updated":"2022-04-12 11:32:44.000000000","message":"As long as we follow this up with a fix for https://bugs.launchpad.net/tripleo/+bug/1968706 then we can merge this to unblock CI... having this is better than changing the job to non-voting which could introduce more new bugs.","commit_id":"30566528b94f106d93f50aae399e888173d51b1b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"21000d4172111a968dcdfb1f77c28f6728dee519","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"74253496_607230e5","updated":"2022-04-12 05:05:50.000000000","message":"Can we get this merg","commit_id":"30566528b94f106d93f50aae399e888173d51b1b"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"406fa0affe1edca360e99eda2f303e9adbda7ade","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e8105fd8_37d7c4c1","updated":"2022-04-12 12:05:17.000000000","message":"Consensus is reached, let\u0027s merged it.","commit_id":"30566528b94f106d93f50aae399e888173d51b1b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"c9ce12cf59a7fe2fe815960615ae37ec31752009","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3d21d272_49eda941","updated":"2022-04-12 05:31:41.000000000","message":"Testing it here: https://review.opendev.org/c/openstack/tripleo-quickstart/+/837455","commit_id":"30566528b94f106d93f50aae399e888173d51b1b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"75fe5647b4e3cdf9696c316f247fb36ceb1071da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bcc4b460_fe147629","updated":"2022-04-12 04:59:52.000000000","message":"We need this patch to fix https://zuul.opendev.org/t/openstack/builds?job_name\u003dtripleo-ci-centos-9-undercloud-upgrade\u0026project\u003dopenstack/tripleo-quickstart it is a gate blocker.","commit_id":"30566528b94f106d93f50aae399e888173d51b1b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"face31678f0424d2e34aa145797663b8d02b4319","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bb9883a0_ebed4094","updated":"2022-04-07 06:55:51.000000000","message":"recheck \n\nthe pep8 job should be fixed now","commit_id":"30566528b94f106d93f50aae399e888173d51b1b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3fe1f673b445b39d9c1f6aed9311e2e28737460e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a57370cb_b0209a5c","in_reply_to":"04cf8058_e5a634c4","updated":"2022-04-12 11:49:33.000000000","message":"thanks yes I would really prefer not to https://review.opendev.org/c/openstack/tripleo-ci/+/837512/1#message-669c0b8d67e5e373361c3b3d17c79dbbba8562e4","commit_id":"30566528b94f106d93f50aae399e888173d51b1b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"e9c642641e6dc9feded1e157d9103c284b8ae2b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"54352c05_620d6d4b","in_reply_to":"3d21d272_49eda941","updated":"2022-04-12 08:31:38.000000000","message":"Based on my testing https://bugs.launchpad.net/tripleo/+bug/1943938/comments/7, we can merge this fix.","commit_id":"30566528b94f106d93f50aae399e888173d51b1b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"21000d4172111a968dcdfb1f77c28f6728dee519","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"19427d9b_f88cac02","in_reply_to":"bcc4b460_fe147629","updated":"2022-04-12 05:05:50.000000000","message":"Can we get this merged? As a follow up patch, we can address the jesse suggestion.","commit_id":"30566528b94f106d93f50aae399e888173d51b1b"}],"deployment/undercloud/undercloud-upgrade.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d265d8d64126d6e429f056e021567b74a492c549","unresolved":true,"context_lines":[{"line_number":72,"context_line":"          loop: \"{{ dnf_module_list|list }}\""},{"line_number":73,"context_line":"          when:"},{"line_number":74,"context_line":"            - step|int \u003d\u003d 0"},{"line_number":75,"context_line":"            - ansible_facts[\u0027distribution_major_version\u0027] is version(\u00278\u0027, \u0027\u003d\u003d\u0027)"},{"line_number":76,"context_line":"            - dnf_module_list|length \u003e 0"},{"line_number":77,"context_line":"        - name: migrate existing introspection data"},{"line_number":78,"context_line":"          shell: \u003e"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"92ad2973_7f5734d1","line":75,"range":{"start_line":75,"start_character":69,"end_line":75,"end_character":72},"updated":"2022-04-08 10:10:32.000000000","message":"In fact, given that we are going to need to support both RHEL8 \u0026 RHEL9 for updates \u0026 upgrades... we\u0027ll likely need to change this to a variable. Perhaps something like this should be done to define the variable:\n\n  DnfStreams: [{\u0027module\u0027:\u0027container-tools\u0027, \u0027stream\u0027:\u00273.0\u0027, \u0027version\u0027:\u00278\u0027}]","commit_id":"30566528b94f106d93f50aae399e888173d51b1b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b6562d90c95aad61541f37c2ea6d8c06f5d6250a","unresolved":true,"context_lines":[{"line_number":72,"context_line":"          loop: \"{{ dnf_module_list|list }}\""},{"line_number":73,"context_line":"          when:"},{"line_number":74,"context_line":"            - step|int \u003d\u003d 0"},{"line_number":75,"context_line":"            - ansible_facts[\u0027distribution_major_version\u0027] is version(\u00278\u0027, \u0027\u003d\u003d\u0027)"},{"line_number":76,"context_line":"            - dnf_module_list|length \u003e 0"},{"line_number":77,"context_line":"        - name: migrate existing introspection data"},{"line_number":78,"context_line":"          shell: \u003e"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"78010eab_7f4a6667","line":75,"updated":"2022-04-08 10:07:01.000000000","message":"This is actually not the right thing to do. Configuring DNFStreams is a perfectly valid thing to do for any versions of RHEL.\n\nWhat we should be doing is removing https://opendev.org/openstack/tripleo-heat-templates/src/commit/ae176c791f80bcd0c7f2d83e1a585bd041813941/environments/lifecycle/update-prepare.yaml#L10 to solve this problem.","commit_id":"30566528b94f106d93f50aae399e888173d51b1b"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"28df47e2cc50e484728c997c479714069c48fb66","unresolved":false,"context_lines":[{"line_number":72,"context_line":"          loop: \"{{ dnf_module_list|list }}\""},{"line_number":73,"context_line":"          when:"},{"line_number":74,"context_line":"            - step|int \u003d\u003d 0"},{"line_number":75,"context_line":"            - ansible_facts[\u0027distribution_major_version\u0027] is version(\u00278\u0027, \u0027\u003d\u003d\u0027)"},{"line_number":76,"context_line":"            - dnf_module_list|length \u003e 0"},{"line_number":77,"context_line":"        - name: migrate existing introspection data"},{"line_number":78,"context_line":"          shell: \u003e"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f4673f23_c98de2d0","line":75,"range":{"start_line":75,"start_character":69,"end_line":75,"end_character":72},"in_reply_to":"75197de0_acc7fdb0","updated":"2022-04-12 11:01:07.000000000","message":"Ack","commit_id":"30566528b94f106d93f50aae399e888173d51b1b"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"73a766c1e548802f9fa2efba136778f240d52f8a","unresolved":true,"context_lines":[{"line_number":72,"context_line":"          loop: \"{{ dnf_module_list|list }}\""},{"line_number":73,"context_line":"          when:"},{"line_number":74,"context_line":"            - step|int \u003d\u003d 0"},{"line_number":75,"context_line":"            - ansible_facts[\u0027distribution_major_version\u0027] is version(\u00278\u0027, \u0027\u003d\u003d\u0027)"},{"line_number":76,"context_line":"            - dnf_module_list|length \u003e 0"},{"line_number":77,"context_line":"        - name: migrate existing introspection data"},{"line_number":78,"context_line":"          shell: \u003e"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2a495270_c59c34b6","line":75,"in_reply_to":"78010eab_7f4a6667","updated":"2022-04-12 08:50:34.000000000","message":"in cs9, the container-tools module is going away https://opendev.org/openstack/tripleo-common/commit/9c479d280bc4d4ca0084343ccdba01493dde2324","commit_id":"30566528b94f106d93f50aae399e888173d51b1b"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"c42eba7bef42b934cd847af04a837bd02a3eb243","unresolved":true,"context_lines":[{"line_number":72,"context_line":"          loop: \"{{ dnf_module_list|list }}\""},{"line_number":73,"context_line":"          when:"},{"line_number":74,"context_line":"            - step|int \u003d\u003d 0"},{"line_number":75,"context_line":"            - ansible_facts[\u0027distribution_major_version\u0027] is version(\u00278\u0027, \u0027\u003d\u003d\u0027)"},{"line_number":76,"context_line":"            - dnf_module_list|length \u003e 0"},{"line_number":77,"context_line":"        - name: migrate existing introspection data"},{"line_number":78,"context_line":"          shell: \u003e"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b0792ba4_86678be8","line":75,"range":{"start_line":75,"start_character":69,"end_line":75,"end_character":72},"in_reply_to":"92ad2973_7f5734d1","updated":"2022-04-12 10:16:35.000000000","message":"Agreed with previous solution, adding \"\u0027version\u0027: \u00278\u0027\" to the hash def in https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/environments/lifecycle/update-prepare.yaml and a test like:\n\n\n- hosts: localhost\n  gather_facts: false\n  tasks:\n    - name: test\n      vars:\n        testv1: [{\u0027name\u0027: \u0027foo\u0027, \u0027version\u0027: \u00278\u0027}, {\u0027name\u0027: \u0027bar\u0027}, {\u0027name\u0027:\u0027bazz\u0027, \u0027version\u0027: \u00279\u0027}]\n      loop: \"{{ testv1|list }}\"\n      when:\n        - item.version is defined and item.version is version(\u00278\u0027, \u0027\u003d\u003d\u0027)\n      shell: \u0027echo YEAH\u0027\n\n\nTested\n\nTASK [test] *******************************************************************************************************************************************************************************************************************************************************************************\nchanged: [localhost] \u003d\u003e (item\u003d{\u0027name\u0027: \u0027foo\u0027, \u0027version\u0027: \u00278\u0027})\nskipping: [localhost] \u003d\u003e (item\u003d{\u0027name\u0027: \u0027bar\u0027})\nskipping: [localhost] \u003d\u003e (item\u003d{\u0027name\u0027: \u0027bazz\u0027, \u0027version\u0027: \u00279\u0027})","commit_id":"30566528b94f106d93f50aae399e888173d51b1b"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"8fd2862d692aecfb3c4ccd4eb3c51054070d8922","unresolved":true,"context_lines":[{"line_number":72,"context_line":"          loop: \"{{ dnf_module_list|list }}\""},{"line_number":73,"context_line":"          when:"},{"line_number":74,"context_line":"            - step|int \u003d\u003d 0"},{"line_number":75,"context_line":"            - ansible_facts[\u0027distribution_major_version\u0027] is version(\u00278\u0027, \u0027\u003d\u003d\u0027)"},{"line_number":76,"context_line":"            - dnf_module_list|length \u003e 0"},{"line_number":77,"context_line":"        - name: migrate existing introspection data"},{"line_number":78,"context_line":"          shell: \u003e"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"75197de0_acc7fdb0","line":75,"range":{"start_line":75,"start_character":69,"end_line":75,"end_character":72},"in_reply_to":"b0792ba4_86678be8","updated":"2022-04-12 11:00:02.000000000","message":"Oh nice test and suggestions, thank you. However, to unblock CI can we agree to merge it as it is and implement it in next change? \nBug for the next change is created here: https://bugs.launchpad.net/tripleo/+bug/1968706","commit_id":"30566528b94f106d93f50aae399e888173d51b1b"}]}