)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d8c44a81e373268f5a2225abd313d81c263bb7a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"16939927_ff50aae0","updated":"2022-04-13 13:11:13.000000000","message":"I\u0027m afraid this change is not backwards compatible with existing users templates/parameters in it","commit_id":"96a28f82b567ca10e3527139c9d3439dd05abe3e"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"300ac0461efa85bfb8d361c47dd02ed314e5f089","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d7e8362e_5efe70c7","updated":"2022-04-14 08:23:17.000000000","message":"Thanks for fixing my original change.","commit_id":"96a28f82b567ca10e3527139c9d3439dd05abe3e"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"1533b2ed88e0165e85195a32df8127dee0db01c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ea8bb3f0_d3f9ee03","updated":"2022-04-18 12:44:45.000000000","message":"can we abandon this one in favor of your other patch? https://review.opendev.org/c/openstack/tripleo-heat-templates/+/837638","commit_id":"96a28f82b567ca10e3527139c9d3439dd05abe3e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"095459440a06b3920e49534cfd6eeb26be9552a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"407ebec7_9f99931c","updated":"2022-04-13 13:12:22.000000000","message":"nevermind, https://review.opendev.org/c/openstack/tripleo-heat-templates/+/832216 has yet to be released :)","commit_id":"96a28f82b567ca10e3527139c9d3439dd05abe3e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3bc0154d9a9eb62bc2bc499a5def309445556d39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"57ee765a_ad7657c0","updated":"2022-04-13 11:47:39.000000000","message":"recheck","commit_id":"96a28f82b567ca10e3527139c9d3439dd05abe3e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c5547a9d47da43451287f1adf4eebff17e69075a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"61b50be5_7fd10cb1","updated":"2022-04-14 09:04:26.000000000","message":"recheck","commit_id":"96a28f82b567ca10e3527139c9d3439dd05abe3e"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"d2c6dc96b6944dbf1ca2f5c2feb2522b2636451a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"668d0681_957a1e64","updated":"2022-04-22 09:50:41.000000000","message":"recheck failed because \"Lost connection to MySQL server during query\". I think it makes sense to squash both changes BTW.","commit_id":"96a28f82b567ca10e3527139c9d3439dd05abe3e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"20842d4c5c66a1e6ead0bd75b969c196a7acbce0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"62abd333_813e8bb8","in_reply_to":"16939927_ff50aae0","updated":"2022-04-13 13:32:26.000000000","message":"This is backword compatible. If user put a single colon-seprated string then the value is recognized as a list with that single long string and the string value is put in octavia.conf","commit_id":"96a28f82b567ca10e3527139c9d3439dd05abe3e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d7698f8b4eb45a74af97b6a5b4f8d20e88ce1e2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"128f7548_c2088b32","in_reply_to":"62abd333_813e8bb8","updated":"2022-04-13 13:34:23.000000000","message":"I mean, this can support both\n\n```\nparameter_defaults:\n  OctaviaDefaultListenerCiphers: \u0027a:b:c:d\u0027\n```\n\nand\n\n```\nparameter_defaults:\n  OctaviaDefaultListenerCiphers: [\u0027a\u0027, \u0027b\u0027, \u0027c\u0027, \u0027d\u0027]\n```\n\nFor the first one value is converted to [\u0027a:b:c:d\u0027] and put into octavia.conf as \u0027a:b:c:d\u0027 which is same as the current implementation.\nThe change is to add support for the 2nd format.","commit_id":"96a28f82b567ca10e3527139c9d3439dd05abe3e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1e577831e7961c1ddf99198c426bc0c15cf43d36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c24d0cd3_6aed7bf6","in_reply_to":"d8dfdec8_f672a549","updated":"2022-04-22 15:33:21.000000000","message":"after giving another thought, I pulled that change into this, because we got some positive feedback about the 2nd one thus making 2 steps change would be redundant.","commit_id":"96a28f82b567ca10e3527139c9d3439dd05abe3e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1ad9b364bf07e2490d48a6328decd47b746f9c49","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d8dfdec8_f672a549","in_reply_to":"ea8bb3f0_d3f9ee03","updated":"2022-04-18 13:30:57.000000000","message":"That one is currently separate and is dependent of this one. If merging these two is preferred then I\u0027ll squash that change into this one.","commit_id":"96a28f82b567ca10e3527139c9d3439dd05abe3e"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"9afa576ba80ce598e8ede7c76aa8dc919d15cdec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4a0fb3d4_1f0b0f6a","updated":"2022-05-02 11:52:43.000000000","message":"recheck DNS issue should be fixed now","commit_id":"fef8dacd9fc394f01df5a2a202938f672bbd43ef"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"64297c5f0e3ac7bd4d01031fe0634fe75de80e12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"658d1c47_f03cf1c9","updated":"2022-05-02 19:51:39.000000000","message":"these parameters were originally added in wallaby, so as long as we also backport this change to wallaby, this won\u0027t be considered a parameter interface breakage.","commit_id":"fef8dacd9fc394f01df5a2a202938f672bbd43ef"}],"deployment/octavia/octavia-api-container-puppet.yaml":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"3394d88fb62a0c005a8b274694130c46bcba03c2","unresolved":true,"context_lines":[{"line_number":90,"context_line":"    description: Number of workers for Octavia service."},{"line_number":91,"context_line":"    type: number"},{"line_number":92,"context_line":"  OctaviaDefaultListenerCiphers:"},{"line_number":93,"context_line":"    type: commma_separated_list"},{"line_number":94,"context_line":"    default:"},{"line_number":95,"context_line":"      - TLS_AES_256_GCM_SHA384"},{"line_number":96,"context_line":"      - TLS_CHACHA20_POLY1305_SHA256"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"98040677_3d395f11","line":93,"range":{"start_line":93,"start_character":10,"end_line":93,"end_character":31},"updated":"2022-04-12 15:37:51.000000000","message":"typo: 3 m. Shouldn\u0027t it be comma_DELIMITED_list?","commit_id":"d6bab7356e0b4a897c219a3b2f7342d50f1ea7cc"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"04ed614b5f78cf277d987512d0942402c9f9f928","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    description: Number of workers for Octavia service."},{"line_number":91,"context_line":"    type: number"},{"line_number":92,"context_line":"  OctaviaDefaultListenerCiphers:"},{"line_number":93,"context_line":"    type: commma_separated_list"},{"line_number":94,"context_line":"    default:"},{"line_number":95,"context_line":"      - TLS_AES_256_GCM_SHA384"},{"line_number":96,"context_line":"      - TLS_CHACHA20_POLY1305_SHA256"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a2ef9c9c_74dd0e26","line":93,"range":{"start_line":93,"start_character":10,"end_line":93,"end_character":31},"in_reply_to":"98040677_3d395f11","updated":"2022-04-12 16:03:24.000000000","message":":facepalm: I was confused by something else...","commit_id":"d6bab7356e0b4a897c219a3b2f7342d50f1ea7cc"}]}