)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"2c9ed83329c212574964ba600e968669957bfc5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2ab177ea_9b1d3a63","updated":"2022-04-19 15:20:08.000000000","message":"Great catch!","commit_id":"bef88f034bc765e7f5b15d40ac83faa4f304d867"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"7a73c102260220c8f8873aa2d2679e77d14c6a61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b52380eb_fd3a582d","updated":"2022-06-08 10:57:02.000000000","message":"Need to wait for fix of https://bugs.launchpad.net/tripleo/+bug/1977873 to be available in repos.","commit_id":"068ca82a4c99269ff7b43441d040ebe6c379d6d5"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"0304a819055ab0371e5b26d08c29e511003662dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d10cb62a_de7d65c7","updated":"2022-06-08 07:59:09.000000000","message":"https://review.opendev.org/c/openstack/tripleo-heat-templates/+/844960","commit_id":"068ca82a4c99269ff7b43441d040ebe6c379d6d5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"440baa4c8d268e45083505fb72cac9d1c4d7d467","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"15948a5e_6cd04f88","updated":"2022-06-06 13:15:37.000000000","message":"recheck","commit_id":"068ca82a4c99269ff7b43441d040ebe6c379d6d5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"d2ef169ff53522033edb1d8b2240ac8f0cb838c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6dfcbfb9_43618150","updated":"2022-06-09 12:47:46.000000000","message":"recheck workaround https://review.opendev.org/c/openstack/tripleo-quickstart/+/845229 merged","commit_id":"068ca82a4c99269ff7b43441d040ebe6c379d6d5"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"21dae4299e542c75acb4c71af524e588d9a505b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"26c31b37_4bef60f8","updated":"2022-06-08 07:32:28.000000000","message":"the NeutronEnableDVR should be a boolean in the end.\nThe whole thing is a bit complicated to read, with the conditions and all. In the end, if NeutronEnableDVR is \"\", then it defaults to true... Which is weird. A follow-up should really migrate that param to a boolean, to make things easier to read imho.","commit_id":"068ca82a4c99269ff7b43441d040ebe6c379d6d5"}],"deployment/neutron/neutron-plugin-ml2-ovn.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"0dd47f5007b40e09f6c55db529d92fad181eb9e7","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    default: 38"},{"line_number":55,"context_line":"  NeutronEnableDVR:"},{"line_number":56,"context_line":"    description: Enable Neutron DVR."},{"line_number":57,"context_line":"    default: \u0027\u0027"},{"line_number":58,"context_line":"    type: string"},{"line_number":59,"context_line":"  NeutronEnableIgmpSnooping:"},{"line_number":60,"context_line":"    description: Enable IGMP Snooping."},{"line_number":61,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"13e826eb_b1111b8c","line":58,"range":{"start_line":57,"start_character":1,"end_line":58,"end_character":16},"updated":"2022-06-06 08:06:17.000000000","message":"If the default is expected to be true, let\u0027s change the parameter to boolean. It won\u0027t break existing usage.\n\ntype: boolean\ndefault: true","commit_id":"bdfcf56dfeda8a883a76104b9bb2f162cc95c211"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"9f4ad2f8a464ba68395f0316ec5bf5305f1eaae9","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    default: 38"},{"line_number":55,"context_line":"  NeutronEnableDVR:"},{"line_number":56,"context_line":"    description: Enable Neutron DVR."},{"line_number":57,"context_line":"    default: \u0027\u0027"},{"line_number":58,"context_line":"    type: string"},{"line_number":59,"context_line":"  NeutronEnableIgmpSnooping:"},{"line_number":60,"context_line":"    description: Enable IGMP Snooping."},{"line_number":61,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"184730d1_79539b45","line":58,"range":{"start_line":57,"start_character":1,"end_line":58,"end_character":16},"in_reply_to":"13e826eb_b1111b8c","updated":"2022-06-06 08:11:05.000000000","message":"@rabi but we need it only for ml2 ovn, at other places like neutron-api and ml2-ovs we don\u0027t want to change like the original patch. So instead of changing default and impact other plugins, i did this change just of ml2 ovn, if no override is passed, consider default as dvr enabled for ml2 ovn else consider the override.","commit_id":"bdfcf56dfeda8a883a76104b9bb2f162cc95c211"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"fc49c00e9d0621ba1210448ac66ebb82abdf989c","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    default: 38"},{"line_number":55,"context_line":"  NeutronEnableDVR:"},{"line_number":56,"context_line":"    description: Enable Neutron DVR."},{"line_number":57,"context_line":"    default: \u0027\u0027"},{"line_number":58,"context_line":"    type: string"},{"line_number":59,"context_line":"  NeutronEnableIgmpSnooping:"},{"line_number":60,"context_line":"    description: Enable IGMP Snooping."},{"line_number":61,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bb0964f1_658a095a","line":58,"range":{"start_line":57,"start_character":1,"end_line":58,"end_character":16},"in_reply_to":"184730d1_79539b45","updated":"2022-06-06 08:23:41.000000000","message":"This should ideally be boolean at all places. We can change it later though.\n\nKeep the condition as before.\n\n  neutron_dvr_set:\n    not: {equals : [{get_param: NeutronEnableDVR}, \u0027\u0027]}\n\n\n...\nneutron::plugins::ml2::ovn::dvr_enabled:\n  if:\n    - neutron_dvr_set\n    - {get_param: NeutronEnableDVR}\n    - true","commit_id":"bdfcf56dfeda8a883a76104b9bb2f162cc95c211"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"b79dc0541149c9d7bc68863f8fa3bbc9f52fc442","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    default: 38"},{"line_number":55,"context_line":"  NeutronEnableDVR:"},{"line_number":56,"context_line":"    description: Enable Neutron DVR."},{"line_number":57,"context_line":"    default: \u0027\u0027"},{"line_number":58,"context_line":"    type: string"},{"line_number":59,"context_line":"  NeutronEnableIgmpSnooping:"},{"line_number":60,"context_line":"    description: Enable IGMP Snooping."},{"line_number":61,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e363ca68_71b7e6f4","line":58,"range":{"start_line":57,"start_character":1,"end_line":58,"end_character":16},"in_reply_to":"885cd672_7910c438","updated":"2022-06-06 08:31:12.000000000","message":"Done","commit_id":"bdfcf56dfeda8a883a76104b9bb2f162cc95c211"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"d23c64b5a24f1988fe586137bd666f721cebe859","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    default: 38"},{"line_number":55,"context_line":"  NeutronEnableDVR:"},{"line_number":56,"context_line":"    description: Enable Neutron DVR."},{"line_number":57,"context_line":"    default: \u0027\u0027"},{"line_number":58,"context_line":"    type: string"},{"line_number":59,"context_line":"  NeutronEnableIgmpSnooping:"},{"line_number":60,"context_line":"    description: Enable IGMP Snooping."},{"line_number":61,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"885cd672_7910c438","line":58,"range":{"start_line":57,"start_character":1,"end_line":58,"end_character":16},"in_reply_to":"bb0964f1_658a095a","updated":"2022-06-06 08:27:46.000000000","message":"This sounds good, will update.","commit_id":"bdfcf56dfeda8a883a76104b9bb2f162cc95c211"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"0dd47f5007b40e09f6c55db529d92fad181eb9e7","unresolved":true,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"conditions:"},{"line_number":113,"context_line":"  neutron_dvr_set: {equals : [{get_param: NeutronEnableDVR}, \u0027\u0027]}"},{"line_number":114,"context_line":"  internal_tls_enabled: {equals: [{get_param: EnableInternalTLS}, true]}"},{"line_number":115,"context_line":"  vhostuser_dir_set:"},{"line_number":116,"context_line":"    or:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"14e61394_3d1faecc","line":113,"range":{"start_line":113,"start_character":2,"end_line":113,"end_character":65},"updated":"2022-06-06 08:06:17.000000000","message":"This condition means user has provided the parameter and is not correct with the change.\n\nAfter changing the type to boolean you can drop this.","commit_id":"bdfcf56dfeda8a883a76104b9bb2f162cc95c211"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"0dd47f5007b40e09f6c55db529d92fad181eb9e7","unresolved":true,"context_lines":[{"line_number":146,"context_line":"            neutron::plugins::ml2::max_header_size: {get_param: NeutronGeneveMaxHeaderSize}"},{"line_number":147,"context_line":"            neutron::plugins::ml2::ovn::dns_servers: {get_param: OVNDnsServers}"},{"line_number":148,"context_line":"            neutron::plugins::ml2::ovn::ovn_emit_need_to_frag: {get_param: OVNEmitNeedToFrag}"},{"line_number":149,"context_line":"            neutron::plugins::ml2::ovn::dvr_enabled:"},{"line_number":150,"context_line":"              if:"},{"line_number":151,"context_line":"                - neutron_dvr_set"},{"line_number":152,"context_line":"                - true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"717f9e88_1a0f75d5","line":149,"range":{"start_line":149,"start_character":12,"end_line":149,"end_character":52},"updated":"2022-06-06 08:06:17.000000000","message":"neutron::plugins::ml2::ovn::dvr_enabled: {get_param: NeutronEnableDVR}","commit_id":"bdfcf56dfeda8a883a76104b9bb2f162cc95c211"}]}