)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"4755424b5436785589215f0cd4754e71f29e386f","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Use update_tasks from tripleo-ansible standalone"},{"line_number":10,"context_line":"role for tripleo_packages."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/c/openstack/tripleo-ansible/+/838604"},{"line_number":13,"context_line":"Change-Id: I0171368eec49abcc602ee225b868afea76721ea0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"137cc2d6_d4d424a1","line":12,"updated":"2022-08-01 17:25:44.000000000","message":"Missing \n\nDepends-On: https://review.opendev.org/c/openstack/tripleo-ansible/+/851694\n\nso that we don\u0027t hit:\n\n2022-08-01 07:40:02 | 2022-08-01 07:40:02.724868 | fa163e7f-e215-7043-9fc0-0000000003c2 |      FATAL | Ensure DNF modules have the right stream enabled | centos-9-stream-iweb-mtl01-0030586801 | item\u003d{\u0027distribution_version\u0027: \u00278\u0027, \u0027module\u0027: \u0027container-tools\u0027, \u0027stream\u0027: \u00273.0\u0027} | error\u003d{\"ansible_loop_var\": \"item\", \"changed\": false, \"failures\": [\"Module container-tools:3.0 is not available in the system.\"], \"item\": {\"distribution_version\": \"8\", \"module\": \"container-tools\", \"stream\": \"3.0\"}, \"msg\": \"Failed to manage some of the specified modules\", \"rc\": 1, \"results\": []}\n2022-08-01 07:40:02 | 2022-08-01 07:40:02.726641 | fa163e7f-e215-7043-9fc0-0000000003c2 |     TIMING | tripleo_packages : Ensu\n\nin the ci[1]\n\n[1] there https://144f783808989e954549-eba87e8a2634bc40bbd03f7dd3d1d142.ssl.cf1.rackcdn.com/838605/6/check/tripleo-ci-centos-9-scenario000-multinode-oooq-container-updates/1daa1b3/logs/undercloud/home/zuul/overcloud_update_run-Controller.log","commit_id":"2b58f0c4706283490e7d72aa59f1534a55889f13"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"d458c2632d9f2597e66da3e1ee427b058fc057ec","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Use update_tasks from tripleo-ansible standalone"},{"line_number":10,"context_line":"role for tripleo_packages."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/c/openstack/tripleo-ansible/+/838604"},{"line_number":13,"context_line":"Change-Id: I0171368eec49abcc602ee225b868afea76721ea0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"96a1a2c9_0068fa61","line":12,"in_reply_to":"137cc2d6_d4d424a1","updated":"2022-09-28 02:51:12.000000000","message":"Done","commit_id":"2b58f0c4706283490e7d72aa59f1534a55889f13"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"529873bc30e4199cdb2fbccfdabb8a706cdc0b63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6b6f59cb_7a9a80fd","updated":"2022-04-29 13:04:31.000000000","message":"comment inline, otherwise lgtm","commit_id":"ab0b79119793cddb736289866c366289133a045d"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"e9034a6d15fa9e0c71e57cf4959754f418cef115","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3d18cae7_c23311c8","updated":"2022-05-17 12:32:22.000000000","message":"recheck","commit_id":"ab0b79119793cddb736289866c366289133a045d"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"f65492fed935eae4de28bb406981682ed8e420cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8c313de6_8bcd1c4e","updated":"2022-04-24 04:42:30.000000000","message":"recheck\n","commit_id":"ab0b79119793cddb736289866c366289133a045d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"4755424b5436785589215f0cd4754e71f29e386f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"053ebffe_64238e44","updated":"2022-08-01 17:25:44.000000000","message":"That looks good and way better organization than in the templates. Thanks.\n\n+1 only because of the CI failure, but seems good to go otherwise.","commit_id":"2b58f0c4706283490e7d72aa59f1534a55889f13"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"dfb084746f61de31ad9056fdee4a65506d9e5316","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7187d76b_45995ff3","updated":"2022-08-02 07:31:40.000000000","message":"One question for tht outputs.\n-1 for missing yum.pid check, but can be discarded if it is not required.","commit_id":"e0ee3da792f5e8e2e797b762324822ed433f96be"}],"deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"91b311fc9c0216a1ab9003bcd846fc98115f28a8","unresolved":true,"context_lines":[{"line_number":386,"context_line":"      update_tasks:"},{"line_number":387,"context_line":"        - include_role:"},{"line_number":388,"context_line":"            name: tripleo_packages"},{"line_number":389,"context_line":"            tasks_from: update.yml"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9b5b9f9c_7ed42f7f","line":389,"updated":"2022-04-21 18:03:16.000000000","message":"see my review on the tripleo-ansible path. here is where you add a when:step\u003d\u003d0 or whatever based on including the right tasks file.","commit_id":"463f694a265f58a0d72e2431105955f6613018e4"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"8ba22f5fd9443339d3ac00d68fc64f471508fb3a","unresolved":false,"context_lines":[{"line_number":386,"context_line":"      update_tasks:"},{"line_number":387,"context_line":"        - include_role:"},{"line_number":388,"context_line":"            name: tripleo_packages"},{"line_number":389,"context_line":"            tasks_from: update.yml"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"238a97d8_e49f626a","line":389,"in_reply_to":"9b5b9f9c_7ed42f7f","updated":"2022-04-22 00:05:27.000000000","message":"Done","commit_id":"463f694a265f58a0d72e2431105955f6613018e4"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"8ba22f5fd9443339d3ac00d68fc64f471508fb3a","unresolved":true,"context_lines":[{"line_number":384,"context_line":"                name: tripleo_persist"},{"line_number":385,"context_line":"                tasks_from: cleanup.yml"},{"line_number":386,"context_line":"      update_tasks:"},{"line_number":387,"context_line":"        - name: Check for existing yum.pid"},{"line_number":388,"context_line":"          stat:  path\u003d/run/yum.pid"},{"line_number":389,"context_line":"          register: yum_pid_file"},{"line_number":390,"context_line":"          when: step|int \u003d\u003d 0 or step|int \u003d\u003d 3"},{"line_number":391,"context_line":"        - name: Exit if existing yum process"},{"line_number":392,"context_line":"          fail: msg\u003d\"ERROR existing yum.pid detected - can\u0027t continue! Please ensure there is no other package update process for the duration of the minor update worfklow. Exiting.\""},{"line_number":393,"context_line":"          when: (step|int \u003d\u003d 0 or step|int \u003d\u003d 3) and yum_pid_file.stat.exists"},{"line_number":394,"context_line":"        - include_role:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4db88478_879f1361","line":391,"range":{"start_line":387,"start_character":0,"end_line":391,"end_character":44},"updated":"2022-04-22 00:05:27.000000000","message":"Maybe this should go into each of the tripleo-ansible files before we use dnf to update the packages.\n\nDoes dnf even write this pid file though? Or has this been broken since RHEL / CentOS8?\n\nI\u0027ll check that separately. But maybe this logic should be moved from THT into the relevant tripleo-ansible files.","commit_id":"f0a34b9d2a6306f7ea34897e77ba0c42087f7450"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"1d4f2afef47637957666ae23078232e744fed253","unresolved":false,"context_lines":[{"line_number":384,"context_line":"                name: tripleo_persist"},{"line_number":385,"context_line":"                tasks_from: cleanup.yml"},{"line_number":386,"context_line":"      update_tasks:"},{"line_number":387,"context_line":"        - name: Check for existing yum.pid"},{"line_number":388,"context_line":"          stat:  path\u003d/run/yum.pid"},{"line_number":389,"context_line":"          register: yum_pid_file"},{"line_number":390,"context_line":"          when: step|int \u003d\u003d 0 or step|int \u003d\u003d 3"},{"line_number":391,"context_line":"        - name: Exit if existing yum process"},{"line_number":392,"context_line":"          fail: msg\u003d\"ERROR existing yum.pid detected - can\u0027t continue! Please ensure there is no other package update process for the duration of the minor update worfklow. Exiting.\""},{"line_number":393,"context_line":"          when: (step|int \u003d\u003d 0 or step|int \u003d\u003d 3) and yum_pid_file.stat.exists"},{"line_number":394,"context_line":"        - include_role:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"6b9acdf5_2279eafd","line":391,"range":{"start_line":387,"start_character":0,"end_line":391,"end_character":44},"in_reply_to":"4db88478_879f1361","updated":"2022-04-26 12:06:10.000000000","message":"Done","commit_id":"f0a34b9d2a6306f7ea34897e77ba0c42087f7450"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"529873bc30e4199cdb2fbccfdabb8a706cdc0b63","unresolved":true,"context_lines":[{"line_number":394,"context_line":"          when: step|int \u003d\u003d 2"},{"line_number":395,"context_line":"        - include_role:"},{"line_number":396,"context_line":"            name: tripleo_packages"},{"line_number":397,"context_line":"            tasks_from: update.yml"},{"line_number":398,"context_line":"          when: step|int \u003d\u003d 3"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"2bb80781_6c3924b9","line":397,"updated":"2022-04-29 13:04:31.000000000","message":"missing a when step|int \u003d\u003d 3?","commit_id":"ab0b79119793cddb736289866c366289133a045d"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"127c14b0f8dd37b788cfdb0360f64edbfb91e005","unresolved":true,"context_lines":[{"line_number":394,"context_line":"          when: step|int \u003d\u003d 2"},{"line_number":395,"context_line":"        - include_role:"},{"line_number":396,"context_line":"            name: tripleo_packages"},{"line_number":397,"context_line":"            tasks_from: update.yml"},{"line_number":398,"context_line":"          when: step|int \u003d\u003d 3"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"8cd0ca05_2b0760d0","line":397,"in_reply_to":"2bb80781_6c3924b9","updated":"2022-04-29 21:55:30.000000000","message":"Hey, that when statement is below the line highlighted here? It would apply to this include_role. Is that what you mean?","commit_id":"ab0b79119793cddb736289866c366289133a045d"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"e91c4cc0d105d30b187b82043052a5c41928ce28","unresolved":true,"context_lines":[{"line_number":394,"context_line":"          when: step|int \u003d\u003d 2"},{"line_number":395,"context_line":"        - include_role:"},{"line_number":396,"context_line":"            name: tripleo_packages"},{"line_number":397,"context_line":"            tasks_from: update.yml"},{"line_number":398,"context_line":"          when: step|int \u003d\u003d 3"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d3469e49_df73f9a8","line":397,"in_reply_to":"8cd0ca05_2b0760d0","updated":"2022-05-02 19:29:02.000000000","message":"ah yes, side-by-side diff was throwing me off, as I didn\u0027t see it on the new side. Thanks!","commit_id":"ab0b79119793cddb736289866c366289133a045d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"df5b9223ab96175abfc1f53ca20da300e90010d2","unresolved":false,"context_lines":[{"line_number":394,"context_line":"          when: step|int \u003d\u003d 2"},{"line_number":395,"context_line":"        - include_role:"},{"line_number":396,"context_line":"            name: tripleo_packages"},{"line_number":397,"context_line":"            tasks_from: update.yml"},{"line_number":398,"context_line":"          when: step|int \u003d\u003d 3"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bc836f43_db9abed3","line":397,"in_reply_to":"d3469e49_df73f9a8","updated":"2022-07-15 11:23:40.000000000","message":"Done","commit_id":"ab0b79119793cddb736289866c366289133a045d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"48c03de9274c7e2379ba66c7a50298079f3f1255","unresolved":true,"context_lines":[{"line_number":404,"context_line":"            - step|int \u003d\u003d 0"},{"line_number":405,"context_line":"            - dnf_module_list|length \u003e 0"},{"line_number":406,"context_line":"            - item.distribution_version is defined"},{"line_number":407,"context_line":"            - ansible_facts[\u0027distribution_major_version\u0027] is version(item.distribution_version, \u0027\u003d\u003d\u0027)"},{"line_number":408,"context_line":"        - name: Check for existing yum.pid"},{"line_number":409,"context_line":"          stat:  path\u003d/run/yum.pid"},{"line_number":410,"context_line":"          register: yum_pid_file"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"37e64649_076ab258","side":"PARENT","line":407,"updated":"2022-08-01 08:02:02.000000000","message":"https://opendev.org/openstack/tripleo-ansible/src/commit/4a32ee47f30a24e668868a90c176a79ed9b0ec1d/tripleo_ansible/roles/tripleo_packages/tasks/update_bootstrap.yml is missing the functionality brought in by https://opendev.org/openstack/tripleo-heat-templates/commit/86d4a348a3c0a372154ead6e3db15e6444ffaa88","commit_id":"210a2dac77b260fa0d9fb06f3b0b8ba82a3ab145"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"5a332bedc4484d8b6c9686c0ac2dc6d020edf650","unresolved":true,"context_lines":[{"line_number":404,"context_line":"            - step|int \u003d\u003d 0"},{"line_number":405,"context_line":"            - dnf_module_list|length \u003e 0"},{"line_number":406,"context_line":"            - item.distribution_version is defined"},{"line_number":407,"context_line":"            - ansible_facts[\u0027distribution_major_version\u0027] is version(item.distribution_version, \u0027\u003d\u003d\u0027)"},{"line_number":408,"context_line":"        - name: Check for existing yum.pid"},{"line_number":409,"context_line":"          stat:  path\u003d/run/yum.pid"},{"line_number":410,"context_line":"          register: yum_pid_file"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3b79671c_8a4f6e3a","side":"PARENT","line":407,"in_reply_to":"37e64649_076ab258","updated":"2022-08-01 12:00:57.000000000","message":"Hey, yeah I submitted a patch to add that here:\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/851694\n\nI think that captures it right?","commit_id":"210a2dac77b260fa0d9fb06f3b0b8ba82a3ab145"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"03fd0348cb63252d9d9ae4987b0ea80ef8528ba1","unresolved":false,"context_lines":[{"line_number":404,"context_line":"            - step|int \u003d\u003d 0"},{"line_number":405,"context_line":"            - dnf_module_list|length \u003e 0"},{"line_number":406,"context_line":"            - item.distribution_version is defined"},{"line_number":407,"context_line":"            - ansible_facts[\u0027distribution_major_version\u0027] is version(item.distribution_version, \u0027\u003d\u003d\u0027)"},{"line_number":408,"context_line":"        - name: Check for existing yum.pid"},{"line_number":409,"context_line":"          stat:  path\u003d/run/yum.pid"},{"line_number":410,"context_line":"          register: yum_pid_file"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c96ffbd7_8d0d7360","side":"PARENT","line":407,"in_reply_to":"3b79671c_8a4f6e3a","updated":"2022-08-02 11:19:41.000000000","message":"Done","commit_id":"210a2dac77b260fa0d9fb06f3b0b8ba82a3ab145"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"dfb084746f61de31ad9056fdee4a65506d9e5316","unresolved":true,"context_lines":[{"line_number":405,"context_line":"            - dnf_module_list|length \u003e 0"},{"line_number":406,"context_line":"            - item.distribution_version is defined"},{"line_number":407,"context_line":"            - ansible_facts[\u0027distribution_major_version\u0027] is version(item.distribution_version, \u0027\u003d\u003d\u0027)"},{"line_number":408,"context_line":"        - name: Check for existing yum.pid"},{"line_number":409,"context_line":"          stat:  path\u003d/run/yum.pid"},{"line_number":410,"context_line":"          register: yum_pid_file"},{"line_number":411,"context_line":"          when: step|int \u003d\u003d 0 or step|int \u003d\u003d 3"},{"line_number":412,"context_line":"        - name: Exit if existing yum process"},{"line_number":413,"context_line":"          fail: msg\u003d\"ERROR existing yum.pid detected - can\u0027t continue! Please ensure there is no other package update process for the duration of the minor update worfklow. Exiting.\""},{"line_number":414,"context_line":"          when: (step|int \u003d\u003d 0 or step|int \u003d\u003d 3) and yum_pid_file.stat.exists"},{"line_number":415,"context_line":"        - name: Special treatment for OpenvSwitch"},{"line_number":416,"context_line":"          tripleo_ovs_upgrade:"},{"line_number":417,"context_line":"          when:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f80c8ce_02fb06a4","side":"PARENT","line":414,"range":{"start_line":408,"start_character":0,"end_line":414,"end_character":77},"updated":"2022-08-02 07:31:40.000000000","message":"This check for existing yum.pid seems to be missing in tripleo-ansible in tripleo_packages tasks.\nDo we still need this safeguard to prevent running multiple update process at the same time?","commit_id":"210a2dac77b260fa0d9fb06f3b0b8ba82a3ab145"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"c1b5218174f072273a20df502442cc82493a3d14","unresolved":false,"context_lines":[{"line_number":405,"context_line":"            - dnf_module_list|length \u003e 0"},{"line_number":406,"context_line":"            - item.distribution_version is defined"},{"line_number":407,"context_line":"            - ansible_facts[\u0027distribution_major_version\u0027] is version(item.distribution_version, \u0027\u003d\u003d\u0027)"},{"line_number":408,"context_line":"        - name: Check for existing yum.pid"},{"line_number":409,"context_line":"          stat:  path\u003d/run/yum.pid"},{"line_number":410,"context_line":"          register: yum_pid_file"},{"line_number":411,"context_line":"          when: step|int \u003d\u003d 0 or step|int \u003d\u003d 3"},{"line_number":412,"context_line":"        - name: Exit if existing yum process"},{"line_number":413,"context_line":"          fail: msg\u003d\"ERROR existing yum.pid detected - can\u0027t continue! Please ensure there is no other package update process for the duration of the minor update worfklow. Exiting.\""},{"line_number":414,"context_line":"          when: (step|int \u003d\u003d 0 or step|int \u003d\u003d 3) and yum_pid_file.stat.exists"},{"line_number":415,"context_line":"        - name: Special treatment for OpenvSwitch"},{"line_number":416,"context_line":"          tripleo_ovs_upgrade:"},{"line_number":417,"context_line":"          when:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"e0b97142_6b2cdfc8","side":"PARENT","line":414,"range":{"start_line":408,"start_character":0,"end_line":414,"end_character":77},"in_reply_to":"13cafaee_ecfd83bd","updated":"2022-08-16 11:10:30.000000000","message":"Ok, let\u0027s leave it out for now.","commit_id":"210a2dac77b260fa0d9fb06f3b0b8ba82a3ab145"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"7c122f2847d41ad8601132b9603d9c241d0197af","unresolved":true,"context_lines":[{"line_number":405,"context_line":"            - dnf_module_list|length \u003e 0"},{"line_number":406,"context_line":"            - item.distribution_version is defined"},{"line_number":407,"context_line":"            - ansible_facts[\u0027distribution_major_version\u0027] is version(item.distribution_version, \u0027\u003d\u003d\u0027)"},{"line_number":408,"context_line":"        - name: Check for existing yum.pid"},{"line_number":409,"context_line":"          stat:  path\u003d/run/yum.pid"},{"line_number":410,"context_line":"          register: yum_pid_file"},{"line_number":411,"context_line":"          when: step|int \u003d\u003d 0 or step|int \u003d\u003d 3"},{"line_number":412,"context_line":"        - name: Exit if existing yum process"},{"line_number":413,"context_line":"          fail: msg\u003d\"ERROR existing yum.pid detected - can\u0027t continue! Please ensure there is no other package update process for the duration of the minor update worfklow. Exiting.\""},{"line_number":414,"context_line":"          when: (step|int \u003d\u003d 0 or step|int \u003d\u003d 3) and yum_pid_file.stat.exists"},{"line_number":415,"context_line":"        - name: Special treatment for OpenvSwitch"},{"line_number":416,"context_line":"          tripleo_ovs_upgrade:"},{"line_number":417,"context_line":"          when:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"13cafaee_ecfd83bd","side":"PARENT","line":414,"range":{"start_line":408,"start_character":0,"end_line":414,"end_character":77},"in_reply_to":"429b5ad3_8352a8d1","updated":"2022-08-15 04:21:55.000000000","message":"Yeah, I guess we don\u0027t expect there to be a dnf process running. If we can\u0027t think of why it should exist, I guess let\u0027s leave it out until we have a reason for it to come back?","commit_id":"210a2dac77b260fa0d9fb06f3b0b8ba82a3ab145"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"e4fd3e59f590b7db87ee2879db80d128c8d87d9a","unresolved":true,"context_lines":[{"line_number":405,"context_line":"            - dnf_module_list|length \u003e 0"},{"line_number":406,"context_line":"            - item.distribution_version is defined"},{"line_number":407,"context_line":"            - ansible_facts[\u0027distribution_major_version\u0027] is version(item.distribution_version, \u0027\u003d\u003d\u0027)"},{"line_number":408,"context_line":"        - name: Check for existing yum.pid"},{"line_number":409,"context_line":"          stat:  path\u003d/run/yum.pid"},{"line_number":410,"context_line":"          register: yum_pid_file"},{"line_number":411,"context_line":"          when: step|int \u003d\u003d 0 or step|int \u003d\u003d 3"},{"line_number":412,"context_line":"        - name: Exit if existing yum process"},{"line_number":413,"context_line":"          fail: msg\u003d\"ERROR existing yum.pid detected - can\u0027t continue! Please ensure there is no other package update process for the duration of the minor update worfklow. Exiting.\""},{"line_number":414,"context_line":"          when: (step|int \u003d\u003d 0 or step|int \u003d\u003d 3) and yum_pid_file.stat.exists"},{"line_number":415,"context_line":"        - name: Special treatment for OpenvSwitch"},{"line_number":416,"context_line":"          tripleo_ovs_upgrade:"},{"line_number":417,"context_line":"          when:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"938dc6a3_b2c39d9c","side":"PARENT","line":414,"range":{"start_line":408,"start_character":0,"end_line":414,"end_character":77},"in_reply_to":"7f80c8ce_02fb06a4","updated":"2022-08-02 11:36:07.000000000","message":"So, the alternative here would be that dnf would just wait for the previous PID to finish. I thought that might be preferable rather than just failing.\n\nSome assumptions I made here were:\n1. We don\u0027t expect users to be manually performing updates. Which would limit their actions to quick tasks like `dnf install tcpdump`, etc. So we wouldn\u0027t be waiting for long. Worst case scenario seems like an edge case in that dnf is hung for $reasons. But that felt like a limited edge case that we might not need to handle?\n\n2. Given the above, our expectation is that we are the only operator likely to conduct a long running update task, in which case it\u0027s conducted once by Ansible and we should never run into a case where we are blocked by another dnf process?\n\nI\u0027m happy to add it back if we feel it\u0027s important, or if it was introduced to specifically address some issue.","commit_id":"210a2dac77b260fa0d9fb06f3b0b8ba82a3ab145"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"33d44f455c2850b354f998f8e2b94d7cacb6e6f5","unresolved":true,"context_lines":[{"line_number":405,"context_line":"            - dnf_module_list|length \u003e 0"},{"line_number":406,"context_line":"            - item.distribution_version is defined"},{"line_number":407,"context_line":"            - ansible_facts[\u0027distribution_major_version\u0027] is version(item.distribution_version, \u0027\u003d\u003d\u0027)"},{"line_number":408,"context_line":"        - name: Check for existing yum.pid"},{"line_number":409,"context_line":"          stat:  path\u003d/run/yum.pid"},{"line_number":410,"context_line":"          register: yum_pid_file"},{"line_number":411,"context_line":"          when: step|int \u003d\u003d 0 or step|int \u003d\u003d 3"},{"line_number":412,"context_line":"        - name: Exit if existing yum process"},{"line_number":413,"context_line":"          fail: msg\u003d\"ERROR existing yum.pid detected - can\u0027t continue! Please ensure there is no other package update process for the duration of the minor update worfklow. Exiting.\""},{"line_number":414,"context_line":"          when: (step|int \u003d\u003d 0 or step|int \u003d\u003d 3) and yum_pid_file.stat.exists"},{"line_number":415,"context_line":"        - name: Special treatment for OpenvSwitch"},{"line_number":416,"context_line":"          tripleo_ovs_upgrade:"},{"line_number":417,"context_line":"          when:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"429b5ad3_8352a8d1","side":"PARENT","line":414,"range":{"start_line":408,"start_character":0,"end_line":414,"end_character":77},"in_reply_to":"938dc6a3_b2c39d9c","updated":"2022-08-03 09:49:21.000000000","message":"Unfortunately I don\u0027t know a reason why there is the check. My guess is that this prevents not only running osp update while dnf update is running, but also running multiple osp updates at the same time, which may happen as an operator mistake. However, I agree this seems like a limited edge case. \n\nTo me, this kind of check should be moved to tripleo-validations provided that they are going to work with standalone-roles too.\nWhat do you think?","commit_id":"210a2dac77b260fa0d9fb06f3b0b8ba82a3ab145"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"dfb084746f61de31ad9056fdee4a65506d9e5316","unresolved":true,"context_lines":[{"line_number":141,"context_line":"  role_data:"},{"line_number":142,"context_line":"    description: Role data for the TripleO package settings"},{"line_number":143,"context_line":"    value:"},{"line_number":144,"context_line":"      ansible_group_vars:"},{"line_number":145,"context_line":"        dnf_module_list: {get_attr: [RoleParametersValue, value, \u0027dnf_module_list\u0027]}"},{"line_number":146,"context_line":"        skip_rhel_enforcement: {get_param: SkipRhelEnforcement}"},{"line_number":147,"context_line":"        skip_package_update: {get_param: SkipPackageUpdate}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"2ca3759a_179445ba","line":144,"range":{"start_line":144,"start_character":6,"end_line":144,"end_character":24},"updated":"2022-08-02 07:31:40.000000000","message":"What is the purpose of these outputs?\nHow are they used and who consumes these outputs?","commit_id":"e0ee3da792f5e8e2e797b762324822ed433f96be"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"e4fd3e59f590b7db87ee2879db80d128c8d87d9a","unresolved":true,"context_lines":[{"line_number":141,"context_line":"  role_data:"},{"line_number":142,"context_line":"    description: Role data for the TripleO package settings"},{"line_number":143,"context_line":"    value:"},{"line_number":144,"context_line":"      ansible_group_vars:"},{"line_number":145,"context_line":"        dnf_module_list: {get_attr: [RoleParametersValue, value, \u0027dnf_module_list\u0027]}"},{"line_number":146,"context_line":"        skip_rhel_enforcement: {get_param: SkipRhelEnforcement}"},{"line_number":147,"context_line":"        skip_package_update: {get_param: SkipPackageUpdate}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"e2c105f2_c7f18ce5","line":144,"range":{"start_line":144,"start_character":6,"end_line":144,"end_character":24},"in_reply_to":"2ca3759a_179445ba","updated":"2022-08-02 11:36:07.000000000","message":"These outputs are written to the group_vars/ROLE_NAME file for the role along with the config-download content. It\u0027s then consumed by Ansible during the playbook execution.","commit_id":"e0ee3da792f5e8e2e797b762324822ed433f96be"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"33d44f455c2850b354f998f8e2b94d7cacb6e6f5","unresolved":false,"context_lines":[{"line_number":141,"context_line":"  role_data:"},{"line_number":142,"context_line":"    description: Role data for the TripleO package settings"},{"line_number":143,"context_line":"    value:"},{"line_number":144,"context_line":"      ansible_group_vars:"},{"line_number":145,"context_line":"        dnf_module_list: {get_attr: [RoleParametersValue, value, \u0027dnf_module_list\u0027]}"},{"line_number":146,"context_line":"        skip_rhel_enforcement: {get_param: SkipRhelEnforcement}"},{"line_number":147,"context_line":"        skip_package_update: {get_param: SkipPackageUpdate}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bbd8d998_f3f091eb","line":144,"range":{"start_line":144,"start_character":6,"end_line":144,"end_character":24},"in_reply_to":"e2c105f2_c7f18ce5","updated":"2022-08-03 09:49:21.000000000","message":"ack,thank you","commit_id":"e0ee3da792f5e8e2e797b762324822ed433f96be"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"89426979bd1de5e8b6e555791cd76917fd0fd264","unresolved":true,"context_lines":[{"line_number":142,"context_line":"    description: Role data for the TripleO package settings"},{"line_number":143,"context_line":"    value:"},{"line_number":144,"context_line":"      ansible_group_vars:"},{"line_number":145,"context_line":"        dnf_module_list: {get_attr: [RoleParametersValue, value, \u0027dnf_module_list\u0027]}"},{"line_number":146,"context_line":"        skip_rhel_enforcement: {get_param: SkipRhelEnforcement}"},{"line_number":147,"context_line":"        skip_package_update: {get_param: SkipPackageUpdate}"},{"line_number":148,"context_line":"      service_name: tripleo_packages"},{"line_number":149,"context_line":"      config_settings:"},{"line_number":150,"context_line":"        tripleo::packages::enable_install: {get_param: EnablePackageInstall}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"8a9fddc6_0a4ff548","line":147,"range":{"start_line":145,"start_character":0,"end_line":147,"end_character":59},"updated":"2022-09-13 08:41:03.000000000","message":"Why not pass these vars to include_role as needed rather than adding them to group_vars if it\u0027s not expected to be used by any other ansible role?","commit_id":"9c1cf4a805764a13ff817d198b9a7309d083cd11"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"d458c2632d9f2597e66da3e1ee427b058fc057ec","unresolved":true,"context_lines":[{"line_number":142,"context_line":"    description: Role data for the TripleO package settings"},{"line_number":143,"context_line":"    value:"},{"line_number":144,"context_line":"      ansible_group_vars:"},{"line_number":145,"context_line":"        dnf_module_list: {get_attr: [RoleParametersValue, value, \u0027dnf_module_list\u0027]}"},{"line_number":146,"context_line":"        skip_rhel_enforcement: {get_param: SkipRhelEnforcement}"},{"line_number":147,"context_line":"        skip_package_update: {get_param: SkipPackageUpdate}"},{"line_number":148,"context_line":"      service_name: tripleo_packages"},{"line_number":149,"context_line":"      config_settings:"},{"line_number":150,"context_line":"        tripleo::packages::enable_install: {get_param: EnablePackageInstall}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"14d617f7_0cf34928","line":147,"range":{"start_line":145,"start_character":0,"end_line":147,"end_character":59},"in_reply_to":"8a9fddc6_0a4ff548","updated":"2022-09-28 02:51:12.000000000","message":"They\u0027re used by 2 of the 3 playbooks we\u0027re calling here. I can pass all of the vars to each inclusion though.","commit_id":"9c1cf4a805764a13ff817d198b9a7309d083cd11"}]}