)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"1474960652b33d9af73c5b3b6393a06207c5868e","unresolved":true,"context_lines":[{"line_number":9,"context_line":"neutronclient and openstackclient are required"},{"line_number":10,"context_line":" - to create a nova flavor"},{"line_number":11,"context_line":" - to create network resources (networks, subnets, ports)"},{"line_number":12,"context_line":"but now these tasks are executed from undercloud since these tasks were"},{"line_number":13,"context_line":"re-implemented by ansible."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Thus we don\u0027t need to install these client packages in overcloud nodes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"6ff6376e_bda99768","line":12,"range":{"start_line":12,"start_character":24,"end_line":12,"end_character":48},"updated":"2022-06-15 13:13:37.000000000","message":"I think this is wrong, the octavia_overcloud_config role is executed on octavia_nodes[0], which is, I think, one of the controller nodes\n\nhttps://opendev.org/openstack/tripleo-ansible/src/branch/master/tripleo_ansible/playbooks/octavia-files.yaml#L42-L71","commit_id":"09b5149e08eab6fc3541e67e2410f66dda0308a8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"251adf9bc2f200d906fa3626bffa23968cf1029d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"neutronclient and openstackclient are required"},{"line_number":10,"context_line":" - to create a nova flavor"},{"line_number":11,"context_line":" - to create network resources (networks, subnets, ports)"},{"line_number":12,"context_line":"but now these tasks are executed from undercloud since these tasks were"},{"line_number":13,"context_line":"re-implemented by ansible."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Thus we don\u0027t need to install these client packages in overcloud nodes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"0090a96f_94cc0b1d","line":12,"range":{"start_line":12,"start_character":24,"end_line":12,"end_character":48},"in_reply_to":"6ff6376e_bda99768","updated":"2022-06-15 13:22:10.000000000","message":"Ugh. I misread the playbook implementation. Quickly reviewing the tasks I believe we can offload some of these to undercloud (eg. network creation) but we still need to assign port creation to each node to pick up port id properly. So we\u0027d still need to install the client.","commit_id":"09b5149e08eab6fc3541e67e2410f66dda0308a8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f3ee547a7558c02e914d2d060d10b0dfc177f142","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5d5e9192_49c0ff2f","updated":"2022-06-14 11:10:02.000000000","message":"I noticed openssl is still required because ssl certificates are generated in the first controller node. will fix the patch to address that.","commit_id":"c3ee40d32b5275c916861181be2e5279c52f6419"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bafe014587f5275311d18b298f81295ba0421770","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bda5e35c_b4e0f1a4","updated":"2022-06-13 04:30:54.000000000","message":"recheck","commit_id":"c3ee40d32b5275c916861181be2e5279c52f6419"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"923ace2490030f0d5c4bbe9c5e521df42e13c540","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0dbb3b66_a1b8334b","updated":"2022-06-15 13:12:07.000000000","message":"Actually, this isn\u0027t true - it could be if we delegated certain tasks to the undercloud or refactored some things, but we do run network commands on the controllers.","commit_id":"09b5149e08eab6fc3541e67e2410f66dda0308a8"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"61ab6c9bb72b60c96e459741d5326269413c69d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e5425b88_fc9e516f","updated":"2022-06-15 13:04:22.000000000","message":"I think this is correct - let\u0027s double check with Gregory.","commit_id":"09b5149e08eab6fc3541e67e2410f66dda0308a8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"251adf9bc2f200d906fa3626bffa23968cf1029d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"56a3a665_96532296","updated":"2022-06-15 13:22:10.000000000","message":"Thanks Brent and Gregory, for correcting my misunderstanding.\nI updated the patch to leave openstackclient but I believe we no longer need neutronclient.\nPlease check the updated version and I\u0027d appreciate you feedback again.","commit_id":"8f9fa20389d921c969f1feed6ccfbca9684eb1b0"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"09e684c74bcef8ac8b0077f3c74f8b456ff185eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2fb88faa_8f8d21e7","updated":"2022-06-15 13:53:59.000000000","message":"Yes I think this is legit. IIUC the OSC only requires neutronclient for advanced networking commands and already includes the core networking features","commit_id":"ac5b16012a4f3164c8c607f9960961c7c1810c2e"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"2f272d3ed0a551758aba2aac250d9a193763fa01","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"868d83e6_5be7da1f","updated":"2022-07-01 05:26:09.000000000","message":"recheck","commit_id":"ac5b16012a4f3164c8c607f9960961c7c1810c2e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c10d19aa63ee0806bfd278cda66a5c7108945aad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8af6cf38_7f34d940","updated":"2022-06-15 16:59:19.000000000","message":"recheck\n\ncephadm failed but it is irrelevant to this change.","commit_id":"ac5b16012a4f3164c8c607f9960961c7c1810c2e"}]}