)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"1fd50bf9d2f028070c5b324653f080eeacfff45c","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Manage CA certificates using ansible"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change introduces a new implementation to manage CA certificate"},{"line_number":10,"context_line":"files by ansible, which will replace the existing one by ansible."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-on: https://review.opendev.org/743620"},{"line_number":13,"context_line":"Change-Id: I241f3d635e36a1497a1146fdd4c1db7dfde28dc8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bfde8303_5042c626","line":10,"range":{"start_line":10,"start_character":57,"end_line":10,"end_character":64},"updated":"2022-06-23 22:04:15.000000000","message":"nit: puppet","commit_id":"7eeffe51ac39bd1a38c408d2f5eb1f4cc5564a9b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"15341b5c2c5f5ff0e81cb5eaccd0cb0e3e157e9c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Manage CA certificates using ansible"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change introduces a new implementation to manage CA certificate"},{"line_number":10,"context_line":"files by ansible, which will replace the existing one by ansible."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-on: https://review.opendev.org/743620"},{"line_number":13,"context_line":"Change-Id: I241f3d635e36a1497a1146fdd4c1db7dfde28dc8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"aced4507_9b5653bf","line":10,"range":{"start_line":10,"start_character":57,"end_line":10,"end_character":64},"in_reply_to":"bfde8303_5042c626","updated":"2022-06-23 23:50:55.000000000","message":"Done. Indeed !","commit_id":"7eeffe51ac39bd1a38c408d2f5eb1f4cc5564a9b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"7ddaca449c5fe5419373320431b10dbf877c8f6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"051ebe34_e92444b2","updated":"2022-04-26 05:24:21.000000000","message":"Nice change. Good to get rid of Puppet here. Just one small comment for consideration.","commit_id":"af7a856abfaac6c8e54a7d84bfc0ee88387bf0b5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0eedd84be6e88a81eeebe8d140b125ec3f01dbf8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0ef319b6_fb360943","updated":"2022-06-23 12:37:40.000000000","message":"check-rdo","commit_id":"7eeffe51ac39bd1a38c408d2f5eb1f4cc5564a9b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5592e19b7e464c7567fbae6b8405f3b4c9a10858","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c8d78a14_12026cec","updated":"2022-06-21 01:02:11.000000000","message":"recheck","commit_id":"7eeffe51ac39bd1a38c408d2f5eb1f4cc5564a9b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"537cdee8fb14ae0ac72fc0e95b30aef50d400ce0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"edf7b443_85a134f7","updated":"2022-06-17 00:27:03.000000000","message":"recheck\n\novb scenario001 failed because of failure during node provisioning","commit_id":"7eeffe51ac39bd1a38c408d2f5eb1f4cc5564a9b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e6b3a6bfcd3637162a2877d411d4db91882470b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8db11e29_e6bc62de","updated":"2022-06-28 02:10:35.000000000","message":"recheck","commit_id":"a433e8fd6195dc0e7672360efada913d06e57e1a"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"23b4c29f99173890e167205dc26252aebb336709","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4d24f2fa_533346a4","updated":"2022-10-11 08:23:48.000000000","message":"sounds OK, but I\u0027d love to get Security views on that one before pushing a +2.","commit_id":"f3ac1f9762f40af995b2026d20488775a7d65eca"}],"deployment/certs/ca-certs-baremetal-ansible.yaml":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"7ddaca449c5fe5419373320431b10dbf877c8f6f","unresolved":true,"context_lines":[{"line_number":40,"context_line":"      service_name: ca_certs"},{"line_number":41,"context_line":"      config_settings: {}"},{"line_number":42,"context_line":"      host_prep_tasks:"},{"line_number":43,"context_line":"        - name: Create certificate files"},{"line_number":44,"context_line":"          copy:"},{"line_number":45,"context_line":"            dest: \"/etc/pki/ca-trust/source/anchors/{{ item.key }}.pem\""},{"line_number":46,"context_line":"            content: \"{{ item.value }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"34b69d23_715ab785","line":43,"updated":"2022-04-26 05:24:21.000000000","message":"I know this is just a small playbook at this stage. But I wonder, given the work we\u0027re doing to move Ansible tasks out of THT and into tripleo-ansible [1]. I wonder if this might be an example of something that we\u0027re better off consolidating in a new tripleo-ansible role?\n\n\nThen just having a simple include_role in THT like below for example:\n\n```\n- include_role: tripleo_certs\n  tasks_from: manage_certs.yml\n```\n\nThat might allow us to expand on this better in the future with less dependency on tripleo-heat-templates specifically. \n\n[1] https://review.opendev.org/q/topic:standalone-roles","commit_id":"b1832cfdf7c8ee3a9ac51d3f07c40966ad7ad1c5"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"10562ad45fea3562e30c791b10b9a6c2d055dbbe","unresolved":true,"context_lines":[{"line_number":40,"context_line":"      service_name: ca_certs"},{"line_number":41,"context_line":"      config_settings: {}"},{"line_number":42,"context_line":"      host_prep_tasks:"},{"line_number":43,"context_line":"        - name: Create certificate files"},{"line_number":44,"context_line":"          copy:"},{"line_number":45,"context_line":"            dest: \"/etc/pki/ca-trust/source/anchors/{{ item.key }}.pem\""},{"line_number":46,"context_line":"            content: \"{{ item.value }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f2efcc40_44d23037","line":43,"in_reply_to":"34b69d23_715ab785","updated":"2022-04-26 05:30:02.000000000","message":"My bad, the correct syntax example would be:\n\n```\n- name: Include tripleo_certs role\n  include_role:\n    name: tripleo_certs\n    tasks_from: manage_certs.yml\n```\n\nBasically the same thing we\u0027re doing with Puppet now, just replacing it with a Ansible role.","commit_id":"b1832cfdf7c8ee3a9ac51d3f07c40966ad7ad1c5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"07e0e364ac104823f937943a6b80e36e29d95672","unresolved":false,"context_lines":[{"line_number":40,"context_line":"      service_name: ca_certs"},{"line_number":41,"context_line":"      config_settings: {}"},{"line_number":42,"context_line":"      host_prep_tasks:"},{"line_number":43,"context_line":"        - name: Create certificate files"},{"line_number":44,"context_line":"          copy:"},{"line_number":45,"context_line":"            dest: \"/etc/pki/ca-trust/source/anchors/{{ item.key }}.pem\""},{"line_number":46,"context_line":"            content: \"{{ item.value }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4979e8cf_4f42b0d3","line":43,"in_reply_to":"f2efcc40_44d23037","updated":"2022-06-16 14:17:41.000000000","message":"Done","commit_id":"b1832cfdf7c8ee3a9ac51d3f07c40966ad7ad1c5"}]}
