)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"13e2993f8e5ebf7d4be2def92d8b85bad5d3f1f9","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     katarimanoj \u003cmkatari@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-04-27 15:59:14 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove deprecated template and parameters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change removes all the deprecated templates and parameters"},{"line_number":10,"context_line":"for storage services like Cinder, Manila and Swift."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dfd69507_0f0f1dd4","line":7,"updated":"2022-04-27 17:27:08.000000000","message":"nit: maybe add \"storage\" (\"Remove deprecated storage template and parameters\")","commit_id":"f79ecf0980c6239380e550b70df485dbc681de32"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"a906e692ee0dcb87a8f9a419e965f147daf06099","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     katarimanoj \u003cmkatari@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-04-27 15:59:14 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove deprecated template and parameters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change removes all the deprecated templates and parameters"},{"line_number":10,"context_line":"for storage services like Cinder, Manila and Swift."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d9624637_4eddf5b6","line":7,"in_reply_to":"dfd69507_0f0f1dd4","updated":"2022-04-28 07:23:26.000000000","message":"Done","commit_id":"f79ecf0980c6239380e550b70df485dbc681de32"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"13e2993f8e5ebf7d4be2def92d8b85bad5d3f1f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"54eecb68_c343123c","updated":"2022-04-27 17:27:08.000000000","message":"There are two issues, and one of needs inputs from other reviewers.\n\nSeveral parameters were deprecated two cycles ago, in xena, but there hasn\u0027t been a stable release since wallaby. The deprecation patches are only available on master, so does that mean we need to wait until the next stable branch is cut before the deprecated parameters can be removed?\n\nThe second issue is this patch needs a release note, with an \"upgrade\" section that lists what\u0027s being removed.","commit_id":"f79ecf0980c6239380e550b70df485dbc681de32"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"a906e692ee0dcb87a8f9a419e965f147daf06099","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"87604f0f_a7c61c6a","in_reply_to":"54eecb68_c343123c","updated":"2022-04-28 07:23:26.000000000","message":"I will wait for the inputs from other reviewers before i undo the changes for manila.\n\nAdded the release notes in the follow up patch.","commit_id":"f79ecf0980c6239380e550b70df485dbc681de32"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"f2b69a4ab0ec8a7373845f967cfad66c2660ccde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"49db827f_a05864e2","updated":"2022-05-16 05:13:34.000000000","message":"All the deprecated changes are now available in Stable/wallaby. Good to go ahead with removals.","commit_id":"3699a56891f8abce10d75a1b1cbbd6f2f775ff77"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"05ccd633524def2834a702c971dff4eecc0f21fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cd560ea6_e31e7890","updated":"2022-05-02 18:02:35.000000000","message":"we should try and follow the deprecation policy of deprecate in one full release, before removal. technically however, I don\u0027t think it is strictly required that TripleO follow that policy given we are on the independent release model.\n\nalso, I think it is allowable to backport deprecations to wallaby still at this stage given we have not yet done a downstream release of wallaby, so that might be the best path forward.","commit_id":"3699a56891f8abce10d75a1b1cbbd6f2f775ff77"}],"deployment/cinder/cinder-backend-dellsc-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"13e2993f8e5ebf7d4be2def92d8b85bad5d3f1f9","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"description: \u003e"},{"line_number":17,"context_line":"  Openstack Cinder Dell EMC Storage Center backend"},{"line_number":18,"context_line":"  Please note, this template is deprecated now."},{"line_number":19,"context_line":"  Use Cinder Dell EMC SC backend template defined in"},{"line_number":20,"context_line":"  cinder-backend-dellemc-sc-puppet.yaml."},{"line_number":21,"context_line":"parameters:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5bc7e749_99248177","side":"PARENT","line":18,"updated":"2022-04-27 17:27:08.000000000","message":"This comment about the template being deprecated was added back in ussuri [1]. The file should probably have been moved to the \u0027deprecated\u0027 THT directory in that patch, but it\u0027s OK to remove it entirely now.\n\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/723038","commit_id":"9d95441f0fca33b217091fb1faac32084c130827"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"a906e692ee0dcb87a8f9a419e965f147daf06099","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"description: \u003e"},{"line_number":17,"context_line":"  Openstack Cinder Dell EMC Storage Center backend"},{"line_number":18,"context_line":"  Please note, this template is deprecated now."},{"line_number":19,"context_line":"  Use Cinder Dell EMC SC backend template defined in"},{"line_number":20,"context_line":"  cinder-backend-dellemc-sc-puppet.yaml."},{"line_number":21,"context_line":"parameters:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"124ac398_64c6fe9e","side":"PARENT","line":18,"in_reply_to":"5bc7e749_99248177","updated":"2022-04-28 07:23:26.000000000","message":"Thanks for the patch details, i will make sure that all future deprecated templates are moved to \u0027depreacted THT\u0027 directory.","commit_id":"9d95441f0fca33b217091fb1faac32084c130827"}],"deployment/cinder/cinder-backend-netapp-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"13e2993f8e5ebf7d4be2def92d8b85bad5d3f1f9","unresolved":true,"context_lines":[{"line_number":130,"context_line":"  description: |"},{"line_number":131,"context_line":"   The following parameters are deprecated and will be removed."},{"line_number":132,"context_line":"  parameters:"},{"line_number":133,"context_line":"  - CinderNetappStoragePools"},{"line_number":134,"context_line":"  - CinderNetappVolumeList"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"outputs:"},{"line_number":137,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"709cbae8_9323a87d","side":"PARENT","line":134,"range":{"start_line":133,"start_character":0,"end_line":134,"end_character":26},"updated":"2022-04-27 17:27:08.000000000","message":"OK to delete these now , as they were deprecated in stable/wallaby.","commit_id":"9d95441f0fca33b217091fb1faac32084c130827"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"a906e692ee0dcb87a8f9a419e965f147daf06099","unresolved":false,"context_lines":[{"line_number":130,"context_line":"  description: |"},{"line_number":131,"context_line":"   The following parameters are deprecated and will be removed."},{"line_number":132,"context_line":"  parameters:"},{"line_number":133,"context_line":"  - CinderNetappStoragePools"},{"line_number":134,"context_line":"  - CinderNetappVolumeList"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"outputs:"},{"line_number":137,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4c5c4a02_0c18d3b5","side":"PARENT","line":134,"range":{"start_line":133,"start_character":0,"end_line":134,"end_character":26},"in_reply_to":"709cbae8_9323a87d","updated":"2022-04-28 07:23:26.000000000","message":"Ack","commit_id":"9d95441f0fca33b217091fb1faac32084c130827"}],"deployment/manila/manila-backend-cephfs.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"13e2993f8e5ebf7d4be2def92d8b85bad5d3f1f9","unresolved":true,"context_lines":[{"line_number":74,"context_line":"    constraints:"},{"line_number":75,"context_line":"    - allowed_values: [\u0027CEPHFS\u0027, \u0027NFS\u0027]"},{"line_number":76,"context_line":"  # Deprecated parameters"},{"line_number":77,"context_line":"  ManilaCephFSCephFSEnableSnapshots:"},{"line_number":78,"context_line":"    type: boolean"},{"line_number":79,"context_line":"    description: |"},{"line_number":80,"context_line":"      Enable snapshot support in CephFS driver. Note that this parameter has"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1782c5d9_1e84834a","side":"PARENT","line":77,"updated":"2022-04-27 17:27:08.000000000","message":"Hmm, this is tricky. The problem is the parameter may have been deprecated back in xena [1], but TripleO switched to an independent release model and so there is no xena (or yoga) THT release. [1] is only on master, so I\u0027m not sure it it\u0027s OK to remove the parameter now, or if we need to wait until after tripleo creates its next stable branch.\n\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/799099","commit_id":"9d95441f0fca33b217091fb1faac32084c130827"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d102eaa0869e9d66912602a36015e78252b5a53a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    constraints:"},{"line_number":75,"context_line":"    - allowed_values: [\u0027CEPHFS\u0027, \u0027NFS\u0027]"},{"line_number":76,"context_line":"  # Deprecated parameters"},{"line_number":77,"context_line":"  ManilaCephFSCephFSEnableSnapshots:"},{"line_number":78,"context_line":"    type: boolean"},{"line_number":79,"context_line":"    description: |"},{"line_number":80,"context_line":"      Enable snapshot support in CephFS driver. Note that this parameter has"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"188370a8_0aae227b","side":"PARENT","line":77,"in_reply_to":"1782c5d9_1e84834a","updated":"2022-05-18 17:01:58.000000000","message":"This is no longer an issue because [1] has been backported to stable/wallaby [2].\n\n[2] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/840581","commit_id":"9d95441f0fca33b217091fb1faac32084c130827"}],"deployment/manila/manila-backend-isilon.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"13e2993f8e5ebf7d4be2def92d8b85bad5d3f1f9","unresolved":true,"context_lines":[{"line_number":67,"context_line":"   parameters, please contact the TripleO development team on IRC or the"},{"line_number":68,"context_line":"   OpenStack mailing list."},{"line_number":69,"context_line":"  parameters:"},{"line_number":70,"context_line":"  - ManilaIsilonDriverHandlesShareServers"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"outputs:"},{"line_number":73,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ab8b5867_9d68d7a7","side":"PARENT","line":70,"updated":"2022-04-27 17:27:08.000000000","message":"See my other comment. This parameter was deprecated in xena, but tripleo hasn\u0027t created any stable branches since wallaby. I don\u0027t know if it\u0027s OK to deprecate and remove parameters all on the master branch, without the deprecation being present on a stable branch.","commit_id":"9d95441f0fca33b217091fb1faac32084c130827"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d102eaa0869e9d66912602a36015e78252b5a53a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"   parameters, please contact the TripleO development team on IRC or the"},{"line_number":68,"context_line":"   OpenStack mailing list."},{"line_number":69,"context_line":"  parameters:"},{"line_number":70,"context_line":"  - ManilaIsilonDriverHandlesShareServers"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"outputs:"},{"line_number":73,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9760b714_c1a4907f","side":"PARENT","line":70,"in_reply_to":"ab8b5867_9d68d7a7","updated":"2022-05-18 17:01:58.000000000","message":"The patch that deprecated this has been backported to stable/wallaby\n\nhttps://review.opendev.org/c/openstack/tripleo-heat-templates/+/840582","commit_id":"9d95441f0fca33b217091fb1faac32084c130827"}],"deployment/manila/manila-backend-vmax.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"13e2993f8e5ebf7d4be2def92d8b85bad5d3f1f9","unresolved":true,"context_lines":[{"line_number":67,"context_line":"   parameters, please contact the TripleO development team on IRC or the"},{"line_number":68,"context_line":"   OpenStack mailing list."},{"line_number":69,"context_line":"  parameters:"},{"line_number":70,"context_line":"  - ManilaVMAXDriverHandlesShareServers"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"outputs:"},{"line_number":73,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9bceb649_f33e6d73","side":"PARENT","line":70,"updated":"2022-04-27 17:27:08.000000000","message":"ditto my other comments regarding parameters that were deprecated after the last stable branch (wallaby) was cut.","commit_id":"9d95441f0fca33b217091fb1faac32084c130827"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d102eaa0869e9d66912602a36015e78252b5a53a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"   parameters, please contact the TripleO development team on IRC or the"},{"line_number":68,"context_line":"   OpenStack mailing list."},{"line_number":69,"context_line":"  parameters:"},{"line_number":70,"context_line":"  - ManilaVMAXDriverHandlesShareServers"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"outputs:"},{"line_number":73,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b9d065d9_4fc6504c","side":"PARENT","line":70,"in_reply_to":"9bceb649_f33e6d73","updated":"2022-05-18 17:01:58.000000000","message":"The deprecation has been backported to stable/wallaby.\n\nhttps://review.opendev.org/c/openstack/tripleo-heat-templates/+/840582","commit_id":"9d95441f0fca33b217091fb1faac32084c130827"}],"deployment/manila/manila-backend-vnx.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"13e2993f8e5ebf7d4be2def92d8b85bad5d3f1f9","unresolved":true,"context_lines":[{"line_number":77,"context_line":"   parameters, please contact the TripleO development team on IRC or the"},{"line_number":78,"context_line":"   OpenStack mailing list."},{"line_number":79,"context_line":"  parameters:"},{"line_number":80,"context_line":"  - ManilaVNXDriverHandlesShareServers"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"outputs:"},{"line_number":83,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"db446a5c_e775c568","side":"PARENT","line":80,"updated":"2022-04-27 17:27:08.000000000","message":"ditto my other comments regarding parameters that were deprecated after the last stable branch (wallaby) was cut.","commit_id":"9d95441f0fca33b217091fb1faac32084c130827"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d102eaa0869e9d66912602a36015e78252b5a53a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"   parameters, please contact the TripleO development team on IRC or the"},{"line_number":78,"context_line":"   OpenStack mailing list."},{"line_number":79,"context_line":"  parameters:"},{"line_number":80,"context_line":"  - ManilaVNXDriverHandlesShareServers"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"outputs:"},{"line_number":83,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"300c9740_9658775a","side":"PARENT","line":80,"in_reply_to":"db446a5c_e775c568","updated":"2022-05-18 17:01:58.000000000","message":"The deprecation has been backported to stable/wallaby.\n\nhttps://review.opendev.org/c/openstack/tripleo-heat-templates/+/840582","commit_id":"9d95441f0fca33b217091fb1faac32084c130827"}],"deployment/swift/swift-storage-container-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"13e2993f8e5ebf7d4be2def92d8b85bad5d3f1f9","unresolved":true,"context_lines":[{"line_number":140,"context_line":"- label: deprecated"},{"line_number":141,"context_line":"  description: Do not use deprecated params, they will be removed."},{"line_number":142,"context_line":"  parameters:"},{"line_number":143,"context_line":"  - ControllerEnableSwiftStorage"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"conditions:"},{"line_number":146,"context_line":"  single_replica_mode: {equals: [{get_param: SwiftReplicas}, 1]}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"83e376f1_74b36a10","side":"PARENT","line":143,"updated":"2022-04-27 17:27:08.000000000","message":"OK to delete this now, as it was deprecated in stable/train.","commit_id":"9d95441f0fca33b217091fb1faac32084c130827"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"a906e692ee0dcb87a8f9a419e965f147daf06099","unresolved":false,"context_lines":[{"line_number":140,"context_line":"- label: deprecated"},{"line_number":141,"context_line":"  description: Do not use deprecated params, they will be removed."},{"line_number":142,"context_line":"  parameters:"},{"line_number":143,"context_line":"  - ControllerEnableSwiftStorage"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"conditions:"},{"line_number":146,"context_line":"  single_replica_mode: {equals: [{get_param: SwiftReplicas}, 1]}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"efb12171_16bf7290","side":"PARENT","line":143,"in_reply_to":"83e376f1_74b36a10","updated":"2022-04-28 07:23:26.000000000","message":"Ack","commit_id":"9d95441f0fca33b217091fb1faac32084c130827"}]}