)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ddf26e6e91a153096ebf5d69b16d95f9a174d0ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"09dc3c86_0c4b8e4b","updated":"2022-04-27 09:26:21.000000000","message":"recheck","commit_id":"a786299bb34f5db9e05a4e2585f7a7dbe0b6dceb"}],"overcloud-resource-registry-puppet.j2.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"c01640c3e28e3c5ef497556f53446386e5f7376b","unresolved":true,"context_lines":[{"line_number":38,"context_line":"{% for role in roles %}"},{"line_number":39,"context_line":"  OS::TripleO::{{role.name}}Server: OS::TripleO::Server"},{"line_number":40,"context_line":"{% endfor %}"},{"line_number":41,"context_line":"  OS::TripleO::DeployedServer::ControlPlanePort: OS::Neutron::Port"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  # This creates the \"heat-admin\" user for all OS images by default"},{"line_number":44,"context_line":"  # To disable, replace with firstboot/userdata_default.yaml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1ae7e269_9ae41198","line":41,"updated":"2022-05-02 22:08:28.000000000","message":"this isn\u0027t the right default mapping for ControlPlanePort as Heat-\u003eNeutron is also not used due to ephemeral Heat. this should likely be deployed-server/deployed-neutron-port.yaml by default.","commit_id":"a786299bb34f5db9e05a4e2585f7a7dbe0b6dceb"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"a10105e674321461cd6bd0db7ff2b98687883cf4","unresolved":true,"context_lines":[{"line_number":38,"context_line":"{% for role in roles %}"},{"line_number":39,"context_line":"  OS::TripleO::{{role.name}}Server: OS::TripleO::Server"},{"line_number":40,"context_line":"{% endfor %}"},{"line_number":41,"context_line":"  OS::TripleO::DeployedServer::ControlPlanePort: OS::Neutron::Port"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  # This creates the \"heat-admin\" user for all OS images by default"},{"line_number":44,"context_line":"  # To disable, replace with firstboot/userdata_default.yaml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"51f628f5_7cbdb8bc","line":41,"in_reply_to":"0e9fb81e_137b459e","updated":"2022-05-04 03:06:22.000000000","message":"+1, https://github.com/openstack/tripleo-heat-templates/blob/master/environments/deployed-server-environment.j2.yaml#L3 was indeed incorrect and resulted in number of issues unless used with deployed-server-deployed-neutron-ports.yaml.","commit_id":"a786299bb34f5db9e05a4e2585f7a7dbe0b6dceb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"86c349a25b5d1b5ac1f6caedecb20f854cc7c108","unresolved":true,"context_lines":[{"line_number":38,"context_line":"{% for role in roles %}"},{"line_number":39,"context_line":"  OS::TripleO::{{role.name}}Server: OS::TripleO::Server"},{"line_number":40,"context_line":"{% endfor %}"},{"line_number":41,"context_line":"  OS::TripleO::DeployedServer::ControlPlanePort: OS::Neutron::Port"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  # This creates the \"heat-admin\" user for all OS images by default"},{"line_number":44,"context_line":"  # To disable, replace with firstboot/userdata_default.yaml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fa007b7_e35bc4f4","line":41,"in_reply_to":"1ae7e269_9ae41198","updated":"2022-05-03 14:53:29.000000000","message":"There are still number of references to Neutron resources in the other places. (For example, L94 of this file), so at this moment usage of Neutron resource is more \"consistent\" across all templates.\n\nUltimately we can replace all Neutron resources but I prefer leaving that to a separate work because it requires some amount of effort.","commit_id":"a786299bb34f5db9e05a4e2585f7a7dbe0b6dceb"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"66daa41cf2e319bc7be47289a75e3819b4e6b74b","unresolved":true,"context_lines":[{"line_number":38,"context_line":"{% for role in roles %}"},{"line_number":39,"context_line":"  OS::TripleO::{{role.name}}Server: OS::TripleO::Server"},{"line_number":40,"context_line":"{% endfor %}"},{"line_number":41,"context_line":"  OS::TripleO::DeployedServer::ControlPlanePort: OS::Neutron::Port"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  # This creates the \"heat-admin\" user for all OS images by default"},{"line_number":44,"context_line":"  # To disable, replace with firstboot/userdata_default.yaml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0e9fb81e_137b459e","line":41,"in_reply_to":"9fa007b7_e35bc4f4","updated":"2022-05-03 16:31:13.000000000","message":"true, there is further cleanup that\u0027s needed, but i don\u0027t see a reason to add in new wrong mappings.","commit_id":"a786299bb34f5db9e05a4e2585f7a7dbe0b6dceb"}]}