)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"77302f69cfcbb8a2374cb55602c8a6cde5b2addb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c8f4f26f_0723fbbf","updated":"2022-05-04 21:58:28.000000000","message":"Yeah, this totally broke tripleo-ci-centos-9-ovb-3ctlr_1comp_1supp-featureset039\n\nhttps://review.opendev.org/c/openstack/tripleo-heat-templates/+/840534 looks like a better approach.\n\nI\u0027ll probably end up abandoning this once the dust settles.","commit_id":"d51ebc6f62bb6cd4d0ce244257627a04fcc42db3"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"ee0818ec4728ceb69cd429b2d6ac7c7594c5b6f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"80e7b97c_cd653260","in_reply_to":"c8f4f26f_0723fbbf","updated":"2022-05-04 22:19:33.000000000","message":"\u003e https://review.opendev.org/c/openstack/tripleo-heat-templates/+/840534 looks like a better approach.\n\u003e \n\nIt feels a bit nasty though. Not sure if there is a better way...","commit_id":"d51ebc6f62bb6cd4d0ce244257627a04fcc42db3"}],"deployment/apache/apache-baremetal-puppet.j2.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"d57208fd2befb7c8d61cf093adb468931f591ade","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        # We skip the tenant and management network (vip !\u003d false)"},{"line_number":74,"context_line":"        # since we don\u0027t generate certificates for those."},{"line_number":75,"context_line":"        - ctlplane"},{"line_number":76,"context_line":"{%- for network in role_networks if network.enabled|default(true) and network.vip|default(false) %}"},{"line_number":77,"context_line":"        - {{network.name_lower}}"},{"line_number":78,"context_line":"{%- endfor %}"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d10973cf_803156b7","line":76,"range":{"start_line":76,"start_character":19,"end_line":76,"end_character":33},"updated":"2022-05-04 19:25:57.000000000","message":"Where is that set? IIUC when rendering these templates roles and networks are defined, but not role_networks","commit_id":"d51ebc6f62bb6cd4d0ce244257627a04fcc42db3"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"655667373497f573bdcdce882e5ae216eb7dbe74","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        # We skip the tenant and management network (vip !\u003d false)"},{"line_number":74,"context_line":"        # since we don\u0027t generate certificates for those."},{"line_number":75,"context_line":"        - ctlplane"},{"line_number":76,"context_line":"{%- for network in role_networks if network.enabled|default(true) and network.vip|default(false) %}"},{"line_number":77,"context_line":"        - {{network.name_lower}}"},{"line_number":78,"context_line":"{%- endfor %}"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c411bf72_ebd77c49","line":76,"range":{"start_line":76,"start_character":19,"end_line":76,"end_character":33},"in_reply_to":"9fa7bf42_bb492ce0","updated":"2022-05-04 19:35:09.000000000","message":"This is where the jinja2 rendering happens AFAIK https://github.com/openstack/tripleo-heat-templates/blob/master/tools/process-templates.py#L310","commit_id":"d51ebc6f62bb6cd4d0ce244257627a04fcc42db3"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"be657ce71e788840ec0a393049546e94dd252423","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        # We skip the tenant and management network (vip !\u003d false)"},{"line_number":74,"context_line":"        # since we don\u0027t generate certificates for those."},{"line_number":75,"context_line":"        - ctlplane"},{"line_number":76,"context_line":"{%- for network in role_networks if network.enabled|default(true) and network.vip|default(false) %}"},{"line_number":77,"context_line":"        - {{network.name_lower}}"},{"line_number":78,"context_line":"{%- endfor %}"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fa7bf42_bb492ce0","line":76,"range":{"start_line":76,"start_character":19,"end_line":76,"end_character":33},"in_reply_to":"d10973cf_803156b7","updated":"2022-05-04 19:30:53.000000000","message":"You may be right, and it\u0027s definitely why I threw this up as a WIP. If role_networks isn\u0027t yet defined then we\u0027ll need to find a different solution.\n\nSee https://github.com/openstack/tripleo-heat-templates/blob/master/overcloud.j2.yaml#L1035","commit_id":"d51ebc6f62bb6cd4d0ce244257627a04fcc42db3"}]}