)]}'
{"deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"27861589f0c7ed743cc710661e1e8a3a56ba99b1","unresolved":true,"context_lines":[{"line_number":298,"context_line":"                  - rsync"},{"line_number":299,"context_line":"                state: present"},{"line_number":300,"context_line":"              when: ansible_facts[\u0027distribution_major_version\u0027] is version(\u00278\u0027, \u0027\u003d\u003d\u0027)"},{"line_number":301,"context_line":"        - name: check if libvirt is installed"},{"line_number":302,"context_line":"          when: step|int \u003d\u003d 0"},{"line_number":303,"context_line":"          command: /usr/bin/rpm -q libvirt-daemon"},{"line_number":304,"context_line":"          failed_when: false"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fee5574_08f034bb","line":301,"updated":"2022-05-06 10:56:30.000000000","message":"Since both these task are related and hast to be executed together, why not move it under a block with step \u003d\u003d 0 condition?","commit_id":"e604adb95757764bd4c53162c3f4430725f76ef2"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"f01f36d4401aecf4dc85b504fd56f8ba3f4a3067","unresolved":true,"context_lines":[{"line_number":298,"context_line":"                  - rsync"},{"line_number":299,"context_line":"                state: present"},{"line_number":300,"context_line":"              when: ansible_facts[\u0027distribution_major_version\u0027] is version(\u00278\u0027, \u0027\u003d\u003d\u0027)"},{"line_number":301,"context_line":"        - name: check if libvirt is installed"},{"line_number":302,"context_line":"          when: step|int \u003d\u003d 0"},{"line_number":303,"context_line":"          command: /usr/bin/rpm -q libvirt-daemon"},{"line_number":304,"context_line":"          failed_when: false"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f5acf775_1f299d3a","line":301,"in_reply_to":"3fee5574_08f034bb","updated":"2022-05-06 11:28:26.000000000","message":"Blocks are logical grouping for readability and play error handling. Ansible actually evaluates the conditional which is defined as part of the block for each and every task inside the block and hence not any more efficient. I did not change it for that reason.","commit_id":"e604adb95757764bd4c53162c3f4430725f76ef2"}]}