)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"b8e460b206d79366a2080d77369d6f4075d0e8c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2b0ac4e6_e49d5496","updated":"2022-06-03 05:47:05.000000000","message":"recheck","commit_id":"7e9aadb638f1f00e7d108c7965c321ea5b55fabb"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"e0c82c3fc35e3af65f6483bee45f3d686ed01d34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"58e05ab4_35a64b21","updated":"2022-05-09 15:10:56.000000000","message":"recheck","commit_id":"7e9aadb638f1f00e7d108c7965c321ea5b55fabb"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"92c7f5d3bfa975d8d1380fdbe15953c24a67f335","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e1c3c039_c53e393b","updated":"2022-07-06 10:37:52.000000000","message":"I just realized there is a potential issue in this sample. See inline comment.","commit_id":"3aa4c925d66109608611d13bb7669edaff2423f9"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"6632f7a47dc736ebdfe2c7a089fceb4e717454c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fa479ac_78631793","updated":"2022-06-16 11:06:05.000000000","message":"recheck","commit_id":"3aa4c925d66109608611d13bb7669edaff2423f9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"793828b493771536dae78f8af90eb1ceb2d50b66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4e279346_e5d96a87","updated":"2022-07-05 23:48:40.000000000","message":"recheck\n\nlet\u0027s get the fresh CI result.","commit_id":"3aa4c925d66109608611d13bb7669edaff2423f9"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"c1bdf13262fd32fc395c050a314ace324df30c6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c0261b66_ffcbf940","updated":"2022-08-01 05:07:49.000000000","message":"Ah damn, this is the cherry-picked one. Hmm, might need to abandon this one and change in master, then back port that","commit_id":"dfcdc6e8d31af35ca85847a1c9a4d877a3c75648"}],"baremetal-samples/baremetal_deployment.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"92c7f5d3bfa975d8d1380fdbe15953c24a67f335","unresolved":true,"context_lines":[{"line_number":2,"context_line":"  count: 1"},{"line_number":3,"context_line":"  defaults:"},{"line_number":4,"context_line":"    networks:"},{"line_number":5,"context_line":"    - network: ctlplane"},{"line_number":6,"context_line":"      subnet: ctlplane-subnet"},{"line_number":7,"context_line":"      vif: true"},{"line_number":8,"context_line":"    - network: external"},{"line_number":9,"context_line":"      subnet: external_subnet"},{"line_number":10,"context_line":"    - network: internalapi"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a77a7603_f4062846","line":7,"range":{"start_line":5,"start_character":0,"end_line":7,"end_character":15},"updated":"2022-07-06 10:37:52.000000000","message":"So the ctlplane entry is implicit, and I think adding it with the subnet specified can cause issues because of the way the check[1] to see if a network matches the default is done.\n\nThe default_network[2] is:\n- network: ctlplane\n  vif: true\n\nComparing that too ...\n\n- network: ctlplane\n  subnet: ctlplane-subnet\n  vif: true\n\n... result will be that both are included?\n\nRemove the entry for ctlplane, Remove the subnet, or improve the check[1]?\n\n[1] https://opendev.org/openstack/tripleo-ansible/src/branch/master/tripleo_ansible/ansible_plugins/module_utils/baremetal_deploy.py#L208-L209\n[2] https://opendev.org/openstack/tripleo-ansible/src/branch/master/tripleo_ansible/ansible_plugins/modules/tripleo_baremetal_expand_roles.py#L95-L102","commit_id":"3aa4c925d66109608611d13bb7669edaff2423f9"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"76f15819315ed141fbf8f04661f1aa7950d52ea3","unresolved":true,"context_lines":[{"line_number":2,"context_line":"  count: 1"},{"line_number":3,"context_line":"  defaults:"},{"line_number":4,"context_line":"    networks:"},{"line_number":5,"context_line":"    - network: ctlplane"},{"line_number":6,"context_line":"      subnet: ctlplane-subnet"},{"line_number":7,"context_line":"      vif: true"},{"line_number":8,"context_line":"    - network: external"},{"line_number":9,"context_line":"      subnet: external_subnet"},{"line_number":10,"context_line":"    - network: internalapi"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f029c443_ff3f6971","line":7,"range":{"start_line":5,"start_character":0,"end_line":7,"end_character":15},"in_reply_to":"a77a7603_f4062846","updated":"2022-07-06 10:39:26.000000000","message":"oops, I messed up the formating.\n\n\u003e The default_network[2] is:\n  - network: ctlplane\n    vif: true\n\u003e Comparing that too ...\n  - network: ctlplane\n    subnet: ctlplane-subnet\n    vif: true\n\u003e ... result will be that both are included?","commit_id":"3aa4c925d66109608611d13bb7669edaff2423f9"}]}