)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"1631eb1654cece1910268fa452395c8742c61686","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4df2f6b3_2fbbfe7d","updated":"2022-05-18 09:28:49.000000000","message":"recheck\n\nOC failed to deploy, but apparently NOT due to the firewall change.","commit_id":"93c3b4bb745b946c87d196c8f9501bdfefab0c18"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"72dc1c86aa96249c072dd3d8000d223b05c3ed7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2033081f_1cd6a4e7","updated":"2022-05-24 05:57:07.000000000","message":"recheck","commit_id":"8f8956aa825cd3d9df886aa1efcdf2a4e916fd6b"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"20818fd8f002d6358f11b80c83adbcfba8a5259a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9a90f36c_115bb47b","updated":"2022-05-19 14:30:26.000000000","message":"recheck","commit_id":"8f8956aa825cd3d9df886aa1efcdf2a4e916fd6b"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"34c159fc034766a916fc1df236f0eece7d068a46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c5388325_c7f551ec","updated":"2022-05-24 11:54:22.000000000","message":"check-rdo","commit_id":"d333761399782922fd15361a627697429b991778"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"84da6c030120e23641c193a031cebc56742ec3a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6b3311ca_4b31ac05","updated":"2022-05-31 08:07:58.000000000","message":"lgtm \u0026 keeps default behaviour\nif you update for release note i will revote thanks","commit_id":"e3913583a5853ae1677c0677c80203372bd1c182"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"43e313f2363386f840eb3a48aeb28d03c51aa908","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"aff225f1_49a36eeb","updated":"2022-06-06 21:09:28.000000000","message":"-1..just to confirm that we actually desire to maintain both long term.","commit_id":"d5b0512f8fb01c55c701f0b3a843758cbb5643f6"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"f4554a8a474a620c8e1c26cdfac2bb9039c42341","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"06b8d061_4cf03eba","updated":"2022-06-06 21:08:55.000000000","message":"what\u0027s the reasoning for supporting both?","commit_id":"d5b0512f8fb01c55c701f0b3a843758cbb5643f6"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"f4ceb877aaf811566ab4ee1e483a347e77bfccfc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f6ebbcf7_7c89cecd","in_reply_to":"448f6f17_3a2fbe3d","updated":"2022-06-07 18:52:06.000000000","message":"I feel like we should be able to make this switch entirely zed, and as such we don\u0027t need a parameter for it, just to remove it later.","commit_id":"d5b0512f8fb01c55c701f0b3a843758cbb5643f6"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"564a7e0ab8b980425493e06e051a299637e420a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"448f6f17_3a2fbe3d","in_reply_to":"aff225f1_49a36eeb","updated":"2022-06-07 07:06:15.000000000","message":"No, we (at least I ;)) don\u0027t desire to maintain both long term - 1 cycle max.\n\nThe ability to switch things will allow to not break the whole CI. A bit like docker vs podman.\n\nThat said, in this case, there aren\u0027t that many differences, especially since iptables is, actually, iptables-nft, calling nftables. We\u0027re just shortening the path. It should be a fast switch, but I\u0027d rather be on the safe side, not all scenarii are tested with the current jobs.","commit_id":"d5b0512f8fb01c55c701f0b3a843758cbb5643f6"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"b052008d0d9eb01c67a58d5303732fe7d58f7cfc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f6bf872c_26b5507a","in_reply_to":"f6ebbcf7_7c89cecd","updated":"2022-06-16 12:28:51.000000000","message":"this param will make easier to switch on the CI side. I\u0027m OK to drop it from the undercloud.conf, but here, we really want to be clean and have an easy way to switch things job by job imho. It\u0027s supposed to work as-is, but if there are some weird rules being pushed by some obscure job... Though I don\u0027t see what they could be. Still - the ansible role supports both by default. Probably better to add the switch here, and be more agile.","commit_id":"d5b0512f8fb01c55c701f0b3a843758cbb5643f6"}],"deployment/tripleo-firewall/tripleo-firewall-baremetal-ansible.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"84da6c030120e23641c193a031cebc56742ec3a7","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    type: json"},{"line_number":34,"context_line":"    tags:"},{"line_number":35,"context_line":"      - role_specific"},{"line_number":36,"context_line":"  FirewallEngine:"},{"line_number":37,"context_line":"    default: \u0027iptables\u0027"},{"line_number":38,"context_line":"    description: Set the actual firewall engine. Can be \"iptables\" or \"nftables\""},{"line_number":39,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"8b77cfbc_6db5bd3a","line":36,"range":{"start_line":36,"start_character":2,"end_line":36,"end_character":16},"updated":"2022-05-31 08:07:58.000000000","message":"maybe needs a release note? I know this isn\u0027t the main work, that is already merged in depends-on but this is the change to the user interface that exposes the new feature.","commit_id":"e3913583a5853ae1677c0677c80203372bd1c182"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4f478cb660f26f5f73c13f044a66d4d7ba2392b5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    type: json"},{"line_number":34,"context_line":"    tags:"},{"line_number":35,"context_line":"      - role_specific"},{"line_number":36,"context_line":"  FirewallEngine:"},{"line_number":37,"context_line":"    default: \u0027iptables\u0027"},{"line_number":38,"context_line":"    description: Set the actual firewall engine. Can be \"iptables\" or \"nftables\""},{"line_number":39,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"c3f867c6_eb2c2af5","line":36,"range":{"start_line":36,"start_character":2,"end_line":36,"end_character":16},"in_reply_to":"8b77cfbc_6db5bd3a","updated":"2022-05-31 09:04:10.000000000","message":"Done","commit_id":"e3913583a5853ae1677c0677c80203372bd1c182"}],"releasenotes/notes/firewall-engine-36c6e6a9006fbad0.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4f478cb660f26f5f73c13f044a66d4d7ba2392b5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new parameter in order to chose what firewall engine we want to use."},{"line_number":5,"context_line":"    Values can be iptables (default), or nftables."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"204a0de6_e942d8cf","line":4,"range":{"start_line":4,"start_character":14,"end_line":4,"end_character":23},"updated":"2022-05-31 09:04:10.000000000","message":"bonus point if you name it here ;) \"a new parameter, \u0027FirewallEngine\u0027\"","commit_id":"85ed3148afb4fd0a1db8e76baec930a29cea4bee"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"933836cbb5e58b1b87f3891796f1a1cc9d04c997","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new parameter in order to chose what firewall engine we want to use."},{"line_number":5,"context_line":"    Values can be iptables (default), or nftables."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"607b7e24_a437381f","line":4,"range":{"start_line":4,"start_character":14,"end_line":4,"end_character":23},"in_reply_to":"204a0de6_e942d8cf","updated":"2022-05-31 09:07:58.000000000","message":"I want my bonus point 😜","commit_id":"85ed3148afb4fd0a1db8e76baec930a29cea4bee"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b80321154414fed8391cffd8cda855c76e3c2daa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new parameter in order to chose what firewall engine we want to use."},{"line_number":5,"context_line":"    Values can be iptables (default), or nftables."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"f657eee8_8a7fdf31","line":4,"range":{"start_line":4,"start_character":14,"end_line":4,"end_character":23},"in_reply_to":"204a0de6_e942d8cf","updated":"2022-05-31 09:08:36.000000000","message":"one beer credit has been deposited in your account \\o/","commit_id":"85ed3148afb4fd0a1db8e76baec930a29cea4bee"}]}