)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"089be45ca971ce4bb3c4ff9f5dd48149a1eb30ce","unresolved":true,"context_lines":[{"line_number":11,"context_line":"This patch depends on the feature [1] enabled on RGW, otherwise"},{"line_number":12,"context_line":"the config-key is ignored and not assimilated by the ceph cluster."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] https://github.com/ceph/ceph/pull/45469"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I2a83cb285e6865cc3c0bb7110d3e7f81c0953fb7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"30590edb_27cf965c","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":43},"updated":"2022-06-28 14:47:56.000000000","message":"this change is not yet merged. Why are we merging this before the change is fixed in Ceph ? Am I missing something ?","commit_id":"ba2e685011fc05b0e206412f5e3dcba55c7a16ac"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"b3f37c241a475bcd5ba06ca6396b2e1caa3e39c0","unresolved":true,"context_lines":[{"line_number":11,"context_line":"This patch depends on the feature [1] enabled on RGW, otherwise"},{"line_number":12,"context_line":"the config-key is ignored and not assimilated by the ceph cluster."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] https://github.com/ceph/ceph/pull/45469"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I2a83cb285e6865cc3c0bb7110d3e7f81c0953fb7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"d92deb12_5582d70f","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":43},"in_reply_to":"30590edb_27cf965c","updated":"2022-06-28 14:53:12.000000000","message":"with cephadm we\u0027re assimilating the config keys generated at this level: if the Ceph PR is not merged and that config doesn\u0027t exists, it\u0027s just ignored [2]. This means we can merge this patch before and having the feature enabled \"for free\" when the patch [1] lands.\n\n[1] https://github.com/ceph/ceph/pull/45469\n[2] https://github.com/ceph/ceph/blob/v16.2.9/src/mon/ConfigMonitor.cc#L659-L662","commit_id":"ba2e685011fc05b0e206412f5e3dcba55c7a16ac"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f051c8f072f6606f2ba335b9f29ba7881d57c0d7","unresolved":true,"context_lines":[{"line_number":11,"context_line":"This patch depends on the feature [1] enabled on RGW, otherwise"},{"line_number":12,"context_line":"the config-key is ignored and not assimilated by the ceph cluster."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] https://github.com/ceph/ceph/pull/45469"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I2a83cb285e6865cc3c0bb7110d3e7f81c0953fb7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"4296ab7c_7819f7b6","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":43},"in_reply_to":"d92deb12_5582d70f","updated":"2022-06-28 14:59:01.000000000","message":"My concern is that the interface might be changed unless the patch has been merged. If any change is made in the parmaeter interface then that would cause a problem or requires additional update, which I believe we should avoid.\n\nI\u0027d not block this in case you need this now \"for some reason\" but please consider keeping the TODO to check the PR later to confirm the actual commit is consistent with current expectation.","commit_id":"ba2e685011fc05b0e206412f5e3dcba55c7a16ac"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"d2d2dd7ca7a7549ea33a94713b0a999484bcc629","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f45214aa_b9bdc7e2","updated":"2022-05-18 06:53:53.000000000","message":"check-rdo","commit_id":"e0b509e49fe4cb98579edd2aeb032c874cd5cfda"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"7ce631f4146a533c8cb530dbaaa041f0a7ad81d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a139ab6b_1ec15754","updated":"2022-06-28 09:12:12.000000000","message":"recheck","commit_id":"ba2e685011fc05b0e206412f5e3dcba55c7a16ac"}]}