)]}'
{"environments/undercloud.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"039a98ca79abfa5bd0c4a869bfe4abf1dc0b1421","unresolved":true,"context_lines":[{"line_number":18,"context_line":"  OS::TripleO::Services::HeatEphemeral: ../deployment/heat/heat-ephemeral-container-ansible.yaml"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  # Disable keystone by default"},{"line_number":21,"context_line":"  OS::TripleO::Services::Keystone: OS::Heat::None"},{"line_number":22,"context_line":"  OS::TripleO::Services::Memcached: OS::Heat::None"},{"line_number":23,"context_line":"  # services we disable by default on the undercloud"},{"line_number":24,"context_line":"  OS::TripleO::Services::AodhApi: OS::Heat::None"},{"line_number":25,"context_line":"  OS::TripleO::Services::AodhEvaluator: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4c8f42bc_9657ec6e","side":"PARENT","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":50},"updated":"2022-05-23 10:33:42.000000000","message":"We don\u0027t test keystone on undercloud anymore. If we\u0027re removing we should remove these too.","commit_id":"6025f9cb56cc96148b19621d7055a86669f0aed5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c17a713be303145989ecefec377b09e184c86e9c","unresolved":true,"context_lines":[{"line_number":18,"context_line":"  OS::TripleO::Services::HeatEphemeral: ../deployment/heat/heat-ephemeral-container-ansible.yaml"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  # Disable keystone by default"},{"line_number":21,"context_line":"  OS::TripleO::Services::Keystone: OS::Heat::None"},{"line_number":22,"context_line":"  OS::TripleO::Services::Memcached: OS::Heat::None"},{"line_number":23,"context_line":"  # services we disable by default on the undercloud"},{"line_number":24,"context_line":"  OS::TripleO::Services::AodhApi: OS::Heat::None"},{"line_number":25,"context_line":"  OS::TripleO::Services::AodhEvaluator: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f4b516d_6f6df8b1","side":"PARENT","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":50},"in_reply_to":"4c8f42bc_9657ec6e","updated":"2022-05-26 14:31:03.000000000","message":"Oh, yes. I\u0027ll cover this in a follow-up.","commit_id":"6025f9cb56cc96148b19621d7055a86669f0aed5"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"039a98ca79abfa5bd0c4a869bfe4abf1dc0b1421","unresolved":true,"context_lines":[{"line_number":42,"context_line":"  OS::TripleO::Services::HeatApiCfn: OS::Heat::None"},{"line_number":43,"context_line":"  OS::TripleO::Services::HeatApiCloudwatch: OS::Heat::None"},{"line_number":44,"context_line":"  OS::TripleO::Services::HeatEngine: OS::Heat::None"},{"line_number":45,"context_line":"  OS::TripleO::Services::NovaApi: OS::Heat::None"},{"line_number":46,"context_line":"  OS::TripleO::Services::NovaConductor: OS::Heat::None"},{"line_number":47,"context_line":"  OS::TripleO::Services::NovaIronic: OS::Heat::None"},{"line_number":48,"context_line":"  OS::TripleO::Services::NovaMetadata: OS::Heat::None"},{"line_number":49,"context_line":"  OS::TripleO::Services::NovaScheduler: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c6e5b465_fb7b206b","side":"PARENT","line":46,"range":{"start_line":45,"start_character":1,"end_line":46,"end_character":54},"updated":"2022-05-23 10:33:42.000000000","message":"I would not remove these. These kind of additionally ensure overriding what\u0027s defined in overcloud-resource-registry-puppet.j2.yaml[1], though these services are not there in https://github.com/openstack/tripleo-heat-templates/blob/master/roles_data_undercloud.yaml.\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/overcloud-resource-registry-puppet.j2.yaml#L191","commit_id":"6025f9cb56cc96148b19621d7055a86669f0aed5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c17a713be303145989ecefec377b09e184c86e9c","unresolved":true,"context_lines":[{"line_number":42,"context_line":"  OS::TripleO::Services::HeatApiCfn: OS::Heat::None"},{"line_number":43,"context_line":"  OS::TripleO::Services::HeatApiCloudwatch: OS::Heat::None"},{"line_number":44,"context_line":"  OS::TripleO::Services::HeatEngine: OS::Heat::None"},{"line_number":45,"context_line":"  OS::TripleO::Services::NovaApi: OS::Heat::None"},{"line_number":46,"context_line":"  OS::TripleO::Services::NovaConductor: OS::Heat::None"},{"line_number":47,"context_line":"  OS::TripleO::Services::NovaIronic: OS::Heat::None"},{"line_number":48,"context_line":"  OS::TripleO::Services::NovaMetadata: OS::Heat::None"},{"line_number":49,"context_line":"  OS::TripleO::Services::NovaScheduler: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8c9a08e2_c7445347","side":"PARENT","line":46,"range":{"start_line":45,"start_character":1,"end_line":46,"end_character":54},"in_reply_to":"c6e5b465_fb7b206b","updated":"2022-05-26 14:31:03.000000000","message":"We\u0027d be able to maintain these.\n\nHowever the current list is incomplete (For example it is missing some of OS::TripleO::Services::Logging:: ), and I\u0027m not sure how much beneficial to keep the list properly updated","commit_id":"6025f9cb56cc96148b19621d7055a86669f0aed5"}]}