)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"19ff3d30afcbc10baf9dfdf284e97ebf55f3753e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"32118664_d65b0a79","updated":"2022-05-17 12:19:10.000000000","message":"Hmm, looks like the cleanup script and service are being referenced elsewhere and removing them is causing the undercloud install to fail:\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/deployment/neutron/neutron-ovs-agent-container-puppet.yaml#L374-L384\n\nhttps://zuul.opendev.org/t/openstack/build/7e798378c40c4aaaae2b2ada87954c0b/log/logs/undercloud/home/zuul/undercloud_install.log\n\nSo we will need to restore those two files for now.","commit_id":"e7a8529442a0e58566c191f5e91fab79d15bad37"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"19a14bcc756e1c8caa967c3b87f58c7e089dab9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"eca6de50_71588d69","updated":"2022-05-17 12:20:51.000000000","message":"Marking -1 while this is WIP and still being tested.","commit_id":"e7a8529442a0e58566c191f5e91fab79d15bad37"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"f7df7e600084727ba7acaf3eec73bad34c400583","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"79e8ab2d_2bbf12d5","updated":"2022-05-17 23:12:26.000000000","message":"Looks like there is something wrong with that cleanup systemd service file:\n```\n{\"changed\": false, \"msg\": \"Error loading unit file \u0027neutron-cleanup\u0027: org.freedesktop.systemd1.BadUnitSetting \\\"Unit neutron-cleanup.service has a bad unit file setting.\\\"\"}\n```","commit_id":"8169903e36c6378d9aecf53109e46cf7cf802967"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"9da1bd66cc316699a13a0010c5b3cec0944658ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"83886190_68df2c37","updated":"2022-05-18 22:33:48.000000000","message":"This is failing because of:\nhttps://bugs.launchpad.net/tripleo/+bug/1973863\n\nUnrelated to the change being made here.","commit_id":"8169903e36c6378d9aecf53109e46cf7cf802967"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"b0a30119287cb419d91e1ed55274f75be0ddeed0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"12ef4c7b_0e377f54","updated":"2022-05-18 06:32:16.000000000","message":"This looks fine now. The issues was with the tripleo-ansible patch rather than this one.","commit_id":"8169903e36c6378d9aecf53109e46cf7cf802967"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"c6bde65913b2e297e0923575c2f3e72b12145f98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c6f420e1_2c9633e6","updated":"2022-05-18 10:34:42.000000000","message":"recheck","commit_id":"8169903e36c6378d9aecf53109e46cf7cf802967"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"2fb376abcee111be625ade042efcc15fd5830dd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c75d342b_2d0478c0","updated":"2022-05-17 17:39:00.000000000","message":"recheck","commit_id":"8169903e36c6378d9aecf53109e46cf7cf802967"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"b9bc07fcc8a0cf59afb41323f8db2acec94848bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d0a43ffe_4b67a1e7","updated":"2022-05-25 23:05:14.000000000","message":"I think it\u0027s failing due to https://bugs.launchpad.net/tripleo/+bug/1975646\n\nI will recheck","commit_id":"3d45b1b3e1007346d6dd08ee2edb42a45b112849"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"a3e667deacc6a5e4cb165d8f05411a69b54544d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5ae4511e_ef6a5abf","updated":"2022-05-23 00:39:28.000000000","message":"Looks good. Much cleaner implementation.","commit_id":"3d45b1b3e1007346d6dd08ee2edb42a45b112849"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"29cd926e95b773795eb390f04e44b4ca2c04b9fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4bb8c91e_8d437691","updated":"2022-05-26 12:05:12.000000000","message":"Tempest tests failing. I think we might already know about this, but it seems we have some jobs passing. Let\u0027s recheck it.","commit_id":"3d45b1b3e1007346d6dd08ee2edb42a45b112849"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"cf42008c7711b8870d84c5588666c0938be267a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"981c1119_b2cddac6","updated":"2022-05-25 23:05:43.000000000","message":"recheck","commit_id":"3d45b1b3e1007346d6dd08ee2edb42a45b112849"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"b77445429f6c52ad0ce0399a1429173934d3422a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f363c82d_68ff6ba8","updated":"2022-05-26 12:05:17.000000000","message":"recheck","commit_id":"3d45b1b3e1007346d6dd08ee2edb42a45b112849"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"0b8d28ac8cf497a1877b96109fcf679ebcd8a9b3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa1a4c70_212a3308","updated":"2022-05-25 07:00:34.000000000","message":"recheck","commit_id":"3d45b1b3e1007346d6dd08ee2edb42a45b112849"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"a43208dad00dac1ac7447bc9e06b55e1f824141d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d803f980_4c7cb54b","updated":"2022-09-19 18:18:35.000000000","message":"nice! thanks Lewis","commit_id":"aa0f5cccc5f768b82d28d6947ac44ae65674036a"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"69085f5be8c99c560c5a399778d08a055e51a29d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f3be3c45_87c35585","updated":"2022-09-15 23:22:07.000000000","message":"recheck now that the depends-on patch has merged","commit_id":"aa0f5cccc5f768b82d28d6947ac44ae65674036a"}],"deployment/ovn/ovn-controller-container-puppet.yaml":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"33adaa8f1265c187dedc73052f3d347598593b69","unresolved":true,"context_lines":[{"line_number":419,"context_line":"                        - {get_param: CertificateKeySize}"},{"line_number":420,"context_line":"                    ca: ipa"},{"line_number":421,"context_line":"      host_prep_tasks:"},{"line_number":422,"context_line":"        - name: Include host prep task"},{"line_number":423,"context_line":"          include_role:"},{"line_number":424,"context_line":"            name: tripleo_ovn"},{"line_number":425,"context_line":"            tasks_from: hostprep.yml"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"23d5ca07_9c7a1ea1","line":422,"range":{"start_line":422,"start_character":34,"end_line":422,"end_character":38},"updated":"2022-06-29 12:26:28.000000000","message":"tasks","commit_id":"3d45b1b3e1007346d6dd08ee2edb42a45b112849"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dc40692da93ad61a60cf790963548ddb5bb1f27f","unresolved":true,"context_lines":[{"line_number":425,"context_line":"        - name: Include host prep tasks"},{"line_number":426,"context_line":"          include_role:"},{"line_number":427,"context_line":"            name: tripleo_ovn"},{"line_number":428,"context_line":"            tasks_from: hostprep.yml"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"      external_deploy_tasks:"},{"line_number":431,"context_line":"        - when:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"50e22962_842e4b02","line":428,"range":{"start_line":428,"start_character":24,"end_line":428,"end_character":32},"updated":"2022-08-10 03:45:58.000000000","message":"@James do you have suggestion about any better naming ? This does not align with the original spec and in tripleo-keystone role you named a few files based on the purpose, rather than the step.","commit_id":"0a9ca686b1298fabd1da541c70a8588dcc620d85"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"cb55f0af1f063cafb7112842c1d498bb2e69fcc4","unresolved":true,"context_lines":[{"line_number":425,"context_line":"        - name: Include host prep tasks"},{"line_number":426,"context_line":"          include_role:"},{"line_number":427,"context_line":"            name: tripleo_ovn"},{"line_number":428,"context_line":"            tasks_from: hostprep.yml"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"      external_deploy_tasks:"},{"line_number":431,"context_line":"        - when:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5c6db5ae_1e7a3e20","line":428,"range":{"start_line":428,"start_character":24,"end_line":428,"end_character":32},"in_reply_to":"50e22962_842e4b02","updated":"2022-08-23 03:12:31.000000000","message":"Yeah, it should install.yml. I\u0027m going to change this as part of my addition to this role:\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/845653\n\nWe can either go ahead with this one, since the depends-on patch mentioned here is already merged with this hostprep.yml name. Or, we wait for my patch above to merge and we rename it here now.","commit_id":"0a9ca686b1298fabd1da541c70a8588dcc620d85"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c6db9ea0b6739c8852f7ea30443012f332727b39","unresolved":true,"context_lines":[{"line_number":425,"context_line":"        - name: Include host prep tasks"},{"line_number":426,"context_line":"          include_role:"},{"line_number":427,"context_line":"            name: tripleo_ovn"},{"line_number":428,"context_line":"            tasks_from: hostprep.yml"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"      external_deploy_tasks:"},{"line_number":431,"context_line":"        - when:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"b93c5bdb_62b1656b","line":428,"range":{"start_line":428,"start_character":24,"end_line":428,"end_character":32},"in_reply_to":"5c6db5ae_1e7a3e20","updated":"2022-09-05 01:44:23.000000000","message":"If we keep current name then it requires additional steps later when we do rename.\n\n- Copy hostprep.yml to install.yml in tripleo-ansible\n- Change tasks_from in tht\n- Remove hostprep.yml\n\nInstead of taking these redundant steps, I\u0027d prefer we rename the file first then use the renamed name here.","commit_id":"0a9ca686b1298fabd1da541c70a8588dcc620d85"}]}