)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"20036808152dd5b766bbf2e65bb4aed276ae65e6","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Updates for chrony role"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Updates the chrony-baremetal-ansible.yaml template to match the updated"},{"line_number":10,"context_line":"ansible-role-chrony task refactorings."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I672364d8358064626ac84dbda05da9151e5d568e"},{"line_number":13,"context_line":"Signed-off-by: James Slagle \u003cjslagle@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"24402b02_5bde0754","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":38},"updated":"2022-11-01 00:01:01.000000000","message":"Might be helpful to include a link to the mentioned refactorings for reference?","commit_id":"2592360ec6399406c085753eb44e067cc4e0d45a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"09e27f82880d61673b2a25d057c20daaa587baba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"61d7c522_5c161611","updated":"2022-10-27 18:35:25.000000000","message":"recheck","commit_id":"300cb9bb24a395ceeb81c322557105ce906a5cbd"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"20036808152dd5b766bbf2e65bb4aed276ae65e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a2644b4a_e2d7495c","updated":"2022-11-01 00:01:01.000000000","message":"Lgtm. Might be nice to include that reference to the refactoring you\u0027re referring to. I assume you mean things like this:\nhttps://github.com/openstack/ansible-role-chrony/commit/9528e8a0b75dbb8f6f9c0867766f69a8b077d611\n\nWhich make running tasks waitsync again from THT redundant. ","commit_id":"2592360ec6399406c085753eb44e067cc4e0d45a"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"38a4be71212e68a32a82599fca7df05fa2b05183","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f1de4888_79c5a085","updated":"2023-01-03 10:44:26.000000000","message":"recheck","commit_id":"2592360ec6399406c085753eb44e067cc4e0d45a"}],"deployment/timesync/chrony-baremetal-ansible.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e814cebe71573e8da8bc11baa653031389458c73","unresolved":true,"context_lines":[{"line_number":104,"context_line":"          dport: 123"},{"line_number":105,"context_line":"          proto: udp"},{"line_number":106,"context_line":"      host_prep_tasks:"},{"line_number":107,"context_line":"        - name: Install, Configure, Run, and Sync Chrony"},{"line_number":108,"context_line":"          include_role:"},{"line_number":109,"context_line":"            name: chrony"},{"line_number":110,"context_line":"      ansible_group_vars:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"aa0c7200_de5345da","line":107,"range":{"start_line":107,"start_character":45,"end_line":107,"end_character":56},"updated":"2022-10-28 03:29:15.000000000","message":"I think we better avoid explaining what is actually done within the role/task because we need to maintain this in tht when we add make any change(eg. adding a few more tasks) in tripleo-ansible. Probably the simple \"Set up corny\" or no name would make our maintenance easier.","commit_id":"300cb9bb24a395ceeb81c322557105ce906a5cbd"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"20036808152dd5b766bbf2e65bb4aed276ae65e6","unresolved":true,"context_lines":[{"line_number":120,"context_line":"        - name: Install, Configure and Run Chrony"},{"line_number":121,"context_line":"          include_role:"},{"line_number":122,"context_line":"            name: chrony"},{"line_number":123,"context_line":"        - name: Force NTP sync"},{"line_number":124,"context_line":"          command: chronyc makestep"},{"line_number":125,"context_line":"        - name: Ensure system is NTP time synced"},{"line_number":126,"context_line":"          command: chronyc waitsync 30"},{"line_number":127,"context_line":"      ansible_group_vars:"},{"line_number":128,"context_line":"        chrony_role_action: all"},{"line_number":129,"context_line":"        chrony_ntp_servers: {get_param: NtpServer}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"8457fcd2_022c723a","side":"PARENT","line":126,"range":{"start_line":123,"start_character":0,"end_line":126,"end_character":38},"updated":"2022-11-01 00:01:01.000000000","message":"Right, we can remove these because they are performed in the chrony role itself now:\nhttps://github.com/openstack/ansible-role-chrony/blob/9528e8a0b75dbb8f6f9c0867766f69a8b077d611/tasks/sync.yml","commit_id":"ae365c45b8d40960771e6cda91fc432db7832f5c"}]}