)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"6f52172fe075eded6d720b2d5dc96e033d01f6ec","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c04d7cd7_38b9f45a","updated":"2022-05-21 02:20:29.000000000","message":"Please note this change does not include https://review.opendev.org/c/842044\n\nShould I rebase this change on top of it?","commit_id":"cc6035c41345d18cd4f1c26d307e3c80b2a50b23"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"a67d7dab93a208976eb5aca26c20bed3e34ef1c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f4070ac3_3f0ca79e","in_reply_to":"c04d7cd7_38b9f45a","updated":"2022-05-25 07:03:13.000000000","message":"Done","commit_id":"cc6035c41345d18cd4f1c26d307e3c80b2a50b23"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"7399d3049cf899ebdce4d65db5c20b78b382a86f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8c77922b_321801ab","updated":"2022-05-23 05:25:16.000000000","message":"It seems the depends-on did not work? Maybe because I used the short URL.\n\n2022-05-22 23:58:57 | ERROR! Could not find specified file in role: tasks/externaldeploy.yml\n","commit_id":"c8ee26b044e2371bd76bbb6a6ead554dbad4d756"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"256bf7235ff2e596017152e7ce482d2268e3bb67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b2d2b5f3_c6e4aa4d","in_reply_to":"3ef43aa5_0ae1e1a8","updated":"2022-05-23 05:35:13.000000000","message":"Ack","commit_id":"c8ee26b044e2371bd76bbb6a6ead554dbad4d756"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"480902138f09b4b87cb47ed46ad404283c66aa77","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3ef43aa5_0ae1e1a8","in_reply_to":"8c77922b_321801ab","updated":"2022-05-23 05:30:06.000000000","message":"yeah, use the full URL maybe?\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/842822","commit_id":"c8ee26b044e2371bd76bbb6a6ead554dbad4d756"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"0243d8ebb38be11e9d2703095ce020b2f0b9d49b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e3e4121c_b8408807","updated":"2022-08-23 02:48:17.000000000","message":"Looks good to me. I\u0027m not sure these external tasks fit within the naming convention outlined by this spec:\nhttps://specs.openstack.org/openstack/tripleo-specs/specs/zed/decouple-tripleo-tasks.html\n\nLet\u0027s push it through, and if we want to change the naming convention too something different, we can push a follow up patch to do so.","commit_id":"abbd67f6fee3371ab53de574a2e73b3d8edb7e1b"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"1f54b4859568e9a3ab016d7f822edcebcf5190a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"48bd25e3_6dde07cf","updated":"2022-06-06 12:08:17.000000000","message":"check-rdo","commit_id":"abbd67f6fee3371ab53de574a2e73b3d8edb7e1b"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"fe5a7a124cdc2b73b217a1b3d30691f12b4426a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fb517703_62f414d9","updated":"2022-06-29 12:22:17.000000000","message":"check-rdo unrelated ovb failures","commit_id":"abbd67f6fee3371ab53de574a2e73b3d8edb7e1b"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"f3b6022e3a57a27f1bc47f92941f7742972ab7d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"288edb6e_d6c22da3","updated":"2022-06-06 06:39:00.000000000","message":"recheck","commit_id":"abbd67f6fee3371ab53de574a2e73b3d8edb7e1b"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"2da40c27a413f67bb0c9ea0bec60a9a48b4b8f72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4cfc9dad_95c8ee8b","updated":"2022-05-26 12:03:35.000000000","message":"recheck\n","commit_id":"abbd67f6fee3371ab53de574a2e73b3d8edb7e1b"}],"deployment/ovn/ovn-controller-container-puppet.yaml":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"01903b7be545c7eb0b6e35fe97201d228ee7680c","unresolved":true,"context_lines":[{"line_number":261,"context_line":"              jump:   \u0027NOTRACK\u0027"},{"line_number":262,"context_line":"              action: \u0027append\u0027"},{"line_number":263,"context_line":"              state: []"},{"line_number":264,"context_line":"      ansible_group_vars:"},{"line_number":265,"context_line":"        role_name: {get_param: RoleName}"},{"line_number":266,"context_line":"        playbook_dir: \"{{ playbook_dir }}\""},{"line_number":267,"context_line":"        stack_name: {get_param: RootStackName}"},{"line_number":268,"context_line":"        server_resource_names:"},{"line_number":269,"context_line":"          str_replace:"},{"line_number":270,"context_line":"            template: \u0027{{ groups[\"$ROLE_NAME\"] }}\u0027"},{"line_number":271,"context_line":"            params:"},{"line_number":272,"context_line":"              $ROLE_NAME: {get_param: RoleName}"},{"line_number":273,"context_line":"        ovn_bridge_mappings: {get_attr: [OVNBridgeMappingsValue, value, ovn_bridge_mappings]}"},{"line_number":274,"context_line":"        ovn_static_bridge_mac_mappings: {get_attr: [OVNBridgeMappingsValue, value, ovn_static_bridge_mac_mappings]}"},{"line_number":275,"context_line":"      config_settings:"},{"line_number":276,"context_line":"        map_merge:"},{"line_number":277,"context_line":"          - get_attr: [RoleParametersValue, value]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"79650f3a_dba41e30","line":274,"range":{"start_line":264,"start_character":1,"end_line":274,"end_character":115},"updated":"2022-05-22 22:10:30.000000000","message":"I don\u0027t think we can use any of these variables from group_vars here. Because the external_steps_tasks_step0.yaml playbook is only targeting the Undercloud.\n\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/common/deploy-steps.j2#L473\n\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/common/deploy-steps.j2#L39-L42\n\nSo I think we will need to pass any variables that this playbook uses to the role when we include it - like you have already done below.\n\nUnless you see a use for these variables being in group_vars further down the line. I would just remove them from here entirely.","commit_id":"95d9fb7aad9eecd848b96cae5cc3302b4acfa05a"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"bf3bb667195773944637710996aa3851eb729399","unresolved":false,"context_lines":[{"line_number":261,"context_line":"              jump:   \u0027NOTRACK\u0027"},{"line_number":262,"context_line":"              action: \u0027append\u0027"},{"line_number":263,"context_line":"              state: []"},{"line_number":264,"context_line":"      ansible_group_vars:"},{"line_number":265,"context_line":"        role_name: {get_param: RoleName}"},{"line_number":266,"context_line":"        playbook_dir: \"{{ playbook_dir }}\""},{"line_number":267,"context_line":"        stack_name: {get_param: RootStackName}"},{"line_number":268,"context_line":"        server_resource_names:"},{"line_number":269,"context_line":"          str_replace:"},{"line_number":270,"context_line":"            template: \u0027{{ groups[\"$ROLE_NAME\"] }}\u0027"},{"line_number":271,"context_line":"            params:"},{"line_number":272,"context_line":"              $ROLE_NAME: {get_param: RoleName}"},{"line_number":273,"context_line":"        ovn_bridge_mappings: {get_attr: [OVNBridgeMappingsValue, value, ovn_bridge_mappings]}"},{"line_number":274,"context_line":"        ovn_static_bridge_mac_mappings: {get_attr: [OVNBridgeMappingsValue, value, ovn_static_bridge_mac_mappings]}"},{"line_number":275,"context_line":"      config_settings:"},{"line_number":276,"context_line":"        map_merge:"},{"line_number":277,"context_line":"          - get_attr: [RoleParametersValue, value]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bd46730e_e20e1963","line":274,"range":{"start_line":264,"start_character":1,"end_line":274,"end_character":115},"in_reply_to":"79650f3a_dba41e30","updated":"2022-05-23 05:20:57.000000000","message":"Done","commit_id":"95d9fb7aad9eecd848b96cae5cc3302b4acfa05a"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"bc23568c59661678cd0d8cdf200038a1cbaa515b","unresolved":true,"context_lines":[{"line_number":461,"context_line":"                name: tripleo_ovn"},{"line_number":462,"context_line":"                tasks_from: externaldeploy.yml"},{"line_number":463,"context_line":"              vars:"},{"line_number":464,"context_line":"                host_role_name: {get_param: RoleName}"},{"line_number":465,"context_line":"                stack_name: {get_param: RootStackName}"},{"line_number":466,"context_line":"                ovn_bridge_mappings: {get_attr: [OVNBridgeMappingsValue, value, ovn_bridge_mappings]}"},{"line_number":467,"context_line":"                ovn_static_bridge_mac_mappings: {get_attr: [OVNBridgeMappingsValue, value, ovn_static_bridge_mac_mappings]}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ec0320ba_cb99e6a7","line":464,"updated":"2022-05-25 05:22:21.000000000","message":"Use tripleo_role_name instead of host_role_name, this is something we already do elsewhere so it\u0027s good to maintain consistency.","commit_id":"a73eb9b82961c106b02b3a813197747e5bec6826"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"a67d7dab93a208976eb5aca26c20bed3e34ef1c7","unresolved":false,"context_lines":[{"line_number":461,"context_line":"                name: tripleo_ovn"},{"line_number":462,"context_line":"                tasks_from: externaldeploy.yml"},{"line_number":463,"context_line":"              vars:"},{"line_number":464,"context_line":"                host_role_name: {get_param: RoleName}"},{"line_number":465,"context_line":"                stack_name: {get_param: RootStackName}"},{"line_number":466,"context_line":"                ovn_bridge_mappings: {get_attr: [OVNBridgeMappingsValue, value, ovn_bridge_mappings]}"},{"line_number":467,"context_line":"                ovn_static_bridge_mac_mappings: {get_attr: [OVNBridgeMappingsValue, value, ovn_static_bridge_mac_mappings]}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2909b8a2_9db4257c","line":464,"in_reply_to":"ec0320ba_cb99e6a7","updated":"2022-05-25 07:03:13.000000000","message":"Done","commit_id":"a73eb9b82961c106b02b3a813197747e5bec6826"}]}