)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e85d8d0051904afef674d3044517a7dfa16143c6","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Signed-off-by: Bogdan Dobrelya \u003cbdobreli@redhat.com\u003e"},{"line_number":17,"context_line":"Change-Id: I7f481f2772f668e7804be93c545116d19ada46ae"},{"line_number":18,"context_line":"(cherry picked from commit 3885a18ba4e65836598774c79e5c0a6bef922e74)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"4b08a222_2059deb2","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":68},"updated":"2022-06-07 07:36:16.000000000","message":"cherry-picked on master? Seems like commit hash of an older patchset,","commit_id":"8e355f5fc70cc2b3ac1c1cd6f46c1a2be7570b96"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5c5235ff9121124bfcab47fa38c68dc96ec6c068","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Signed-off-by: Bogdan Dobrelya \u003cbdobreli@redhat.com\u003e"},{"line_number":17,"context_line":"Change-Id: I7f481f2772f668e7804be93c545116d19ada46ae"},{"line_number":18,"context_line":"(cherry picked from commit 3885a18ba4e65836598774c79e5c0a6bef922e74)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1c19d8da_aba68ab2","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":68},"in_reply_to":"4b08a222_2059deb2","updated":"2022-06-07 12:44:20.000000000","message":"Done","commit_id":"8e355f5fc70cc2b3ac1c1cd6f46c1a2be7570b96"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ca2790020981acd159c76a426b43527bf8443ff7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"218704ac_ba373eb9","updated":"2022-05-26 16:18:04.000000000","message":"This would kill the monolithic libvirt service which is deprecated but still supported. To support both you need to add a systemd target which I was trying in https://review.opendev.org/c/openstack/tripleo-heat-templates/+/839311\n\nAlso, it\u0027d be better to link https://bugs.launchpad.net/tripleo/+bug/1967021 .","commit_id":"be1a351dc3239fc0a726f4f04c538b2164432a06"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"fa37e0d5b9120a986c7ecc3b7e952e1d5cfc1ab7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cac4c7c0_4ffdedeb","updated":"2022-05-25 13:40:44.000000000","message":"recheck","commit_id":"be1a351dc3239fc0a726f4f04c538b2164432a06"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2c836f2ff4f56665d9971220df8054f4295e0c8e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"237386ef_2093b63f","in_reply_to":"218704ac_ba373eb9","updated":"2022-05-26 16:21:35.000000000","message":"(posting this to open my comment)","commit_id":"be1a351dc3239fc0a726f4f04c538b2164432a06"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"0b739c13cc8bdc33bcb5ccae35d9d8792b9cc0a5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d193c6ca_3f683ed9","in_reply_to":"237386ef_2093b63f","updated":"2022-05-30 12:02:57.000000000","message":"Monolithic and modular containers cannot co-exist on a host. Mind clarifying that corner case please?","commit_id":"be1a351dc3239fc0a726f4f04c538b2164432a06"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c8ede2a4c7bcfe83b3a5aa9318573f59b0abdcdf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aa91e823_6bf8b162","in_reply_to":"d193c6ca_3f683ed9","updated":"2022-05-30 13:51:34.000000000","message":"Done","commit_id":"be1a351dc3239fc0a726f4f04c538b2164432a06"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9f2e6141d51b9f1d50c678a2994accef3007d6a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"484f4f51_71d273ad","updated":"2022-05-26 16:21:14.000000000","message":"Sorry I rebased this patch accidentally while I intended to rebase mine ...","commit_id":"51277fd197612741a5a1e61e8c11f4d76cdcddc8"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e85d8d0051904afef674d3044517a7dfa16143c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"764b1806_3000fe0f","updated":"2022-06-07 07:36:16.000000000","message":"Needs rebase for merge conflict.","commit_id":"8e355f5fc70cc2b3ac1c1cd6f46c1a2be7570b96"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"13591f39a839117dc934b1e55182889082620e5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1c20bccb_230e4756","updated":"2022-06-03 13:20:41.000000000","message":"recheck","commit_id":"8e355f5fc70cc2b3ac1c1cd6f46c1a2be7570b96"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"31128308d5a34da399d711ca5ff14f74012032ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9604f290_22260aef","updated":"2022-07-04 13:55:15.000000000","message":"I\u0027ll merge this now but please consider merging the follow-up patch to fix the service to make it work with monolithic libvirt.","commit_id":"dccd879ce9056fffaf3d3cb38ee3def8afb505e0"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1e1f06f6698c504b62b82940d798bae66b334e27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"70e9a6ba_c71df63e","updated":"2022-06-23 13:39:08.000000000","message":"PTAL","commit_id":"dccd879ce9056fffaf3d3cb38ee3def8afb505e0"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c819a3c3f95dabcfcb70d3c5e2f3341c4998231f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6efc042c_c9f43bc3","updated":"2022-07-04 13:26:12.000000000","message":"sup","commit_id":"dccd879ce9056fffaf3d3cb38ee3def8afb505e0"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8a7c060f42cd4d13523a233d5a041c49744601cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"da79cd84_5c5198c5","updated":"2022-07-05 15:06:21.000000000","message":"thank you!\nI don\u0027t think there is anything to fix for monolithic libvirt becase tripleo_libvirt container just works as is for it","commit_id":"dccd879ce9056fffaf3d3cb38ee3def8afb505e0"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"499aec3990e38800a8ac90371b042a5b7cd30a0d","unresolved":true,"context_lines":[{"line_number":1479,"context_line":"                    Requires\u003dvirt-guest-shutdown.target"},{"line_number":1480,"context_line":"                    After\u003dsystemd-machined.service"},{"line_number":1481,"context_line":"                    After\u003dnetwork-online.target"},{"line_number":1482,"context_line":"                    After\u003dtripleo_nova_libvirt.target"},{"line_number":1483,"context_line":"                    Before\u003dtripleo_nova_compute.service"},{"line_number":1484,"context_line":"                    Documentation\u003dman:libvirtd(8)"},{"line_number":1485,"context_line":"                    Documentation\u003dhttps://libvirt.org"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"60bcfd72_340a4b97","line":1482,"updated":"2022-05-30 13:40:53.000000000","message":"should add tripleo_nova_virtproxyd.target here as well?","commit_id":"442d3b5d1d496c435147af881c045676d555f6c1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c8ede2a4c7bcfe83b3a5aa9318573f59b0abdcdf","unresolved":false,"context_lines":[{"line_number":1479,"context_line":"                    Requires\u003dvirt-guest-shutdown.target"},{"line_number":1480,"context_line":"                    After\u003dsystemd-machined.service"},{"line_number":1481,"context_line":"                    After\u003dnetwork-online.target"},{"line_number":1482,"context_line":"                    After\u003dtripleo_nova_libvirt.target"},{"line_number":1483,"context_line":"                    Before\u003dtripleo_nova_compute.service"},{"line_number":1484,"context_line":"                    Documentation\u003dman:libvirtd(8)"},{"line_number":1485,"context_line":"                    Documentation\u003dhttps://libvirt.org"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a4b4aa3f_29aaff48","line":1482,"in_reply_to":"60bcfd72_340a4b97","updated":"2022-05-30 13:51:34.000000000","message":"no, this target is being smart defined by the bottom patch","commit_id":"442d3b5d1d496c435147af881c045676d555f6c1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d66c26ea77d45f31a6542bd3b0ee06559e70ad06","unresolved":true,"context_lines":[{"line_number":1486,"context_line":""},{"line_number":1487,"context_line":"                    [Service]"},{"line_number":1488,"context_line":"                    EnvironmentFile\u003d-/etc/sysconfig/libvirt-guests"},{"line_number":1489,"context_line":"                    ExecStartPre\u003d-/bin/podman exec nova_libvirt /bin/rm -f /var/lib/libvirt/libvirt-guests"},{"line_number":1490,"context_line":"                    ExecStartPre\u003d-/bin/podman exec nova_virtproxyd /bin/rm -f /var/lib/libvirt/libvirt-guests"},{"line_number":1491,"context_line":"                    ExecStart\u003d/bin/true"},{"line_number":1492,"context_line":"                    ExecStopPre\u003d-/bin/podman exec nova_libvirt /bin/sh -x /usr/libexec/libvirt-guests.sh shutdown"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"343e6913_6ea2a763","line":1489,"updated":"2022-05-30 13:29:08.000000000","message":"we probably only need to cover both for Wallaby, where we do support modular and monolitic libvirt cases?\n\nso for master, I can put it as\n\nExecStart\u003d/bin/podman exec nova_virtproxyd /bin/rm -f /var/lib/libvirt/libvirt-guests","commit_id":"442d3b5d1d496c435147af881c045676d555f6c1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a8e6dd9cb5caff19587adc4951c7aa05fc8d993b","unresolved":false,"context_lines":[{"line_number":1486,"context_line":""},{"line_number":1487,"context_line":"                    [Service]"},{"line_number":1488,"context_line":"                    EnvironmentFile\u003d-/etc/sysconfig/libvirt-guests"},{"line_number":1489,"context_line":"                    ExecStartPre\u003d-/bin/podman exec nova_libvirt /bin/rm -f /var/lib/libvirt/libvirt-guests"},{"line_number":1490,"context_line":"                    ExecStartPre\u003d-/bin/podman exec nova_virtproxyd /bin/rm -f /var/lib/libvirt/libvirt-guests"},{"line_number":1491,"context_line":"                    ExecStart\u003d/bin/true"},{"line_number":1492,"context_line":"                    ExecStopPre\u003d-/bin/podman exec nova_libvirt /bin/sh -x /usr/libexec/libvirt-guests.sh shutdown"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"35c8257e_98012662","line":1489,"in_reply_to":"343e6913_6ea2a763","updated":"2022-05-30 13:49:34.000000000","message":"Done","commit_id":"442d3b5d1d496c435147af881c045676d555f6c1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c8ede2a4c7bcfe83b3a5aa9318573f59b0abdcdf","unresolved":true,"context_lines":[{"line_number":1490,"context_line":"                    EnvironmentFile\u003d-/var/lib/config-data/puppet-generated/nova_libvirt/etc/sysconfig/libvirt-guests"},{"line_number":1491,"context_line":"                    # Hack just call traditional service until we factor"},{"line_number":1492,"context_line":"                    # out the code"},{"line_number":1493,"context_line":"                    ExecStart\u003d/bin/{{container_cli}} exec nova_libvirt /bin/sh -x /usr/libexec/libvirt-guests.sh start"},{"line_number":1494,"context_line":"                    ExecStop\u003d/bin/{{container_cli}} stop nova_compute"},{"line_number":1495,"context_line":"                    ExecStop\u003d/bin/{{container_cli}}  exec nova_libvirt /bin/sh -x /usr/libexec/libvirt-guests.sh stop"},{"line_number":1496,"context_line":"                    Type\u003doneshot"},{"line_number":1497,"context_line":"                    RemainAfterExit\u003dyes"},{"line_number":1498,"context_line":"                    StandardOutput\u003djournal+console"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfa41a6c_40d567e4","side":"PARENT","line":1495,"range":{"start_line":1493,"start_character":0,"end_line":1495,"end_character":117},"updated":"2022-05-30 13:51:34.000000000","message":"so the question is, should I restore these commands and the service unit lost after the docker to podman switch?","commit_id":"11fbf75dd2021be1f73b47cb7d1b9b90108be0f3"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d9e0291e2f40c22318ba09ec8b3770094e3c8ea3","unresolved":false,"context_lines":[{"line_number":1490,"context_line":"                    EnvironmentFile\u003d-/var/lib/config-data/puppet-generated/nova_libvirt/etc/sysconfig/libvirt-guests"},{"line_number":1491,"context_line":"                    # Hack just call traditional service until we factor"},{"line_number":1492,"context_line":"                    # out the code"},{"line_number":1493,"context_line":"                    ExecStart\u003d/bin/{{container_cli}} exec nova_libvirt /bin/sh -x /usr/libexec/libvirt-guests.sh start"},{"line_number":1494,"context_line":"                    ExecStop\u003d/bin/{{container_cli}} stop nova_compute"},{"line_number":1495,"context_line":"                    ExecStop\u003d/bin/{{container_cli}}  exec nova_libvirt /bin/sh -x /usr/libexec/libvirt-guests.sh stop"},{"line_number":1496,"context_line":"                    Type\u003doneshot"},{"line_number":1497,"context_line":"                    RemainAfterExit\u003dyes"},{"line_number":1498,"context_line":"                    StandardOutput\u003djournal+console"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c33ae967_732de2f9","side":"PARENT","line":1495,"range":{"start_line":1493,"start_character":0,"end_line":1495,"end_character":117},"in_reply_to":"6473a72f_461f03f1","updated":"2022-05-30 14:04:47.000000000","message":"Ack","commit_id":"11fbf75dd2021be1f73b47cb7d1b9b90108be0f3"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"00abce03c2c5a97eb308ce48966378458ae9a802","unresolved":true,"context_lines":[{"line_number":1490,"context_line":"                    EnvironmentFile\u003d-/var/lib/config-data/puppet-generated/nova_libvirt/etc/sysconfig/libvirt-guests"},{"line_number":1491,"context_line":"                    # Hack just call traditional service until we factor"},{"line_number":1492,"context_line":"                    # out the code"},{"line_number":1493,"context_line":"                    ExecStart\u003d/bin/{{container_cli}} exec nova_libvirt /bin/sh -x /usr/libexec/libvirt-guests.sh start"},{"line_number":1494,"context_line":"                    ExecStop\u003d/bin/{{container_cli}} stop nova_compute"},{"line_number":1495,"context_line":"                    ExecStop\u003d/bin/{{container_cli}}  exec nova_libvirt /bin/sh -x /usr/libexec/libvirt-guests.sh stop"},{"line_number":1496,"context_line":"                    Type\u003doneshot"},{"line_number":1497,"context_line":"                    RemainAfterExit\u003dyes"},{"line_number":1498,"context_line":"                    StandardOutput\u003djournal+console"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"6473a72f_461f03f1","side":"PARENT","line":1495,"range":{"start_line":1493,"start_character":0,"end_line":1495,"end_character":117},"in_reply_to":"bfa41a6c_40d567e4","updated":"2022-05-30 13:56:35.000000000","message":"don\u0027t think we need that start as nova-compute service is responsible to start the instances. But we need to make sure nova-compute is down before libvirt-guests shutdown the instances. if the instance gets shut down and nova-compute is up, the instances gets set to off in the DB and on the host boot it won\u0027t get started","commit_id":"11fbf75dd2021be1f73b47cb7d1b9b90108be0f3"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f0fc38a61943c3f8d2d44b48296034cbeef31684","unresolved":true,"context_lines":[{"line_number":1480,"context_line":"                    After\u003dsystemd-machined.service"},{"line_number":1481,"context_line":"                    After\u003dnetwork-online.target"},{"line_number":1482,"context_line":"                    After\u003dtripleo_nova_libvirt.target"},{"line_number":1483,"context_line":"                    Before\u003dtripleo_nova_compute.service"},{"line_number":1484,"context_line":"                    Documentation\u003dman:libvirtd(8)"},{"line_number":1485,"context_line":"                    Documentation\u003dhttps://libvirt.org"},{"line_number":1486,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7e9e1d13_86ab142f","line":1483,"updated":"2022-05-30 15:00:48.000000000","message":"this creates wrong shutdown dependency, compare it to what we have for tripleo-container-shutdown-service [0]:\n\ndocker \u0026 pacemaker.service -\u003e (\u003c-after) tripleo-container-shutdown -\u003e (before) -\u003e shutdown.target\n\nand here it will create:\nsystemd-machined \u0026 virt-guest-shutdown empty target (\u003c- after/requires) tripleo_nova_libvirt_guests.service, calls /usr/libexec/libvirt-guests.sh shutdown -\u003e (before) -\u003e tripleo_nova_compute.service (should be requires!?)\n\n[0] https://opendev.org/openstack/tripleo-ansible/src/branch/master/tripleo_ansible/roles/tripleo_container_manage/files/tripleo-container-shutdown-service#L8","commit_id":"d6e644920a689b63716c6d729a1d270ac6c49a17"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"91ec7f2fdefb2353e340ef499978646177a577ea","unresolved":false,"context_lines":[{"line_number":1480,"context_line":"                    After\u003dsystemd-machined.service"},{"line_number":1481,"context_line":"                    After\u003dnetwork-online.target"},{"line_number":1482,"context_line":"                    After\u003dtripleo_nova_libvirt.target"},{"line_number":1483,"context_line":"                    Before\u003dtripleo_nova_compute.service"},{"line_number":1484,"context_line":"                    Documentation\u003dman:libvirtd(8)"},{"line_number":1485,"context_line":"                    Documentation\u003dhttps://libvirt.org"},{"line_number":1486,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ecc95b21_f101da14","line":1483,"in_reply_to":"046d2b46_7097529a","updated":"2022-05-30 15:39:49.000000000","message":"so basically this is:\n\ntripleo_nova_compute.service -\u003e (\u003c- before) tripleo_nova_libvirt_guests.service, calls /usr/libexec/libvirt-guests.sh shutdown -\u003e (after/requires) -\u003e systemd-machined \u0026 virt-guest-shutdown empty target \u0026 tripleo_nova_libvirt.target\n\nand this matches:\nn-cpu -\u003e after+wants -\u003e libvirt target\n\nand also follows the established pattern with tripleo-container-shutdown-service:\nshutdown.target -\u003e (\u003c- before) tripleo-container-shutdown, docker only -\u003e (after) docker \u0026 pacemaker.service\n\nSo we don\u0027t need that stop nova_compute command.","commit_id":"d6e644920a689b63716c6d729a1d270ac6c49a17"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a772d5dc85a62eedbdb8a04db25350bf235e51a8","unresolved":false,"context_lines":[{"line_number":1480,"context_line":"                    After\u003dsystemd-machined.service"},{"line_number":1481,"context_line":"                    After\u003dnetwork-online.target"},{"line_number":1482,"context_line":"                    After\u003dtripleo_nova_libvirt.target"},{"line_number":1483,"context_line":"                    Before\u003dtripleo_nova_compute.service"},{"line_number":1484,"context_line":"                    Documentation\u003dman:libvirtd(8)"},{"line_number":1485,"context_line":"                    Documentation\u003dhttps://libvirt.org"},{"line_number":1486,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"046d2b46_7097529a","line":1483,"in_reply_to":"7e9e1d13_86ab142f","updated":"2022-05-30 15:35:13.000000000","message":"please disregard, its fine","commit_id":"d6e644920a689b63716c6d729a1d270ac6c49a17"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d9e0291e2f40c22318ba09ec8b3770094e3c8ea3","unresolved":true,"context_lines":[{"line_number":1487,"context_line":"                    [Service]"},{"line_number":1488,"context_line":"                    EnvironmentFile\u003d-/etc/sysconfig/libvirt-guests"},{"line_number":1489,"context_line":"                    ExecStart\u003d/bin/podman exec nova_virtproxyd /bin/rm -f /var/lib/libvirt/libvirt-guests"},{"line_number":1490,"context_line":"                    ExecStop\u003d/bin/podman exec nova_virtproxyd /bin/sh -x /usr/libexec/libvirt-guests.sh shutdown"},{"line_number":1491,"context_line":"                    Type\u003doneshot"},{"line_number":1492,"context_line":"                    RemainAfterExit\u003dyes"},{"line_number":1493,"context_line":"                    StandardOutput\u003djournal+console"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f07d1cda_d0cfad80","line":1490,"updated":"2022-05-30 14:04:47.000000000","message":"...well right, stopping nova compute unit should work automatically on systemd level","commit_id":"d6e644920a689b63716c6d729a1d270ac6c49a17"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"65042b4911878692f17d14ac953091acaba09cd8","unresolved":false,"context_lines":[{"line_number":1487,"context_line":"                    [Service]"},{"line_number":1488,"context_line":"                    EnvironmentFile\u003d-/etc/sysconfig/libvirt-guests"},{"line_number":1489,"context_line":"                    ExecStart\u003d/bin/podman exec nova_virtproxyd /bin/rm -f /var/lib/libvirt/libvirt-guests"},{"line_number":1490,"context_line":"                    ExecStop\u003d/bin/podman exec nova_virtproxyd /bin/sh -x /usr/libexec/libvirt-guests.sh shutdown"},{"line_number":1491,"context_line":"                    Type\u003doneshot"},{"line_number":1492,"context_line":"                    RemainAfterExit\u003dyes"},{"line_number":1493,"context_line":"                    StandardOutput\u003djournal+console"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5647e0df_17b8200a","line":1490,"in_reply_to":"f07d1cda_d0cfad80","updated":"2022-05-30 15:40:41.000000000","message":"Done","commit_id":"d6e644920a689b63716c6d729a1d270ac6c49a17"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"95f7f6e54ceec5bd909d9b529e2161daa750991a","unresolved":true,"context_lines":[{"line_number":1486,"context_line":""},{"line_number":1487,"context_line":"                    [Service]"},{"line_number":1488,"context_line":"                    EnvironmentFile\u003d-/etc/sysconfig/libvirt-guests"},{"line_number":1489,"context_line":"                    ExecStart\u003d/bin/podman exec nova_virtproxyd /bin/rm -f /var/lib/libvirt/libvirt-guests"},{"line_number":1490,"context_line":"                    ExecStop\u003d/bin/podman exec nova_virtproxyd /bin/sh -x /usr/libexec/libvirt-guests.sh shutdown"},{"line_number":1491,"context_line":"                    Type\u003doneshot"},{"line_number":1492,"context_line":"                    RemainAfterExit\u003dyes"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"90da3ad7_0dbe662e","line":1489,"updated":"2022-07-04 13:27:48.000000000","message":"Is multi-container only an option, or is the monolithic things dropped for good? If not, we may need to set a parameter for that in order to point to the correct entity depending on the way libvirt is deployed.. ?","commit_id":"dccd879ce9056fffaf3d3cb38ee3def8afb505e0"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"ee129eb98e72dc70cd34fa9dae05f6ac2ed02af3","unresolved":false,"context_lines":[{"line_number":1486,"context_line":""},{"line_number":1487,"context_line":"                    [Service]"},{"line_number":1488,"context_line":"                    EnvironmentFile\u003d-/etc/sysconfig/libvirt-guests"},{"line_number":1489,"context_line":"                    ExecStart\u003d/bin/podman exec nova_virtproxyd /bin/rm -f /var/lib/libvirt/libvirt-guests"},{"line_number":1490,"context_line":"                    ExecStop\u003d/bin/podman exec nova_virtproxyd /bin/sh -x /usr/libexec/libvirt-guests.sh shutdown"},{"line_number":1491,"context_line":"                    Type\u003doneshot"},{"line_number":1492,"context_line":"                    RemainAfterExit\u003dyes"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"83defbf7_384247ab","line":1489,"in_reply_to":"1445db91_b1125c3d","updated":"2022-07-04 13:30:57.000000000","message":"Ack","commit_id":"dccd879ce9056fffaf3d3cb38ee3def8afb505e0"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e6df12011a1808a2edd7be0d00cf5db3e1d7f259","unresolved":true,"context_lines":[{"line_number":1486,"context_line":""},{"line_number":1487,"context_line":"                    [Service]"},{"line_number":1488,"context_line":"                    EnvironmentFile\u003d-/etc/sysconfig/libvirt-guests"},{"line_number":1489,"context_line":"                    ExecStart\u003d/bin/podman exec nova_virtproxyd /bin/rm -f /var/lib/libvirt/libvirt-guests"},{"line_number":1490,"context_line":"                    ExecStop\u003d/bin/podman exec nova_virtproxyd /bin/sh -x /usr/libexec/libvirt-guests.sh shutdown"},{"line_number":1491,"context_line":"                    Type\u003doneshot"},{"line_number":1492,"context_line":"                    RemainAfterExit\u003dyes"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1445db91_b1125c3d","line":1489,"in_reply_to":"90da3ad7_0dbe662e","updated":"2022-07-04 13:28:50.000000000","message":"monolithic is deprecated and only backports are expected as of now","commit_id":"dccd879ce9056fffaf3d3cb38ee3def8afb505e0"}]}