)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"3ac9071098cc3b447f603fdccd0794e2b78da6dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"58aa92ae_3d843b62","updated":"2022-05-25 13:00:21.000000000","message":"testproject is here: https://review.rdoproject.org/r/c/testproject/+/42344","commit_id":"7b756dddc1fd93abc0f383b801a1bc639d61c865"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"038b2d2bd4c46e73b843f05d5aee16779fe6878a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dbba1cbc_5acd3c00","updated":"2022-05-25 13:14:00.000000000","message":"This is definitely cleaner !","commit_id":"6eb66751e1615190d1049f136041f67cc41c2ce2"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"a8d6908e6047fcd5480248878c3d1750b851d669","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"82e8fd80_545fb896","updated":"2022-05-30 06:55:02.000000000","message":"RDO failures aren\u0027t linked to the patch.","commit_id":"7386a25e871be444421b20df3204614c14ccaa09"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"56fe906fbdc01ff91f6945626a401b4d061fda2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fe18e823_ac360ae9","updated":"2022-05-31 09:50:22.000000000","message":"releasenote would be good as we\u0027re deprecating a service and adding a new one. Also, I would have liked to get rid of the service completely if only relevant for uc.","commit_id":"b1b989471d21f74df582ce48846c7c07257df9ce"}],"deployment/masquerade-networks/masquerade-networks-baremetal-ansible.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"038b2d2bd4c46e73b843f05d5aee16779fe6878a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                 via parameter_defaults in the resource registry."},{"line_number":29,"context_line":"    type: json"},{"line_number":30,"context_line":"  MasqueradeNetworks:"},{"line_number":31,"context_line":"    default: {\u0027192.168.24.0/24\u0027: [\u0027192.168.24.0/24\u0027, \u0027192.168.25.0/24\u0027]}"},{"line_number":32,"context_line":"    description: Hash of masquerade networks to manage."},{"line_number":33,"context_line":"    type: json"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f72121b_bf816cc1","line":31,"range":{"start_line":31,"start_character":13,"end_line":31,"end_character":72},"updated":"2022-05-25 13:14:00.000000000","message":"(Just dumping my thoughts for record)\n\nAlternatively we can update this default to {} and just implement this MasqueradeNetworks parameter in firewall template.\n\nHowever I\u0027m good with the current approach with separate service because I don\u0027t want to see any case users would intentionally/unintentionally use this parameter in their overcloud :-)","commit_id":"6eb66751e1615190d1049f136041f67cc41c2ce2"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"86269f325e8b6e6cc0b6792f0b75a5ffc2115660","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                 via parameter_defaults in the resource registry."},{"line_number":29,"context_line":"    type: json"},{"line_number":30,"context_line":"  MasqueradeNetworks:"},{"line_number":31,"context_line":"    default: {\u0027192.168.24.0/24\u0027: [\u0027192.168.24.0/24\u0027, \u0027192.168.25.0/24\u0027]}"},{"line_number":32,"context_line":"    description: Hash of masquerade networks to manage."},{"line_number":33,"context_line":"    type: json"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"09870770_80ec45a2","line":31,"range":{"start_line":31,"start_character":13,"end_line":31,"end_character":72},"in_reply_to":"9f72121b_bf816cc1","updated":"2022-05-25 13:37:25.000000000","message":"I think keeping things with a clear and hard separation is better, especially since it MAY either break things (masquerading the wrong network) or open some doors we\u0027d better keep closed. At least, we don\u0027t change the current way things are done.","commit_id":"6eb66751e1615190d1049f136041f67cc41c2ce2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"038b2d2bd4c46e73b843f05d5aee16779fe6878a","unresolved":true,"context_lines":[{"line_number":35,"context_line":"outputs:"},{"line_number":36,"context_line":"  role_data:"},{"line_number":37,"context_line":"    description: Role data for the TripleO Masquerade Networks service."},{"line_number":38,"context_line":"    value:"},{"line_number":39,"context_line":"      service_name: masquerade_networks"},{"line_number":40,"context_line":"      ansible_group_vars:"},{"line_number":41,"context_line":"        tripleo_masquerade_networks: {get_param: MasqueradeNetworks }"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ece0c922_4a918de5","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":9},"updated":"2022-05-25 13:14:00.000000000","message":"just in case you update this patch for some reason (I guess template validation might fail because of some missing \"fundamental\" keys), it might be helpful to leave a note to explain the actual ansible task is imported by the firewall service resource.","commit_id":"6eb66751e1615190d1049f136041f67cc41c2ce2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3916adcda598f8d557f5fb8ccec0d7dcdf64bb04","unresolved":false,"context_lines":[{"line_number":35,"context_line":"outputs:"},{"line_number":36,"context_line":"  role_data:"},{"line_number":37,"context_line":"    description: Role data for the TripleO Masquerade Networks service."},{"line_number":38,"context_line":"    value:"},{"line_number":39,"context_line":"      service_name: masquerade_networks"},{"line_number":40,"context_line":"      ansible_group_vars:"},{"line_number":41,"context_line":"        tripleo_masquerade_networks: {get_param: MasqueradeNetworks }"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2e7567a4_638da557","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":9},"in_reply_to":"32056166_56729a21","updated":"2022-05-30 07:34:18.000000000","message":"Done","commit_id":"6eb66751e1615190d1049f136041f67cc41c2ce2"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"86269f325e8b6e6cc0b6792f0b75a5ffc2115660","unresolved":true,"context_lines":[{"line_number":35,"context_line":"outputs:"},{"line_number":36,"context_line":"  role_data:"},{"line_number":37,"context_line":"    description: Role data for the TripleO Masquerade Networks service."},{"line_number":38,"context_line":"    value:"},{"line_number":39,"context_line":"      service_name: masquerade_networks"},{"line_number":40,"context_line":"      ansible_group_vars:"},{"line_number":41,"context_line":"        tripleo_masquerade_networks: {get_param: MasqueradeNetworks }"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"32056166_56729a21","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":9},"in_reply_to":"ece0c922_4a918de5","updated":"2022-05-25 13:37:25.000000000","message":"Right. I\u0027ll consider this once I get the CI result. Thanks for that pointer!","commit_id":"6eb66751e1615190d1049f136041f67cc41c2ce2"}]}