)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1ee73c1ab6802c2120bb3cbc84f27089b84f40ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"49c267cc_7738cd46","updated":"2022-06-01 00:52:27.000000000","message":"The original intention of adding a separate Overrides option was to keep users to use the original SshOptions to \"remove\" any line in the default value. The behavior has been kept for several cycles so I was concerned about breaking any existing usage.\n\nHowever seeing multiple cases where users face problems when they try to use this parameter expecting it would be merged, I feel like that removal would be quite rare compared to override. So I\u0027m good with this change.","commit_id":"e174fd82cf11d65cfd02ca428774ee14548822c7"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"5d489b1d7a2e17f6e808559318021e587242e51c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8ef64056_363a9b57","updated":"2022-05-31 11:37:36.000000000","message":"We indeed got customer cases caused by this confusion. Keeping only one option, and calling the \"merge\" thingy is far easier to maintain and understand. Thank you Rabi!","commit_id":"e174fd82cf11d65cfd02ca428774ee14548822c7"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"008fdf47d64732f8dbee47cdbd160c6ebc80dcb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"52a65655_282ec77b","in_reply_to":"49c267cc_7738cd46","updated":"2022-06-01 01:54:31.000000000","message":"I don\u0027t see any usecase for removal of existing options. Either these options are (other than being set to specific value) deprecated with an alias (ex. KbdInteractiveAuthentication/ChallengeResponseAuthentication) or existing keys are ignored (not break an existing config).","commit_id":"e174fd82cf11d65cfd02ca428774ee14548822c7"}],"overcloud-resource-registry-puppet.j2.yaml":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"b4594573d5be9285c28854655ad0512176d5c56b","unresolved":true,"context_lines":[{"line_number":347,"context_line":"  ServiceNetMap: merge"},{"line_number":348,"context_line":"  VipSubnetMap: merge"},{"line_number":349,"context_line":"  EndpointMap: merge"},{"line_number":350,"context_line":"  SshServerOptions: merge"},{"line_number":351,"context_line":"{% for role in roles %}"},{"line_number":352,"context_line":"  {{role.name}}Parameters: merge"},{"line_number":353,"context_line":"{% endfor %}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0220c54d_27ce0a1c","line":350,"updated":"2022-05-31 11:44:23.000000000","message":"Would we need to use `deep_merge` here instead of `merge`?","commit_id":"e174fd82cf11d65cfd02ca428774ee14548822c7"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"56a3504ba7b6a595cbe3b8fa5496c7cf3c50fc2b","unresolved":true,"context_lines":[{"line_number":347,"context_line":"  ServiceNetMap: merge"},{"line_number":348,"context_line":"  VipSubnetMap: merge"},{"line_number":349,"context_line":"  EndpointMap: merge"},{"line_number":350,"context_line":"  SshServerOptions: merge"},{"line_number":351,"context_line":"{% for role in roles %}"},{"line_number":352,"context_line":"  {{role.name}}Parameters: merge"},{"line_number":353,"context_line":"{% endfor %}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2ba05e32_9c032b48","line":350,"in_reply_to":"0220c54d_27ce0a1c","updated":"2022-05-31 14:51:59.000000000","message":"No, it\u0027s map of key/value pairs and you don\u0027t merge specific key values.","commit_id":"e174fd82cf11d65cfd02ca428774ee14548822c7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bbdc0b7e5bd438e124cfc26e2072d2d007884aef","unresolved":false,"context_lines":[{"line_number":347,"context_line":"  ServiceNetMap: merge"},{"line_number":348,"context_line":"  VipSubnetMap: merge"},{"line_number":349,"context_line":"  EndpointMap: merge"},{"line_number":350,"context_line":"  SshServerOptions: merge"},{"line_number":351,"context_line":"{% for role in roles %}"},{"line_number":352,"context_line":"  {{role.name}}Parameters: merge"},{"line_number":353,"context_line":"{% endfor %}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a1294730_ffcc17fe","line":350,"in_reply_to":"2ba05e32_9c032b48","updated":"2022-06-03 13:21:44.000000000","message":"Ack","commit_id":"e174fd82cf11d65cfd02ca428774ee14548822c7"}]}