)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"4dcbfae2c72e0d55ff88ec254da94fcb509deaad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"924a664e_9b9100bd","updated":"2022-06-15 16:01:46.000000000","message":"Maybe the type currently doesn\u0027t matter but it might. I\u0027d rather have it changed.","commit_id":"6873441779c9903c71ad0921ec8e53466ac68880"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"abad7d894666f86e24642c2eb0cdb1106a74943e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2efa7973_6d48930b","updated":"2022-06-21 14:16:37.000000000","message":"LGTM","commit_id":"86d4a348a3c0a372154ead6e3db15e6444ffaa88"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"aaf070f46dc3488e34c6db638dc762ab4931781c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"29c20c31_ef7fd534","updated":"2022-06-21 14:30:57.000000000","message":"check-rdo","commit_id":"86d4a348a3c0a372154ead6e3db15e6444ffaa88"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"9435b67f1eceba97259954e55d1c3372a438d17e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"227a43bf_ad118e34","updated":"2022-06-22 10:04:35.000000000","message":"recheck","commit_id":"86d4a348a3c0a372154ead6e3db15e6444ffaa88"}],"deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8b3c058a33684f7c1a73b32120d77301bf4d77bb","unresolved":true,"context_lines":[{"line_number":104,"context_line":"                 Mainly for CI purpose.  It shouldn\u0027t matter on other distributions"},{"line_number":105,"context_line":"                 where it\u0027s disabled in the role. Set to true to skip the enforcement."},{"line_number":106,"context_line":"    type: boolean"},{"line_number":107,"context_line":"  DnfStreams:"},{"line_number":108,"context_line":"    default: []"},{"line_number":109,"context_line":"    description: List of streams to be configured before updating packages. Each list"},{"line_number":110,"context_line":"             element contains a dictionary with the following values defined"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e137e9d0_217fe003","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":13},"updated":"2022-06-06 12:39:10.000000000","message":"Shouldn\u0027t there be a release note to describe the change in this interface?","commit_id":"958cd9fef4ceeeae8d32de4a654712aaff40a96b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f58b342cd0f3153fbc0a524db7e293a325f6cd8c","unresolved":true,"context_lines":[{"line_number":104,"context_line":"                 Mainly for CI purpose.  It shouldn\u0027t matter on other distributions"},{"line_number":105,"context_line":"                 where it\u0027s disabled in the role. Set to true to skip the enforcement."},{"line_number":106,"context_line":"    type: boolean"},{"line_number":107,"context_line":"  DnfStreams:"},{"line_number":108,"context_line":"    default: []"},{"line_number":109,"context_line":"    description: List of streams to be configured before updating packages. Each list"},{"line_number":110,"context_line":"             element contains a dictionary with the following values defined"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4f603a81_111b3df8","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":13},"in_reply_to":"05974e58_2f37427f","updated":"2022-06-08 13:32:17.000000000","message":"This introduces a new mandatory key, which means that it will break any previous usage of this argument. Either we need to make it optional (and assume the same things as we did before), or we need to add a release note to notify anyone using this argument that there is a change in the configuration required.\n\nEven if it\u0027s optional, I\u0027d still say add a release note because it introduces a new data structure change which should be noted for anyone using this argument.","commit_id":"958cd9fef4ceeeae8d32de4a654712aaff40a96b"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"0bdc7648c39a1f79b878b6e9211a0152c97472c8","unresolved":true,"context_lines":[{"line_number":104,"context_line":"                 Mainly for CI purpose.  It shouldn\u0027t matter on other distributions"},{"line_number":105,"context_line":"                 where it\u0027s disabled in the role. Set to true to skip the enforcement."},{"line_number":106,"context_line":"    type: boolean"},{"line_number":107,"context_line":"  DnfStreams:"},{"line_number":108,"context_line":"    default: []"},{"line_number":109,"context_line":"    description: List of streams to be configured before updating packages. Each list"},{"line_number":110,"context_line":"             element contains a dictionary with the following values defined"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e5205f1e_7975727a","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":13},"in_reply_to":"4f603a81_111b3df8","updated":"2022-06-08 14:00:13.000000000","message":"Thank you for explaining that. I\u0027ll add release note soon.","commit_id":"958cd9fef4ceeeae8d32de4a654712aaff40a96b"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"541643f9ee9aeeed88666e5c35e01e18e7816276","unresolved":true,"context_lines":[{"line_number":104,"context_line":"                 Mainly for CI purpose.  It shouldn\u0027t matter on other distributions"},{"line_number":105,"context_line":"                 where it\u0027s disabled in the role. Set to true to skip the enforcement."},{"line_number":106,"context_line":"    type: boolean"},{"line_number":107,"context_line":"  DnfStreams:"},{"line_number":108,"context_line":"    default: []"},{"line_number":109,"context_line":"    description: List of streams to be configured before updating packages. Each list"},{"line_number":110,"context_line":"             element contains a dictionary with the following values defined"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"05974e58_2f37427f","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":13},"in_reply_to":"e137e9d0_217fe003","updated":"2022-06-08 09:27:53.000000000","message":"What is a general rule for creating or not creating release notes?\nI\u0027m aware that this changes interface, but every change introduces some fix or change. Just curious.","commit_id":"958cd9fef4ceeeae8d32de4a654712aaff40a96b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"93d88f21054f24cd603316e96fbbab05b3cdf3f0","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                 Mainly for CI purpose.  It shouldn\u0027t matter on other distributions"},{"line_number":105,"context_line":"                 where it\u0027s disabled in the role. Set to true to skip the enforcement."},{"line_number":106,"context_line":"    type: boolean"},{"line_number":107,"context_line":"  DnfStreams:"},{"line_number":108,"context_line":"    default: []"},{"line_number":109,"context_line":"    description: List of streams to be configured before updating packages. Each list"},{"line_number":110,"context_line":"             element contains a dictionary with the following values defined"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"43d8333b_a13b5923","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":13},"in_reply_to":"e5205f1e_7975727a","updated":"2022-06-09 08:28:44.000000000","message":"Done","commit_id":"958cd9fef4ceeeae8d32de4a654712aaff40a96b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"93d88f21054f24cd603316e96fbbab05b3cdf3f0","unresolved":true,"context_lines":[{"line_number":283,"context_line":"              loop: \"{{ dnf_module_list|list }}\""},{"line_number":284,"context_line":"              when:"},{"line_number":285,"context_line":"                - dnf_module_list|length \u003e 0"},{"line_number":286,"context_line":"                - item.distribution_version is defined and item.distribution_version \u003d\u003d ansible_facts[\u0027distribution_major_version\u0027]"},{"line_number":287,"context_line":"            - name: Ensure TripleO prerequisite packages are installed"},{"line_number":288,"context_line":"              package:"},{"line_number":289,"context_line":"                name:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"375ffb8b_693930fe","line":286,"range":{"start_line":286,"start_character":59,"end_line":286,"end_character":131},"updated":"2022-06-09 08:28:44.000000000","message":"Are we sure that both types are the same? Perhaps we should use \u0027| int\u0027 to force the type?","commit_id":"6873441779c9903c71ad0921ec8e53466ac68880"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"671531d5b761d468f5b1e014c46511151098f5a3","unresolved":true,"context_lines":[{"line_number":283,"context_line":"              loop: \"{{ dnf_module_list|list }}\""},{"line_number":284,"context_line":"              when:"},{"line_number":285,"context_line":"                - dnf_module_list|length \u003e 0"},{"line_number":286,"context_line":"                - item.distribution_version is defined and item.distribution_version \u003d\u003d ansible_facts[\u0027distribution_major_version\u0027]"},{"line_number":287,"context_line":"            - name: Ensure TripleO prerequisite packages are installed"},{"line_number":288,"context_line":"              package:"},{"line_number":289,"context_line":"                name:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"acb7d636_927a3eac","line":286,"updated":"2022-06-09 11:41:21.000000000","message":"not essential, but the line can be arranged vertically for easier reading:\n\n - item.distribution_version is defined\n - item.distribution_version \u003d\u003d ansible_facts[\u0027distribution_major_version\u0027]\n\nThe two conditions in the list are processed via a sequential logical AND, so the second condition will not be evaluated if the first is not met.","commit_id":"6873441779c9903c71ad0921ec8e53466ac68880"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"376f83bdca6f6280da521d3ffe0de5bb9e6c221e","unresolved":false,"context_lines":[{"line_number":283,"context_line":"              loop: \"{{ dnf_module_list|list }}\""},{"line_number":284,"context_line":"              when:"},{"line_number":285,"context_line":"                - dnf_module_list|length \u003e 0"},{"line_number":286,"context_line":"                - item.distribution_version is defined and item.distribution_version \u003d\u003d ansible_facts[\u0027distribution_major_version\u0027]"},{"line_number":287,"context_line":"            - name: Ensure TripleO prerequisite packages are installed"},{"line_number":288,"context_line":"              package:"},{"line_number":289,"context_line":"                name:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"43249a1c_790cea38","line":286,"range":{"start_line":286,"start_character":59,"end_line":286,"end_character":131},"in_reply_to":"375ffb8b_693930fe","updated":"2022-06-21 09:21:18.000000000","message":"Done","commit_id":"6873441779c9903c71ad0921ec8e53466ac68880"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"4dcbfae2c72e0d55ff88ec254da94fcb509deaad","unresolved":true,"context_lines":[{"line_number":283,"context_line":"              loop: \"{{ dnf_module_list|list }}\""},{"line_number":284,"context_line":"              when:"},{"line_number":285,"context_line":"                - dnf_module_list|length \u003e 0"},{"line_number":286,"context_line":"                - item.distribution_version is defined and item.distribution_version \u003d\u003d ansible_facts[\u0027distribution_major_version\u0027]"},{"line_number":287,"context_line":"            - name: Ensure TripleO prerequisite packages are installed"},{"line_number":288,"context_line":"              package:"},{"line_number":289,"context_line":"                name:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c8d1ea80_ca287e46","line":286,"in_reply_to":"acb7d636_927a3eac","updated":"2022-06-15 16:01:46.000000000","message":"Oki, I like the developed version, ie the one with two items.\n\nThen I think the point raised by Jesse might need love as it would diminish the chance of any surprise:\n\nrunning this:\n\n    ---\n    - hosts: localhost\n      vars:\n        - toto: 36\n        - tata: \"36\"\n      tasks:\n        - debug:\n           var: ansible_facts[\u0027distribution_major_version\u0027]\n          \n            \n        - debug:\n           msg: \"YOOOO\"\n          when:\n            - \"ansible_facts[\u0027distribution_major_version\u0027] \u003d\u003d toto\"\n        - debug:\n           msg: \"YAAAA\"\n          when:\n            - \"ansible_facts[\u0027distribution_major_version\u0027] \u003d\u003d tata\"\n        - debug:\n           msg: \"YIIII\"\n          when:\n          - \"ansible_facts[\u0027distribution_major_version\u0027] is version(toto, \u0027\u003d\u003d\u0027)\"\n    \n        - debug:\n           msg: \"YUUUU\"\n          when:\n          - \"ansible_facts[\u0027distribution_major_version\u0027] is version(tata, \u0027\u003d\u003d\u0027)\"\n    \ngives:\n    PLAY [localhost] \n    TASK [Gathering Facts] \n    ok: [localhost]\n    TASK [debug] \n    ok: [localhost] \u003d\u003e {\n        \"ansible_facts[\u0027distribution_major_version\u0027]\": \"36\"\n    }\n    TASK [debug] \n    skipping: [localhost]\n    TASK [debug] \n    ok: [localhost] \u003d\u003e {\n        \"msg\": \"YAAAA\"\n    }\n    TASK [debug] \n    ok: [localhost] \u003d\u003e {\n        \"msg\": \"YIIII\"\n    }\n    TASK [debug] \n    ok: [localhost] \u003d\u003e {\n        \"msg\": \"YUUUU\"\n    }\n\nSo type do matter as \"YOOOO\" is not there.  Maybe it doesn\u0027t in this\ncurrent context but better be full-proofed.\n\nChoose the idiom you like better (|int or is version).","commit_id":"6873441779c9903c71ad0921ec8e53466ac68880"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"376f83bdca6f6280da521d3ffe0de5bb9e6c221e","unresolved":false,"context_lines":[{"line_number":283,"context_line":"              loop: \"{{ dnf_module_list|list }}\""},{"line_number":284,"context_line":"              when:"},{"line_number":285,"context_line":"                - dnf_module_list|length \u003e 0"},{"line_number":286,"context_line":"                - item.distribution_version is defined and item.distribution_version \u003d\u003d ansible_facts[\u0027distribution_major_version\u0027]"},{"line_number":287,"context_line":"            - name: Ensure TripleO prerequisite packages are installed"},{"line_number":288,"context_line":"              package:"},{"line_number":289,"context_line":"                name:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"260a37d0_e39d1de1","line":286,"in_reply_to":"c8d1ea80_ca287e46","updated":"2022-06-21 09:21:18.000000000","message":"Done","commit_id":"6873441779c9903c71ad0921ec8e53466ac68880"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"93d88f21054f24cd603316e96fbbab05b3cdf3f0","unresolved":true,"context_lines":[{"line_number":402,"context_line":"          when:"},{"line_number":403,"context_line":"            - step|int \u003d\u003d 0"},{"line_number":404,"context_line":"            - dnf_module_list|length \u003e 0"},{"line_number":405,"context_line":"            - item.distribution_version is defined and item.distribution_version \u003d\u003d ansible_facts[\u0027distribution_major_version\u0027]"},{"line_number":406,"context_line":"        - name: Check for existing yum.pid"},{"line_number":407,"context_line":"          stat:  path\u003d/run/yum.pid"},{"line_number":408,"context_line":"          register: yum_pid_file"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b0625758_0d43206b","line":405,"range":{"start_line":405,"start_character":55,"end_line":405,"end_character":127},"updated":"2022-06-09 08:28:44.000000000","message":"Are we sure that both types are the same? Perhaps we should use \u0027| int\u0027 to force the type?","commit_id":"6873441779c9903c71ad0921ec8e53466ac68880"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"376f83bdca6f6280da521d3ffe0de5bb9e6c221e","unresolved":false,"context_lines":[{"line_number":402,"context_line":"          when:"},{"line_number":403,"context_line":"            - step|int \u003d\u003d 0"},{"line_number":404,"context_line":"            - dnf_module_list|length \u003e 0"},{"line_number":405,"context_line":"            - item.distribution_version is defined and item.distribution_version \u003d\u003d ansible_facts[\u0027distribution_major_version\u0027]"},{"line_number":406,"context_line":"        - name: Check for existing yum.pid"},{"line_number":407,"context_line":"          stat:  path\u003d/run/yum.pid"},{"line_number":408,"context_line":"          register: yum_pid_file"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e83566b7_d13c57e2","line":405,"range":{"start_line":405,"start_character":55,"end_line":405,"end_character":127},"in_reply_to":"b0625758_0d43206b","updated":"2022-06-21 09:21:18.000000000","message":"Done","commit_id":"6873441779c9903c71ad0921ec8e53466ac68880"}],"deployment/undercloud/undercloud-upgrade.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"93d88f21054f24cd603316e96fbbab05b3cdf3f0","unresolved":true,"context_lines":[{"line_number":74,"context_line":"            - step|int \u003d\u003d 0"},{"line_number":75,"context_line":"            - dnf_module_list|length \u003e 0"},{"line_number":76,"context_line":"            - item.distribution_version is defined and item.distribution_version \u003d\u003d ansible_facts[\u0027distribution_major_version\u0027]"},{"line_number":77,"context_line":"        - name: Clean up Nova containers"},{"line_number":78,"context_line":"          when: step|int \u003d\u003d 0"},{"line_number":79,"context_line":"          block:"},{"line_number":80,"context_line":"            - name: Stop nova containers"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9520a3bf_8b7698cd","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":40},"updated":"2022-06-09 08:28:44.000000000","message":"Are we sure that both types are the same? Perhaps we should use \u0027| int\u0027 to force the type?","commit_id":"6873441779c9903c71ad0921ec8e53466ac68880"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"376f83bdca6f6280da521d3ffe0de5bb9e6c221e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            - step|int \u003d\u003d 0"},{"line_number":75,"context_line":"            - dnf_module_list|length \u003e 0"},{"line_number":76,"context_line":"            - item.distribution_version is defined and item.distribution_version \u003d\u003d ansible_facts[\u0027distribution_major_version\u0027]"},{"line_number":77,"context_line":"        - name: Clean up Nova containers"},{"line_number":78,"context_line":"          when: step|int \u003d\u003d 0"},{"line_number":79,"context_line":"          block:"},{"line_number":80,"context_line":"            - name: Stop nova containers"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"0944fa36_83732949","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":40},"in_reply_to":"9520a3bf_8b7698cd","updated":"2022-06-21 09:21:18.000000000","message":"Done","commit_id":"6873441779c9903c71ad0921ec8e53466ac68880"}]}