)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"036a9930cf98641e9bb0f941bd7cdd802d4dea34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0786d49d_4f0a8fd1","updated":"2022-06-03 13:49:31.000000000","message":"yep i found this while debuging an issue with vtpm and noticed i could not view the logs on the host so had to exec into the container.\n\nthat means that they will not be included in sosreports and would be lost if the contaienr was recreated for an update.\nso +1 to bind mounting them on the host becide the rest of the libvirt logs.","commit_id":"5cfc1d47dc2ff2b095b81cb506653db5519efc09"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"77444da51bfc53a43493a6ed33719bcece14092b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fdcc5d3f_8fb69c3c","updated":"2022-06-03 14:31:42.000000000","message":"Yep; these swtpm logs are important to be bind-mounted as well.","commit_id":"f0fa791232e3e1b6d4a1af6808f956108fe2197d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"aa9b695d52608673f9c3da23e4b326269a15dc1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c0016492_8214a6cc","updated":"2022-06-03 14:00:21.000000000","message":"i do not have a way to test this locally but i belive this is now correct so +1","commit_id":"f0fa791232e3e1b6d4a1af6808f956108fe2197d"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"23c016a7fe8f8e91bf73129cce67e3f6f971d28c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"55f0ad49_21e2acd5","updated":"2022-07-06 13:30:50.000000000","message":"PTAL","commit_id":"7a9c95fb63741d9d69ee7248abe0eef77ab61ff7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"0a8c0a3fb895ec52c6373be69409d7110cfa6913","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"76984105_87b72678","updated":"2022-07-11 12:43:56.000000000","message":"PTAL","commit_id":"7a9c95fb63741d9d69ee7248abe0eef77ab61ff7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"613ae10699b33020d3c5cd5b8e41116bb36f7552","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"adf988ad_be80d57c","updated":"2022-07-08 12:56:49.000000000","message":"PTAL, it\u0027s good to go","commit_id":"7a9c95fb63741d9d69ee7248abe0eef77ab61ff7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d245bac4eb64a911326237c2c01a39a068f8d0dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a51427c3_ff9ccd6b","updated":"2022-07-04 13:52:43.000000000","message":"recheck IPA unrelated","commit_id":"7a9c95fb63741d9d69ee7248abe0eef77ab61ff7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f4e04aa201fb0219601e16cbd700819c2827c417","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4b58ea31_4c22ba61","updated":"2022-07-25 12:11:11.000000000","message":"PTAL","commit_id":"2d39456c2b7453e8585ff915917c34c3ce966b44"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d48a884b81f1009c0b9f0c9b2d0395a2791636d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"80e1864e_3865b810","updated":"2022-08-01 14:27:47.000000000","message":"please merge this","commit_id":"2d39456c2b7453e8585ff915917c34c3ce966b44"}],"deployment/logging/files/nova-libvirt.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1e5241ca470f198a5f339c4ce9999318729cf498","unresolved":true,"context_lines":[{"line_number":153,"context_line":"  volumes:"},{"line_number":154,"context_line":"    description: The volumes needed to log to files in the host."},{"line_number":155,"context_line":"    value:"},{"line_number":156,"context_line":"      - /var/log/containers/libvirt:/var/log/libvirt:shared,z  # +qemu subdir"},{"line_number":157,"context_line":"  docker_config:"},{"line_number":158,"context_line":"    description: Extra containers needed for logging to file in the host."},{"line_number":159,"context_line":"    value: null"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"274cd1c0_e2f69b90","line":156,"range":{"start_line":156,"start_character":8,"end_line":156,"end_character":77},"updated":"2022-07-11 13:23:44.000000000","message":"Because the directory is created in this Logging resource, IMO we should define the bind mount here instead of individual modules. I guess your intention is to add it to what actually need it but that makes it difficult to understand where the directory is created/used.","commit_id":"7a9c95fb63741d9d69ee7248abe0eef77ab61ff7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ff6458138e39f80740d32bd8d7595e6ae26f2b9c","unresolved":true,"context_lines":[{"line_number":153,"context_line":"  volumes:"},{"line_number":154,"context_line":"    description: The volumes needed to log to files in the host."},{"line_number":155,"context_line":"    value:"},{"line_number":156,"context_line":"      - /var/log/containers/libvirt:/var/log/libvirt:shared,z  # +qemu subdir"},{"line_number":157,"context_line":"  docker_config:"},{"line_number":158,"context_line":"    description: Extra containers needed for logging to file in the host."},{"line_number":159,"context_line":"    value: null"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7aa7f613_d254573d","line":156,"range":{"start_line":156,"start_character":8,"end_line":156,"end_character":77},"in_reply_to":"274cd1c0_e2f69b90","updated":"2022-07-11 13:24:53.000000000","message":"Or we can create the directory in the individual template. AFAIK swtpm logs are created even if you enable stdout logging in libvirt and that looks more appropriate.","commit_id":"7a9c95fb63741d9d69ee7248abe0eef77ab61ff7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8e0bbfce28658f1e3c12e83b6215ea42d7b1d516","unresolved":false,"context_lines":[{"line_number":153,"context_line":"  volumes:"},{"line_number":154,"context_line":"    description: The volumes needed to log to files in the host."},{"line_number":155,"context_line":"    value:"},{"line_number":156,"context_line":"      - /var/log/containers/libvirt:/var/log/libvirt:shared,z  # +qemu subdir"},{"line_number":157,"context_line":"  docker_config:"},{"line_number":158,"context_line":"    description: Extra containers needed for logging to file in the host."},{"line_number":159,"context_line":"    value: null"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"f61eb84e_3a66862f","line":156,"range":{"start_line":156,"start_character":8,"end_line":156,"end_character":77},"in_reply_to":"37f014b1_8182c749","updated":"2022-07-11 15:07:28.000000000","message":"Done","commit_id":"7a9c95fb63741d9d69ee7248abe0eef77ab61ff7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"58851295202250eef773d71ee4c0e3629047e7c4","unresolved":true,"context_lines":[{"line_number":153,"context_line":"  volumes:"},{"line_number":154,"context_line":"    description: The volumes needed to log to files in the host."},{"line_number":155,"context_line":"    value:"},{"line_number":156,"context_line":"      - /var/log/containers/libvirt:/var/log/libvirt:shared,z  # +qemu subdir"},{"line_number":157,"context_line":"  docker_config:"},{"line_number":158,"context_line":"    description: Extra containers needed for logging to file in the host."},{"line_number":159,"context_line":"    value: null"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"c5cb21f1_3a939ec1","line":156,"range":{"start_line":156,"start_character":8,"end_line":156,"end_character":77},"in_reply_to":"7aa7f613_d254573d","updated":"2022-07-11 15:01:00.000000000","message":"Actually. this is needed only for libvirt container, no need to share...","commit_id":"7a9c95fb63741d9d69ee7248abe0eef77ab61ff7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"78e9bdf45856ea37afddb1ac9ef0a894f3b6f140","unresolved":true,"context_lines":[{"line_number":153,"context_line":"  volumes:"},{"line_number":154,"context_line":"    description: The volumes needed to log to files in the host."},{"line_number":155,"context_line":"    value:"},{"line_number":156,"context_line":"      - /var/log/containers/libvirt:/var/log/libvirt:shared,z  # +qemu subdir"},{"line_number":157,"context_line":"  docker_config:"},{"line_number":158,"context_line":"    description: Extra containers needed for logging to file in the host."},{"line_number":159,"context_line":"    value: null"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fdb9d9b7_270e891d","line":156,"range":{"start_line":156,"start_character":8,"end_line":156,"end_character":77},"in_reply_to":"c5cb21f1_3a939ec1","updated":"2022-07-11 15:03:10.000000000","message":"nvm, this is good to have it","commit_id":"7a9c95fb63741d9d69ee7248abe0eef77ab61ff7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4eb956a936f7260dfd7607b95811c09a9714aced","unresolved":true,"context_lines":[{"line_number":153,"context_line":"  volumes:"},{"line_number":154,"context_line":"    description: The volumes needed to log to files in the host."},{"line_number":155,"context_line":"    value:"},{"line_number":156,"context_line":"      - /var/log/containers/libvirt:/var/log/libvirt:shared,z  # +qemu subdir"},{"line_number":157,"context_line":"  docker_config:"},{"line_number":158,"context_line":"    description: Extra containers needed for logging to file in the host."},{"line_number":159,"context_line":"    value: null"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"37f014b1_8182c749","line":156,"range":{"start_line":156,"start_character":8,"end_line":156,"end_character":77},"in_reply_to":"fdb9d9b7_270e891d","updated":"2022-07-11 15:05:27.000000000","message":"...aaand no, the problem is only virt_qemud needs accessing that log path.\nI better keep this file unchanged then, and move everything into the modular libvirt template","commit_id":"7a9c95fb63741d9d69ee7248abe0eef77ab61ff7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"442c8b73f3cce2a68e2ff00de443221cda85b031","unresolved":true,"context_lines":[{"line_number":168,"context_line":"          mode: \"{{ item.mode }}\""},{"line_number":169,"context_line":"        with_items:"},{"line_number":170,"context_line":"          - { \u0027path\u0027: /var/log/containers/libvirt, \u0027setype\u0027: container_file_t, \u0027mode\u0027: \u00270750\u0027 }"},{"line_number":171,"context_line":"          - { \u0027path\u0027: /var/log/containers/libvirt/swtpm, \u0027setype\u0027: container_file_t, \u0027mode\u0027: \u00270750\u0027 }"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"c88a2eab_b16eb84b","line":171,"range":{"start_line":171,"start_character":22,"end_line":171,"end_character":55},"updated":"2022-08-01 15:22:11.000000000","message":"This is already implemented in https://review.opendev.org/c/openstack/tripleo-heat-templates/+/844592/8/deployment/nova/nova-modular-libvirt-container-puppet.yaml#937 and I think we can remove this.","commit_id":"2d39456c2b7453e8585ff915917c34c3ce966b44"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1e35bc7d064549350da312a06409198f8d539b7f","unresolved":false,"context_lines":[{"line_number":168,"context_line":"          mode: \"{{ item.mode }}\""},{"line_number":169,"context_line":"        with_items:"},{"line_number":170,"context_line":"          - { \u0027path\u0027: /var/log/containers/libvirt, \u0027setype\u0027: container_file_t, \u0027mode\u0027: \u00270750\u0027 }"},{"line_number":171,"context_line":"          - { \u0027path\u0027: /var/log/containers/libvirt/swtpm, \u0027setype\u0027: container_file_t, \u0027mode\u0027: \u00270750\u0027 }"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7c81c143_7c08dd45","line":171,"range":{"start_line":171,"start_character":22,"end_line":171,"end_character":55},"in_reply_to":"c88a2eab_b16eb84b","updated":"2022-08-03 12:02:25.000000000","message":"Done","commit_id":"2d39456c2b7453e8585ff915917c34c3ce966b44"}],"deployment/nova/nova-modular-libvirt-container-puppet.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"036a9930cf98641e9bb0f941bd7cdd802d4dea34","unresolved":true,"context_lines":[{"line_number":650,"context_line":"                    - {get_attr: [NovaLibvirtCommon, volumes]}"},{"line_number":651,"context_line":"                    - {get_attr: [RoleParametersValue, value, nova_libvirt_opt_volumes]}"},{"line_number":652,"context_line":"                    - - /var/lib/kolla/config_files/nova_virtstoraged.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":653,"context_line":"                      - /var/log/containers/libvirt/swtpm:/var/log/swtpm:z"},{"line_number":654,"context_line":"            - nova_virtqemud:"},{"line_number":655,"context_line":"                start_order: 4"},{"line_number":656,"context_line":"                image: {get_attr: [RoleParametersValue, value, ContainerNovaLibvirtImage]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d3b95491_9af17f02","line":653,"updated":"2022-06-03 13:49:31.000000000","message":"you updated the wrong container this need to be in virtqemud i think\n\nwe do not use virtstoraged with openstack so this contaienr shoudl be removed evnetually.","commit_id":"5cfc1d47dc2ff2b095b81cb506653db5519efc09"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"80839fd775239c59efacccc5fee93f2c1c77a57c","unresolved":false,"context_lines":[{"line_number":650,"context_line":"                    - {get_attr: [NovaLibvirtCommon, volumes]}"},{"line_number":651,"context_line":"                    - {get_attr: [RoleParametersValue, value, nova_libvirt_opt_volumes]}"},{"line_number":652,"context_line":"                    - - /var/lib/kolla/config_files/nova_virtstoraged.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":653,"context_line":"                      - /var/log/containers/libvirt/swtpm:/var/log/swtpm:z"},{"line_number":654,"context_line":"            - nova_virtqemud:"},{"line_number":655,"context_line":"                start_order: 4"},{"line_number":656,"context_line":"                image: {get_attr: [RoleParametersValue, value, ContainerNovaLibvirtImage]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"34bfbb4e_10bc328b","line":653,"in_reply_to":"d3b95491_9af17f02","updated":"2022-06-03 13:52:04.000000000","message":"done, see also https://github.com/sosreport/sos/pull/2950","commit_id":"5cfc1d47dc2ff2b095b81cb506653db5519efc09"}]}