)]}'
{"deployment/nova/nova-migration-target-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7ce6d7dff16e1cad58804584b51cebaa457fc80b","unresolved":true,"context_lines":[{"line_number":135,"context_line":"              params:"},{"line_number":136,"context_line":"                $NETWORK: {get_param: [ServiceNetMap, NovaLibvirtNetwork]}"},{"line_number":137,"context_line":"        tripleo::profile::base::sshd::port:"},{"line_number":138,"context_line":"          - {get_param: MigrationSshPort}"},{"line_number":139,"context_line":"        tripleo::profile::base::sshd::password_authentication: \u0027no\u0027"},{"line_number":140,"context_line":"        tripleo::profile::base::sshd::options:"},{"line_number":141,"context_line":"          # NOTE(tkajinam): Thse values inherits the default sshd options"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bdbecf6f_5d900a5e","line":138,"updated":"2022-07-04 11:46:10.000000000","message":"do we want to keep DockerNovaMigrationSshdPort working or make it changes nothing?","commit_id":"62e8832e7d19b21a19f7133f4623615df5d91ad1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9b3fb4f1e8ff3631a105f30aa7ed3390267c831b","unresolved":false,"context_lines":[{"line_number":135,"context_line":"              params:"},{"line_number":136,"context_line":"                $NETWORK: {get_param: [ServiceNetMap, NovaLibvirtNetwork]}"},{"line_number":137,"context_line":"        tripleo::profile::base::sshd::port:"},{"line_number":138,"context_line":"          - {get_param: MigrationSshPort}"},{"line_number":139,"context_line":"        tripleo::profile::base::sshd::password_authentication: \u0027no\u0027"},{"line_number":140,"context_line":"        tripleo::profile::base::sshd::options:"},{"line_number":141,"context_line":"          # NOTE(tkajinam): Thse values inherits the default sshd options"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"eece2cd3_bcfba96d","line":138,"in_reply_to":"8fab1df4_8fae6217","updated":"2022-07-04 16:25:17.000000000","message":"I totally forgot I dealt with these duplicate parameters in https://review.opendev.org/c/openstack/tripleo-heat-templates/+/828214/ ... I\u0027ll use that patch as it has received a few +2s already.","commit_id":"62e8832e7d19b21a19f7133f4623615df5d91ad1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c571cef52ee43a0873320b753a546023ec1e0736","unresolved":true,"context_lines":[{"line_number":135,"context_line":"              params:"},{"line_number":136,"context_line":"                $NETWORK: {get_param: [ServiceNetMap, NovaLibvirtNetwork]}"},{"line_number":137,"context_line":"        tripleo::profile::base::sshd::port:"},{"line_number":138,"context_line":"          - {get_param: MigrationSshPort}"},{"line_number":139,"context_line":"        tripleo::profile::base::sshd::password_authentication: \u0027no\u0027"},{"line_number":140,"context_line":"        tripleo::profile::base::sshd::options:"},{"line_number":141,"context_line":"          # NOTE(tkajinam): Thse values inherits the default sshd options"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8fab1df4_8fae6217","line":138,"in_reply_to":"bdbecf6f_5d900a5e","updated":"2022-07-04 16:15:14.000000000","message":"Currently a user needs to set both of MigrationSshPort and DockerNovaMigrationSshdPort by the same value so using only one of them does not break the existing usage, so I tend to just make that deprecated parameter noop instead of implementing redundant fallback logics.","commit_id":"62e8832e7d19b21a19f7133f4623615df5d91ad1"}]}
