)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"7c913c31fa85b745399dd30aa639b621c59d1419","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"71dbf2be_6dfc1455","updated":"2022-06-08 08:12:16.000000000","message":"This is follow up of https://review.opendev.org/c/openstack/tripleo-heat-templates/+/837898","commit_id":"b5d0d7cc160ae4f5fac1fe64a44ba437eed39675"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"d3a03499d1ad9826511f34045b54c036216e5540","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cd783079_cc8f90e1","updated":"2022-06-28 10:06:54.000000000","message":"bump","commit_id":"df58fe7bf1df8fae1f7e1358b45e6e021a1b6729"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"f41a2ea04bb09c32bca903d563df6001f02ad053","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"245087de_49c5e2a8","updated":"2022-06-10 04:01:13.000000000","message":"recheck","commit_id":"df58fe7bf1df8fae1f7e1358b45e6e021a1b6729"}],"deployment/neutron/neutron-api-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ef5f54a3c0c8c708fcbf160927626198850c4f65","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    description: The password for the Placement service and db account"},{"line_number":96,"context_line":"    type: string"},{"line_number":97,"context_line":"    hidden: true"},{"line_number":98,"context_line":"  NeutronEnableDVR:"},{"line_number":99,"context_line":"    description: Enable Neutron DVR."},{"line_number":100,"context_line":"    default: false"},{"line_number":101,"context_line":"    type: boolean"},{"line_number":102,"context_line":"  NeutronEnableIgmpSnooping:"},{"line_number":103,"context_line":"    description: Enable IGMP Snooping."},{"line_number":104,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"596f4676_91d51f8f","line":101,"range":{"start_line":98,"start_character":0,"end_line":101,"end_character":17},"updated":"2022-06-09 04:41:59.000000000","message":"Note to myself: This neutron-api is used for both ml2+ovs and ml2+ovn but the hieradata keys controlled by this parameter affects only ml2+ovs so making this default to false is correct.\n\nIdeally we should move this to a separate resource specific to ml2-ovs. However that would require additional refactoring so we can leave it for now.","commit_id":"df58fe7bf1df8fae1f7e1358b45e6e021a1b6729"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"42370b5a58f9c39c7522a0bcb9995dc735b35bb7","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    description: The password for the Placement service and db account"},{"line_number":96,"context_line":"    type: string"},{"line_number":97,"context_line":"    hidden: true"},{"line_number":98,"context_line":"  NeutronEnableDVR:"},{"line_number":99,"context_line":"    description: Enable Neutron DVR."},{"line_number":100,"context_line":"    default: false"},{"line_number":101,"context_line":"    type: boolean"},{"line_number":102,"context_line":"  NeutronEnableIgmpSnooping:"},{"line_number":103,"context_line":"    description: Enable IGMP Snooping."},{"line_number":104,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bc607b81_dcfc1c41","line":101,"range":{"start_line":98,"start_character":0,"end_line":101,"end_character":17},"in_reply_to":"55a9ed3b_1fde1c3e","updated":"2022-06-28 23:15:23.000000000","message":"That\u0027s an option, though the next question is which template should be used. (maybe l3-agent ?) anyway we can leave it for follow-up now.","commit_id":"df58fe7bf1df8fae1f7e1358b45e6e021a1b6729"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"80b59582a6a3da3bc35d67b5d25d97dae4913bc2","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    description: The password for the Placement service and db account"},{"line_number":96,"context_line":"    type: string"},{"line_number":97,"context_line":"    hidden: true"},{"line_number":98,"context_line":"  NeutronEnableDVR:"},{"line_number":99,"context_line":"    description: Enable Neutron DVR."},{"line_number":100,"context_line":"    default: false"},{"line_number":101,"context_line":"    type: boolean"},{"line_number":102,"context_line":"  NeutronEnableIgmpSnooping:"},{"line_number":103,"context_line":"    description: Enable IGMP Snooping."},{"line_number":104,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"55a9ed3b_1fde1c3e","line":101,"range":{"start_line":98,"start_character":0,"end_line":101,"end_character":17},"in_reply_to":"596f4676_91d51f8f","updated":"2022-06-28 18:08:53.000000000","message":"Can you use just set the hiera service_config_settings in the ovs template and just remove this parameter from the API template?","commit_id":"df58fe7bf1df8fae1f7e1358b45e6e021a1b6729"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9130d1a1181194b93f4077110a83817d37332050","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    description: The password for the Placement service and db account"},{"line_number":96,"context_line":"    type: string"},{"line_number":97,"context_line":"    hidden: true"},{"line_number":98,"context_line":"  NeutronEnableDVR:"},{"line_number":99,"context_line":"    description: Enable Neutron DVR."},{"line_number":100,"context_line":"    default: false"},{"line_number":101,"context_line":"    type: boolean"},{"line_number":102,"context_line":"  NeutronEnableIgmpSnooping:"},{"line_number":103,"context_line":"    description: Enable IGMP Snooping."},{"line_number":104,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"19b5880a_9e5c93af","line":101,"range":{"start_line":98,"start_character":0,"end_line":101,"end_character":17},"in_reply_to":"93827500_6ae2d760","updated":"2022-07-04 12:47:20.000000000","message":"This will be covered by https://review.opendev.org/c/openstack/tripleo-heat-templates/+/848036/1 so I\u0027ll go ahead to merge this now.","commit_id":"df58fe7bf1df8fae1f7e1358b45e6e021a1b6729"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ba605e71578eb533c2a2a2adbec9f3e5c99301e3","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    description: The password for the Placement service and db account"},{"line_number":96,"context_line":"    type: string"},{"line_number":97,"context_line":"    hidden: true"},{"line_number":98,"context_line":"  NeutronEnableDVR:"},{"line_number":99,"context_line":"    description: Enable Neutron DVR."},{"line_number":100,"context_line":"    default: false"},{"line_number":101,"context_line":"    type: boolean"},{"line_number":102,"context_line":"  NeutronEnableIgmpSnooping:"},{"line_number":103,"context_line":"    description: Enable IGMP Snooping."},{"line_number":104,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"93827500_6ae2d760","line":101,"range":{"start_line":98,"start_character":0,"end_line":101,"end_character":17},"in_reply_to":"bc607b81_dcfc1c41","updated":"2022-06-28 23:16:23.000000000","message":"\u003e That\u0027s an option, though the next question is which template should be used. (maybe l3-agent ?)\n\nIgnore this part. We already have the parameter in ovs-agent so we add service_config_settings there.","commit_id":"df58fe7bf1df8fae1f7e1358b45e6e021a1b6729"}]}
