)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"9aedce8165536c6a603633a943417479cb0d6f8e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"01fbd4c3_55dc75e1","updated":"2022-07-15 13:20:58.000000000","message":"This change isn\u0027t something we can readily test in CI, so it would be good if you manually test this and comment on the results.","commit_id":"48b65b4820524754441fc03025d5916eed778fe4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"81c165ef4f9d02b21e442854feffeda80fe3751c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"85bbcf2e_061ce070","updated":"2022-07-05 16:24:03.000000000","message":"We might also want to add mount for staging nfs share.","commit_id":"48b65b4820524754441fc03025d5916eed778fe4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8c8c2463a6f6973e258b583622b6baf7bb0b4378","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"178ab975_cd043ad8","updated":"2022-06-28 13:02:52.000000000","message":"recheck","commit_id":"48b65b4820524754441fc03025d5916eed778fe4"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"67eec2732b7951a80ce3a80989aa03d4a90cae88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1a34713f_532c8443","updated":"2022-06-22 12:18:52.000000000","message":"recheck","commit_id":"48b65b4820524754441fc03025d5916eed778fe4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ee4a688e7cc28842383c45748789a24d25a0f6e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"48c03c4f_b5d32e76","updated":"2022-06-09 13:15:03.000000000","message":"recheck","commit_id":"48b65b4820524754441fc03025d5916eed778fe4"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"43c1190c6795c7e7aad4e5adaee0867113127167","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4c5b3b7a_660b2597","updated":"2022-07-05 12:47:02.000000000","message":"recheck","commit_id":"48b65b4820524754441fc03025d5916eed778fe4"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"31a91b04812dbb3ec3a1626d5c767999d35e2677","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9bcea436_746d20e2","updated":"2022-06-29 07:18:36.000000000","message":"recheck","commit_id":"48b65b4820524754441fc03025d5916eed778fe4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2b01f7c47e34ee5562035f062dac684465628521","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"08bf99ab_02b1a306","updated":"2022-06-09 02:29:33.000000000","message":"recheck\n\nSELinux boolean os_enable_vtpm does not exist.","commit_id":"48b65b4820524754441fc03025d5916eed778fe4"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"9aedce8165536c6a603633a943417479cb0d6f8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"69aba21f_c2b464f5","in_reply_to":"85bbcf2e_061ce070","updated":"2022-07-15 13:20:58.000000000","message":"This one is much less critical.","commit_id":"48b65b4820524754441fc03025d5916eed778fe4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7fca40c4d218886016dad161817c660ae603f3c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"aeafd922_14d1b8cd","updated":"2022-11-18 06:55:32.000000000","message":"I\u0027d try to get some time to test this but if somebody can chime in then that\u0027s nice. In the mean time I addressed the Alan\u0027s comment regarding the NetApp NFS.","commit_id":"072ea319370166daad8b92135105fa44f13f797d"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"2c17bb7cedc8ae5b4c4f098d6723263869205914","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3e356719_8a6037a7","updated":"2022-11-21 05:40:04.000000000","message":"lgtm","commit_id":"88e510415faff86507f825de972a5881a207995c"}],"deployment/glance/glance-api-container-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"9aedce8165536c6a603633a943417479cb0d6f8e","unresolved":true,"context_lines":[{"line_number":789,"context_line":"            restart: always"},{"line_number":790,"context_line":"            depends_on:"},{"line_number":791,"context_line":"              if:"},{"line_number":792,"context_line":"                - {get_param: GlanceNfsEnabled}"},{"line_number":793,"context_line":"                - var-lib-glance-images.mount"},{"line_number":794,"context_line":"            healthcheck:"},{"line_number":795,"context_line":"              test: /openstack/healthcheck"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c14be155_1f2279ae","line":792,"updated":"2022-07-15 13:20:58.000000000","message":"This needs a heat \u0027or\u0027 clause for GlanceNetappNfsEnabled (or historical reasons, regular NFS and \"NetApp NFS\" are very close variants).\n\nSee L853 for similar logic.","commit_id":"48b65b4820524754441fc03025d5916eed778fe4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7fca40c4d218886016dad161817c660ae603f3c9","unresolved":false,"context_lines":[{"line_number":789,"context_line":"            restart: always"},{"line_number":790,"context_line":"            depends_on:"},{"line_number":791,"context_line":"              if:"},{"line_number":792,"context_line":"                - {get_param: GlanceNfsEnabled}"},{"line_number":793,"context_line":"                - var-lib-glance-images.mount"},{"line_number":794,"context_line":"            healthcheck:"},{"line_number":795,"context_line":"              test: /openstack/healthcheck"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d8291722_33d68c4a","line":792,"in_reply_to":"c14be155_1f2279ae","updated":"2022-11-18 06:55:32.000000000","message":"Done","commit_id":"48b65b4820524754441fc03025d5916eed778fe4"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"4ea4d0584fec12ccb1c988f6d55dc1450f6de922","unresolved":true,"context_lines":[{"line_number":787,"context_line":"            net: host"},{"line_number":788,"context_line":"            privileged: {if: [cinder_backend_enabled, true, false]}"},{"line_number":789,"context_line":"            restart: always"},{"line_number":790,"context_line":"            depends_on:"},{"line_number":791,"context_line":"              if:"},{"line_number":792,"context_line":"                - or:"},{"line_number":793,"context_line":"                    - {get_param: GlanceShowMultipleLocations}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"82195f15_7b5de438","line":790,"updated":"2022-11-18 14:03:21.000000000","message":"Should this line be inside the conditional?","commit_id":"072ea319370166daad8b92135105fa44f13f797d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a10bd0193ccd78fc7a1148f971e6699762df3ea0","unresolved":false,"context_lines":[{"line_number":787,"context_line":"            net: host"},{"line_number":788,"context_line":"            privileged: {if: [cinder_backend_enabled, true, false]}"},{"line_number":789,"context_line":"            restart: always"},{"line_number":790,"context_line":"            depends_on:"},{"line_number":791,"context_line":"              if:"},{"line_number":792,"context_line":"                - or:"},{"line_number":793,"context_line":"                    - {get_param: GlanceShowMultipleLocations}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"90bc37bd_a85f0ec2","line":790,"in_reply_to":"82195f15_7b5de438","updated":"2022-11-21 00:32:27.000000000","message":"No. Heat should remove the parent key automatically.\n\nexample: https://github.com/openstack/tripleo-heat-templates/blob/429853422cf3a0bd0d62c7676c24ee4ca39ec263/deployment/glance/glance-api-container-puppet.yaml#L785-L802","commit_id":"072ea319370166daad8b92135105fa44f13f797d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"4ea4d0584fec12ccb1c988f6d55dc1450f6de922","unresolved":true,"context_lines":[{"line_number":790,"context_line":"            depends_on:"},{"line_number":791,"context_line":"              if:"},{"line_number":792,"context_line":"                - or:"},{"line_number":793,"context_line":"                    - {get_param: GlanceShowMultipleLocations}"},{"line_number":794,"context_line":"                    - {get_param: GlanceNetappNfsEnabled}"},{"line_number":795,"context_line":"                - var-lib-glance-images.mount"},{"line_number":796,"context_line":"            healthcheck:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"b13f9c2e_bfe05054","line":793,"updated":"2022-11-18 14:03:21.000000000","message":"This doesn\u0027t look right. I think you meant to reference GlanceNfsEnabled.\n\n                - or:\n                    - {get_param: GlanceNfsEnabled}\n                    - {get_param: GlanceNetappNfsEnabled}","commit_id":"072ea319370166daad8b92135105fa44f13f797d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a10bd0193ccd78fc7a1148f971e6699762df3ea0","unresolved":false,"context_lines":[{"line_number":790,"context_line":"            depends_on:"},{"line_number":791,"context_line":"              if:"},{"line_number":792,"context_line":"                - or:"},{"line_number":793,"context_line":"                    - {get_param: GlanceShowMultipleLocations}"},{"line_number":794,"context_line":"                    - {get_param: GlanceNetappNfsEnabled}"},{"line_number":795,"context_line":"                - var-lib-glance-images.mount"},{"line_number":796,"context_line":"            healthcheck:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"cc814d13_2292aa60","line":793,"in_reply_to":"b13f9c2e_bfe05054","updated":"2022-11-21 00:32:27.000000000","message":"Done. I don\u0027t know how I messed up the existing line ...","commit_id":"072ea319370166daad8b92135105fa44f13f797d"}]}