)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"eb344bc69bc3271792a4a764cf5927d103d26188","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"aa9d864d_24f3cedd","updated":"2022-06-29 06:07:14.000000000","message":"I think a complete solution for this would be that already nova_statedir_owner in step_3 to depend on the nfs backend to be ready. that\u0027s the one which fixes possible wrong permissions in /var/lib/nova/...","commit_id":"3af4772b64543ea38a666d02541a61aef17449dc"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bdcb17370b4d9fdb5cb4259ba60bf3427d32b31d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c766899d_f406782c","updated":"2022-06-28 13:04:00.000000000","message":"recheck","commit_id":"3af4772b64543ea38a666d02541a61aef17449dc"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"fad8bab1a733ecaa059067e2d9d8c775ea0a26ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e1942701_d32f0ce6","updated":"2022-07-01 15:35:27.000000000","message":"thanks you for fixing this!\n\nCI failure looks real heatclient.exc.HTTPBadRequest: ERROR: resources.StandaloneServiceChain\u003cfile:///home/zuul/tripleo-deploy/tripleo-heat-installer-templates/common/services/standalone-role.yaml\u003e.resources.ServiceChain\u003cnested_stack\u003e.resources.20\u003cfile:///home/zuul/tripleo-deploy/tripleo-heat-installer-templates/deployment/nova/nova-compute-container-puppet.yaml\u003e.outputs.role_data.value.docker_config.step_5.map_merge[0].nova_compute.depends_on.list_concat[1].if: Invalid condition \"{\u0027get_params\u0027: \u0027NovaNfsEnabled\u0027}\"","commit_id":"3af4772b64543ea38a666d02541a61aef17449dc"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"6deecb758a04de3230340ae16c1798c283728a94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"87ddef7b_9cac373d","in_reply_to":"aa9d864d_24f3cedd","updated":"2022-07-01 15:41:36.000000000","message":"Thank you Martin! I will address that in the next revision","commit_id":"3af4772b64543ea38a666d02541a61aef17449dc"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8c0951da0a6e9f0c40be3a18c00a71ed3562d9ca","unresolved":true,"context_lines":[{"line_number":1344,"context_line":"        step_3:"},{"line_number":1345,"context_line":"          nova_statedir_owner:"},{"line_number":1346,"context_line":"            image: \u0026nova_compute_image {get_attr: [RoleParametersValue, value, ContainerNovaComputeImage]}"},{"line_number":1347,"context_line":"            depends_on: \u0026nfs_mounts_up"},{"line_number":1348,"context_line":"              list_concat:"},{"line_number":1349,"context_line":"                - - tripleo_nova_libvirt.target"},{"line_number":1350,"context_line":"                - if:"},{"line_number":1351,"context_line":"                  - {get_param: NovaNfsEnabled}"},{"line_number":1352,"context_line":"                  - var-lib-nova-instances.mount"},{"line_number":1353,"context_line":"            net: none"},{"line_number":1354,"context_line":"            user: root"},{"line_number":1355,"context_line":"            security_opt:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"10508d7f_8421b0f8","line":1352,"range":{"start_line":1347,"start_character":12,"end_line":1352,"end_character":48},"updated":"2022-07-02 12:27:39.000000000","message":"depends_on works only for the containers managed by systemd. This container does NOT have restart policy and is never managed by systemd so IMO this update is wrong. If we need to ensure availability of NFS before this then we need","commit_id":"44c433ad880b94df6d22c7b884637ed5931cc230"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e7be07a7fbf0962de457e17b2f19ed6337664936","unresolved":true,"context_lines":[{"line_number":1344,"context_line":"        step_3:"},{"line_number":1345,"context_line":"          nova_statedir_owner:"},{"line_number":1346,"context_line":"            image: \u0026nova_compute_image {get_attr: [RoleParametersValue, value, ContainerNovaComputeImage]}"},{"line_number":1347,"context_line":"            depends_on: \u0026nfs_mounts_up"},{"line_number":1348,"context_line":"              list_concat:"},{"line_number":1349,"context_line":"                - - tripleo_nova_libvirt.target"},{"line_number":1350,"context_line":"                - if:"},{"line_number":1351,"context_line":"                  - {get_param: NovaNfsEnabled}"},{"line_number":1352,"context_line":"                  - var-lib-nova-instances.mount"},{"line_number":1353,"context_line":"            net: none"},{"line_number":1354,"context_line":"            user: root"},{"line_number":1355,"context_line":"            security_opt:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8bbccab9_3fa30219","line":1352,"range":{"start_line":1347,"start_character":12,"end_line":1352,"end_character":48},"in_reply_to":"10508d7f_8421b0f8","updated":"2022-07-02 12:28:17.000000000","message":"Also this pulls libvirt which is started at step4. this point also looks wrong.","commit_id":"44c433ad880b94df6d22c7b884637ed5931cc230"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c44911ca58bb7497c315b09f2b03a27d72ce828e","unresolved":true,"context_lines":[{"line_number":1344,"context_line":"        step_3:"},{"line_number":1345,"context_line":"          nova_statedir_owner:"},{"line_number":1346,"context_line":"            image: \u0026nova_compute_image {get_attr: [RoleParametersValue, value, ContainerNovaComputeImage]}"},{"line_number":1347,"context_line":"            depends_on: \u0026nfs_mounts_up"},{"line_number":1348,"context_line":"              list_concat:"},{"line_number":1349,"context_line":"                - - tripleo_nova_libvirt.target"},{"line_number":1350,"context_line":"                - if:"},{"line_number":1351,"context_line":"                  - {get_param: NovaNfsEnabled}"},{"line_number":1352,"context_line":"                  - var-lib-nova-instances.mount"},{"line_number":1353,"context_line":"            net: none"},{"line_number":1354,"context_line":"            user: root"},{"line_number":1355,"context_line":"            security_opt:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f96c429f_3e891dc0","line":1352,"range":{"start_line":1347,"start_character":12,"end_line":1352,"end_character":48},"in_reply_to":"8bbccab9_3fa30219","updated":"2022-07-04 11:48:34.000000000","message":"I see, those are good points.\nDid you send the above comment before finishing it? What should we do \u003cthen\u003e?","commit_id":"44c433ad880b94df6d22c7b884637ed5931cc230"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0749edebf570d8bdfe0b7be90a8ab35794566e0c","unresolved":true,"context_lines":[{"line_number":1344,"context_line":"        step_3:"},{"line_number":1345,"context_line":"          nova_statedir_owner:"},{"line_number":1346,"context_line":"            image: \u0026nova_compute_image {get_attr: [RoleParametersValue, value, ContainerNovaComputeImage]}"},{"line_number":1347,"context_line":"            depends_on: \u0026nfs_mounts_up"},{"line_number":1348,"context_line":"              list_concat:"},{"line_number":1349,"context_line":"                - - tripleo_nova_libvirt.target"},{"line_number":1350,"context_line":"                - if:"},{"line_number":1351,"context_line":"                  - {get_param: NovaNfsEnabled}"},{"line_number":1352,"context_line":"                  - var-lib-nova-instances.mount"},{"line_number":1353,"context_line":"            net: none"},{"line_number":1354,"context_line":"            user: root"},{"line_number":1355,"context_line":"            security_opt:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fb8420f8_d7ce68b8","line":1352,"range":{"start_line":1347,"start_character":12,"end_line":1352,"end_character":48},"in_reply_to":"f96c429f_3e891dc0","updated":"2022-07-04 12:10:58.000000000","message":"Oops.\n\nIf we need to ensure availability of NFS before this then we need to implement the step to ensure NFS mount before this. However looking at the current implementation we mount NFS share in host prep tasks. If we see any problems with it then it might be that the task is executing lazy mount and we need to have a seprate step(or option) to do strict mount instead of lazy one.","commit_id":"44c433ad880b94df6d22c7b884637ed5931cc230"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"81d1e0d8520255852e1f7b4881734dcd85ff2c02","unresolved":false,"context_lines":[{"line_number":1344,"context_line":"        step_3:"},{"line_number":1345,"context_line":"          nova_statedir_owner:"},{"line_number":1346,"context_line":"            image: \u0026nova_compute_image {get_attr: [RoleParametersValue, value, ContainerNovaComputeImage]}"},{"line_number":1347,"context_line":"            depends_on: \u0026nfs_mounts_up"},{"line_number":1348,"context_line":"              list_concat:"},{"line_number":1349,"context_line":"                - - tripleo_nova_libvirt.target"},{"line_number":1350,"context_line":"                - if:"},{"line_number":1351,"context_line":"                  - {get_param: NovaNfsEnabled}"},{"line_number":1352,"context_line":"                  - var-lib-nova-instances.mount"},{"line_number":1353,"context_line":"            net: none"},{"line_number":1354,"context_line":"            user: root"},{"line_number":1355,"context_line":"            security_opt:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"27c682e9_d795f92d","line":1352,"range":{"start_line":1347,"start_character":12,"end_line":1352,"end_character":48},"in_reply_to":"fb8420f8_d7ce68b8","updated":"2022-07-07 12:54:27.000000000","message":"Done","commit_id":"44c433ad880b94df6d22c7b884637ed5931cc230"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5f784bc78f5a34c58c6fda666b2053a361c5acaf","unresolved":true,"context_lines":[{"line_number":1384,"context_line":"                    - - tripleo_nova_libvirt.target"},{"line_number":1385,"context_line":"                    - if:"},{"line_number":1386,"context_line":"                      - {get_param: NovaNfsEnabled}"},{"line_number":1387,"context_line":"                      - var-lib-nova-instances.mount"},{"line_number":1388,"context_line":"                healthcheck: {get_attr: [ContainersCommon, healthcheck_rpc_port]}"},{"line_number":1389,"context_line":"                volumes:"},{"line_number":1390,"context_line":"                  list_concat:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"da10671e_bbc42f03","line":1387,"updated":"2022-07-04 13:07:06.000000000","message":"two questions please: where that mount target comes from? and shouldn\u0027t we rely on remote-fs, like https://review.opendev.org/c/openstack/tripleo-heat-templates/+/845180 does?","commit_id":"728d2ad43394802cadc97d90915c63da231f1dcf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e9c25d3b0453bec1f874f540b4bfdf235dea6729","unresolved":false,"context_lines":[{"line_number":1384,"context_line":"                    - - tripleo_nova_libvirt.target"},{"line_number":1385,"context_line":"                    - if:"},{"line_number":1386,"context_line":"                      - {get_param: NovaNfsEnabled}"},{"line_number":1387,"context_line":"                      - var-lib-nova-instances.mount"},{"line_number":1388,"context_line":"                healthcheck: {get_attr: [ContainersCommon, healthcheck_rpc_port]}"},{"line_number":1389,"context_line":"                volumes:"},{"line_number":1390,"context_line":"                  list_concat:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ee276cf1_8bd5906c","line":1387,"in_reply_to":"4d08eeba_eadc19ba","updated":"2022-07-07 16:51:10.000000000","message":"Hmm... this is likely to reveal the problem with tripleo-ansible... https://bugs.launchpad.net/tripleo/+bug/1980976","commit_id":"728d2ad43394802cadc97d90915c63da231f1dcf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"81d1e0d8520255852e1f7b4881734dcd85ff2c02","unresolved":false,"context_lines":[{"line_number":1384,"context_line":"                    - - tripleo_nova_libvirt.target"},{"line_number":1385,"context_line":"                    - if:"},{"line_number":1386,"context_line":"                      - {get_param: NovaNfsEnabled}"},{"line_number":1387,"context_line":"                      - var-lib-nova-instances.mount"},{"line_number":1388,"context_line":"                healthcheck: {get_attr: [ContainersCommon, healthcheck_rpc_port]}"},{"line_number":1389,"context_line":"                volumes:"},{"line_number":1390,"context_line":"                  list_concat:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"4d08eeba_eadc19ba","line":1387,"in_reply_to":"b4d0d203_0f087090","updated":"2022-07-07 12:54:27.000000000","message":"Done","commit_id":"728d2ad43394802cadc97d90915c63da231f1dcf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"36aefbd84e2d8d94b6f2ff3bd24d8b6b2631842d","unresolved":true,"context_lines":[{"line_number":1384,"context_line":"                    - - tripleo_nova_libvirt.target"},{"line_number":1385,"context_line":"                    - if:"},{"line_number":1386,"context_line":"                      - {get_param: NovaNfsEnabled}"},{"line_number":1387,"context_line":"                      - var-lib-nova-instances.mount"},{"line_number":1388,"context_line":"                healthcheck: {get_attr: [ContainersCommon, healthcheck_rpc_port]}"},{"line_number":1389,"context_line":"                volumes:"},{"line_number":1390,"context_line":"                  list_concat:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"b4d0d203_0f087090","line":1387,"in_reply_to":"da10671e_bbc42f03","updated":"2022-07-04 15:19:22.000000000","message":"The unit name is determined by systemd according to the mount path. We can use remote-fs target but I selected the specific unit as we use the static path for NFS mount to avoid pulling in additional dependencies.","commit_id":"728d2ad43394802cadc97d90915c63da231f1dcf"}]}