)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"9761757316858056405fcd1a4123a2a2818a5f27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"349cba7b_1adcce30","updated":"2022-06-13 13:17:15.000000000","message":"recheck","commit_id":"215d918651eef3eaef0e612fca2d35742a78e4fa"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"faf8fbc3d2fe194aca5a9465b43ed0c85a77d408","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fdb3b2d8_7dea0a91","updated":"2022-06-10 13:29:45.000000000","message":"so it uses /etc/rhsm/rhsm.conf even if \"in_container\" by mistake...\n\nwe don\u0027t have a better way to go, we need /run bind mounted, so let\u0027s be it","commit_id":"215d918651eef3eaef0e612fca2d35742a78e4fa"}],"deployment/podman/podman-baremetal-ansible.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6819c6f38aa306c7c944066fb941d4a3f95daaad","unresolved":true,"context_lines":[{"line_number":89,"context_line":"      host_prep_tasks:"},{"line_number":90,"context_line":"        - name: Install and configure Podman"},{"line_number":91,"context_line":"          block: \u0026install_and_configure_podman"},{"line_number":92,"context_line":"          - name: Ensure subscription-manager is not detecting container"},{"line_number":93,"context_line":"            when:"},{"line_number":94,"context_line":"              - ansible_facts[\u0027distribution\u0027] \u003d\u003d \u0027RedHat\u0027"},{"line_number":95,"context_line":"            # Needed in order to solve rhbz#2075080."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"52a4d596_58b21612","line":92,"range":{"start_line":92,"start_character":12,"end_line":92,"end_character":72},"updated":"2022-06-13 10:57:04.000000000","message":"Currently the task to set up subscription is implemented as part of host_prep_tasks in a different resource.\n\nI still need to dig into the playbook rendering but is it really guaranteed that this task is executed before that task ? My initial feeling is that it would execute resources in dictionary order and this is executed AFTER that task. In that case we should implement this task in the rhsm service instead.\n\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/deployment/rhsm/rhsm-baremetal-ansible.yaml#L63-L66","commit_id":"215d918651eef3eaef0e612fca2d35742a78e4fa"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"8359582271f3e231d629ab43e17cdc9fdcb7ea1b","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      host_prep_tasks:"},{"line_number":90,"context_line":"        - name: Install and configure Podman"},{"line_number":91,"context_line":"          block: \u0026install_and_configure_podman"},{"line_number":92,"context_line":"          - name: Ensure subscription-manager is not detecting container"},{"line_number":93,"context_line":"            when:"},{"line_number":94,"context_line":"              - ansible_facts[\u0027distribution\u0027] \u003d\u003d \u0027RedHat\u0027"},{"line_number":95,"context_line":"            # Needed in order to solve rhbz#2075080."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e39d0486_a21cfbfc","line":92,"range":{"start_line":92,"start_character":12,"end_line":92,"end_character":72},"in_reply_to":"16134dbd_4fd3afee","updated":"2022-06-13 11:30:43.000000000","message":"Good point. I think this can be a problem if the source dir /etc/rhsm is not yet created with fresh deploy.","commit_id":"215d918651eef3eaef0e612fca2d35742a78e4fa"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"40cd405cf46d3f34f9a7e74fadb18c01f012060a","unresolved":true,"context_lines":[{"line_number":89,"context_line":"      host_prep_tasks:"},{"line_number":90,"context_line":"        - name: Install and configure Podman"},{"line_number":91,"context_line":"          block: \u0026install_and_configure_podman"},{"line_number":92,"context_line":"          - name: Ensure subscription-manager is not detecting container"},{"line_number":93,"context_line":"            when:"},{"line_number":94,"context_line":"              - ansible_facts[\u0027distribution\u0027] \u003d\u003d \u0027RedHat\u0027"},{"line_number":95,"context_line":"            # Needed in order to solve rhbz#2075080."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cb4c57b1_f9fedd92","line":92,"range":{"start_line":92,"start_character":12,"end_line":92,"end_character":72},"in_reply_to":"52a4d596_58b21612","updated":"2022-06-13 10:59:18.000000000","message":"Hmm... it might be that it is required only when it ties to install a package actually and is not required when registering subscription.\n\nAnother concern is that there might be a task to install any packages during host prep tasks, which might be executed before this but I need to go through the all tasks implemented in host_prep_tasks.","commit_id":"215d918651eef3eaef0e612fca2d35742a78e4fa"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"2a06c9879386e8334b3b93243730f1dc879df008","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      host_prep_tasks:"},{"line_number":90,"context_line":"        - name: Install and configure Podman"},{"line_number":91,"context_line":"          block: \u0026install_and_configure_podman"},{"line_number":92,"context_line":"          - name: Ensure subscription-manager is not detecting container"},{"line_number":93,"context_line":"            when:"},{"line_number":94,"context_line":"              - ansible_facts[\u0027distribution\u0027] \u003d\u003d \u0027RedHat\u0027"},{"line_number":95,"context_line":"            # Needed in order to solve rhbz#2075080."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6484a319_a3c455a1","line":92,"range":{"start_line":92,"start_character":12,"end_line":92,"end_character":72},"in_reply_to":"52a4d596_58b21612","updated":"2022-06-13 11:13:35.000000000","message":"It *may* have issues for update/upgrade. Or \"just\" update, upgrade implies a complete cleaning of the containers, as well  as, if I\u0027m not mistaken, a reboot.\n\nWe don\u0027t have container startup during host_prep_tasks. So yeah... update MAY be at risk, it\u0027s something I overlooked :/. I may have to create a follow-up. Though moving that task to the rhsm itself may be \"weird\", since it\u0027s due to containers... Meh.","commit_id":"215d918651eef3eaef0e612fca2d35742a78e4fa"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2439a6dec66628fb189abb413afd1ad93fe6fcdf","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      host_prep_tasks:"},{"line_number":90,"context_line":"        - name: Install and configure Podman"},{"line_number":91,"context_line":"          block: \u0026install_and_configure_podman"},{"line_number":92,"context_line":"          - name: Ensure subscription-manager is not detecting container"},{"line_number":93,"context_line":"            when:"},{"line_number":94,"context_line":"              - ansible_facts[\u0027distribution\u0027] \u003d\u003d \u0027RedHat\u0027"},{"line_number":95,"context_line":"            # Needed in order to solve rhbz#2075080."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"16134dbd_4fd3afee","line":92,"range":{"start_line":92,"start_character":12,"end_line":92,"end_character":72},"in_reply_to":"a9427b36_e782d798","updated":"2022-06-13 11:15:06.000000000","message":"After discussion with Tengu++, we noticed host_prep_tasks should be executed before launching any containers, so this should not be a problem.","commit_id":"215d918651eef3eaef0e612fca2d35742a78e4fa"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"310f5d4ba96a04d83caa17122822f6dbf2e3f933","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      host_prep_tasks:"},{"line_number":90,"context_line":"        - name: Install and configure Podman"},{"line_number":91,"context_line":"          block: \u0026install_and_configure_podman"},{"line_number":92,"context_line":"          - name: Ensure subscription-manager is not detecting container"},{"line_number":93,"context_line":"            when:"},{"line_number":94,"context_line":"              - ansible_facts[\u0027distribution\u0027] \u003d\u003d \u0027RedHat\u0027"},{"line_number":95,"context_line":"            # Needed in order to solve rhbz#2075080."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"92839333_3d1f7860","line":92,"range":{"start_line":92,"start_character":12,"end_line":92,"end_character":72},"in_reply_to":"b56c41df_9ef7cc5d","updated":"2022-06-13 12:44:30.000000000","message":"just checked: unregistered rhel9 does have the /etc/rhsm; it\u0027s created by subscription-manager, and that one is, of course, installed in the base. Sooo... I think we\u0027re all good?","commit_id":"215d918651eef3eaef0e612fca2d35742a78e4fa"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"e4f351bec790eef42c33519ee062a31362e6df68","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      host_prep_tasks:"},{"line_number":90,"context_line":"        - name: Install and configure Podman"},{"line_number":91,"context_line":"          block: \u0026install_and_configure_podman"},{"line_number":92,"context_line":"          - name: Ensure subscription-manager is not detecting container"},{"line_number":93,"context_line":"            when:"},{"line_number":94,"context_line":"              - ansible_facts[\u0027distribution\u0027] \u003d\u003d \u0027RedHat\u0027"},{"line_number":95,"context_line":"            # Needed in order to solve rhbz#2075080."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b56c41df_9ef7cc5d","line":92,"range":{"start_line":92,"start_character":12,"end_line":92,"end_character":72},"in_reply_to":"beb37972_b8835c89","updated":"2022-06-13 12:14:15.000000000","message":"It shouldn\u0027t be an issue. on a unregistered RHEL, /etc/rhsm should exist. This is also why I ensure we\u0027re on an actual RHEL, and not \"some other distro from the same family\".\n\nAs said, the main concern right now is \"what about updates\"... Though it SHOULD be fine, since an update won\u0027t move from 8 to 9 (that\u0027s an upgrade) and osp-17 isn\u0027t out yet.","commit_id":"215d918651eef3eaef0e612fca2d35742a78e4fa"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b3668f1a48bd306b3f582f6d98cea33bbe094705","unresolved":true,"context_lines":[{"line_number":89,"context_line":"      host_prep_tasks:"},{"line_number":90,"context_line":"        - name: Install and configure Podman"},{"line_number":91,"context_line":"          block: \u0026install_and_configure_podman"},{"line_number":92,"context_line":"          - name: Ensure subscription-manager is not detecting container"},{"line_number":93,"context_line":"            when:"},{"line_number":94,"context_line":"              - ansible_facts[\u0027distribution\u0027] \u003d\u003d \u0027RedHat\u0027"},{"line_number":95,"context_line":"            # Needed in order to solve rhbz#2075080."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a9427b36_e782d798","line":92,"range":{"start_line":92,"start_character":12,"end_line":92,"end_character":72},"in_reply_to":"cb4c57b1_f9fedd92","updated":"2022-06-13 11:03:10.000000000","message":"\u003e Another concern is that there might be a task to install any packages during host prep tasks, which might be executed before this but I need to go through the all tasks implemented in host_prep_tasks.\n\nHmm.. this problem exists even in the current version and is not \"fixed\" or \"added\" by this change. so I think we can leave this point for a follow-up.","commit_id":"215d918651eef3eaef0e612fca2d35742a78e4fa"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e9a929c4e1ba568e28eac87cea451f976004a8ea","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      host_prep_tasks:"},{"line_number":90,"context_line":"        - name: Install and configure Podman"},{"line_number":91,"context_line":"          block: \u0026install_and_configure_podman"},{"line_number":92,"context_line":"          - name: Ensure subscription-manager is not detecting container"},{"line_number":93,"context_line":"            when:"},{"line_number":94,"context_line":"              - ansible_facts[\u0027distribution\u0027] \u003d\u003d \u0027RedHat\u0027"},{"line_number":95,"context_line":"            # Needed in order to solve rhbz#2075080."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"beb37972_b8835c89","line":92,"range":{"start_line":92,"start_character":12,"end_line":92,"end_character":72},"in_reply_to":"e39d0486_a21cfbfc","updated":"2022-06-13 11:47:05.000000000","message":"I guess rhsm after podman in default role_data[1] would break it. Did we verify it?\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/roles_data.yaml#L166-L169","commit_id":"215d918651eef3eaef0e612fca2d35742a78e4fa"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"bf83452ccc33672775279512042bea591240575e","unresolved":true,"context_lines":[{"line_number":91,"context_line":"          block: \u0026install_and_configure_podman"},{"line_number":92,"context_line":"          - name: Ensure subscription-manager is not detecting container"},{"line_number":93,"context_line":"            when:"},{"line_number":94,"context_line":"              - ansible_facts[\u0027distribution\u0027] \u003d\u003d \u0027RedHat\u0027"},{"line_number":95,"context_line":"            # Needed in order to solve rhbz#2075080."},{"line_number":96,"context_line":"            # Please refer to rhbz#2095316 for more internal details."},{"line_number":97,"context_line":"            file:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fec3708d_cb9a17bb","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":57},"updated":"2022-06-13 10:11:09.000000000","message":"Why this check? Isn\u0027t it specific to all podman[1] which is the only container cli we support.\n\n[1] https://github.com/containers/podman/issues/6192","commit_id":"215d918651eef3eaef0e612fca2d35742a78e4fa"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"2a06c9879386e8334b3b93243730f1dc879df008","unresolved":false,"context_lines":[{"line_number":91,"context_line":"          block: \u0026install_and_configure_podman"},{"line_number":92,"context_line":"          - name: Ensure subscription-manager is not detecting container"},{"line_number":93,"context_line":"            when:"},{"line_number":94,"context_line":"              - ansible_facts[\u0027distribution\u0027] \u003d\u003d \u0027RedHat\u0027"},{"line_number":95,"context_line":"            # Needed in order to solve rhbz#2075080."},{"line_number":96,"context_line":"            # Please refer to rhbz#2095316 for more internal details."},{"line_number":97,"context_line":"            file:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"037f83e1_e5537da8","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":57},"in_reply_to":"f48909ad_9a8b5667","updated":"2022-06-13 11:13:35.000000000","message":"Exactly","commit_id":"215d918651eef3eaef0e612fca2d35742a78e4fa"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e9a83348b83ab2364552af03f1db9556045b3c08","unresolved":true,"context_lines":[{"line_number":91,"context_line":"          block: \u0026install_and_configure_podman"},{"line_number":92,"context_line":"          - name: Ensure subscription-manager is not detecting container"},{"line_number":93,"context_line":"            when:"},{"line_number":94,"context_line":"              - ansible_facts[\u0027distribution\u0027] \u003d\u003d \u0027RedHat\u0027"},{"line_number":95,"context_line":"            # Needed in order to solve rhbz#2075080."},{"line_number":96,"context_line":"            # Please refer to rhbz#2095316 for more internal details."},{"line_number":97,"context_line":"            file:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f48909ad_9a8b5667","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":57},"in_reply_to":"fec3708d_cb9a17bb","updated":"2022-06-13 10:32:34.000000000","message":"OK, not to use with centos.","commit_id":"215d918651eef3eaef0e612fca2d35742a78e4fa"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"bf83452ccc33672775279512042bea591240575e","unresolved":true,"context_lines":[{"line_number":95,"context_line":"            # Needed in order to solve rhbz#2075080."},{"line_number":96,"context_line":"            # Please refer to rhbz#2095316 for more internal details."},{"line_number":97,"context_line":"            file:"},{"line_number":98,"context_line":"              dest: /etc/rhsm-host"},{"line_number":99,"context_line":"              src: /etc/rhsm"},{"line_number":100,"context_line":"              state: link"},{"line_number":101,"context_line":"          - name: Set login facts"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5392723d_593c018c","line":98,"range":{"start_line":98,"start_character":14,"end_line":98,"end_character":34},"updated":"2022-06-13 10:11:09.000000000","message":"This would make rhsm to think that we\u0027re running it in a container (Though now also it assumes to be running in a container but not able to find rhsm.conf). Super side effect of mounting /var/run for containers:/","commit_id":"215d918651eef3eaef0e612fca2d35742a78e4fa"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"2a06c9879386e8334b3b93243730f1dc879df008","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            # Needed in order to solve rhbz#2075080."},{"line_number":96,"context_line":"            # Please refer to rhbz#2095316 for more internal details."},{"line_number":97,"context_line":"            file:"},{"line_number":98,"context_line":"              dest: /etc/rhsm-host"},{"line_number":99,"context_line":"              src: /etc/rhsm"},{"line_number":100,"context_line":"              state: link"},{"line_number":101,"context_line":"          - name: Set login facts"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"98808bb3_36e2f9cc","line":98,"range":{"start_line":98,"start_character":14,"end_line":98,"end_character":34},"in_reply_to":"5392723d_593c018c","updated":"2022-06-13 11:13:35.000000000","message":"Yeah. I can\u0027t call this a \"fix\", more a workaround. Note, before EL9, it wasn\u0027t an issue, because subscription-manager didn\u0027t override the repository list... But now, it\u0027s an actual thing, and apparently we won\u0027t get anything from candlepin maintainers. We can\u0027t drop the /run:/run yet, and probably never will. Sooo... Meh.\n\nI\u0027ll follow up as soon as I get another possibility. Note, there actually IS another way, but it\u0027s not really usable within OSP: exporting a specific env var makes subscription-manager drop the container check[1]. I tried it, but without any success :(.\n\n[1] https://github.com/candlepin/subscription-manager/blob/385d64843affed7b58c2fb461612cf05f1dac4e5/src/rhsm/config.py#L106-L109","commit_id":"215d918651eef3eaef0e612fca2d35742a78e4fa"}]}