)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"5b784fe77d554e059b4602d714cf8e1b2a7a4895","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6bea5446_035c01f2","updated":"2022-06-15 14:41:48.000000000","message":"recheck","commit_id":"dca7f556da1b64e3a6ca94c559441d529b8cd49b"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"a2f4fd9758d4f71cab7e77ce94cd82f197fe8b55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"472fefae_0ebb668b","updated":"2022-06-22 11:44:27.000000000","message":"recheck","commit_id":"a7106ecbd748b8b6b60781e49cdd8d6af62a0b06"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"a31bf8c7708323b2ad83a5dcaa9adddae3ab04a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"87c98b72_111ed6c8","updated":"2022-06-16 09:39:43.000000000","message":"recheck","commit_id":"a7106ecbd748b8b6b60781e49cdd8d6af62a0b06"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"cfdb3caea328136cd9bbde8b88e77efd2b16ae04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"256266cc_6efad621","updated":"2022-07-04 07:20:50.000000000","message":"Looks like a good idea to do some verification and the usage of verify_package looks okay.\n\nhttps://opendev.org/openstack/validations-common/src/branch/master/validations_common/roles/verify_package/README.md\n\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_ebd/845569/4/check/tripleo-ci-centos-9-containers-multinode/ebdf3bc/logs/undercloud/home/zuul/ansible.log\n\n~~~\n2022-07-01 16:31:23,956 p\u003d102334 u\u003dzuul n\u003dansible | 2022-07-01 16:31:23.955936 | bc764e10-025e-8ba1-233a-000000000045 |       TASK | Verify package openstack-selinux\n2022-07-01 16:31:25,103 p\u003d102334 u\u003dzuul n\u003dansible | 2022-07-01 16:31:25.102501 | bc764e10-025e-8ba1-233a-000000000045 |    CHANGED | Verify package openstack-selinux | centos-9-stream-rax-ord-0030249924\n~~~\n\n","commit_id":"d4190bb515b9c0c0b9329878e8b69b036afe49b0"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"d262e1cab8c883656dddada9238191ec7fbdd660","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fb437205_41040997","updated":"2022-07-01 14:10:51.000000000","message":"recheck\n\n2022-07-01 13:18:21 | Error: error creating container storage: the container name \"nova_statedir_owner\" is already in use by \"918e8f5632800d8bb284ba523a7b3276459eb92f1e18fba09505dd53b9194a3f\". You have to remove that container to be able to reuse that name.: that name is already in use\n\nI thought this one was corrected... ?","commit_id":"d4190bb515b9c0c0b9329878e8b69b036afe49b0"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"841a565dbad8247c775fb5fad16ea57737fbf3f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4c560423_12b61109","updated":"2022-07-05 14:47:53.000000000","message":"so this patch may address James\u0027 comment:\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/848754\n\nIn the meanwhile, I\u0027m -W this one. If the tripleo-ansible version merges, we may even abandon this t-h-t change, since it calls tripleo_bootstrap anyway.","commit_id":"d4190bb515b9c0c0b9329878e8b69b036afe49b0"}],"common/deploy-steps-tasks-step-0.j2.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"49a2c79271597ec1e12005e86c13f8d9eacd9c08","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  become: true"},{"line_number":39,"context_line":"  no_log: True"},{"line_number":40,"context_line":"  copy: src\u003dcontainer_puppet_script.yaml dest\u003d/var/lib/container-puppet/container-puppet.sh force\u003dyes mode\u003d0755 setype\u003dcontainer_file_t"},{"line_number":41,"context_line":"- name: Ensure openstack-selinux is properly installed"},{"line_number":42,"context_line":"  vars:"},{"line_number":43,"context_line":"    verify_package_pkg: openstack-selinux"},{"line_number":44,"context_line":"    verify_package_verbose: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1c552e83_0d65a160","line":41,"range":{"start_line":41,"start_character":2,"end_line":41,"end_character":54},"updated":"2022-07-04 07:01:37.000000000","message":"Note to self: The openstack-selinux package is currently installed by the tripleo_bootstrap role called in the deploy_steps_common_roles_playbook, which is executed before step 0.\n\nhttps://github.com/openstack/tripleo-heat-templates/blob/61a88bc64faa749030e846442f701a35b768287c/common/deploy-steps.j2#L506","commit_id":"d4190bb515b9c0c0b9329878e8b69b036afe49b0"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"de14e9b085461926447d3a58df860c911f47cbdb","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  become: true"},{"line_number":39,"context_line":"  no_log: True"},{"line_number":40,"context_line":"  copy: src\u003dcontainer_puppet_script.yaml dest\u003d/var/lib/container-puppet/container-puppet.sh force\u003dyes mode\u003d0755 setype\u003dcontainer_file_t"},{"line_number":41,"context_line":"- name: Ensure openstack-selinux is properly installed"},{"line_number":42,"context_line":"  vars:"},{"line_number":43,"context_line":"    verify_package_pkg: openstack-selinux"},{"line_number":44,"context_line":"    verify_package_verbose: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e5844c62_51c0efb1","line":41,"range":{"start_line":41,"start_character":2,"end_line":41,"end_character":54},"in_reply_to":"1c552e83_0d65a160","updated":"2022-07-04 07:16:35.000000000","message":"iirc it\u0027s even a dependency of tripleoclient.","commit_id":"d4190bb515b9c0c0b9329878e8b69b036afe49b0"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"4544a3bdd48efdbb534214960c5935c22bfca5a4","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  become: true"},{"line_number":39,"context_line":"  no_log: True"},{"line_number":40,"context_line":"  copy: src\u003dcontainer_puppet_script.yaml dest\u003d/var/lib/container-puppet/container-puppet.sh force\u003dyes mode\u003d0755 setype\u003dcontainer_file_t"},{"line_number":41,"context_line":"- name: Ensure openstack-selinux is properly installed"},{"line_number":42,"context_line":"  vars:"},{"line_number":43,"context_line":"    verify_package_pkg: openstack-selinux"},{"line_number":44,"context_line":"    verify_package_verbose: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ed6aa236_2071059f","line":41,"range":{"start_line":41,"start_character":2,"end_line":41,"end_character":54},"in_reply_to":"aee69638_e0f03c00","updated":"2022-07-05 13:46:00.000000000","message":"hmmm, tripleo_bootstrap being a role in tripleo-ansible, is tripleo-ansible depending on validations-common? That\u0027s where the validation (role) is defined...","commit_id":"d4190bb515b9c0c0b9329878e8b69b036afe49b0"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"57c7ddd455d66a2a32719a50ef6a04a30c64e416","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  become: true"},{"line_number":39,"context_line":"  no_log: True"},{"line_number":40,"context_line":"  copy: src\u003dcontainer_puppet_script.yaml dest\u003d/var/lib/container-puppet/container-puppet.sh force\u003dyes mode\u003d0755 setype\u003dcontainer_file_t"},{"line_number":41,"context_line":"- name: Ensure openstack-selinux is properly installed"},{"line_number":42,"context_line":"  vars:"},{"line_number":43,"context_line":"    verify_package_pkg: openstack-selinux"},{"line_number":44,"context_line":"    verify_package_verbose: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"aee69638_e0f03c00","line":41,"range":{"start_line":41,"start_character":2,"end_line":41,"end_character":54},"in_reply_to":"e5844c62_51c0efb1","updated":"2022-07-05 13:00:14.000000000","message":"can we add this task to tripleo_bootstrap instead? I\u0027d rather see it alongside where the package is installed, instead of creating a \"hidden\" coupling between this playbook and that role.","commit_id":"d4190bb515b9c0c0b9329878e8b69b036afe49b0"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"b956268b8b349809598f7405ccad8db1fea4c908","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  become: true"},{"line_number":39,"context_line":"  no_log: True"},{"line_number":40,"context_line":"  copy: src\u003dcontainer_puppet_script.yaml dest\u003d/var/lib/container-puppet/container-puppet.sh force\u003dyes mode\u003d0755 setype\u003dcontainer_file_t"},{"line_number":41,"context_line":"- name: Ensure openstack-selinux is properly installed"},{"line_number":42,"context_line":"  vars:"},{"line_number":43,"context_line":"    verify_package_pkg: openstack-selinux"},{"line_number":44,"context_line":"    verify_package_verbose: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f5d1954a_135b3427","line":41,"range":{"start_line":41,"start_character":2,"end_line":41,"end_character":54},"in_reply_to":"ed6aa236_2071059f","updated":"2022-07-05 14:29:49.000000000","message":"if need be, yes. the premise of this issue is that openstack-selinux is not actually installed correctly. we need to detect that and fail where we actually install openstack-selinux, not in some other spot.","commit_id":"d4190bb515b9c0c0b9329878e8b69b036afe49b0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"49a2c79271597ec1e12005e86c13f8d9eacd9c08","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    verify_package_pkg: openstack-selinux"},{"line_number":44,"context_line":"    verify_package_verbose: true"},{"line_number":45,"context_line":"  import_role:"},{"line_number":46,"context_line":"    name: verify_package"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"{%- for role in roles %}"},{"line_number":49,"context_line":"- include_tasks: \"{% raw %}{{ _task_file_path }}{% endraw %}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"cd0ea322_6bb5fba7","line":46,"range":{"start_line":46,"start_character":10,"end_line":46,"end_character":24},"updated":"2022-07-04 07:01:37.000000000","message":"Note to self: In RDO validations-common is required by tripleoclient so we can assume it is installed.","commit_id":"d4190bb515b9c0c0b9329878e8b69b036afe49b0"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"de14e9b085461926447d3a58df860c911f47cbdb","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    verify_package_pkg: openstack-selinux"},{"line_number":44,"context_line":"    verify_package_verbose: true"},{"line_number":45,"context_line":"  import_role:"},{"line_number":46,"context_line":"    name: verify_package"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"{%- for role in roles %}"},{"line_number":49,"context_line":"- include_tasks: \"{% raw %}{{ _task_file_path }}{% endraw %}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b3100831_864b30b0","line":46,"range":{"start_line":46,"start_character":10,"end_line":46,"end_character":24},"in_reply_to":"cd0ea322_6bb5fba7","updated":"2022-07-04 07:16:35.000000000","message":"yep, \"inflight validations\" were the goal of that dependency, allowing to run actual validation from within (yet again ;)) the deploy.","commit_id":"d4190bb515b9c0c0b9329878e8b69b036afe49b0"}]}