)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f89d942654fa0db7d63857a3f3c6b17f102e2475","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"43bd0e5b_013c2470","updated":"2022-06-21 18:57:39.000000000","message":"Cinder services in tripleo-ci-centos-9-scenario002-standalone are working, so lgtm (CI issues appear to be related to ceph)","commit_id":"189395aec5b430af9e766a7dd4ccefa6dde18d89"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"051aacf9cc5097fbe2e2147d2b82049d53816cf7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7963941d_ea537c17","updated":"2022-06-21 15:55:18.000000000","message":"Thanks Alan for that good finding ! I\u0027ve updated the patch accordingly.\n\nAlso I renamed a few resources to import non-pacemaker version so that the naming becomes more consistent.","commit_id":"189395aec5b430af9e766a7dd4ccefa6dde18d89"}],"deployment/cinder/cinder-backup-pacemaker-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c264093fe0f5a483fd6554baab9054e6eb7ed9c4","unresolved":true,"context_lines":[{"line_number":164,"context_line":"          list_join:"},{"line_number":165,"context_line":"            - \"\\n\""},{"line_number":166,"context_line":"            - - {get_attr: [CinderBackupBase, role_data, puppet_config, step_config]}"},{"line_number":167,"context_line":"              - \"include tripleo::profile::base::cinder::backup\""},{"line_number":168,"context_line":"        config_image: {get_attr: [RoleParametersValue, value, ContainerCinderConfigImage]}"},{"line_number":169,"context_line":"      kolla_config:"},{"line_number":170,"context_line":"        /var/lib/kolla/config_files/cinder_backup.json:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8bded5e5_b735ef6c","line":167,"updated":"2022-06-21 15:13:59.000000000","message":"Adding this new L167 isn\u0027t necessary because it\u0027s already handled by L166.\n\nIn fact, you can replace all of L161..L168 with a reference to the non-pcmk\u0027s puppet-config:\n\n      puppet_config:\n        get_attr: [CinderBackupBase, role_data, puppet_config]","commit_id":"5dfae9615ad32bd4eee6a29e44b97d2450cd0087"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"051aacf9cc5097fbe2e2147d2b82049d53816cf7","unresolved":false,"context_lines":[{"line_number":164,"context_line":"          list_join:"},{"line_number":165,"context_line":"            - \"\\n\""},{"line_number":166,"context_line":"            - - {get_attr: [CinderBackupBase, role_data, puppet_config, step_config]}"},{"line_number":167,"context_line":"              - \"include tripleo::profile::base::cinder::backup\""},{"line_number":168,"context_line":"        config_image: {get_attr: [RoleParametersValue, value, ContainerCinderConfigImage]}"},{"line_number":169,"context_line":"      kolla_config:"},{"line_number":170,"context_line":"        /var/lib/kolla/config_files/cinder_backup.json:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8abf157a_feeedc48","line":167,"in_reply_to":"8bded5e5_b735ef6c","updated":"2022-06-21 15:55:18.000000000","message":"Indeed ! Fixed it.","commit_id":"5dfae9615ad32bd4eee6a29e44b97d2450cd0087"}],"deployment/cinder/cinder-volume-pacemaker-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c264093fe0f5a483fd6554baab9054e6eb7ed9c4","unresolved":true,"context_lines":[{"line_number":152,"context_line":"          list_join:"},{"line_number":153,"context_line":"            - \"\\n\""},{"line_number":154,"context_line":"            - - \"include tripleo::profile::base::lvm\""},{"line_number":155,"context_line":"            - - \"include tripleo::profile::base::cinder::volume\""},{"line_number":156,"context_line":"              - get_attr: [MySQLClient, role_data, step_config]"},{"line_number":157,"context_line":"        config_image: {get_attr: [RoleParametersValue, value, ContainerCinderConfigImage]}"},{"line_number":158,"context_line":"      kolla_config:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7561c364_8d08ebde","line":155,"updated":"2022-06-21 15:13:59.000000000","message":"See my comment for the c-bak change. Basically, this should work:\n\n      puppet_config:\n        get_attr: [CinderBase, role_data, puppet_config]","commit_id":"5dfae9615ad32bd4eee6a29e44b97d2450cd0087"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"051aacf9cc5097fbe2e2147d2b82049d53816cf7","unresolved":false,"context_lines":[{"line_number":152,"context_line":"          list_join:"},{"line_number":153,"context_line":"            - \"\\n\""},{"line_number":154,"context_line":"            - - \"include tripleo::profile::base::lvm\""},{"line_number":155,"context_line":"            - - \"include tripleo::profile::base::cinder::volume\""},{"line_number":156,"context_line":"              - get_attr: [MySQLClient, role_data, step_config]"},{"line_number":157,"context_line":"        config_image: {get_attr: [RoleParametersValue, value, ContainerCinderConfigImage]}"},{"line_number":158,"context_line":"      kolla_config:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0c2377d1_4a11c3b5","line":155,"in_reply_to":"7561c364_8d08ebde","updated":"2022-06-21 15:55:18.000000000","message":"Done","commit_id":"5dfae9615ad32bd4eee6a29e44b97d2450cd0087"}],"deployment/manila/manila-share-pacemaker-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c264093fe0f5a483fd6554baab9054e6eb7ed9c4","unresolved":true,"context_lines":[{"line_number":142,"context_line":"        step_config:"},{"line_number":143,"context_line":"          list_join:"},{"line_number":144,"context_line":"            - \"\\n\""},{"line_number":145,"context_line":"            - - \"include tripleo::profile::base::manila::share\""},{"line_number":146,"context_line":"              - {get_attr: [MySQLClient, role_data, step_config]}"},{"line_number":147,"context_line":"        config_image: {get_attr: [RoleParametersValue, value, ContainerManilaConfigImage]}"},{"line_number":148,"context_line":"      kolla_config:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f24f39af_fb3fbfc9","line":145,"updated":"2022-06-21 15:13:59.000000000","message":"Ditto, try this:\n\n      puppet_config:\n        {get_attr: [ManilaShareContainerBase, role_data, puppet_config]}","commit_id":"5dfae9615ad32bd4eee6a29e44b97d2450cd0087"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"051aacf9cc5097fbe2e2147d2b82049d53816cf7","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        step_config:"},{"line_number":143,"context_line":"          list_join:"},{"line_number":144,"context_line":"            - \"\\n\""},{"line_number":145,"context_line":"            - - \"include tripleo::profile::base::manila::share\""},{"line_number":146,"context_line":"              - {get_attr: [MySQLClient, role_data, step_config]}"},{"line_number":147,"context_line":"        config_image: {get_attr: [RoleParametersValue, value, ContainerManilaConfigImage]}"},{"line_number":148,"context_line":"      kolla_config:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4544e876_41968d4b","line":145,"in_reply_to":"f24f39af_fb3fbfc9","updated":"2022-06-21 15:55:18.000000000","message":"Done","commit_id":"5dfae9615ad32bd4eee6a29e44b97d2450cd0087"}]}