)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2b8f421f6c4193a16e71b8389415257574356454","unresolved":true,"context_lines":[{"line_number":14,"context_line":"This patch makes the T-H-T match the"},{"line_number":15,"context_line":"variables on backup-and-restore roles, so it"},{"line_number":16,"context_line":"can be configured."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related-Bug: #1979207"},{"line_number":19,"context_line":"Change-Id: Idc72693861a652de81cb05dfbaf68d7cf8b80fa2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5d9079d0_f5f210f2","line":17,"updated":"2022-06-21 08:24:34.000000000","message":"it also switches scenario1 job to stop skipping the NFSTest","commit_id":"b37f534c6f7dc5b800ccf276c3f5d0b0d2c4acdd"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"56f581567e7f39c685378c95aa2a53b2b6c435a9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"This patch makes the T-H-T match the"},{"line_number":15,"context_line":"variables on backup-and-restore roles, so it"},{"line_number":16,"context_line":"can be configured."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related-Bug: #1979207"},{"line_number":19,"context_line":"Change-Id: Idc72693861a652de81cb05dfbaf68d7cf8b80fa2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"382b5214_6953ae58","line":17,"in_reply_to":"34b378cc_b1951dfb","updated":"2022-06-22 07:32:37.000000000","message":"what name on the scenario did you change? i don\u0027t follow. my point was you should mention in the commit message that this changes a value in the scenario 1 CI env file and that will affect any scenario1 job running on any repo. it needs to be called out.","commit_id":"b37f534c6f7dc5b800ccf276c3f5d0b0d2c4acdd"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"58b01d8b6bbdf47d0bd4f4eb0bb054cb066f5831","unresolved":true,"context_lines":[{"line_number":14,"context_line":"This patch makes the T-H-T match the"},{"line_number":15,"context_line":"variables on backup-and-restore roles, so it"},{"line_number":16,"context_line":"can be configured."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related-Bug: #1979207"},{"line_number":19,"context_line":"Change-Id: Idc72693861a652de81cb05dfbaf68d7cf8b80fa2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"f8151785_78aab4d7","line":17,"in_reply_to":"5d9079d0_f5f210f2","updated":"2022-06-21 08:37:13.000000000","message":"Yes, I forgot to change the name on the scenario. Already changed.","commit_id":"b37f534c6f7dc5b800ccf276c3f5d0b0d2c4acdd"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"78008a6a294cc8db6af9e63723dc1d5c526c2a62","unresolved":false,"context_lines":[{"line_number":14,"context_line":"This patch makes the T-H-T match the"},{"line_number":15,"context_line":"variables on backup-and-restore roles, so it"},{"line_number":16,"context_line":"can be configured."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related-Bug: #1979207"},{"line_number":19,"context_line":"Change-Id: Idc72693861a652de81cb05dfbaf68d7cf8b80fa2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"34b378cc_b1951dfb","line":17,"in_reply_to":"f8151785_78aab4d7","updated":"2022-06-21 08:38:15.000000000","message":"Ack","commit_id":"b37f534c6f7dc5b800ccf276c3f5d0b0d2c4acdd"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2b8f421f6c4193a16e71b8389415257574356454","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3bf6e907_76d7f287","updated":"2022-06-21 08:24:34.000000000","message":"waiting for zuul latest run on scen1 (last one was red but didn\u0027t dig to see if related to this yet)","commit_id":"b37f534c6f7dc5b800ccf276c3f5d0b0d2c4acdd"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"78008a6a294cc8db6af9e63723dc1d5c526c2a62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6577794c_c039b391","in_reply_to":"3bf6e907_76d7f287","updated":"2022-06-21 08:38:15.000000000","message":"BTW, the errors in zuul were due to Ceph installation issue.","commit_id":"b37f534c6f7dc5b800ccf276c3f5d0b0d2c4acdd"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4377ff4c2a25fbd9cae673a4c2d02a89e9c4fd97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5da57336_c831041c","updated":"2022-06-22 13:19:59.000000000","message":"I think this can be abandoned as it\u0027s superseded by https://review.opendev.org/c/openstack/tripleo-heat-templates/+/847145","commit_id":"f89a0287ae422540cefda2b735cc5a4209e390dd"}],"deployment/backup-and-restore/rear-baremetal-ansible.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2b8f421f6c4193a16e71b8389415257574356454","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    default: {}"},{"line_number":28,"context_line":"    description: Parameters specific to the role"},{"line_number":29,"context_line":"    type: json"},{"line_number":30,"context_line":"  BackupAndRestoreNFSServer:"},{"line_number":31,"context_line":"    default: \u0027192.168.24.1\u0027"},{"line_number":32,"context_line":"    description: The URL of NFS server to connect to"},{"line_number":33,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"57d49e14_51f054f6","side":"PARENT","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":27},"updated":"2022-06-21 08:24:34.000000000","message":"so do we need to deprecate any of these?\n\nfrom codesearch i see this is the only reference for this one for example\n\n\nhttps://codesearch.opendev.org/?q\u003dBackupAndRestoreNFSServer\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d","commit_id":"8cb7c81d2094c0bdfd735dcef45f02db5b195199"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"40b932eb068cf376fd15c7f9cce4eace1b29046d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    default: {}"},{"line_number":28,"context_line":"    description: Parameters specific to the role"},{"line_number":29,"context_line":"    type: json"},{"line_number":30,"context_line":"  BackupAndRestoreNFSServer:"},{"line_number":31,"context_line":"    default: \u0027192.168.24.1\u0027"},{"line_number":32,"context_line":"    description: The URL of NFS server to connect to"},{"line_number":33,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"4ba99b0f_5c659d84","side":"PARENT","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":27},"in_reply_to":"032b3801_9ec96538","updated":"2022-06-21 12:28:51.000000000","message":"It might be good to add the deprecation notice on a different patch, but remember that we want to deprecate this in wallaby, so the deprecation notice must be also cherry-picked to wallaby.","commit_id":"8cb7c81d2094c0bdfd735dcef45f02db5b195199"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"56f581567e7f39c685378c95aa2a53b2b6c435a9","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    default: {}"},{"line_number":28,"context_line":"    description: Parameters specific to the role"},{"line_number":29,"context_line":"    type: json"},{"line_number":30,"context_line":"  BackupAndRestoreNFSServer:"},{"line_number":31,"context_line":"    default: \u0027192.168.24.1\u0027"},{"line_number":32,"context_line":"    description: The URL of NFS server to connect to"},{"line_number":33,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d208621b_b31214d9","side":"PARENT","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":27},"in_reply_to":"4ba99b0f_5c659d84","updated":"2022-06-22 07:32:37.000000000","message":"but hold on i\u0027m confused then.\n\nif we\u0027re deprecating this then that depracation needs to come first. this patch should not merge as it removes things. So what will you deprecate after you merge this?","commit_id":"8cb7c81d2094c0bdfd735dcef45f02db5b195199"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"58b01d8b6bbdf47d0bd4f4eb0bb054cb066f5831","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    default: {}"},{"line_number":28,"context_line":"    description: Parameters specific to the role"},{"line_number":29,"context_line":"    type: json"},{"line_number":30,"context_line":"  BackupAndRestoreNFSServer:"},{"line_number":31,"context_line":"    default: \u0027192.168.24.1\u0027"},{"line_number":32,"context_line":"    description: The URL of NFS server to connect to"},{"line_number":33,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"efc47b48_5f69e1f0","side":"PARENT","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":27},"in_reply_to":"57d49e14_51f054f6","updated":"2022-06-21 08:37:13.000000000","message":"We want to deprecated this THT file, and install ReaR with the CLI. But that will come in a different patch. As this patch needs to be cherry pick to wallaby.","commit_id":"8cb7c81d2094c0bdfd735dcef45f02db5b195199"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"a77204ceb174ee1425a105428b3e221c067bd679","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    default: {}"},{"line_number":28,"context_line":"    description: Parameters specific to the role"},{"line_number":29,"context_line":"    type: json"},{"line_number":30,"context_line":"  BackupAndRestoreNFSServer:"},{"line_number":31,"context_line":"    default: \u0027192.168.24.1\u0027"},{"line_number":32,"context_line":"    description: The URL of NFS server to connect to"},{"line_number":33,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ee10bde4_5d939e2f","side":"PARENT","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":27},"in_reply_to":"d208621b_b31214d9","updated":"2022-06-22 07:53:08.000000000","message":"sorry Marios, let me try to be more clear.\n\nthis patch does not remove anything, it just fixes the issue we are facing now in the launchpad bug. However, we do not desire this heat template to be maintained anymore, as we currently offer other way to perform the same action, without the need of heat templates.\n\nBut it does seem to be too agressive just to delete this heat template without having a release where it has been deprecated, so what we wanted is:\n\n1.- Fix the issue (which this patch is doing)\n2.- Adding a deprecation notice that this feature is deprecated in wallaby\n3.- Delete this feature completely from zed onwards.\n\nThis is intended to be performed in three separate patches, the first two must be cherry-picked to wallaby while the third will not.\n\nDoes this makes more sense?","commit_id":"8cb7c81d2094c0bdfd735dcef45f02db5b195199"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"78008a6a294cc8db6af9e63723dc1d5c526c2a62","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    default: {}"},{"line_number":28,"context_line":"    description: Parameters specific to the role"},{"line_number":29,"context_line":"    type: json"},{"line_number":30,"context_line":"  BackupAndRestoreNFSServer:"},{"line_number":31,"context_line":"    default: \u0027192.168.24.1\u0027"},{"line_number":32,"context_line":"    description: The URL of NFS server to connect to"},{"line_number":33,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"032b3801_9ec96538","side":"PARENT","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":27},"in_reply_to":"efc47b48_5f69e1f0","updated":"2022-06-21 08:38:15.000000000","message":"Ack","commit_id":"8cb7c81d2094c0bdfd735dcef45f02db5b195199"}]}
