)]}'
{"deployment/cinder/cinder-api-container-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"8151d383649bd5d359fcdddc44cb12043d4919fa","unresolved":true,"context_lines":[{"line_number":436,"context_line":"            service_type: \"{{ item.service_type }}\""},{"line_number":437,"context_line":"            state: absent"},{"line_number":438,"context_line":"          loop:"},{"line_number":439,"context_line":"            - {service_name: cinderv2, service_type: volumev2}"},{"line_number":440,"context_line":"            # The following cinderv3/volume entry removes a legacy workaround"},{"line_number":441,"context_line":"            # unrelated to cinder\u0027s v3 API service (cinderv3/volumev3). See"},{"line_number":442,"context_line":"            # Ic0eb72f78e2a19e2f40ab12631a872d828bab46a for details."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e3f04e47_2eed8a8b","side":"PARENT","line":439,"updated":"2022-06-21 17:34:20.000000000","message":"This cleanup must remain in the wallaby code, but it could be moved to the external_update_tasks. The idea is that the v2 API endpoint that is present in train needs to be removed in wallaby.","commit_id":"af78cf50b8ea3b75f5e70aef7848afb5d8795d47"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f6487ca08d574e007dc60879b53ae0725c30d4e4","unresolved":false,"context_lines":[{"line_number":436,"context_line":"            service_type: \"{{ item.service_type }}\""},{"line_number":437,"context_line":"            state: absent"},{"line_number":438,"context_line":"          loop:"},{"line_number":439,"context_line":"            - {service_name: cinderv2, service_type: volumev2}"},{"line_number":440,"context_line":"            # The following cinderv3/volume entry removes a legacy workaround"},{"line_number":441,"context_line":"            # unrelated to cinder\u0027s v3 API service (cinderv3/volumev3). See"},{"line_number":442,"context_line":"            # Ic0eb72f78e2a19e2f40ab12631a872d828bab46a for details."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c91e3060_145c4ad4","side":"PARENT","line":439,"in_reply_to":"557bf312_9785bc97","updated":"2022-09-06 16:51:56.000000000","message":"Ack","commit_id":"af78cf50b8ea3b75f5e70aef7848afb5d8795d47"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fc13f2995dd14fd0791e4889bb81da2a223a16c2","unresolved":true,"context_lines":[{"line_number":436,"context_line":"            service_type: \"{{ item.service_type }}\""},{"line_number":437,"context_line":"            state: absent"},{"line_number":438,"context_line":"          loop:"},{"line_number":439,"context_line":"            - {service_name: cinderv2, service_type: volumev2}"},{"line_number":440,"context_line":"            # The following cinderv3/volume entry removes a legacy workaround"},{"line_number":441,"context_line":"            # unrelated to cinder\u0027s v3 API service (cinderv3/volumev3). See"},{"line_number":442,"context_line":"            # Ic0eb72f78e2a19e2f40ab12631a872d828bab46a for details."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"557bf312_9785bc97","side":"PARENT","line":439,"in_reply_to":"e3f04e47_2eed8a8b","updated":"2022-09-06 03:11:45.000000000","message":"The intention of this change is to remove the clean up from Zed, not from Wallaby. Unless we try supporting direct upgrade from train to zed (I\u0027m not aware of any plan, futhermore we\u0027ve already dome a few cleanups thus it would no longer work), we can remove these code, IIUC.","commit_id":"af78cf50b8ea3b75f5e70aef7848afb5d8795d47"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"8151d383649bd5d359fcdddc44cb12043d4919fa","unresolved":true,"context_lines":[{"line_number":437,"context_line":"            state: absent"},{"line_number":438,"context_line":"          loop:"},{"line_number":439,"context_line":"            - {service_name: cinderv2, service_type: volumev2}"},{"line_number":440,"context_line":"            # The following cinderv3/volume entry removes a legacy workaround"},{"line_number":441,"context_line":"            # unrelated to cinder\u0027s v3 API service (cinderv3/volumev3). See"},{"line_number":442,"context_line":"            # Ic0eb72f78e2a19e2f40ab12631a872d828bab46a for details."},{"line_number":443,"context_line":"            - {service_name: cinderv3, service_type: volume}"},{"line_number":444,"context_line":"          loop_control:"},{"line_number":445,"context_line":"            index_var: cinder_api_service"},{"line_number":446,"context_line":"          when:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"86f2b79a_96955018","side":"PARENT","line":443,"range":{"start_line":440,"start_character":0,"end_line":443,"end_character":60},"updated":"2022-06-21 17:34:20.000000000","message":"These can definitely be removed. This cleanup would have been handled when the overcloud was running Train, so it\u0027s no longer relevant.","commit_id":"af78cf50b8ea3b75f5e70aef7848afb5d8795d47"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fc13f2995dd14fd0791e4889bb81da2a223a16c2","unresolved":false,"context_lines":[{"line_number":437,"context_line":"            state: absent"},{"line_number":438,"context_line":"          loop:"},{"line_number":439,"context_line":"            - {service_name: cinderv2, service_type: volumev2}"},{"line_number":440,"context_line":"            # The following cinderv3/volume entry removes a legacy workaround"},{"line_number":441,"context_line":"            # unrelated to cinder\u0027s v3 API service (cinderv3/volumev3). See"},{"line_number":442,"context_line":"            # Ic0eb72f78e2a19e2f40ab12631a872d828bab46a for details."},{"line_number":443,"context_line":"            - {service_name: cinderv3, service_type: volume}"},{"line_number":444,"context_line":"          loop_control:"},{"line_number":445,"context_line":"            index_var: cinder_api_service"},{"line_number":446,"context_line":"          when:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f5470e7a_076dd97f","side":"PARENT","line":443,"range":{"start_line":440,"start_character":0,"end_line":443,"end_character":60},"in_reply_to":"86f2b79a_96955018","updated":"2022-09-06 03:11:45.000000000","message":"+1","commit_id":"af78cf50b8ea3b75f5e70aef7848afb5d8795d47"}]}